Mixing
Parsing Retrofit response.body()
up vote
2
down vote
favorite
1
I am having difficulty with Retrofit as I am trying to understand what I should expect to see in the response.body() that is returned.
I think I have a mapping error in my JSON to POJO conversion because I am not seeing the right response when I print it to the log.
Here is the response I am seeing:
V/RESPONSE_BODY: response:com.troychuinard.flickr_test.Model.Model@36b2e4c9
I would expect this response to simply be the JSON data. I know I am making the correct call to FlickR, as I am using the logging interceptor to see the JSON:
https://api.flickr.com/services/rest/?method=flickr.photos.getRecent&api_key=1c448390199c03a6f2d436c40defd90e&format=json&nojsoncallback=1&extras=url_m&text=test
Model:
public class Model {
Photos photos;
int code;
String stat;
String message; // when you text = null
public class Photos {
@SerializedName("page")
@Expose
private int page;
@SerializedName("pages")
@Expose
private int pages;
@SerializedName("perpage")
@Expose
private int perpage;
@SerializedName("total")
@Expose
private String total;
@SerializedName("photo")
@Expose
private List<Photo> photo = new ArrayList<Photo>();
/**
* @return The page
*/
public int getPage() {
return page;
}
/**
* @param page The page
*/
public void setPage(int page) {
this.page = page;
}
/**
* @return The pages
*/
public int getPages() {
return pages;
}
/**
* @param pages The pages
*/
public void setPages(int pages) {
this.pages = pages;
}
/**
* @return The perpage
*/
public int getPerpage() {
return perpage;
}
/**
* @param perpage The perpage
*/
public void setPerpage(int perpage) {
this.perpage = perpage;
}
/**
* @return The total
*/
public String getTotal() {
return total;
}
/**
* @param total The total
*/
public void setTotal(String total) {
this.total = total;
}
/**
* @return The photo
*/
public List<Photo> getPhoto() {
return photo;
}
/**
* @param photo The photo
*/
public void setPhoto(List<Photo> photo) {
this.photo = photo;
}
}
public class Photo {
@SerializedName("id")
@Expose
private String id;
@SerializedName("owner")
@Expose
private String owner;
@SerializedName("secret")
@Expose
private String secret;
@SerializedName("server")
@Expose
private String server;
@SerializedName("farm")
@Expose
private int farm;
@SerializedName("title")
@Expose
private String title;
@SerializedName("ispublic")
@Expose
private int ispublic;
@SerializedName("isfriend")
@Expose
private int isfriend;
@SerializedName("isfamily")
@Expose
private int isfamily;
@SerializedName("url_m")
@Expose
private String urlM;
@SerializedName("height_m")
@Expose
private String heightM;
@SerializedName("width_m")
@Expose
private String widthM;
public Photo(){
}
/**
* @return The id
*/
public String getId() {
return id;
}
/**
* @param id The id
*/
public void setId(String id) {
this.id = id;
}
/**
* @return The owner
*/
public String getOwner() {
return owner;
}
/**
* @param owner The owner
*/
public void setOwner(String owner) {
this.owner = owner;
}
/**
* @return The secret
*/
public String getSecret() {
return secret;
}
/**
* @param secret The secret
*/
public void setSecret(String secret) {
this.secret = secret;
}
/**
* @return The server
*/
public String getServer() {
return server;
}
/**
* @param server The server
*/
public void setServer(String server) {
this.server = server;
}
/**
* @return The farm
*/
public int getFarm() {
return farm;
}
/**
* @param farm The farm
*/
public void setFarm(int farm) {
this.farm = farm;
}
/**
* @return The title
*/
public String getTitle() {
return title;
}
/**
* @param title The title
*/
public void setTitle(String title) {
this.title = title;
}
/**
* @return The ispublic
*/
public int getIspublic() {
return ispublic;
}
/**
* @param ispublic The ispublic
*/
public void setIspublic(int ispublic) {
this.ispublic = ispublic;
}
/**
* @return The isfriend
*/
public int getIsfriend() {
return isfriend;
}
/**
* @param isfriend The isfriend
*/
public void setIsfriend(int isfriend) {
this.isfriend = isfriend;
}
/**
* @return The isfamily
*/
public int getIsfamily() {
return isfamily;
}
/**
* @param isfamily The isfamily
*/
public void setIsfamily(int isfamily) {
this.isfamily = isfamily;
}
/**
* @return The urlM
*/
public String getUrlM() {
return urlM;
}
/**
* @param urlM The url_m
*/
public void setUrlM(String urlM) {
this.urlM = urlM;
}
/**
* @return The heightM
*/
public String getHeightM() {
return heightM;
}
/**
* @param heightM The height_m
*/
public void setHeightM(String heightM) {
this.heightM = heightM;
}
/**
* @return The widthM
*/
public String getWidthM() {
return widthM;
}
/**
* @param widthM The width_m
*/
public void setWidthM(String widthM) {
this.widthM = widthM;
}
}
}
JSON Response:
{
photos: {
page: 1,
pages: 3683,
perpage: 100,
total: "368270",
photo: [
{
id: "29264707352",
owner: "84316756@N02",
secret: "9ed355a86e",
server: "8603",
farm: 9,
title: "Tercer Patio de los Claustros de la Compañía/ Arequipa",
ispublic: 1,
isfriend: 0,
isfamily: 0,
url_m: "https://farm9.staticflickr.com/8603/29264707352_9ed355a86e.jpg",
height_m: "500",
width_m: "333"
},
{
id: "29339070436",
owner: "146617764@N02",
secret: "b52f1e9914",
server: "8509",
farm: 9,
title: "2016-04-17 09.24.07",
ispublic: 1,
isfriend: 0,
isfamily: 0,
url_m: "https://farm9.staticflickr.com/8509/29339070436_b52f1e9914.jpg",
height_m: "281",
width_m: "500"
},
LOGCAT
09-03 15:11:33.037 1846-1846/com.troychuinard.flickr_test E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.troychuinard.flickr_test, PID: 1846
java.lang.NullPointerException: println needs a message
at android.util.Log.println_native(Native Method)
at android.util.Log.v(Log.java:118)
at com.troychuinard.flickr_test.MainActivity$1$1.onResponse(MainActivity.java:72)
at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run(ExecutorCallAdapterFactory.java:68)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5254)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
09-03 15:14:21.858 1846-1846/com.troychuinard.flickr_test I/Process: Sending signal. PID: 1846 SIG: 9
Line 72
Log.v("RESPONSE_BODY", response.body().getTotal());
Activity
public class MainActivity extends AppCompatActivity {
private EditText mSearchTerm;
private Button mRequestButton;
private Button mSearchButton;
private String mQuery;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
mSearchTerm = (EditText) findViewById(R.id.ediText_search_term);
mRequestButton = (Button) findViewById(R.id.request_button);
mSearchButton = (Button) findViewById(R.id.search_button_flickr);
mRequestButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
mQuery = mSearchTerm.getText().toString();
HttpLoggingInterceptor interceptor = new HttpLoggingInterceptor();
interceptor.setLevel(HttpLoggingInterceptor.Level.BODY);
OkHttpClient client = new OkHttpClient.Builder().addInterceptor(interceptor).build();
Retrofit retrofit = new Retrofit.Builder()
.baseUrl("https://api.flickr.com/services/rest/")
.client(client)
.addConverterFactory(GsonConverterFactory.create())
.build();
ApiInterface apiInterface = retrofit.create(ApiInterface.class);
Call<Photos> call = apiInterface.getImages(mQuery);
call.enqueue(new Callback<Photos>() {
@Override
public void onResponse(Call<Photos> call, Response<Photos> response) {
Log.v("RESPONSE_CALLED", "ON_RESPONSE_CALLED");
String didItWork = String.valueOf(response.isSuccessful());
Log.v("SUCCESS?", didItWork);
Log.v("RESPONSE_CODE", String.valueOf(response.code()));
Photos photos = response.body();
Log.v("RESPONSE_BODY", "response:" + photos);
String total = response.body().getTotal();
Log.v("Total", total);
List<Photos.Photo> photoResults = response.body().getPhoto();
for (Photos.Photo photo : photoResults) {
Log.v("PHOTO_URL:", photo.getTitle()
);
}
}
@Override
public void onFailure(Call<Photos> call, Throwable t) {
}
});
}
});
mSearchButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
Intent toSearch = new Intent(MainActivity.this, FlickRActivity.class);
startActivity(toSearch);
}
});
}
//Synchronous vs. Asynchronous
public interface ApiInterface {
@GET("?method=flickr.photos.search&api_key=1c448390199c03a6f2d436c40defd90e&format=json&nojsoncallback=1&extras=url_m")
Call<Photos> getImages(@Query("text") String query);
}
}
java
android json rest retrofit edited yesterday
barbsan
2,131521
asked Sep 11 '16 at 22:52
tccpg288
1,11911533
add a comment |
up vote
2
down vote
favorite
1
I am having difficulty with Retrofit as I am trying to understand what I should expect to see in the response.body() that is returned.
I think I have a mapping error in my JSON to POJO conversion because I am not seeing the right response when I print it to the log.
Here is the response I am seeing:
V/RESPONSE_BODY: response:com.troychuinard.flickr_test.Model.Model@36b2e4c9
I would expect this response to simply be the JSON data. I know I am making the correct call to FlickR, as I am using the logging interceptor to see the JSON:
https://api.flickr.com/services/rest/?method=flickr.photos.getRecent&api_key=1c448390199c03a6f2d436c40defd90e&format=json&nojsoncallback=1&extras=url_m&text=test
Model:
public class Model {
Photos photos;
int code;
String stat;
String message; // when you text = null
public class Photos {
@SerializedName("page")
@Expose
private int page;
@SerializedName("pages")
@Expose
private int pages;
@SerializedName("perpage")
@Expose
private int perpage;
@SerializedName("total")
@Expose
private String total;
@SerializedName("photo")
@Expose
private List<Photo> photo = new ArrayList<Photo>();
/**
* @return The page
*/
public int getPage() {
return page;
}
/**
* @param page The page
*/
public void setPage(int page) {
this.page = page;
}
/**
* @return The pages
*/
public int getPages() {
return pages;
}
/**
* @param pages The pages
*/
public void setPages(int pages) {
this.pages = pages;
}
/**
* @return The perpage
*/
public int getPerpage() {
return perpage;
}
/**
* @param perpage The perpage
*/
public void setPerpage(int perpage) {
this.perpage = perpage;
}
/**
* @return The total
*/
public String getTotal() {
return total;
}
/**
* @param total The total
*/
public void setTotal(String total) {
this.total = total;
}
/**
* @return The photo
*/
public List<Photo> getPhoto() {
return photo;
}
/**
* @param photo The photo
*/
public void setPhoto(List<Photo> photo) {
this.photo = photo;
}
}
public class Photo {
@SerializedName("id")
@Expose
private String id;
@SerializedName("owner")
@Expose
private String owner;
@SerializedName("secret")
@Expose
private String secret;
@SerializedName("server")
@Expose
private String server;
@SerializedName("farm")
@Expose
private int farm;
@SerializedName("title")
@Expose
private String title;
@SerializedName("ispublic")
@Expose
private int ispublic;
@SerializedName("isfriend")
@Expose
private int isfriend;
@SerializedName("isfamily")
@Expose
private int isfamily;
@SerializedName("url_m")
@Expose
private String urlM;
@SerializedName("height_m")
@Expose
private String heightM;
@SerializedName("width_m")
@Expose
private String widthM;
public Photo(){
}
/**
* @return The id
*/
public String getId() {
return id;
}
/**
* @param id The id
*/
public void setId(String id) {
this.id = id;
}
/**
* @return The owner
*/
public String getOwner() {
return owner;
}
/**
* @param owner The owner
*/
public void setOwner(String owner) {
this.owner = owner;
}
/**
* @return The secret
*/
public String getSecret() {
return secret;
}
/**
* @param secret The secret
*/
public void setSecret(String secret) {
this.secret = secret;
}
/**
* @return The server
*/
public String getServer() {
return server;
}
/**
* @param server The server
*/
public void setServer(String server) {
this.server = server;
}
/**
* @return The farm
*/
public int getFarm() {
return farm;
}
/**
* @param farm The farm
*/
public void setFarm(int farm) {
this.farm = farm;
}
/**
* @return The title
*/
public String getTitle() {
return title;
}
/**
* @param title The title
*/
public void setTitle(String title) {
this.title = title;
}
/**
* @return The ispublic
*/
public int getIspublic() {
return ispublic;
}
/**
* @param ispublic The ispublic
*/
public void setIspublic(int ispublic) {
this.ispublic = ispublic;
}
/**
* @return The isfriend
*/
public int getIsfriend() {
return isfriend;
}
/**
* @param isfriend The isfriend
*/
public void setIsfriend(int isfriend) {
this.isfriend = isfriend;
}
/**
* @return The isfamily
*/
public int getIsfamily() {
return isfamily;
}
/**
* @param isfamily The isfamily
*/
public void setIsfamily(int isfamily) {
this.isfamily = isfamily;
}
/**
* @return The urlM
*/
public String getUrlM() {
return urlM;
}
/**
* @param urlM The url_m
*/
public void setUrlM(String urlM) {
this.urlM = urlM;
}
/**
* @return The heightM
*/
public String getHeightM() {
return heightM;
}
/**
* @param heightM The height_m
*/
public void setHeightM(String heightM) {
this.heightM = heightM;
}
/**
* @return The widthM
*/
public String getWidthM() {
return widthM;
}
/**
* @param widthM The width_m
*/
public void setWidthM(String widthM) {
this.widthM = widthM;
}
}
}
JSON Response:
{
photos: {
page: 1,
pages: 3683,
perpage: 100,
total: "368270",
photo: [
{
id: "29264707352",
owner: "84316756@N02",
secret: "9ed355a86e",
server: "8603",
farm: 9,
title: "Tercer Patio de los Claustros de la Compañía/ Arequipa",
ispublic: 1,
isfriend: 0,
isfamily: 0,
url_m: "https://farm9.staticflickr.com/8603/29264707352_9ed355a86e.jpg",
height_m: "500",
width_m: "333"
},
{
id: "29339070436",
owner: "146617764@N02",
secret: "b52f1e9914",
server: "8509",
farm: 9,
title: "2016-04-17 09.24.07",
ispublic: 1,
isfriend: 0,
isfamily: 0,
url_m: "https://farm9.staticflickr.com/8509/29339070436_b52f1e9914.jpg",
height_m: "281",
width_m: "500"
},
LOGCAT
09-03 15:11:33.037 1846-1846/com.troychuinard.flickr_test E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.troychuinard.flickr_test, PID: 1846
java.lang.NullPointerException: println needs a message
at android.util.Log.println_native(Native Method)
at android.util.Log.v(Log.java:118)
at com.troychuinard.flickr_test.MainActivity$1$1.onResponse(MainActivity.java:72)
at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run(ExecutorCallAdapterFactory.java:68)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5254)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
09-03 15:14:21.858 1846-1846/com.troychuinard.flickr_test I/Process: Sending signal. PID: 1846 SIG: 9
Line 72
Log.v("RESPONSE_BODY", response.body().getTotal());
Activity
public class MainActivity extends AppCompatActivity {
private EditText mSearchTerm;
private Button mRequestButton;
private Button mSearchButton;
private String mQuery;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
mSearchTerm = (EditText) findViewById(R.id.ediText_search_term);
mRequestButton = (Button) findViewById(R.id.request_button);
mSearchButton = (Button) findViewById(R.id.search_button_flickr);
mRequestButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
mQuery = mSearchTerm.getText().toString();
HttpLoggingInterceptor interceptor = new HttpLoggingInterceptor();
interceptor.setLevel(HttpLoggingInterceptor.Level.BODY);
OkHttpClient client = new OkHttpClient.Builder().addInterceptor(interceptor).build();
Retrofit retrofit = new Retrofit.Builder()
.baseUrl("https://api.flickr.com/services/rest/")
.client(client)
.addConverterFactory(GsonConverterFactory.create())
.build();
ApiInterface apiInterface = retrofit.create(ApiInterface.class);
Call<Photos> call = apiInterface.getImages(mQuery);
call.enqueue(new Callback<Photos>() {
@Override
public void onResponse(Call<Photos> call, Response<Photos> response) {
Log.v("RESPONSE_CALLED", "ON_RESPONSE_CALLED");
String didItWork = String.valueOf(response.isSuccessful());
Log.v("SUCCESS?", didItWork);
Log.v("RESPONSE_CODE", String.valueOf(response.code()));
Photos photos = response.body();
Log.v("RESPONSE_BODY", "response:" + photos);
String total = response.body().getTotal();
Log.v("Total", total);
List<Photos.Photo> photoResults = response.body().getPhoto();
for (Photos.Photo photo : photoResults) {
Log.v("PHOTO_URL:", photo.getTitle()
);
}
}
@Override
public void onFailure(Call<Photos> call, Throwable t) {
}
});
}
});
mSearchButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
Intent toSearch = new Intent(MainActivity.this, FlickRActivity.class);
startActivity(toSearch);
}
});
}
//Synchronous vs. Asynchronous
public interface ApiInterface {
@GET("?method=flickr.photos.search&api_key=1c448390199c03a6f2d436c40defd90e&format=json&nojsoncallback=1&extras=url_m")
Call<Photos> getImages(@Query("text") String query);
}
}
java
android json rest retrofit edited yesterday
barbsan
2,131521
asked Sep 11 '16 at 22:52
tccpg288
1,11911533
add a comment |
up vote
2
down vote
favorite
1
up vote
2
down vote
favorite
1
1
I am having difficulty with Retrofit as I am trying to understand what I should expect to see in the response.body() that is returned.
I think I have a mapping error in my JSON to POJO conversion because I am not seeing the right response when I print it to the log.
Here is the response I am seeing:
V/RESPONSE_BODY: response:com.troychuinard.flickr_test.Model.Model@36b2e4c9
I would expect this response to simply be the JSON data. I know I am making the correct call to FlickR, as I am using the logging interceptor to see the JSON:
https://api.flickr.com/services/rest/?method=flickr.photos.getRecent&api_key=1c448390199c03a6f2d436c40defd90e&format=json&nojsoncallback=1&extras=url_m&text=test
Model:
public class Model {
Photos photos;
int code;
String stat;
String message; // when you text = null
public class Photos {
@SerializedName("page")
@Expose
private int page;
@SerializedName("pages")
@Expose
private int pages;
@SerializedName("perpage")
@Expose
private int perpage;
@SerializedName("total")
@Expose
private String total;
@SerializedName("photo")
@Expose
private List<Photo> photo = new ArrayList<Photo>();
/**
* @return The page
*/
public int getPage() {
return page;
}
/**
* @param page The page
*/
public void setPage(int page) {
this.page = page;
}
/**
* @return The pages
*/
public int getPages() {
return pages;
}
/**
* @param pages The pages
*/
public void setPages(int pages) {
this.pages = pages;
}
/**
* @return The perpage
*/
public int getPerpage() {
return perpage;
}
/**
* @param perpage The perpage
*/
public void setPerpage(int perpage) {
this.perpage = perpage;
}
/**
* @return The total
*/
public String getTotal() {
return total;
}
/**
* @param total The total
*/
public void setTotal(String total) {
this.total = total;
}
/**
* @return The photo
*/
public List<Photo> getPhoto() {
return photo;
}
/**
* @param photo The photo
*/
public void setPhoto(List<Photo> photo) {
this.photo = photo;
}
}
public class Photo {
@SerializedName("id")
@Expose
private String id;
@SerializedName("owner")
@Expose
private String owner;
@SerializedName("secret")
@Expose
private String secret;
@SerializedName("server")
@Expose
private String server;
@SerializedName("farm")
@Expose
private int farm;
@SerializedName("title")
@Expose
private String title;
@SerializedName("ispublic")
@Expose
private int ispublic;
@SerializedName("isfriend")
@Expose
private int isfriend;
@SerializedName("isfamily")
@Expose
private int isfamily;
@SerializedName("url_m")
@Expose
private String urlM;
@SerializedName("height_m")
@Expose
private String heightM;
@SerializedName("width_m")
@Expose
private String widthM;
public Photo(){
}
/**
* @return The id
*/
public String getId() {
return id;
}
/**
* @param id The id
*/
public void setId(String id) {
this.id = id;
}
/**
* @return The owner
*/
public String getOwner() {
return owner;
}
/**
* @param owner The owner
*/
public void setOwner(String owner) {
this.owner = owner;
}
/**
* @return The secret
*/
public String getSecret() {
return secret;
}
/**
* @param secret The secret
*/
public void setSecret(String secret) {
this.secret = secret;
}
/**
* @return The server
*/
public String getServer() {
return server;
}
/**
* @param server The server
*/
public void setServer(String server) {
this.server = server;
}
/**
* @return The farm
*/
public int getFarm() {
return farm;
}
/**
* @param farm The farm
*/
public void setFarm(int farm) {
this.farm = farm;
}
/**
* @return The title
*/
public String getTitle() {
return title;
}
/**
* @param title The title
*/
public void setTitle(String title) {
this.title = title;
}
/**
* @return The ispublic
*/
public int getIspublic() {
return ispublic;
}
/**
* @param ispublic The ispublic
*/
public void setIspublic(int ispublic) {
this.ispublic = ispublic;
}
/**
* @return The isfriend
*/
public int getIsfriend() {
return isfriend;
}
/**
* @param isfriend The isfriend
*/
public void setIsfriend(int isfriend) {
this.isfriend = isfriend;
}
/**
* @return The isfamily
*/
public int getIsfamily() {
return isfamily;
}
/**
* @param isfamily The isfamily
*/
public void setIsfamily(int isfamily) {
this.isfamily = isfamily;
}
/**
* @return The urlM
*/
public String getUrlM() {
return urlM;
}
/**
* @param urlM The url_m
*/
public void setUrlM(String urlM) {
this.urlM = urlM;
}
/**
* @return The heightM
*/
public String getHeightM() {
return heightM;
}
/**
* @param heightM The height_m
*/
public void setHeightM(String heightM) {
this.heightM = heightM;
}
/**
* @return The widthM
*/
public String getWidthM() {
return widthM;
}
/**
* @param widthM The width_m
*/
public void setWidthM(String widthM) {
this.widthM = widthM;
}
}
}
JSON Response:
{
photos: {
page: 1,
pages: 3683,
perpage: 100,
total: "368270",
photo: [
{
id: "29264707352",
owner: "84316756@N02",
secret: "9ed355a86e",
server: "8603",
farm: 9,
title: "Tercer Patio de los Claustros de la Compañía/ Arequipa",
ispublic: 1,
isfriend: 0,
isfamily: 0,
url_m: "https://farm9.staticflickr.com/8603/29264707352_9ed355a86e.jpg",
height_m: "500",
width_m: "333"
},
{
id: "29339070436",
owner: "146617764@N02",
secret: "b52f1e9914",
server: "8509",
farm: 9,
title: "2016-04-17 09.24.07",
ispublic: 1,
isfriend: 0,
isfamily: 0,
url_m: "https://farm9.staticflickr.com/8509/29339070436_b52f1e9914.jpg",
height_m: "281",
width_m: "500"
},
LOGCAT
09-03 15:11:33.037 1846-1846/com.troychuinard.flickr_test E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.troychuinard.flickr_test, PID: 1846
java.lang.NullPointerException: println needs a message
at android.util.Log.println_native(Native Method)
at android.util.Log.v(Log.java:118)
at com.troychuinard.flickr_test.MainActivity$1$1.onResponse(MainActivity.java:72)
at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run(ExecutorCallAdapterFactory.java:68)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5254)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
09-03 15:14:21.858 1846-1846/com.troychuinard.flickr_test I/Process: Sending signal. PID: 1846 SIG: 9
Line 72
Log.v("RESPONSE_BODY", response.body().getTotal());
Activity
public class MainActivity extends AppCompatActivity {
private EditText mSearchTerm;
private Button mRequestButton;
private Button mSearchButton;
private String mQuery;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
mSearchTerm = (EditText) findViewById(R.id.ediText_search_term);
mRequestButton = (Button) findViewById(R.id.request_button);
mSearchButton = (Button) findViewById(R.id.search_button_flickr);
mRequestButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
mQuery = mSearchTerm.getText().toString();
HttpLoggingInterceptor interceptor = new HttpLoggingInterceptor();
interceptor.setLevel(HttpLoggingInterceptor.Level.BODY);
OkHttpClient client = new OkHttpClient.Builder().addInterceptor(interceptor).build();
Retrofit retrofit = new Retrofit.Builder()
.baseUrl("https://api.flickr.com/services/rest/")
.client(client)
.addConverterFactory(GsonConverterFactory.create())
.build();
ApiInterface apiInterface = retrofit.create(ApiInterface.class);
Call<Photos> call = apiInterface.getImages(mQuery);
call.enqueue(new Callback<Photos>() {
@Override
public void onResponse(Call<Photos> call, Response<Photos> response) {
Log.v("RESPONSE_CALLED", "ON_RESPONSE_CALLED");
String didItWork = String.valueOf(response.isSuccessful());
Log.v("SUCCESS?", didItWork);
Log.v("RESPONSE_CODE", String.valueOf(response.code()));
Photos photos = response.body();
Log.v("RESPONSE_BODY", "response:" + photos);
String total = response.body().getTotal();
Log.v("Total", total);
List<Photos.Photo> photoResults = response.body().getPhoto();
for (Photos.Photo photo : photoResults) {
Log.v("PHOTO_URL:", photo.getTitle()
);
}
}
@Override
public void onFailure(Call<Photos> call, Throwable t) {
}
});
}
});
mSearchButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
Intent toSearch = new Intent(MainActivity.this, FlickRActivity.class);
startActivity(toSearch);
}
});
}
//Synchronous vs. Asynchronous
public interface ApiInterface {
@GET("?method=flickr.photos.search&api_key=1c448390199c03a6f2d436c40defd90e&format=json&nojsoncallback=1&extras=url_m")
Call<Photos> getImages(@Query("text") String query);
}
}
java
android json rest retrofit edited yesterday
barbsan
2,131521
asked Sep 11 '16 at 22:52
tccpg288
1,11911533
I am having difficulty with Retrofit as I am trying to understand what I should expect to see in the response.body() that is returned.
I think I have a mapping error in my JSON to POJO conversion because I am not seeing the right response when I print it to the log.
Here is the response I am seeing:
V/RESPONSE_BODY: response:com.troychuinard.flickr_test.Model.Model@36b2e4c9
I would expect this response to simply be the JSON data. I know I am making the correct call to FlickR, as I am using the logging interceptor to see the JSON:
https://api.flickr.com/services/rest/?method=flickr.photos.getRecent&api_key=1c448390199c03a6f2d436c40defd90e&format=json&nojsoncallback=1&extras=url_m&text=test
Model:
public class Model {
Photos photos;
int code;
String stat;
String message; // when you text = null
public class Photos {
@SerializedName("page")
@Expose
private int page;
@SerializedName("pages")
@Expose
private int pages;
@SerializedName("perpage")
@Expose
private int perpage;
@SerializedName("total")
@Expose
private String total;
@SerializedName("photo")
@Expose
private List<Photo> photo = new ArrayList<Photo>();
/**
* @return The page
*/
public int getPage() {
return page;
}
/**
* @param page The page
*/
public void setPage(int page) {
this.page = page;
}
/**
* @return The pages
*/
public int getPages() {
return pages;
}
/**
* @param pages The pages
*/
public void setPages(int pages) {
this.pages = pages;
}
/**
* @return The perpage
*/
public int getPerpage() {
return perpage;
}
/**
* @param perpage The perpage
*/
public void setPerpage(int perpage) {
this.perpage = perpage;
}
/**
* @return The total
*/
public String getTotal() {
return total;
}
/**
* @param total The total
*/
public void setTotal(String total) {
this.total = total;
}
/**
* @return The photo
*/
public List<Photo> getPhoto() {
return photo;
}
/**
* @param photo The photo
*/
public void setPhoto(List<Photo> photo) {
this.photo = photo;
}
}
public class Photo {
@SerializedName("id")
@Expose
private String id;
@SerializedName("owner")
@Expose
private String owner;
@SerializedName("secret")
@Expose
private String secret;
@SerializedName("server")
@Expose
private String server;
@SerializedName("farm")
@Expose
private int farm;
@SerializedName("title")
@Expose
private String title;
@SerializedName("ispublic")
@Expose
private int ispublic;
@SerializedName("isfriend")
@Expose
private int isfriend;
@SerializedName("isfamily")
@Expose
private int isfamily;
@SerializedName("url_m")
@Expose
private String urlM;
@SerializedName("height_m")
@Expose
private String heightM;
@SerializedName("width_m")
@Expose
private String widthM;
public Photo(){
}
/**
* @return The id
*/
public String getId() {
return id;
}
/**
* @param id The id
*/
public void setId(String id) {
this.id = id;
}
/**
* @return The owner
*/
public String getOwner() {
return owner;
}
/**
* @param owner The owner
*/
public void setOwner(String owner) {
this.owner = owner;
}
/**
* @return The secret
*/
public String getSecret() {
return secret;
}
/**
* @param secret The secret
*/
public void setSecret(String secret) {
this.secret = secret;
}
/**
* @return The server
*/
public String getServer() {
return server;
}
/**
* @param server The server
*/
public void setServer(String server) {
this.server = server;
}
/**
* @return The farm
*/
public int getFarm() {
return farm;
}
/**
* @param farm The farm
*/
public void setFarm(int farm) {
this.farm = farm;
}
/**
* @return The title
*/
public String getTitle() {
return title;
}
/**
* @param title The title
*/
public void setTitle(String title) {
this.title = title;
}
/**
* @return The ispublic
*/
public int getIspublic() {
return ispublic;
}
/**
* @param ispublic The ispublic
*/
public void setIspublic(int ispublic) {
this.ispublic = ispublic;
}
/**
* @return The isfriend
*/
public int getIsfriend() {
return isfriend;
}
/**
* @param isfriend The isfriend
*/
public void setIsfriend(int isfriend) {
this.isfriend = isfriend;
}
/**
* @return The isfamily
*/
public int getIsfamily() {
return isfamily;
}
/**
* @param isfamily The isfamily
*/
public void setIsfamily(int isfamily) {
this.isfamily = isfamily;
}
/**
* @return The urlM
*/
public String getUrlM() {
return urlM;
}
/**
* @param urlM The url_m
*/
public void setUrlM(String urlM) {
this.urlM = urlM;
}
/**
* @return The heightM
*/
public String getHeightM() {
return heightM;
}
/**
* @param heightM The height_m
*/
public void setHeightM(String heightM) {
this.heightM = heightM;
}
/**
* @return The widthM
*/
public String getWidthM() {
return widthM;
}
/**
* @param widthM The width_m
*/
public void setWidthM(String widthM) {
this.widthM = widthM;
}
}
}
JSON Response:
{
photos: {
page: 1,
pages: 3683,
perpage: 100,
total: "368270",
photo: [
{
id: "29264707352",
owner: "84316756@N02",
secret: "9ed355a86e",
server: "8603",
farm: 9,
title: "Tercer Patio de los Claustros de la Compañía/ Arequipa",
ispublic: 1,
isfriend: 0,
isfamily: 0,
url_m: "https://farm9.staticflickr.com/8603/29264707352_9ed355a86e.jpg",
height_m: "500",
width_m: "333"
},
{
id: "29339070436",
owner: "146617764@N02",
secret: "b52f1e9914",
server: "8509",
farm: 9,
title: "2016-04-17 09.24.07",
ispublic: 1,
isfriend: 0,
isfamily: 0,
url_m: "https://farm9.staticflickr.com/8509/29339070436_b52f1e9914.jpg",
height_m: "281",
width_m: "500"
},
LOGCAT
09-03 15:11:33.037 1846-1846/com.troychuinard.flickr_test E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.troychuinard.flickr_test, PID: 1846
java.lang.NullPointerException: println needs a message
at android.util.Log.println_native(Native Method)
at android.util.Log.v(Log.java:118)
at com.troychuinard.flickr_test.MainActivity$1$1.onResponse(MainActivity.java:72)
at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run(ExecutorCallAdapterFactory.java:68)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5254)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
09-03 15:14:21.858 1846-1846/com.troychuinard.flickr_test I/Process: Sending signal. PID: 1846 SIG: 9
Line 72
Log.v("RESPONSE_BODY", response.body().getTotal());
Activity
public class MainActivity extends AppCompatActivity {
private EditText mSearchTerm;
private Button mRequestButton;
private Button mSearchButton;
private String mQuery;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
mSearchTerm = (EditText) findViewById(R.id.ediText_search_term);
mRequestButton = (Button) findViewById(R.id.request_button);
mSearchButton = (Button) findViewById(R.id.search_button_flickr);
mRequestButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
mQuery = mSearchTerm.getText().toString();
HttpLoggingInterceptor interceptor = new HttpLoggingInterceptor();
interceptor.setLevel(HttpLoggingInterceptor.Level.BODY);
OkHttpClient client = new OkHttpClient.Builder().addInterceptor(interceptor).build();
Retrofit retrofit = new Retrofit.Builder()
.baseUrl("https://api.flickr.com/services/rest/")
.client(client)
.addConverterFactory(GsonConverterFactory.create())
.build();
ApiInterface apiInterface = retrofit.create(ApiInterface.class);
Call<Photos> call = apiInterface.getImages(mQuery);
call.enqueue(new Callback<Photos>() {
@Override
public void onResponse(Call<Photos> call, Response<Photos> response) {
Log.v("RESPONSE_CALLED", "ON_RESPONSE_CALLED");
String didItWork = String.valueOf(response.isSuccessful());
Log.v("SUCCESS?", didItWork);
Log.v("RESPONSE_CODE", String.valueOf(response.code()));
Photos photos = response.body();
Log.v("RESPONSE_BODY", "response:" + photos);
String total = response.body().getTotal();
Log.v("Total", total);
List<Photos.Photo> photoResults = response.body().getPhoto();
for (Photos.Photo photo : photoResults) {
Log.v("PHOTO_URL:", photo.getTitle()
);
}
}
@Override
public void onFailure(Call<Photos> call, Throwable t) {
}
});
}
});
mSearchButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
Intent toSearch = new Intent(MainActivity.this, FlickRActivity.class);
startActivity(toSearch);
}
});
}
//Synchronous vs. Asynchronous
public interface ApiInterface {
@GET("?method=flickr.photos.search&api_key=1c448390199c03a6f2d436c40defd90e&format=json&nojsoncallback=1&extras=url_m")
Call<Photos> getImages(@Query("text") String query);
}
}
java
android json rest retrofit java
android json rest retrofit edited yesterday
barbsan
2,131521
asked Sep 11 '16 at 22:52
tccpg288
1,11911533
edited yesterday
barbsan
2,131521
asked Sep 11 '16 at 22:52
tccpg288
1,11911533
edited yesterday
barbsan
2,131521
edited yesterday
barbsan
2,131521
edited yesterday
barbsan
2,131521
2,131521
asked Sep 11 '16 at 22:52
tccpg288
1,11911533
asked Sep 11 '16 at 22:52
tccpg288
1,11911533
asked Sep 11 '16 at 22:52
tccpg288
1,11911533
1,11911533
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
up vote
1
down vote
accepted
I think I have a mapping error in my JSON to POJO conversion
Yes you are right , you have problem with JSON to POJO conversion . I have created the POJO based on your Json Response
The main or root Class , I named "Flicker" , then "Flicker" class contains another property of class "Photos" , and "Photos" contains a List of object of class Photo
Here are the classes ,
Flicker.java
public class Flicker {
private Photos photos;
private String stat;
public Photos getPhotos() {
return photos;
}
public void setPhotos(Photos photos) {
this.photos = photos;
}
public String getStat() {
return stat;
}
public void setStat(String stat) {
this.stat = stat;
}
}
Photos.java
public class Photos {
private Integer page;
private Integer pages;
private Integer perpage;
private Integer total;
private List<Photo> photo = new ArrayList<Photo>();
public Integer getPage() {
return page;
}
public void setPage(Integer page) {
this.page = page;
}
public Integer getPages() {
return pages;
}
public void setPages(Integer pages) {
this.pages = pages;
}
public Integer getPerpage() {
return perpage;
}
public void setPerpage(Integer perpage) {
this.perpage = perpage;
}
public Integer getTotal() {
return total;
}
public void setTotal(Integer total) {
this.total = total;
}
public List<Photo> getPhoto() {
return photo;
}
public void setPhoto(List<Photo> photo) {
this.photo = photo;
}
}
Photo.java
public class Photo {
private String id;
private String owner;
private String secret;
private String server;
private Integer farm;
private String title;
private Integer ispublic;
private Integer isfriend;
private Integer isfamily;
private String url_m;
private String height_m;
private String width_m;
public String getId() {
return id;
}
public void setId(String id) {
this.id = id;
}
public String getOwner() {
return owner;
}
public void setOwner(String owner) {
this.owner = owner;
}
public String getSecret() {
return secret;
}
public void setSecret(String secret) {
this.secret = secret;
}
public String getServer() {
return server;
}
public void setServer(String server) {
this.server = server;
}
public Integer getFarm() {
return farm;
}
public void setFarm(Integer farm) {
this.farm = farm;
}
public String getTitle() {
return title;
}
public void setTitle(String title) {
this.title = title;
}
public Integer getIspublic() {
return ispublic;
}
public void setIspublic(Integer ispublic) {
this.ispublic = ispublic;
}
public Integer getIsfriend() {
return isfriend;
}
public void setIsfriend(Integer isfriend) {
this.isfriend = isfriend;
}
public Integer getIsfamily() {
return isfamily;
}
public void setIsfamily(Integer isfamily) {
this.isfamily = isfamily;
}
public String getUrl_m() {
return url_m;
}
public void setUrl_m(String url_m) {
this.url_m = url_m;
}
public String getHeight_m() {
return height_m;
}
public void setHeight_m(String height_m) {
this.height_m = height_m;
}
public String getWidth_m() {
return width_m;
}
public void setWidth_m(String width_m) {
this.width_m = width_m;
}
}
And I have created Retrofit client differently , This is what I have done , inside onClick method of code
mQuery = mSearchTerm.getText().toString();
Retrofit retrofit = new Retrofit.Builder()
.baseUrl("https://api.flickr.com/services/rest/")
.addConverterFactory(GsonConverterFactory.create())
.build();
ApiInterface apiInterface = retrofit.create(ApiInterface.class);
Call<Flicker> call = apiInterface.getImages(mQuery);
call.enqueue(new Callback<Flicker>() {
@Override
public void onResponse(Call<Flicker> call, Response<Flicker> response) {
Log.v("RESPONSE_CALLED", "ON_RESPONSE_CALLED");
String didItWork = String.valueOf(response.isSuccessful());
Log.v("SUCCESS?", didItWork);
Log.v("RESPONSE_CODE", String.valueOf(response.code()));
Flicker flicker_photos = response.body();
Log.v("RESPONSE_BODY", "response:" + flicker_photos);
String total = response.body().getPhotos().getTotal().toString();
Log.v("Total", total);
List<Photo> photoResults = response.body().getPhotos().getPhoto();
for (Photo photo : photoResults) {
Log.v("PHOTO_URL:", photo.getTitle()
);
}
}
@Override
public void onFailure(Call<Flicker> call, Throwable t) {
}
});
And I have added the following dependencies in my gradle
compile 'com.squareup.retrofit2:retrofit:2.1.0'
compile 'com.squareup.retrofit2:converter-gson:2.1.0'
Everything is working . Hope it helps . Let me if your problem is fixed or not
answered Sep 12 '16 at 0:08
Mithun Sarker Shuvro
1,90152038
Everything is working perfectly. Was it simply a mapping error, what exactly was wrong? Took me a while to figure it all out.
– tccpg288
Sep 13 '16 at 0:31
The only issue I am noticing is that while looping through the photo : photoResults, I return a few results and then get a nullPointer. Try searching "lebron james" and let me know if you crash.
– tccpg288
Sep 13 '16 at 0:58
add a comment |
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
1
down vote
accepted
I think I have a mapping error in my JSON to POJO conversion
Yes you are right , you have problem with JSON to POJO conversion . I have created the POJO based on your Json Response
The main or root Class , I named "Flicker" , then "Flicker" class contains another property of class "Photos" , and "Photos" contains a List of object of class Photo
Here are the classes ,
Flicker.java
public class Flicker {
private Photos photos;
private String stat;
public Photos getPhotos() {
return photos;
}
public void setPhotos(Photos photos) {
this.photos = photos;
}
public String getStat() {
return stat;
}
public void setStat(String stat) {
this.stat = stat;
}
}
Photos.java
public class Photos {
private Integer page;
private Integer pages;
private Integer perpage;
private Integer total;
private List<Photo> photo = new ArrayList<Photo>();
public Integer getPage() {
return page;
}
public void setPage(Integer page) {
this.page = page;
}
public Integer getPages() {
return pages;
}
public void setPages(Integer pages) {
this.pages = pages;
}
public Integer getPerpage() {
return perpage;
}
public void setPerpage(Integer perpage) {
this.perpage = perpage;
}
public Integer getTotal() {
return total;
}
public void setTotal(Integer total) {
this.total = total;
}
public List<Photo> getPhoto() {
return photo;
}
public void setPhoto(List<Photo> photo) {
this.photo = photo;
}
}
Photo.java
public class Photo {
private String id;
private String owner;
private String secret;
private String server;
private Integer farm;
private String title;
private Integer ispublic;
private Integer isfriend;
private Integer isfamily;
private String url_m;
private String height_m;
private String width_m;
public String getId() {
return id;
}
public void setId(String id) {
this.id = id;
}
public String getOwner() {
return owner;
}
public void setOwner(String owner) {
this.owner = owner;
}
public String getSecret() {
return secret;
}
public void setSecret(String secret) {
this.secret = secret;
}
public String getServer() {
return server;
}
public void setServer(String server) {
this.server = server;
}
public Integer getFarm() {
return farm;
}
public void setFarm(Integer farm) {
this.farm = farm;
}
public String getTitle() {
return title;
}
public void setTitle(String title) {
this.title = title;
}
public Integer getIspublic() {
return ispublic;
}
public void setIspublic(Integer ispublic) {
this.ispublic = ispublic;
}
public Integer getIsfriend() {
return isfriend;
}
public void setIsfriend(Integer isfriend) {
this.isfriend = isfriend;
}
public Integer getIsfamily() {
return isfamily;
}
public void setIsfamily(Integer isfamily) {
this.isfamily = isfamily;
}
public String getUrl_m() {
return url_m;
}
public void setUrl_m(String url_m) {
this.url_m = url_m;
}
public String getHeight_m() {
return height_m;
}
public void setHeight_m(String height_m) {
this.height_m = height_m;
}
public String getWidth_m() {
return width_m;
}
public void setWidth_m(String width_m) {
this.width_m = width_m;
}
}
And I have created Retrofit client differently , This is what I have done , inside onClick method of code
mQuery = mSearchTerm.getText().toString();
Retrofit retrofit = new Retrofit.Builder()
.baseUrl("https://api.flickr.com/services/rest/")
.addConverterFactory(GsonConverterFactory.create())
.build();
ApiInterface apiInterface = retrofit.create(ApiInterface.class);
Call<Flicker> call = apiInterface.getImages(mQuery);
call.enqueue(new Callback<Flicker>() {
@Override
public void onResponse(Call<Flicker> call, Response<Flicker> response) {
Log.v("RESPONSE_CALLED", "ON_RESPONSE_CALLED");
String didItWork = String.valueOf(response.isSuccessful());
Log.v("SUCCESS?", didItWork);
Log.v("RESPONSE_CODE", String.valueOf(response.code()));
Flicker flicker_photos = response.body();
Log.v("RESPONSE_BODY", "response:" + flicker_photos);
String total = response.body().getPhotos().getTotal().toString();
Log.v("Total", total);
List<Photo> photoResults = response.body().getPhotos().getPhoto();
for (Photo photo : photoResults) {
Log.v("PHOTO_URL:", photo.getTitle()
);
}
}
@Override
public void onFailure(Call<Flicker> call, Throwable t) {
}
});
And I have added the following dependencies in my gradle
compile 'com.squareup.retrofit2:retrofit:2.1.0'
compile 'com.squareup.retrofit2:converter-gson:2.1.0'
Everything is working . Hope it helps . Let me if your problem is fixed or not
answered Sep 12 '16 at 0:08
Mithun Sarker Shuvro
1,90152038
Everything is working perfectly. Was it simply a mapping error, what exactly was wrong? Took me a while to figure it all out.
– tccpg288
Sep 13 '16 at 0:31
The only issue I am noticing is that while looping through the photo : photoResults, I return a few results and then get a nullPointer. Try searching "lebron james" and let me know if you crash.
– tccpg288
Sep 13 '16 at 0:58
add a comment |
up vote
1
down vote
accepted
I think I have a mapping error in my JSON to POJO conversion
Yes you are right , you have problem with JSON to POJO conversion . I have created the POJO based on your Json Response
The main or root Class , I named "Flicker" , then "Flicker" class contains another property of class "Photos" , and "Photos" contains a List of object of class Photo
Here are the classes ,
Flicker.java
public class Flicker {
private Photos photos;
private String stat;
public Photos getPhotos() {
return photos;
}
public void setPhotos(Photos photos) {
this.photos = photos;
}
public String getStat() {
return stat;
}
public void setStat(String stat) {
this.stat = stat;
}
}
Photos.java
public class Photos {
private Integer page;
private Integer pages;
private Integer perpage;
private Integer total;
private List<Photo> photo = new ArrayList<Photo>();
public Integer getPage() {
return page;
}
public void setPage(Integer page) {
this.page = page;
}
public Integer getPages() {
return pages;
}
public void setPages(Integer pages) {
this.pages = pages;
}
public Integer getPerpage() {
return perpage;
}
public void setPerpage(Integer perpage) {
this.perpage = perpage;
}
public Integer getTotal() {
return total;
}
public void setTotal(Integer total) {
this.total = total;
}
public List<Photo> getPhoto() {
return photo;
}
public void setPhoto(List<Photo> photo) {
this.photo = photo;
}
}
Photo.java
public class Photo {
private String id;
private String owner;
private String secret;
private String server;
private Integer farm;
private String title;
private Integer ispublic;
private Integer isfriend;
private Integer isfamily;
private String url_m;
private String height_m;
private String width_m;
public String getId() {
return id;
}
public void setId(String id) {
this.id = id;
}
public String getOwner() {
return owner;
}
public void setOwner(String owner) {
this.owner = owner;
}
public String getSecret() {
return secret;
}
public void setSecret(String secret) {
this.secret = secret;
}
public String getServer() {
return server;
}
public void setServer(String server) {
this.server = server;
}
public Integer getFarm() {
return farm;
}
public void setFarm(Integer farm) {
this.farm = farm;
}
public String getTitle() {
return title;
}
public void setTitle(String title) {
this.title = title;
}
public Integer getIspublic() {
return ispublic;
}
public void setIspublic(Integer ispublic) {
this.ispublic = ispublic;
}
public Integer getIsfriend() {
return isfriend;
}
public void setIsfriend(Integer isfriend) {
this.isfriend = isfriend;
}
public Integer getIsfamily() {
return isfamily;
}
public void setIsfamily(Integer isfamily) {
this.isfamily = isfamily;
}
public String getUrl_m() {
return url_m;
}
public void setUrl_m(String url_m) {
this.url_m = url_m;
}
public String getHeight_m() {
return height_m;
}
public void setHeight_m(String height_m) {
this.height_m = height_m;
}
public String getWidth_m() {
return width_m;
}
public void setWidth_m(String width_m) {
this.width_m = width_m;
}
}
And I have created Retrofit client differently , This is what I have done , inside onClick method of code
mQuery = mSearchTerm.getText().toString();
Retrofit retrofit = new Retrofit.Builder()
.baseUrl("https://api.flickr.com/services/rest/")
.addConverterFactory(GsonConverterFactory.create())
.build();
ApiInterface apiInterface = retrofit.create(ApiInterface.class);
Call<Flicker> call = apiInterface.getImages(mQuery);
call.enqueue(new Callback<Flicker>() {
@Override
public void onResponse(Call<Flicker> call, Response<Flicker> response) {
Log.v("RESPONSE_CALLED", "ON_RESPONSE_CALLED");
String didItWork = String.valueOf(response.isSuccessful());
Log.v("SUCCESS?", didItWork);
Log.v("RESPONSE_CODE", String.valueOf(response.code()));
Flicker flicker_photos = response.body();
Log.v("RESPONSE_BODY", "response:" + flicker_photos);
String total = response.body().getPhotos().getTotal().toString();
Log.v("Total", total);
List<Photo> photoResults = response.body().getPhotos().getPhoto();
for (Photo photo : photoResults) {
Log.v("PHOTO_URL:", photo.getTitle()
);
}
}
@Override
public void onFailure(Call<Flicker> call, Throwable t) {
}
});
And I have added the following dependencies in my gradle
compile 'com.squareup.retrofit2:retrofit:2.1.0'
compile 'com.squareup.retrofit2:converter-gson:2.1.0'
Everything is working . Hope it helps . Let me if your problem is fixed or not
answered Sep 12 '16 at 0:08
Mithun Sarker Shuvro
1,90152038
Everything is working perfectly. Was it simply a mapping error, what exactly was wrong? Took me a while to figure it all out.
– tccpg288
Sep 13 '16 at 0:31
The only issue I am noticing is that while looping through the photo : photoResults, I return a few results and then get a nullPointer. Try searching "lebron james" and let me know if you crash.
– tccpg288
Sep 13 '16 at 0:58
add a comment |
up vote
1
down vote
accepted
up vote
1
down vote
accepted
I think I have a mapping error in my JSON to POJO conversion
Yes you are right , you have problem with JSON to POJO conversion . I have created the POJO based on your Json Response
The main or root Class , I named "Flicker" , then "Flicker" class contains another property of class "Photos" , and "Photos" contains a List of object of class Photo
Here are the classes ,
Flicker.java
public class Flicker {
private Photos photos;
private String stat;
public Photos getPhotos() {
return photos;
}
public void setPhotos(Photos photos) {
this.photos = photos;
}
public String getStat() {
return stat;
}
public void setStat(String stat) {
this.stat = stat;
}
}
Photos.java
public class Photos {
private Integer page;
private Integer pages;
private Integer perpage;
private Integer total;
private List<Photo> photo = new ArrayList<Photo>();
public Integer getPage() {
return page;
}
public void setPage(Integer page) {
this.page = page;
}
public Integer getPages() {
return pages;
}
public void setPages(Integer pages) {
this.pages = pages;
}
public Integer getPerpage() {
return perpage;
}
public void setPerpage(Integer perpage) {
this.perpage = perpage;
}
public Integer getTotal() {
return total;
}
public void setTotal(Integer total) {
this.total = total;
}
public List<Photo> getPhoto() {
return photo;
}
public void setPhoto(List<Photo> photo) {
this.photo = photo;
}
}
Photo.java
public class Photo {
private String id;
private String owner;
private String secret;
private String server;
private Integer farm;
private String title;
private Integer ispublic;
private Integer isfriend;
private Integer isfamily;
private String url_m;
private String height_m;
private String width_m;
public String getId() {
return id;
}
public void setId(String id) {
this.id = id;
}
public String getOwner() {
return owner;
}
public void setOwner(String owner) {
this.owner = owner;
}
public String getSecret() {
return secret;
}
public void setSecret(String secret) {
this.secret = secret;
}
public String getServer() {
return server;
}
public void setServer(String server) {
this.server = server;
}
public Integer getFarm() {
return farm;
}
public void setFarm(Integer farm) {
this.farm = farm;
}
public String getTitle() {
return title;
}
public void setTitle(String title) {
this.title = title;
}
public Integer getIspublic() {
return ispublic;
}
public void setIspublic(Integer ispublic) {
this.ispublic = ispublic;
}
public Integer getIsfriend() {
return isfriend;
}
public void setIsfriend(Integer isfriend) {
this.isfriend = isfriend;
}
public Integer getIsfamily() {
return isfamily;
}
public void setIsfamily(Integer isfamily) {
this.isfamily = isfamily;
}
public String getUrl_m() {
return url_m;
}
public void setUrl_m(String url_m) {
this.url_m = url_m;
}
public String getHeight_m() {
return height_m;
}
public void setHeight_m(String height_m) {
this.height_m = height_m;
}
public String getWidth_m() {
return width_m;
}
public void setWidth_m(String width_m) {
this.width_m = width_m;
}
}
And I have created Retrofit client differently , This is what I have done , inside onClick method of code
mQuery = mSearchTerm.getText().toString();
Retrofit retrofit = new Retrofit.Builder()
.baseUrl("https://api.flickr.com/services/rest/")
.addConverterFactory(GsonConverterFactory.create())
.build();
ApiInterface apiInterface = retrofit.create(ApiInterface.class);
Call<Flicker> call = apiInterface.getImages(mQuery);
call.enqueue(new Callback<Flicker>() {
@Override
public void onResponse(Call<Flicker> call, Response<Flicker> response) {
Log.v("RESPONSE_CALLED", "ON_RESPONSE_CALLED");
String didItWork = String.valueOf(response.isSuccessful());
Log.v("SUCCESS?", didItWork);
Log.v("RESPONSE_CODE", String.valueOf(response.code()));
Flicker flicker_photos = response.body();
Log.v("RESPONSE_BODY", "response:" + flicker_photos);
String total = response.body().getPhotos().getTotal().toString();
Log.v("Total", total);
List<Photo> photoResults = response.body().getPhotos().getPhoto();
for (Photo photo : photoResults) {
Log.v("PHOTO_URL:", photo.getTitle()
);
}
}
@Override
public void onFailure(Call<Flicker> call, Throwable t) {
}
});
And I have added the following dependencies in my gradle
compile 'com.squareup.retrofit2:retrofit:2.1.0'
compile 'com.squareup.retrofit2:converter-gson:2.1.0'
Everything is working . Hope it helps . Let me if your problem is fixed or not
answered Sep 12 '16 at 0:08
Mithun Sarker Shuvro
1,90152038
I think I have a mapping error in my JSON to POJO conversion
Yes you are right , you have problem with JSON to POJO conversion . I have created the POJO based on your Json Response
The main or root Class , I named "Flicker" , then "Flicker" class contains another property of class "Photos" , and "Photos" contains a List of object of class Photo
Here are the classes ,
Flicker.java
public class Flicker {
private Photos photos;
private String stat;
public Photos getPhotos() {
return photos;
}
public void setPhotos(Photos photos) {
this.photos = photos;
}
public String getStat() {
return stat;
}
public void setStat(String stat) {
this.stat = stat;
}
}
Photos.java
public class Photos {
private Integer page;
private Integer pages;
private Integer perpage;
private Integer total;
private List<Photo> photo = new ArrayList<Photo>();
public Integer getPage() {
return page;
}
public void setPage(Integer page) {
this.page = page;
}
public Integer getPages() {
return pages;
}
public void setPages(Integer pages) {
this.pages = pages;
}
public Integer getPerpage() {
return perpage;
}
public void setPerpage(Integer perpage) {
this.perpage = perpage;
}
public Integer getTotal() {
return total;
}
public void setTotal(Integer total) {
this.total = total;
}
public List<Photo> getPhoto() {
return photo;
}
public void setPhoto(List<Photo> photo) {
this.photo = photo;
}
}
Photo.java
public class Photo {
private String id;
private String owner;
private String secret;
private String server;
private Integer farm;
private String title;
private Integer ispublic;
private Integer isfriend;
private Integer isfamily;
private String url_m;
private String height_m;
private String width_m;
public String getId() {
return id;
}
public void setId(String id) {
this.id = id;
}
public String getOwner() {
return owner;
}
public void setOwner(String owner) {
this.owner = owner;
}
public String getSecret() {
return secret;
}
public void setSecret(String secret) {
this.secret = secret;
}
public String getServer() {
return server;
}
public void setServer(String server) {
this.server = server;
}
public Integer getFarm() {
return farm;
}
public void setFarm(Integer farm) {
this.farm = farm;
}
public String getTitle() {
return title;
}
public void setTitle(String title) {
this.title = title;
}
public Integer getIspublic() {
return ispublic;
}
public void setIspublic(Integer ispublic) {
this.ispublic = ispublic;
}
public Integer getIsfriend() {
return isfriend;
}
public void setIsfriend(Integer isfriend) {
this.isfriend = isfriend;
}
public Integer getIsfamily() {
return isfamily;
}
public void setIsfamily(Integer isfamily) {
this.isfamily = isfamily;
}
public String getUrl_m() {
return url_m;
}
public void setUrl_m(String url_m) {
this.url_m = url_m;
}
public String getHeight_m() {
return height_m;
}
public void setHeight_m(String height_m) {
this.height_m = height_m;
}
public String getWidth_m() {
return width_m;
}
public void setWidth_m(String width_m) {
this.width_m = width_m;
}
}
And I have created Retrofit client differently , This is what I have done , inside onClick method of code
mQuery = mSearchTerm.getText().toString();
Retrofit retrofit = new Retrofit.Builder()
.baseUrl("https://api.flickr.com/services/rest/")
.addConverterFactory(GsonConverterFactory.create())
.build();
ApiInterface apiInterface = retrofit.create(ApiInterface.class);
Call<Flicker> call = apiInterface.getImages(mQuery);
call.enqueue(new Callback<Flicker>() {
@Override
public void onResponse(Call<Flicker> call, Response<Flicker> response) {
Log.v("RESPONSE_CALLED", "ON_RESPONSE_CALLED");
String didItWork = String.valueOf(response.isSuccessful());
Log.v("SUCCESS?", didItWork);
Log.v("RESPONSE_CODE", String.valueOf(response.code()));
Flicker flicker_photos = response.body();
Log.v("RESPONSE_BODY", "response:" + flicker_photos);
String total = response.body().getPhotos().getTotal().toString();
Log.v("Total", total);
List<Photo> photoResults = response.body().getPhotos().getPhoto();
for (Photo photo : photoResults) {
Log.v("PHOTO_URL:", photo.getTitle()
);
}
}
@Override
public void onFailure(Call<Flicker> call, Throwable t) {
}
});
And I have added the following dependencies in my gradle
compile 'com.squareup.retrofit2:retrofit:2.1.0'
compile 'com.squareup.retrofit2:converter-gson:2.1.0'
Everything is working . Hope it helps . Let me if your problem is fixed or not
answered Sep 12 '16 at 0:08
Mithun Sarker Shuvro
1,90152038
answered Sep 12 '16 at 0:08
Mithun Sarker Shuvro
1,90152038
answered Sep 12 '16 at 0:08
Mithun Sarker Shuvro
1,90152038
answered Sep 12 '16 at 0:08
Mithun Sarker Shuvro
1,90152038
1,90152038
Everything is working perfectly. Was it simply a mapping error, what exactly was wrong? Took me a while to figure it all out.
– tccpg288
Sep 13 '16 at 0:31
The only issue I am noticing is that while looping through the photo : photoResults, I return a few results and then get a nullPointer. Try searching "lebron james" and let me know if you crash.
– tccpg288
Sep 13 '16 at 0:58
add a comment |
Everything is working perfectly. Was it simply a mapping error, what exactly was wrong? Took me a while to figure it all out.
– tccpg288
Sep 13 '16 at 0:31
The only issue I am noticing is that while looping through the photo : photoResults, I return a few results and then get a nullPointer. Try searching "lebron james" and let me know if you crash.
– tccpg288
Sep 13 '16 at 0:58
Everything is working perfectly. Was it simply a mapping error, what exactly was wrong? Took me a while to figure it all out.
– tccpg288
Sep 13 '16 at 0:31
Everything is working perfectly. Was it simply a mapping error, what exactly was wrong? Took me a while to figure it all out.
– tccpg288
Sep 13 '16 at 0:31
The only issue I am noticing is that while looping through the photo : photoResults, I return a few results and then get a nullPointer. Try searching "lebron james" and let me know if you crash.
– tccpg288
Sep 13 '16 at 0:58
The only issue I am noticing is that while looping through the photo : photoResults, I return a few results and then get a nullPointer. Try searching "lebron james" and let me know if you crash.
– tccpg288
Sep 13 '16 at 0:58
add a comment |
draft saved
draft discarded
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f39441418%2fparsing-retrofit-response-body%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
