Mixing
Jpeg to Bmp conversion takes unreasonable amount of time
I have this function that takes 4.2 seconds to convert a jpg to bmp.
Why it takes so long? Can I make if faster?
IrfanView loads and converts the file in only a fraction of that time.
I thought that is spends most of the time in JPG.LoadFromFile. But when I measured the time I was surprised to see it spends most of the time in BMP.Assing(JPG).
function ConvertJPG2BMP(CONST FileName: string): TBitmap;
VAR JPG: TJpegImage;
begin
Result:= NIL;
JPG:= TJpegImage.Create;
TRY
JPG.LoadFromFile(FileName);
if (JPG.Width > 0) AND (JPG.Width < 32768)
AND (JPG.Height> 0) AND (JPG.Height < 32768) then
begin
Result:= TBitmap.Create;
TRY
Result.HandleType:= bmDIB;
// Fuji_FinePix_F550.JPG [3200x1800] [1.44MB]
Result.Assign(JPG); <--- 4 seconds!!
EXCEPT
FreeAndNil(Result);
END;
end;
FINALLY
FreeAndNil(JPG);
end;
end;
delphi
asked Nov 19 '18 at 20:21
RigelRigel
9,94014111220
add a comment |
I have this function that takes 4.2 seconds to convert a jpg to bmp.
Why it takes so long? Can I make if faster?
IrfanView loads and converts the file in only a fraction of that time.
I thought that is spends most of the time in JPG.LoadFromFile. But when I measured the time I was surprised to see it spends most of the time in BMP.Assing(JPG).
function ConvertJPG2BMP(CONST FileName: string): TBitmap;
VAR JPG: TJpegImage;
begin
Result:= NIL;
JPG:= TJpegImage.Create;
TRY
JPG.LoadFromFile(FileName);
if (JPG.Width > 0) AND (JPG.Width < 32768)
AND (JPG.Height> 0) AND (JPG.Height < 32768) then
begin
Result:= TBitmap.Create;
TRY
Result.HandleType:= bmDIB;
// Fuji_FinePix_F550.JPG [3200x1800] [1.44MB]
Result.Assign(JPG); <--- 4 seconds!!
EXCEPT
FreeAndNil(Result);
END;
end;
FINALLY
FreeAndNil(JPG);
end;
end;
delphi
asked Nov 19 '18 at 20:21
RigelRigel
9,94014111220
1
Actual decompression occurs in the assign function. That's why its slow.
– Orhan ODABAŞI
Nov 19 '18 at 20:43
1
Since you are not showing your image anywhere in your application you could try to useTBitmapclass fromFMX.Graphicsto load the image from JPG and then directly save it to BMP. YesFMX.Graphics.TBitmapclass can also be used in VCL application.
– SilverWarior
Nov 20 '18 at 11:17
there is this open source library for imaging. I see some ASM code in the JPG unit. I haven't tested yet: sourceforge.net/p/imaginglib/code/ci/default/tree/Source/…
– Rigel
Nov 22 '18 at 8:36
add a comment |
I have this function that takes 4.2 seconds to convert a jpg to bmp.
Why it takes so long? Can I make if faster?
IrfanView loads and converts the file in only a fraction of that time.
I thought that is spends most of the time in JPG.LoadFromFile. But when I measured the time I was surprised to see it spends most of the time in BMP.Assing(JPG).
function ConvertJPG2BMP(CONST FileName: string): TBitmap;
VAR JPG: TJpegImage;
begin
Result:= NIL;
JPG:= TJpegImage.Create;
TRY
JPG.LoadFromFile(FileName);
if (JPG.Width > 0) AND (JPG.Width < 32768)
AND (JPG.Height> 0) AND (JPG.Height < 32768) then
begin
Result:= TBitmap.Create;
TRY
Result.HandleType:= bmDIB;
// Fuji_FinePix_F550.JPG [3200x1800] [1.44MB]
Result.Assign(JPG); <--- 4 seconds!!
EXCEPT
FreeAndNil(Result);
END;
end;
FINALLY
FreeAndNil(JPG);
end;
end;
delphi
asked Nov 19 '18 at 20:21
RigelRigel
9,94014111220
I have this function that takes 4.2 seconds to convert a jpg to bmp.
Why it takes so long? Can I make if faster?
IrfanView loads and converts the file in only a fraction of that time.
I thought that is spends most of the time in JPG.LoadFromFile. But when I measured the time I was surprised to see it spends most of the time in BMP.Assing(JPG).
function ConvertJPG2BMP(CONST FileName: string): TBitmap;
VAR JPG: TJpegImage;
begin
Result:= NIL;
JPG:= TJpegImage.Create;
TRY
JPG.LoadFromFile(FileName);
if (JPG.Width > 0) AND (JPG.Width < 32768)
AND (JPG.Height> 0) AND (JPG.Height < 32768) then
begin
Result:= TBitmap.Create;
TRY
Result.HandleType:= bmDIB;
// Fuji_FinePix_F550.JPG [3200x1800] [1.44MB]
Result.Assign(JPG); <--- 4 seconds!!
EXCEPT
FreeAndNil(Result);
END;
end;
FINALLY
FreeAndNil(JPG);
end;
end;
delphi
delphi
asked Nov 19 '18 at 20:21
RigelRigel
9,94014111220
asked Nov 19 '18 at 20:21
RigelRigel
9,94014111220
edited Nov 19 '18 at 20:33
Rigel
asked Nov 19 '18 at 20:21
RigelRigel
9,94014111220
asked Nov 19 '18 at 20:21
RigelRigel
9,94014111220
asked Nov 19 '18 at 20:21
RigelRigel
9,94014111220
9,94014111220
1
Actual decompression occurs in the assign function. That's why its slow.
– Orhan ODABAŞI
Nov 19 '18 at 20:43
1
Since you are not showing your image anywhere in your application you could try to useTBitmapclass fromFMX.Graphicsto load the image from JPG and then directly save it to BMP. YesFMX.Graphics.TBitmapclass can also be used in VCL application.
– SilverWarior
Nov 20 '18 at 11:17
there is this open source library for imaging. I see some ASM code in the JPG unit. I haven't tested yet: sourceforge.net/p/imaginglib/code/ci/default/tree/Source/…
– Rigel
Nov 22 '18 at 8:36
add a comment |
1
Actual decompression occurs in the assign function. That's why its slow.
– Orhan ODABAŞI
Nov 19 '18 at 20:43
1
Since you are not showing your image anywhere in your application you could try to useTBitmapclass fromFMX.Graphicsto load the image from JPG and then directly save it to BMP. YesFMX.Graphics.TBitmapclass can also be used in VCL application.
– SilverWarior
Nov 20 '18 at 11:17
there is this open source library for imaging. I see some ASM code in the JPG unit. I haven't tested yet: sourceforge.net/p/imaginglib/code/ci/default/tree/Source/…
– Rigel
Nov 22 '18 at 8:36
1
1
Actual decompression occurs in the assign function. That's why its slow.
– Orhan ODABAŞI
Nov 19 '18 at 20:43
Actual decompression occurs in the assign function. That's why its slow.
– Orhan ODABAŞI
Nov 19 '18 at 20:43
1
1
Since you are not showing your image anywhere in your application you could try to use
TBitmap class from FMX.Graphics to load the image from JPG and then directly save it to BMP. Yes FMX.Graphics.TBitmap class can also be used in VCL application.– SilverWarior
Nov 20 '18 at 11:17
Since you are not showing your image anywhere in your application you could try to use
TBitmap class from FMX.Graphics to load the image from JPG and then directly save it to BMP. Yes FMX.Graphics.TBitmap class can also be used in VCL application.– SilverWarior
Nov 20 '18 at 11:17
there is this open source library for imaging. I see some ASM code in the JPG unit. I haven't tested yet: sourceforge.net/p/imaginglib/code/ci/default/tree/Source/…
– Rigel
Nov 22 '18 at 8:36
there is this open source library for imaging. I see some ASM code in the JPG unit. I haven't tested yet: sourceforge.net/p/imaginglib/code/ci/default/tree/Source/…
– Rigel
Nov 22 '18 at 8:36
add a comment |
3 Answers
3
active
oldest
votes
Since I wanted to test the slightly older functions once, it is a good opportunity to do this now.
The sources used are here
These have been changed a bit in the code below.
Somewhat adapted source code of OP's function ConvertJPG2BMP() (2512 : ms)
function ConvertJPG2BMP(CONST FileName: string): TBitmap;
VAR
JPG: TJpegImage;
begin
Result:= NIL;
JPG:= TJpegImage.Create;
TRY
JPG.LoadFromFile(FileName);
if (JPG.Width > 0) AND (JPG.Width < 32768)
AND (JPG.Height> 0) AND (JPG.Height < 32768) then
begin
Result:= TBitmap.Create;
TRY
Result.PixelFormat := pf24bit;
Result.Width := JPG.Width;
Result.Height := JPG.Height;
Result.HandleType:= bmDIB;
// 2018-10-17 14.04.23.jpg [2560x1920] [1.66MB]
Result.Assign(JPG);
Result.SaveToFile('F:ProgramFilesEmbarcaderodtxProjectsBmp-DIBJPG2BMP.bmp');
EXCEPT
FreeAndNil(Result);
END;
end;
FINALLY
FreeAndNil(JPG);
end;
end;
The source for the TWICImage usage (296 : ms)
There is another class in Vcl.Graphics? called TWICImage that handles images supported by the Microsoft Imaging Component
Including BMP, GIF, ICO, JPEG, PNG, TIF and Windows Media Photo
procedure LoadImageFromStream(Stream: TStream; Image: TImage);
var
wic: TWICImage;
Bitmap: TBitmap;
begin
Stream.Position := 0;
wic := TWICImage.Create;
try
wic.LoadFromStream(Stream);
Image.Picture.Assign(wic);
Bitmap := TBitmap.Create;
try
Bitmap.PixelFormat := pf24bit;
Bitmap.Width := Image.Picture.Width;
Bitmap.Height := Image.Picture.Height;
Bitmap.Canvas.Draw(0, 0, Image.Picture.Graphic);
Bitmap.SaveToFile('F:ProgramFilesEmbarcaderodtxProjectsBmp-DIBTWICImage.bmp');
finally
Bitmap.Free;
end;
finally
wic.Free;
end;
end;
procedure RenderImage(const Filename: string);
var
fs: TFileStream;
begin
fs := TFileStream.Create(Filename, fmOpenRead);
try
LoadImageFromStream(fs, Form1.Image1);
finally
fs.Free;
end;
end;
GetTickCount for all tested routines.
procedure TForm1.Button1Click(Sender: TObject);
var
MyDIB : TBitmap;
loadStr : string;
XStart,Xend : LongWord;
begin
loadStr := 'F:ProgramFilesEmbarcaderodtxProjectsBmp-DIB2018-10-17 14.04.23.jpg';
XStart := GetTickCount;
if RadioGroup1.ItemIndex = 0 then MyDIB := ConvertJPG2BMP(loadStr);// ConvertJPG2BMP()
if RadioGroup1.ItemIndex = 1 then TestBmp(loadStr);
if RadioGroup1.ItemIndex = 2 then RenderImage(loadStr);// TWICImage
if RadioGroup1.ItemIndex = 3 then GetOleGraphic(loadStr);
Xend := GetTickCount;
Label1.Caption := IntToStr(xEnd-XStart) + ' : MS' ;
end;
The generated images are identical to the file size only from the function GetOleGraphic() is a smaller file produced with a worse resolution?
here the source used for the GetOleGraphic()
edited Nov 20 '18 at 10:54
Rigel
9,94014111220
answered Nov 20 '18 at 6:27
moskito-xmoskito-x
10.6k43550
1
What about the time for TPicture? I guess is similar with the one for Jpg2Bmp. Right?
– Rigel
Nov 20 '18 at 10:51
in "LoadImageFromStream" -> Is it possible to assign the wic directly to a BMP? so, we get rid of TImage
– Rigel
Nov 20 '18 at 11:26
TPicture = 2356 ms :"Is it possible to assign the wic directly to a BMP?"-> You can try to improve it :-)
– moskito-x
Nov 20 '18 at 15:46
add a comment |
Here is a compact version of WIC image loader posted by moskito-x above.
Please VOTE HIS answer not mine. My answer here is only to provide the compact version and some details.
{ Uses TWICImage
>8 times faster than Delphi's JPG function
Tested with:
Animated GIF, PNG, JPG
Drawbacks:
Fails with JPEG2K
No EXIF support.}
function LoadImageWic(CONST FileName: string): TBitmap;
VAR
wic: TWICImage;
begin
wic := TWICImage.Create;
TRY
wic.LoadFromFile(FileName);
Result := TBitmap.Create;
TRY
Result.Assign(wic);
EXCEPT
FreeAndNil(Result);
END;
FINALLY
FreeAndNil(wic);
END;
end;
answered Nov 21 '18 at 19:45
RigelRigel
9,94014111220
1
Thanks : fast, short and flush.
– moskito-x
Nov 21 '18 at 19:50
add a comment |
Just try to decompress the jpeg using our Open Source SynGDIPlus unit.
We found it much faster than the Delphi built-in jpeg.pas unit.
The latest revision can be retrieved from github.
As an alternative, you may try to use our fast Jpeg decoder using SSE2 but it doesn't handle all kind of Jpegs, and it is for Win32 only.
edited Nov 19 '18 at 22:47
David Heffernan
515k348151207
answered Nov 19 '18 at 21:28
Arnaud BouchezArnaud Bouchez
37.1k356135
I think I tried it in the past and it was showing JPEGs in black and white colors only.
– Rigel
Nov 20 '18 at 12:23
@Rigel SynGdiPlus (and the SSE2 decoder) are used on production for years to produce jpeg-oriented videos with great stability (in a multi-threaded server process) and much better performance than the standard jpeg.pas unit - so I guess something was wrong with your use
– Arnaud Bouchez
Nov 21 '18 at 13:35
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53382075%2fjpeg-to-bmp-conversion-takes-unreasonable-amount-of-time%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
3 Answers
3
active
oldest
votes
3 Answers
3
active
oldest
votes
active
oldest
votes
active
oldest
votes
Since I wanted to test the slightly older functions once, it is a good opportunity to do this now.
The sources used are here
These have been changed a bit in the code below.
Somewhat adapted source code of OP's function ConvertJPG2BMP() (2512 : ms)
function ConvertJPG2BMP(CONST FileName: string): TBitmap;
VAR
JPG: TJpegImage;
begin
Result:= NIL;
JPG:= TJpegImage.Create;
TRY
JPG.LoadFromFile(FileName);
if (JPG.Width > 0) AND (JPG.Width < 32768)
AND (JPG.Height> 0) AND (JPG.Height < 32768) then
begin
Result:= TBitmap.Create;
TRY
Result.PixelFormat := pf24bit;
Result.Width := JPG.Width;
Result.Height := JPG.Height;
Result.HandleType:= bmDIB;
// 2018-10-17 14.04.23.jpg [2560x1920] [1.66MB]
Result.Assign(JPG);
Result.SaveToFile('F:ProgramFilesEmbarcaderodtxProjectsBmp-DIBJPG2BMP.bmp');
EXCEPT
FreeAndNil(Result);
END;
end;
FINALLY
FreeAndNil(JPG);
end;
end;
The source for the TWICImage usage (296 : ms)
There is another class in Vcl.Graphics? called TWICImage that handles images supported by the Microsoft Imaging Component
Including BMP, GIF, ICO, JPEG, PNG, TIF and Windows Media Photo
procedure LoadImageFromStream(Stream: TStream; Image: TImage);
var
wic: TWICImage;
Bitmap: TBitmap;
begin
Stream.Position := 0;
wic := TWICImage.Create;
try
wic.LoadFromStream(Stream);
Image.Picture.Assign(wic);
Bitmap := TBitmap.Create;
try
Bitmap.PixelFormat := pf24bit;
Bitmap.Width := Image.Picture.Width;
Bitmap.Height := Image.Picture.Height;
Bitmap.Canvas.Draw(0, 0, Image.Picture.Graphic);
Bitmap.SaveToFile('F:ProgramFilesEmbarcaderodtxProjectsBmp-DIBTWICImage.bmp');
finally
Bitmap.Free;
end;
finally
wic.Free;
end;
end;
procedure RenderImage(const Filename: string);
var
fs: TFileStream;
begin
fs := TFileStream.Create(Filename, fmOpenRead);
try
LoadImageFromStream(fs, Form1.Image1);
finally
fs.Free;
end;
end;
GetTickCount for all tested routines.
procedure TForm1.Button1Click(Sender: TObject);
var
MyDIB : TBitmap;
loadStr : string;
XStart,Xend : LongWord;
begin
loadStr := 'F:ProgramFilesEmbarcaderodtxProjectsBmp-DIB2018-10-17 14.04.23.jpg';
XStart := GetTickCount;
if RadioGroup1.ItemIndex = 0 then MyDIB := ConvertJPG2BMP(loadStr);// ConvertJPG2BMP()
if RadioGroup1.ItemIndex = 1 then TestBmp(loadStr);
if RadioGroup1.ItemIndex = 2 then RenderImage(loadStr);// TWICImage
if RadioGroup1.ItemIndex = 3 then GetOleGraphic(loadStr);
Xend := GetTickCount;
Label1.Caption := IntToStr(xEnd-XStart) + ' : MS' ;
end;
The generated images are identical to the file size only from the function GetOleGraphic() is a smaller file produced with a worse resolution?
here the source used for the GetOleGraphic()
edited Nov 20 '18 at 10:54
Rigel
9,94014111220
answered Nov 20 '18 at 6:27
moskito-xmoskito-x
10.6k43550
1
What about the time for TPicture? I guess is similar with the one for Jpg2Bmp. Right?
– Rigel
Nov 20 '18 at 10:51
in "LoadImageFromStream" -> Is it possible to assign the wic directly to a BMP? so, we get rid of TImage
– Rigel
Nov 20 '18 at 11:26
TPicture = 2356 ms :"Is it possible to assign the wic directly to a BMP?"-> You can try to improve it :-)
– moskito-x
Nov 20 '18 at 15:46
add a comment |
Since I wanted to test the slightly older functions once, it is a good opportunity to do this now.
The sources used are here
These have been changed a bit in the code below.
Somewhat adapted source code of OP's function ConvertJPG2BMP() (2512 : ms)
function ConvertJPG2BMP(CONST FileName: string): TBitmap;
VAR
JPG: TJpegImage;
begin
Result:= NIL;
JPG:= TJpegImage.Create;
TRY
JPG.LoadFromFile(FileName);
if (JPG.Width > 0) AND (JPG.Width < 32768)
AND (JPG.Height> 0) AND (JPG.Height < 32768) then
begin
Result:= TBitmap.Create;
TRY
Result.PixelFormat := pf24bit;
Result.Width := JPG.Width;
Result.Height := JPG.Height;
Result.HandleType:= bmDIB;
// 2018-10-17 14.04.23.jpg [2560x1920] [1.66MB]
Result.Assign(JPG);
Result.SaveToFile('F:ProgramFilesEmbarcaderodtxProjectsBmp-DIBJPG2BMP.bmp');
EXCEPT
FreeAndNil(Result);
END;
end;
FINALLY
FreeAndNil(JPG);
end;
end;
The source for the TWICImage usage (296 : ms)
There is another class in Vcl.Graphics? called TWICImage that handles images supported by the Microsoft Imaging Component
Including BMP, GIF, ICO, JPEG, PNG, TIF and Windows Media Photo
procedure LoadImageFromStream(Stream: TStream; Image: TImage);
var
wic: TWICImage;
Bitmap: TBitmap;
begin
Stream.Position := 0;
wic := TWICImage.Create;
try
wic.LoadFromStream(Stream);
Image.Picture.Assign(wic);
Bitmap := TBitmap.Create;
try
Bitmap.PixelFormat := pf24bit;
Bitmap.Width := Image.Picture.Width;
Bitmap.Height := Image.Picture.Height;
Bitmap.Canvas.Draw(0, 0, Image.Picture.Graphic);
Bitmap.SaveToFile('F:ProgramFilesEmbarcaderodtxProjectsBmp-DIBTWICImage.bmp');
finally
Bitmap.Free;
end;
finally
wic.Free;
end;
end;
procedure RenderImage(const Filename: string);
var
fs: TFileStream;
begin
fs := TFileStream.Create(Filename, fmOpenRead);
try
LoadImageFromStream(fs, Form1.Image1);
finally
fs.Free;
end;
end;
GetTickCount for all tested routines.
procedure TForm1.Button1Click(Sender: TObject);
var
MyDIB : TBitmap;
loadStr : string;
XStart,Xend : LongWord;
begin
loadStr := 'F:ProgramFilesEmbarcaderodtxProjectsBmp-DIB2018-10-17 14.04.23.jpg';
XStart := GetTickCount;
if RadioGroup1.ItemIndex = 0 then MyDIB := ConvertJPG2BMP(loadStr);// ConvertJPG2BMP()
if RadioGroup1.ItemIndex = 1 then TestBmp(loadStr);
if RadioGroup1.ItemIndex = 2 then RenderImage(loadStr);// TWICImage
if RadioGroup1.ItemIndex = 3 then GetOleGraphic(loadStr);
Xend := GetTickCount;
Label1.Caption := IntToStr(xEnd-XStart) + ' : MS' ;
end;
The generated images are identical to the file size only from the function GetOleGraphic() is a smaller file produced with a worse resolution?
here the source used for the GetOleGraphic()
edited Nov 20 '18 at 10:54
Rigel
9,94014111220
answered Nov 20 '18 at 6:27
moskito-xmoskito-x
10.6k43550
1
What about the time for TPicture? I guess is similar with the one for Jpg2Bmp. Right?
– Rigel
Nov 20 '18 at 10:51
in "LoadImageFromStream" -> Is it possible to assign the wic directly to a BMP? so, we get rid of TImage
– Rigel
Nov 20 '18 at 11:26
TPicture = 2356 ms :"Is it possible to assign the wic directly to a BMP?"-> You can try to improve it :-)
– moskito-x
Nov 20 '18 at 15:46
add a comment |
Since I wanted to test the slightly older functions once, it is a good opportunity to do this now.
The sources used are here
These have been changed a bit in the code below.
Somewhat adapted source code of OP's function ConvertJPG2BMP() (2512 : ms)
function ConvertJPG2BMP(CONST FileName: string): TBitmap;
VAR
JPG: TJpegImage;
begin
Result:= NIL;
JPG:= TJpegImage.Create;
TRY
JPG.LoadFromFile(FileName);
if (JPG.Width > 0) AND (JPG.Width < 32768)
AND (JPG.Height> 0) AND (JPG.Height < 32768) then
begin
Result:= TBitmap.Create;
TRY
Result.PixelFormat := pf24bit;
Result.Width := JPG.Width;
Result.Height := JPG.Height;
Result.HandleType:= bmDIB;
// 2018-10-17 14.04.23.jpg [2560x1920] [1.66MB]
Result.Assign(JPG);
Result.SaveToFile('F:ProgramFilesEmbarcaderodtxProjectsBmp-DIBJPG2BMP.bmp');
EXCEPT
FreeAndNil(Result);
END;
end;
FINALLY
FreeAndNil(JPG);
end;
end;
The source for the TWICImage usage (296 : ms)
There is another class in Vcl.Graphics? called TWICImage that handles images supported by the Microsoft Imaging Component
Including BMP, GIF, ICO, JPEG, PNG, TIF and Windows Media Photo
procedure LoadImageFromStream(Stream: TStream; Image: TImage);
var
wic: TWICImage;
Bitmap: TBitmap;
begin
Stream.Position := 0;
wic := TWICImage.Create;
try
wic.LoadFromStream(Stream);
Image.Picture.Assign(wic);
Bitmap := TBitmap.Create;
try
Bitmap.PixelFormat := pf24bit;
Bitmap.Width := Image.Picture.Width;
Bitmap.Height := Image.Picture.Height;
Bitmap.Canvas.Draw(0, 0, Image.Picture.Graphic);
Bitmap.SaveToFile('F:ProgramFilesEmbarcaderodtxProjectsBmp-DIBTWICImage.bmp');
finally
Bitmap.Free;
end;
finally
wic.Free;
end;
end;
procedure RenderImage(const Filename: string);
var
fs: TFileStream;
begin
fs := TFileStream.Create(Filename, fmOpenRead);
try
LoadImageFromStream(fs, Form1.Image1);
finally
fs.Free;
end;
end;
GetTickCount for all tested routines.
procedure TForm1.Button1Click(Sender: TObject);
var
MyDIB : TBitmap;
loadStr : string;
XStart,Xend : LongWord;
begin
loadStr := 'F:ProgramFilesEmbarcaderodtxProjectsBmp-DIB2018-10-17 14.04.23.jpg';
XStart := GetTickCount;
if RadioGroup1.ItemIndex = 0 then MyDIB := ConvertJPG2BMP(loadStr);// ConvertJPG2BMP()
if RadioGroup1.ItemIndex = 1 then TestBmp(loadStr);
if RadioGroup1.ItemIndex = 2 then RenderImage(loadStr);// TWICImage
if RadioGroup1.ItemIndex = 3 then GetOleGraphic(loadStr);
Xend := GetTickCount;
Label1.Caption := IntToStr(xEnd-XStart) + ' : MS' ;
end;
The generated images are identical to the file size only from the function GetOleGraphic() is a smaller file produced with a worse resolution?
here the source used for the GetOleGraphic()
edited Nov 20 '18 at 10:54
Rigel
9,94014111220
answered Nov 20 '18 at 6:27
moskito-xmoskito-x
10.6k43550
Since I wanted to test the slightly older functions once, it is a good opportunity to do this now.
The sources used are here
These have been changed a bit in the code below.
Somewhat adapted source code of OP's function ConvertJPG2BMP() (2512 : ms)
function ConvertJPG2BMP(CONST FileName: string): TBitmap;
VAR
JPG: TJpegImage;
begin
Result:= NIL;
JPG:= TJpegImage.Create;
TRY
JPG.LoadFromFile(FileName);
if (JPG.Width > 0) AND (JPG.Width < 32768)
AND (JPG.Height> 0) AND (JPG.Height < 32768) then
begin
Result:= TBitmap.Create;
TRY
Result.PixelFormat := pf24bit;
Result.Width := JPG.Width;
Result.Height := JPG.Height;
Result.HandleType:= bmDIB;
// 2018-10-17 14.04.23.jpg [2560x1920] [1.66MB]
Result.Assign(JPG);
Result.SaveToFile('F:ProgramFilesEmbarcaderodtxProjectsBmp-DIBJPG2BMP.bmp');
EXCEPT
FreeAndNil(Result);
END;
end;
FINALLY
FreeAndNil(JPG);
end;
end;
The source for the TWICImage usage (296 : ms)
There is another class in Vcl.Graphics? called TWICImage that handles images supported by the Microsoft Imaging Component
Including BMP, GIF, ICO, JPEG, PNG, TIF and Windows Media Photo
procedure LoadImageFromStream(Stream: TStream; Image: TImage);
var
wic: TWICImage;
Bitmap: TBitmap;
begin
Stream.Position := 0;
wic := TWICImage.Create;
try
wic.LoadFromStream(Stream);
Image.Picture.Assign(wic);
Bitmap := TBitmap.Create;
try
Bitmap.PixelFormat := pf24bit;
Bitmap.Width := Image.Picture.Width;
Bitmap.Height := Image.Picture.Height;
Bitmap.Canvas.Draw(0, 0, Image.Picture.Graphic);
Bitmap.SaveToFile('F:ProgramFilesEmbarcaderodtxProjectsBmp-DIBTWICImage.bmp');
finally
Bitmap.Free;
end;
finally
wic.Free;
end;
end;
procedure RenderImage(const Filename: string);
var
fs: TFileStream;
begin
fs := TFileStream.Create(Filename, fmOpenRead);
try
LoadImageFromStream(fs, Form1.Image1);
finally
fs.Free;
end;
end;
GetTickCount for all tested routines.
procedure TForm1.Button1Click(Sender: TObject);
var
MyDIB : TBitmap;
loadStr : string;
XStart,Xend : LongWord;
begin
loadStr := 'F:ProgramFilesEmbarcaderodtxProjectsBmp-DIB2018-10-17 14.04.23.jpg';
XStart := GetTickCount;
if RadioGroup1.ItemIndex = 0 then MyDIB := ConvertJPG2BMP(loadStr);// ConvertJPG2BMP()
if RadioGroup1.ItemIndex = 1 then TestBmp(loadStr);
if RadioGroup1.ItemIndex = 2 then RenderImage(loadStr);// TWICImage
if RadioGroup1.ItemIndex = 3 then GetOleGraphic(loadStr);
Xend := GetTickCount;
Label1.Caption := IntToStr(xEnd-XStart) + ' : MS' ;
end;
The generated images are identical to the file size only from the function GetOleGraphic() is a smaller file produced with a worse resolution?
here the source used for the GetOleGraphic()
edited Nov 20 '18 at 10:54
Rigel
9,94014111220
answered Nov 20 '18 at 6:27
moskito-xmoskito-x
10.6k43550
edited Nov 20 '18 at 10:54
Rigel
9,94014111220
edited Nov 20 '18 at 10:54
Rigel
9,94014111220
edited Nov 20 '18 at 10:54
Rigel
9,94014111220
9,94014111220
answered Nov 20 '18 at 6:27
moskito-xmoskito-x
10.6k43550
answered Nov 20 '18 at 6:27
moskito-xmoskito-x
10.6k43550
answered Nov 20 '18 at 6:27
moskito-xmoskito-x
10.6k43550
10.6k43550
1
What about the time for TPicture? I guess is similar with the one for Jpg2Bmp. Right?
– Rigel
Nov 20 '18 at 10:51
in "LoadImageFromStream" -> Is it possible to assign the wic directly to a BMP? so, we get rid of TImage
– Rigel
Nov 20 '18 at 11:26
TPicture = 2356 ms :"Is it possible to assign the wic directly to a BMP?"-> You can try to improve it :-)
– moskito-x
Nov 20 '18 at 15:46
add a comment |
1
What about the time for TPicture? I guess is similar with the one for Jpg2Bmp. Right?
– Rigel
Nov 20 '18 at 10:51
in "LoadImageFromStream" -> Is it possible to assign the wic directly to a BMP? so, we get rid of TImage
– Rigel
Nov 20 '18 at 11:26
TPicture = 2356 ms :"Is it possible to assign the wic directly to a BMP?"-> You can try to improve it :-)
– moskito-x
Nov 20 '18 at 15:46
1
1
What about the time for TPicture? I guess is similar with the one for Jpg2Bmp. Right?
– Rigel
Nov 20 '18 at 10:51
What about the time for TPicture? I guess is similar with the one for Jpg2Bmp. Right?
– Rigel
Nov 20 '18 at 10:51
in "LoadImageFromStream" -> Is it possible to assign the wic directly to a BMP? so, we get rid of TImage
– Rigel
Nov 20 '18 at 11:26
in "LoadImageFromStream" -> Is it possible to assign the wic directly to a BMP? so, we get rid of TImage
– Rigel
Nov 20 '18 at 11:26
TPicture = 2356 ms :
"Is it possible to assign the wic directly to a BMP?" -> You can try to improve it :-)– moskito-x
Nov 20 '18 at 15:46
TPicture = 2356 ms :
"Is it possible to assign the wic directly to a BMP?" -> You can try to improve it :-)– moskito-x
Nov 20 '18 at 15:46
add a comment |
Here is a compact version of WIC image loader posted by moskito-x above.
Please VOTE HIS answer not mine. My answer here is only to provide the compact version and some details.
{ Uses TWICImage
>8 times faster than Delphi's JPG function
Tested with:
Animated GIF, PNG, JPG
Drawbacks:
Fails with JPEG2K
No EXIF support.}
function LoadImageWic(CONST FileName: string): TBitmap;
VAR
wic: TWICImage;
begin
wic := TWICImage.Create;
TRY
wic.LoadFromFile(FileName);
Result := TBitmap.Create;
TRY
Result.Assign(wic);
EXCEPT
FreeAndNil(Result);
END;
FINALLY
FreeAndNil(wic);
END;
end;
answered Nov 21 '18 at 19:45
RigelRigel
9,94014111220
1
Thanks : fast, short and flush.
– moskito-x
Nov 21 '18 at 19:50
add a comment |
Here is a compact version of WIC image loader posted by moskito-x above.
Please VOTE HIS answer not mine. My answer here is only to provide the compact version and some details.
{ Uses TWICImage
>8 times faster than Delphi's JPG function
Tested with:
Animated GIF, PNG, JPG
Drawbacks:
Fails with JPEG2K
No EXIF support.}
function LoadImageWic(CONST FileName: string): TBitmap;
VAR
wic: TWICImage;
begin
wic := TWICImage.Create;
TRY
wic.LoadFromFile(FileName);
Result := TBitmap.Create;
TRY
Result.Assign(wic);
EXCEPT
FreeAndNil(Result);
END;
FINALLY
FreeAndNil(wic);
END;
end;
answered Nov 21 '18 at 19:45
RigelRigel
9,94014111220
1
Thanks : fast, short and flush.
– moskito-x
Nov 21 '18 at 19:50
add a comment |
Here is a compact version of WIC image loader posted by moskito-x above.
Please VOTE HIS answer not mine. My answer here is only to provide the compact version and some details.
{ Uses TWICImage
>8 times faster than Delphi's JPG function
Tested with:
Animated GIF, PNG, JPG
Drawbacks:
Fails with JPEG2K
No EXIF support.}
function LoadImageWic(CONST FileName: string): TBitmap;
VAR
wic: TWICImage;
begin
wic := TWICImage.Create;
TRY
wic.LoadFromFile(FileName);
Result := TBitmap.Create;
TRY
Result.Assign(wic);
EXCEPT
FreeAndNil(Result);
END;
FINALLY
FreeAndNil(wic);
END;
end;
answered Nov 21 '18 at 19:45
RigelRigel
9,94014111220
Here is a compact version of WIC image loader posted by moskito-x above.
Please VOTE HIS answer not mine. My answer here is only to provide the compact version and some details.
{ Uses TWICImage
>8 times faster than Delphi's JPG function
Tested with:
Animated GIF, PNG, JPG
Drawbacks:
Fails with JPEG2K
No EXIF support.}
function LoadImageWic(CONST FileName: string): TBitmap;
VAR
wic: TWICImage;
begin
wic := TWICImage.Create;
TRY
wic.LoadFromFile(FileName);
Result := TBitmap.Create;
TRY
Result.Assign(wic);
EXCEPT
FreeAndNil(Result);
END;
FINALLY
FreeAndNil(wic);
END;
end;
answered Nov 21 '18 at 19:45
RigelRigel
9,94014111220
answered Nov 21 '18 at 19:45
RigelRigel
9,94014111220
answered Nov 21 '18 at 19:45
RigelRigel
9,94014111220
answered Nov 21 '18 at 19:45
RigelRigel
9,94014111220
9,94014111220
1
Thanks : fast, short and flush.
– moskito-x
Nov 21 '18 at 19:50
add a comment |
1
Thanks : fast, short and flush.
– moskito-x
Nov 21 '18 at 19:50
1
1
Thanks : fast, short and flush.
– moskito-x
Nov 21 '18 at 19:50
Thanks : fast, short and flush.
– moskito-x
Nov 21 '18 at 19:50
add a comment |
Just try to decompress the jpeg using our Open Source SynGDIPlus unit.
We found it much faster than the Delphi built-in jpeg.pas unit.
The latest revision can be retrieved from github.
As an alternative, you may try to use our fast Jpeg decoder using SSE2 but it doesn't handle all kind of Jpegs, and it is for Win32 only.
edited Nov 19 '18 at 22:47
David Heffernan
515k348151207
answered Nov 19 '18 at 21:28
Arnaud BouchezArnaud Bouchez
37.1k356135
I think I tried it in the past and it was showing JPEGs in black and white colors only.
– Rigel
Nov 20 '18 at 12:23
@Rigel SynGdiPlus (and the SSE2 decoder) are used on production for years to produce jpeg-oriented videos with great stability (in a multi-threaded server process) and much better performance than the standard jpeg.pas unit - so I guess something was wrong with your use
– Arnaud Bouchez
Nov 21 '18 at 13:35
add a comment |
Just try to decompress the jpeg using our Open Source SynGDIPlus unit.
We found it much faster than the Delphi built-in jpeg.pas unit.
The latest revision can be retrieved from github.
As an alternative, you may try to use our fast Jpeg decoder using SSE2 but it doesn't handle all kind of Jpegs, and it is for Win32 only.
edited Nov 19 '18 at 22:47
David Heffernan
515k348151207
answered Nov 19 '18 at 21:28
Arnaud BouchezArnaud Bouchez
37.1k356135
I think I tried it in the past and it was showing JPEGs in black and white colors only.
– Rigel
Nov 20 '18 at 12:23
@Rigel SynGdiPlus (and the SSE2 decoder) are used on production for years to produce jpeg-oriented videos with great stability (in a multi-threaded server process) and much better performance than the standard jpeg.pas unit - so I guess something was wrong with your use
– Arnaud Bouchez
Nov 21 '18 at 13:35
add a comment |
Just try to decompress the jpeg using our Open Source SynGDIPlus unit.
We found it much faster than the Delphi built-in jpeg.pas unit.
The latest revision can be retrieved from github.
As an alternative, you may try to use our fast Jpeg decoder using SSE2 but it doesn't handle all kind of Jpegs, and it is for Win32 only.
edited Nov 19 '18 at 22:47
David Heffernan
515k348151207
answered Nov 19 '18 at 21:28
Arnaud BouchezArnaud Bouchez
37.1k356135
Just try to decompress the jpeg using our Open Source SynGDIPlus unit.
We found it much faster than the Delphi built-in jpeg.pas unit.
The latest revision can be retrieved from github.
As an alternative, you may try to use our fast Jpeg decoder using SSE2 but it doesn't handle all kind of Jpegs, and it is for Win32 only.
edited Nov 19 '18 at 22:47
David Heffernan
515k348151207
answered Nov 19 '18 at 21:28
Arnaud BouchezArnaud Bouchez
37.1k356135
edited Nov 19 '18 at 22:47
David Heffernan
515k348151207
edited Nov 19 '18 at 22:47
David Heffernan
515k348151207
edited Nov 19 '18 at 22:47
David Heffernan
515k348151207
515k348151207
answered Nov 19 '18 at 21:28
Arnaud BouchezArnaud Bouchez
37.1k356135
answered Nov 19 '18 at 21:28
Arnaud BouchezArnaud Bouchez
37.1k356135
answered Nov 19 '18 at 21:28
Arnaud BouchezArnaud Bouchez
37.1k356135
37.1k356135
I think I tried it in the past and it was showing JPEGs in black and white colors only.
– Rigel
Nov 20 '18 at 12:23
@Rigel SynGdiPlus (and the SSE2 decoder) are used on production for years to produce jpeg-oriented videos with great stability (in a multi-threaded server process) and much better performance than the standard jpeg.pas unit - so I guess something was wrong with your use
– Arnaud Bouchez
Nov 21 '18 at 13:35
add a comment |
I think I tried it in the past and it was showing JPEGs in black and white colors only.
– Rigel
Nov 20 '18 at 12:23
@Rigel SynGdiPlus (and the SSE2 decoder) are used on production for years to produce jpeg-oriented videos with great stability (in a multi-threaded server process) and much better performance than the standard jpeg.pas unit - so I guess something was wrong with your use
– Arnaud Bouchez
Nov 21 '18 at 13:35
I think I tried it in the past and it was showing JPEGs in black and white colors only.
– Rigel
Nov 20 '18 at 12:23
I think I tried it in the past and it was showing JPEGs in black and white colors only.
– Rigel
Nov 20 '18 at 12:23
@Rigel SynGdiPlus (and the SSE2 decoder) are used on production for years to produce jpeg-oriented videos with great stability (in a multi-threaded server process) and much better performance than the standard jpeg.pas unit - so I guess something was wrong with your use
– Arnaud Bouchez
Nov 21 '18 at 13:35
@Rigel SynGdiPlus (and the SSE2 decoder) are used on production for years to produce jpeg-oriented videos with great stability (in a multi-threaded server process) and much better performance than the standard jpeg.pas unit - so I guess something was wrong with your use
– Arnaud Bouchez
Nov 21 '18 at 13:35
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53382075%2fjpeg-to-bmp-conversion-takes-unreasonable-amount-of-time%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Actual decompression occurs in the assign function. That's why its slow.
– Orhan ODABAŞI
Nov 19 '18 at 20:43
1
Since you are not showing your image anywhere in your application you could try to use
TBitmapclass fromFMX.Graphicsto load the image from JPG and then directly save it to BMP. YesFMX.Graphics.TBitmapclass can also be used in VCL application.– SilverWarior
Nov 20 '18 at 11:17
there is this open source library for imaging. I see some ASM code in the JPG unit. I haven't tested yet: sourceforge.net/p/imaginglib/code/ci/default/tree/Source/…
– Rigel
Nov 22 '18 at 8:36