Complex Expression Tree with no changing context of param











up vote
3
down vote

favorite












i need to dinamically generate expression like this:



Expression<Func<MyClass, bool>> expr = x => (x.SomeField.CompareTo(someValue) <= 0);


trying to do it like this:



var paramExpr = Expression.Parameter(typeof(MyClass), "x");

Expression<Func<MyClass, FieldType>> pathToField = x => x.SomeField;

Expression path = pathToField;

if (!(path is LambdaExpression lambdaMember))

    throw ...;

Expression valueExpr = Expression.Constant(someValue);

var bodyExpr = Expression.LessThanOrEqual(Expression.Call(lambdaMember.Body, "CompareTo", null, valueExpr ), Expression.Constant(0));

return Expression.Lambda<Func<MyClass, FieldType>>(bodyExpr, paramExpr);


but always getting error when trying to compile this:




variable 'x' of type 'MyClass' referenced from scope '', but it is not defined




how i could do this correctly?






c# reflection expression-trees







share|improve this question









New contributor




Razor Revenant is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.




















  • That doesn't compile. The var bodyExpr has a trailing },
    – MickyD
    yesterday

















up vote
3
down vote

favorite












i need to dinamically generate expression like this:



Expression<Func<MyClass, bool>> expr = x => (x.SomeField.CompareTo(someValue) <= 0);


trying to do it like this:



var paramExpr = Expression.Parameter(typeof(MyClass), "x");

Expression<Func<MyClass, FieldType>> pathToField = x => x.SomeField;

Expression path = pathToField;

if (!(path is LambdaExpression lambdaMember))

    throw ...;

Expression valueExpr = Expression.Constant(someValue);

var bodyExpr = Expression.LessThanOrEqual(Expression.Call(lambdaMember.Body, "CompareTo", null, valueExpr ), Expression.Constant(0));

return Expression.Lambda<Func<MyClass, FieldType>>(bodyExpr, paramExpr);


but always getting error when trying to compile this:




variable 'x' of type 'MyClass' referenced from scope '', but it is not defined




how i could do this correctly?






c# reflection expression-trees







share|improve this question









New contributor




Razor Revenant is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.




















  • That doesn't compile. The var bodyExpr has a trailing },
    – MickyD
    yesterday















up vote
3
down vote

favorite









up vote
3
down vote

favorite











i need to dinamically generate expression like this:



Expression<Func<MyClass, bool>> expr = x => (x.SomeField.CompareTo(someValue) <= 0);


trying to do it like this:



var paramExpr = Expression.Parameter(typeof(MyClass), "x");

Expression<Func<MyClass, FieldType>> pathToField = x => x.SomeField;

Expression path = pathToField;

if (!(path is LambdaExpression lambdaMember))

    throw ...;

Expression valueExpr = Expression.Constant(someValue);

var bodyExpr = Expression.LessThanOrEqual(Expression.Call(lambdaMember.Body, "CompareTo", null, valueExpr ), Expression.Constant(0));

return Expression.Lambda<Func<MyClass, FieldType>>(bodyExpr, paramExpr);


but always getting error when trying to compile this:




variable 'x' of type 'MyClass' referenced from scope '', but it is not defined




how i could do this correctly?






c# reflection expression-trees







share|improve this question









New contributor




Razor Revenant is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











i need to dinamically generate expression like this:



Expression<Func<MyClass, bool>> expr = x => (x.SomeField.CompareTo(someValue) <= 0);


trying to do it like this:



var paramExpr = Expression.Parameter(typeof(MyClass), "x");

Expression<Func<MyClass, FieldType>> pathToField = x => x.SomeField;

Expression path = pathToField;

if (!(path is LambdaExpression lambdaMember))

    throw ...;

Expression valueExpr = Expression.Constant(someValue);

var bodyExpr = Expression.LessThanOrEqual(Expression.Call(lambdaMember.Body, "CompareTo", null, valueExpr ), Expression.Constant(0));

return Expression.Lambda<Func<MyClass, FieldType>>(bodyExpr, paramExpr);


but always getting error when trying to compile this:




variable 'x' of type 'MyClass' referenced from scope '', but it is not defined




how i could do this correctly?






c# reflection expression-trees




c# reflection expression-trees






share|improve this question









New contributor




Razor Revenant is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.











share|improve this question









New contributor




Razor Revenant is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









share|improve this question




share|improve this question








edited yesterday





















New contributor




Razor Revenant is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









asked yesterday









Razor Revenant

214




214




New contributor




Razor Revenant is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.





New contributor





Razor Revenant is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.






Razor Revenant is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.












  • That doesn't compile. The var bodyExpr has a trailing },
    – MickyD
    yesterday




















  • That doesn't compile. The var bodyExpr has a trailing },
    – MickyD
    yesterday


















That doesn't compile. The var bodyExpr has a trailing },
– MickyD
yesterday






That doesn't compile. The var bodyExpr has a trailing },
– MickyD
yesterday














1 Answer
1






active

oldest

votes

















up vote
4
down vote



accepted










The problem here is that you're using lambdaMember.Body, which references the x from x => x.SomeField - but because you only used the .Body, that is undefined - and is unrelated to the x from Expression.Parameter(typeof(MyClass), "x");



In the general case, there are 2 options here:




  • invoke the entire lambda (i.e. lambdaMember, not lambdaMember.Body) - passing in the arguments to use for the parameters

  • rewrite the inner lambda at runtime using ExpressionVisitor - swapping out instances of the x from the inner expression with whatever you wanted to use as the argument - presumably paramExpr


The first option is easier, and is just Expression.Invoke:



var bodyExpr = Expression.LessThanOrEqual(

    Expression.Call(Expression.Invoke(lambdaMember, paramExpr),

    "CompareTo", null, valueExpr), Expression.Constant(0));


Note: there is a third option in this case, since it is a relatively simple example - you can just hijack the parameter from the inner expression and use it instead of declaring paramExpr as a new parameter expression:



var paramExpr = lambdaMember.Parameters.Single();

Expression valueExpr = Expression.Constant(someValue);

var bodyExpr = Expression.LessThanOrEqual(

    Expression.Call(lambdaMember.Body,

    "CompareTo", null, valueExpr), Expression.Constant(0));

return Expression.Lambda<Func<MyClass, FieldType>>(bodyExpr, lambdaMember.Parameters);





share|improve this answer























  • Thank you, but in third option u just get x => x.Field.CompareTo(value), not x => x.Field.CompareTo(value) <= 0
    – Razor Revenant
    yesterday












  • @RazorRevenant no, you don't; I think you've made a transcription error from the example I gave
    – Marc Gravell♦
    yesterday











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});






Razor Revenant is a new contributor. Be nice, and check out our Code of Conduct.










 

draft saved


draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53372563%2fcomplex-expression-tree-with-no-changing-context-of-param%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes








up vote
4
down vote



accepted










The problem here is that you're using lambdaMember.Body, which references the x from x => x.SomeField - but because you only used the .Body, that is undefined - and is unrelated to the x from Expression.Parameter(typeof(MyClass), "x");



In the general case, there are 2 options here:




  • invoke the entire lambda (i.e. lambdaMember, not lambdaMember.Body) - passing in the arguments to use for the parameters

  • rewrite the inner lambda at runtime using ExpressionVisitor - swapping out instances of the x from the inner expression with whatever you wanted to use as the argument - presumably paramExpr


The first option is easier, and is just Expression.Invoke:



var bodyExpr = Expression.LessThanOrEqual(

    Expression.Call(Expression.Invoke(lambdaMember, paramExpr),

    "CompareTo", null, valueExpr), Expression.Constant(0));


Note: there is a third option in this case, since it is a relatively simple example - you can just hijack the parameter from the inner expression and use it instead of declaring paramExpr as a new parameter expression:



var paramExpr = lambdaMember.Parameters.Single();

Expression valueExpr = Expression.Constant(someValue);

var bodyExpr = Expression.LessThanOrEqual(

    Expression.Call(lambdaMember.Body,

    "CompareTo", null, valueExpr), Expression.Constant(0));

return Expression.Lambda<Func<MyClass, FieldType>>(bodyExpr, lambdaMember.Parameters);





share|improve this answer























  • Thank you, but in third option u just get x => x.Field.CompareTo(value), not x => x.Field.CompareTo(value) <= 0
    – Razor Revenant
    yesterday












  • @RazorRevenant no, you don't; I think you've made a transcription error from the example I gave
    – Marc Gravell♦
    yesterday















up vote
4
down vote



accepted










The problem here is that you're using lambdaMember.Body, which references the x from x => x.SomeField - but because you only used the .Body, that is undefined - and is unrelated to the x from Expression.Parameter(typeof(MyClass), "x");



In the general case, there are 2 options here:




  • invoke the entire lambda (i.e. lambdaMember, not lambdaMember.Body) - passing in the arguments to use for the parameters

  • rewrite the inner lambda at runtime using ExpressionVisitor - swapping out instances of the x from the inner expression with whatever you wanted to use as the argument - presumably paramExpr


The first option is easier, and is just Expression.Invoke:



var bodyExpr = Expression.LessThanOrEqual(

    Expression.Call(Expression.Invoke(lambdaMember, paramExpr),

    "CompareTo", null, valueExpr), Expression.Constant(0));


Note: there is a third option in this case, since it is a relatively simple example - you can just hijack the parameter from the inner expression and use it instead of declaring paramExpr as a new parameter expression:



var paramExpr = lambdaMember.Parameters.Single();

Expression valueExpr = Expression.Constant(someValue);

var bodyExpr = Expression.LessThanOrEqual(

    Expression.Call(lambdaMember.Body,

    "CompareTo", null, valueExpr), Expression.Constant(0));

return Expression.Lambda<Func<MyClass, FieldType>>(bodyExpr, lambdaMember.Parameters);





share|improve this answer























  • Thank you, but in third option u just get x => x.Field.CompareTo(value), not x => x.Field.CompareTo(value) <= 0
    – Razor Revenant
    yesterday












  • @RazorRevenant no, you don't; I think you've made a transcription error from the example I gave
    – Marc Gravell♦
    yesterday













up vote
4
down vote



accepted







up vote
4
down vote



accepted






The problem here is that you're using lambdaMember.Body, which references the x from x => x.SomeField - but because you only used the .Body, that is undefined - and is unrelated to the x from Expression.Parameter(typeof(MyClass), "x");



In the general case, there are 2 options here:




  • invoke the entire lambda (i.e. lambdaMember, not lambdaMember.Body) - passing in the arguments to use for the parameters

  • rewrite the inner lambda at runtime using ExpressionVisitor - swapping out instances of the x from the inner expression with whatever you wanted to use as the argument - presumably paramExpr


The first option is easier, and is just Expression.Invoke:



var bodyExpr = Expression.LessThanOrEqual(

    Expression.Call(Expression.Invoke(lambdaMember, paramExpr),

    "CompareTo", null, valueExpr), Expression.Constant(0));


Note: there is a third option in this case, since it is a relatively simple example - you can just hijack the parameter from the inner expression and use it instead of declaring paramExpr as a new parameter expression:



var paramExpr = lambdaMember.Parameters.Single();

Expression valueExpr = Expression.Constant(someValue);

var bodyExpr = Expression.LessThanOrEqual(

    Expression.Call(lambdaMember.Body,

    "CompareTo", null, valueExpr), Expression.Constant(0));

return Expression.Lambda<Func<MyClass, FieldType>>(bodyExpr, lambdaMember.Parameters);





share|improve this answer














The problem here is that you're using lambdaMember.Body, which references the x from x => x.SomeField - but because you only used the .Body, that is undefined - and is unrelated to the x from Expression.Parameter(typeof(MyClass), "x");



In the general case, there are 2 options here:




  • invoke the entire lambda (i.e. lambdaMember, not lambdaMember.Body) - passing in the arguments to use for the parameters

  • rewrite the inner lambda at runtime using ExpressionVisitor - swapping out instances of the x from the inner expression with whatever you wanted to use as the argument - presumably paramExpr


The first option is easier, and is just Expression.Invoke:



var bodyExpr = Expression.LessThanOrEqual(

    Expression.Call(Expression.Invoke(lambdaMember, paramExpr),

    "CompareTo", null, valueExpr), Expression.Constant(0));


Note: there is a third option in this case, since it is a relatively simple example - you can just hijack the parameter from the inner expression and use it instead of declaring paramExpr as a new parameter expression:



var paramExpr = lambdaMember.Parameters.Single();

Expression valueExpr = Expression.Constant(someValue);

var bodyExpr = Expression.LessThanOrEqual(

    Expression.Call(lambdaMember.Body,

    "CompareTo", null, valueExpr), Expression.Constant(0));

return Expression.Lambda<Func<MyClass, FieldType>>(bodyExpr, lambdaMember.Parameters);






share|improve this answer














share|improve this answer



share|improve this answer








edited yesterday

























answered yesterday









Marc Gravell♦

769k19021152528




769k19021152528












  • Thank you, but in third option u just get x => x.Field.CompareTo(value), not x => x.Field.CompareTo(value) <= 0
    – Razor Revenant
    yesterday












  • @RazorRevenant no, you don't; I think you've made a transcription error from the example I gave
    – Marc Gravell♦
    yesterday


















  • Thank you, but in third option u just get x => x.Field.CompareTo(value), not x => x.Field.CompareTo(value) <= 0
    – Razor Revenant
    yesterday












  • @RazorRevenant no, you don't; I think you've made a transcription error from the example I gave
    – Marc Gravell♦
    yesterday
















Thank you, but in third option u just get x => x.Field.CompareTo(value), not x => x.Field.CompareTo(value) <= 0
– Razor Revenant
yesterday






Thank you, but in third option u just get x => x.Field.CompareTo(value), not x => x.Field.CompareTo(value) <= 0
– Razor Revenant
yesterday














@RazorRevenant no, you don't; I think you've made a transcription error from the example I gave
– Marc Gravell♦
yesterday




@RazorRevenant no, you don't; I think you've made a transcription error from the example I gave
– Marc Gravell♦
yesterday










Razor Revenant is a new contributor. Be nice, and check out our Code of Conduct.










 

draft saved


draft discarded


















Razor Revenant is a new contributor. Be nice, and check out our Code of Conduct.













Razor Revenant is a new contributor. Be nice, and check out our Code of Conduct.












Razor Revenant is a new contributor. Be nice, and check out our Code of Conduct.















 


draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53372563%2fcomplex-expression-tree-with-no-changing-context-of-param%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

android studio warns about leanback feature tag usage required on manifest while using Unity exported app?

Image
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ height:90px;width:728px;box-sizing:border-box; } 0 This is a simple project showing cubes on Unity, exported to android project and imported on Android studio. On maifest file it showed following warning: Expecting <uses-feature android:name="android.software.leanback" android:required="false" /> tag I have no information about it. And also on default emptyview android project does not use/mention this feature. I know it is required by TV's and such but why its not added by default? Why is this? And Should I concern about it? android unity3d
Read more

SQL update select statement

Image
0 I'm trying to update an entry in my database (postgresql). I'm having a problem with updating the query: INSERT INTO prices (price, product_id) SELECT product_price, commn_id FROM products_temp as prod WHERE NOT EXISTS (SELECT * FROM prices od WHERE prod.commn_id = od.product_id) OR prod.product_price != ( SELECT price FROM prices as p WHERE p.product_id = prod.commn_id order by p.end desc LIMIT 1 ) Query works fine when i delete: OR prod.product_price != ( SELECT price FROM prices as p WHERE p.product_id = prod.commn_id order by p.end desc LIMIT 1 ) So it seems to me that it's looping through this operation. My question is, how can I fix it? sql postgresql
Read more

WPF add header to Image with URL pettitions [duplicate]

Image
up vote 0 down vote favorite This question already has an answer here: Image source URI requiring authorization 3 answers Add header to all* HTTP requests on a machine 1 answer first of all sorry for my english. Recently I added some security in the backend of my project, and now I need to send a validation code(apiKey) inside the headers to retrieve the images. I have a problem with ALL images in my project that I had attached in my UI. For example, before I had: <Image Height="90" Source="{Binding Video.Thumbnail}"/> Now I need to change my code to create a CUSTOM petition add the apiKey in the header:
Read more