Mixing
JS alert not playing once per session
I want an alert that plays if the user visits my website for the first time or if its their first time for a set amount of time. I have a function that checks if its the first visit then sends the alert. But it's not playing.
index.html
<script src="alert.js"></script>
alert.js
sessionStorage.setItem('firstVisit', '1');
function welcome(){
if (!sessionStorage.getItem('firstVisit') === "1"){
alert('yeet');
}
}
javascript html
asked Nov 19 '18 at 18:10
TerryJ26TerryJ26
133
add a comment |
I want an alert that plays if the user visits my website for the first time or if its their first time for a set amount of time. I have a function that checks if its the first visit then sends the alert. But it's not playing.
index.html
<script src="alert.js"></script>
alert.js
sessionStorage.setItem('firstVisit', '1');
function welcome(){
if (!sessionStorage.getItem('firstVisit') === "1"){
alert('yeet');
}
}
javascript html
asked Nov 19 '18 at 18:10
TerryJ26TerryJ26
133
1
You have to call the "welcome()" method.
– dev4life
Nov 19 '18 at 18:16
When are you doingsessionStorage.setItem('firstVisit', '1');?
– Frank Modica
Nov 19 '18 at 18:16
On every page load you are saying firstvisit = '1' and then if firstvisit is not '1' show alert. So how is it ever going to show the alert? firstvisit is always '1'.
– Nawed Khan
Nov 19 '18 at 18:17
add a comment |
I want an alert that plays if the user visits my website for the first time or if its their first time for a set amount of time. I have a function that checks if its the first visit then sends the alert. But it's not playing.
index.html
<script src="alert.js"></script>
alert.js
sessionStorage.setItem('firstVisit', '1');
function welcome(){
if (!sessionStorage.getItem('firstVisit') === "1"){
alert('yeet');
}
}
javascript html
asked Nov 19 '18 at 18:10
TerryJ26TerryJ26
133
I want an alert that plays if the user visits my website for the first time or if its their first time for a set amount of time. I have a function that checks if its the first visit then sends the alert. But it's not playing.
index.html
<script src="alert.js"></script>
alert.js
sessionStorage.setItem('firstVisit', '1');
function welcome(){
if (!sessionStorage.getItem('firstVisit') === "1"){
alert('yeet');
}
}
javascript html
javascript html
asked Nov 19 '18 at 18:10
TerryJ26TerryJ26
133
asked Nov 19 '18 at 18:10
TerryJ26TerryJ26
133
asked Nov 19 '18 at 18:10
TerryJ26TerryJ26
133
asked Nov 19 '18 at 18:10
TerryJ26TerryJ26
133
asked Nov 19 '18 at 18:10
TerryJ26TerryJ26
133
133
1
You have to call the "welcome()" method.
– dev4life
Nov 19 '18 at 18:16
When are you doingsessionStorage.setItem('firstVisit', '1');?
– Frank Modica
Nov 19 '18 at 18:16
On every page load you are saying firstvisit = '1' and then if firstvisit is not '1' show alert. So how is it ever going to show the alert? firstvisit is always '1'.
– Nawed Khan
Nov 19 '18 at 18:17
add a comment |
1
You have to call the "welcome()" method.
– dev4life
Nov 19 '18 at 18:16
When are you doingsessionStorage.setItem('firstVisit', '1');?
– Frank Modica
Nov 19 '18 at 18:16
On every page load you are saying firstvisit = '1' and then if firstvisit is not '1' show alert. So how is it ever going to show the alert? firstvisit is always '1'.
– Nawed Khan
Nov 19 '18 at 18:17
1
1
You have to call the "welcome()" method.
– dev4life
Nov 19 '18 at 18:16
You have to call the "welcome()" method.
– dev4life
Nov 19 '18 at 18:16
When are you doing
sessionStorage.setItem('firstVisit', '1');?– Frank Modica
Nov 19 '18 at 18:16
When are you doing
sessionStorage.setItem('firstVisit', '1');?– Frank Modica
Nov 19 '18 at 18:16
On every page load you are saying firstvisit = '1' and then if firstvisit is not '1' show alert. So how is it ever going to show the alert? firstvisit is always '1'.
– Nawed Khan
Nov 19 '18 at 18:17
On every page load you are saying firstvisit = '1' and then if firstvisit is not '1' show alert. So how is it ever going to show the alert? firstvisit is always '1'.
– Nawed Khan
Nov 19 '18 at 18:17
add a comment |
1 Answer
1
active
oldest
votes
You're only defining welcome(); you aren't calling it. Also, you're setting it every time, so it's always true. Try setting it only if it's not set yet:
function welcome(){
if (!sessionStorage.getItem('firstVisit')){
sessionStorage.setItem('firstVisit', '1');
alert('yeet');
}
}
welcome();
Here's a fiddle: https://jsfiddle.net/jmbldwn/24e1scp6/4/
answered Nov 19 '18 at 18:16
Jim B.Jim B.
2,6661929
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53380391%2fjs-alert-not-playing-once-per-session%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
You're only defining welcome(); you aren't calling it. Also, you're setting it every time, so it's always true. Try setting it only if it's not set yet:
function welcome(){
if (!sessionStorage.getItem('firstVisit')){
sessionStorage.setItem('firstVisit', '1');
alert('yeet');
}
}
welcome();
Here's a fiddle: https://jsfiddle.net/jmbldwn/24e1scp6/4/
answered Nov 19 '18 at 18:16
Jim B.Jim B.
2,6661929
add a comment |
You're only defining welcome(); you aren't calling it. Also, you're setting it every time, so it's always true. Try setting it only if it's not set yet:
function welcome(){
if (!sessionStorage.getItem('firstVisit')){
sessionStorage.setItem('firstVisit', '1');
alert('yeet');
}
}
welcome();
Here's a fiddle: https://jsfiddle.net/jmbldwn/24e1scp6/4/
answered Nov 19 '18 at 18:16
Jim B.Jim B.
2,6661929
add a comment |
You're only defining welcome(); you aren't calling it. Also, you're setting it every time, so it's always true. Try setting it only if it's not set yet:
function welcome(){
if (!sessionStorage.getItem('firstVisit')){
sessionStorage.setItem('firstVisit', '1');
alert('yeet');
}
}
welcome();
Here's a fiddle: https://jsfiddle.net/jmbldwn/24e1scp6/4/
answered Nov 19 '18 at 18:16
Jim B.Jim B.
2,6661929
You're only defining welcome(); you aren't calling it. Also, you're setting it every time, so it's always true. Try setting it only if it's not set yet:
function welcome(){
if (!sessionStorage.getItem('firstVisit')){
sessionStorage.setItem('firstVisit', '1');
alert('yeet');
}
}
welcome();
Here's a fiddle: https://jsfiddle.net/jmbldwn/24e1scp6/4/
answered Nov 19 '18 at 18:16
Jim B.Jim B.
2,6661929
answered Nov 19 '18 at 18:16
Jim B.Jim B.
2,6661929
answered Nov 19 '18 at 18:16
Jim B.Jim B.
2,6661929
answered Nov 19 '18 at 18:16
Jim B.Jim B.
2,6661929
2,6661929
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53380391%2fjs-alert-not-playing-once-per-session%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
You have to call the "welcome()" method.
– dev4life
Nov 19 '18 at 18:16
When are you doing
sessionStorage.setItem('firstVisit', '1');?– Frank Modica
Nov 19 '18 at 18:16
On every page load you are saying firstvisit = '1' and then if firstvisit is not '1' show alert. So how is it ever going to show the alert? firstvisit is always '1'.
– Nawed Khan
Nov 19 '18 at 18:17