Mixing
Moving pictureBox in winforms
0
My goal for my code is to create a simple pong game in winforms (Should've used monogame), however my code should be working.
Problem: The picturebox location will not update when I change it's location.
I suspect something is taking up the UI thread probably my series of KeyDown / KeyUp events?
EDIT: Based on some testing I have recently done it seems the timer is not ticking, however I may be wrong.
Code:
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
Thread t = new Thread(ChangePaddleState);
t.Start();
BringToFront();
Activate();
}
//change this later?
static bool upArrow = false;
static bool downArrow = false;
static bool wKey = false;
static bool sKey = false;
//movement speed of paddle
const byte movementspeed = 3;
Paddle paddleL = new Paddle();
Paddle paddleR = new Paddle();
void ChangePaddleState()
{
while (true)
{
//left paddle
if (upArrow)
{
paddleL.idle = false;
paddleL.movingDown = false;
paddleL.movingUp = true;
}
else if (downArrow)
{
paddleL.idle = false;
paddleL.movingUp = false;
paddleL.movingDown = true;
}
//left paddle
//right paddle
if (wKey)
{
paddleR.movingDown = false;
paddleR.idle = false;
paddleR.movingUp = true;
}
else if (sKey)
{
paddleR.idle = false;
paddleR.movingUp = false;
paddleR.movingDown = true;
}
//checking if idle
if(!paddleR.movingDown && !paddleR.movingUp)
{
paddleR.idle = true;
}
if (!paddleL.movingDown && !paddleL.movingUp)
{
paddleL.idle = true;
}
//checking if idle
Thread.Sleep(50);
}
}
private void Form1_KeyDown(object sender, KeyEventArgs e)
{
KeySwitch.setKeysTrue(e);
}
private void Form1_KeyUp(object sender, KeyEventArgs e)
{
KeySwitch.setKeysFalse(e);
}
//Key Swicth Region
#region
static class KeySwitch
{
public static void setKeysTrue(KeyEventArgs e)
{
switch (e.KeyCode)
{
case Keys.Up:
upArrow = true;
Debug.Write("Up Arrow Pressed");
break;
case Keys.Down:
downArrow = true;
Debug.Write("Down Arrow Pressed");
break;
case Keys.W:
wKey = true;
Debug.Write("W Key Arrow Pressed");
break;
case Keys.S:
sKey = false;
Debug.Write("S Key Pressed");
break;
}
}
public static void setKeysFalse(KeyEventArgs e)
{
switch (e.KeyCode)
{
case Keys.Up:
upArrow = false;
Debug.Write("Up Arrow Released");
break;
case Keys.Down:
downArrow = false;
Debug.Write("Down Arrow Released");
break;
case Keys.W:
wKey = false;
Debug.Write("W Key Released");
break;
case Keys.S:
sKey = false;
Debug.Write("S Key Released");
break;
}
}
}
#endregion //KeySwitch Class KeySwitchClass
private void button1_Click(object sender, EventArgs e)
{
DebugHelper.GetPaddleState(paddleL, paddleR);
ActiveControl = null;
}
private void gameLoop_Tick(object sender, EventArgs e)
{
if (paddleL.movingUp)
{
aPaddleLeft.Location = new Point(aPaddleLeft.Location.X, aPaddleLeft.Location.Y + movementspeed);
}
else if (paddleR.movingDown)
{
aPaddleRight.Location = new Point(aPaddleRight.Location.X, aPaddleLeft.Location.Y - movementspeed);
}
}
}
}
c# winforms
asked Nov 20 '18 at 3:04
spacecadetMJspacecadetMJ
12
add a comment |
0
My goal for my code is to create a simple pong game in winforms (Should've used monogame), however my code should be working.
Problem: The picturebox location will not update when I change it's location.
I suspect something is taking up the UI thread probably my series of KeyDown / KeyUp events?
EDIT: Based on some testing I have recently done it seems the timer is not ticking, however I may be wrong.
Code:
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
Thread t = new Thread(ChangePaddleState);
t.Start();
BringToFront();
Activate();
}
//change this later?
static bool upArrow = false;
static bool downArrow = false;
static bool wKey = false;
static bool sKey = false;
//movement speed of paddle
const byte movementspeed = 3;
Paddle paddleL = new Paddle();
Paddle paddleR = new Paddle();
void ChangePaddleState()
{
while (true)
{
//left paddle
if (upArrow)
{
paddleL.idle = false;
paddleL.movingDown = false;
paddleL.movingUp = true;
}
else if (downArrow)
{
paddleL.idle = false;
paddleL.movingUp = false;
paddleL.movingDown = true;
}
//left paddle
//right paddle
if (wKey)
{
paddleR.movingDown = false;
paddleR.idle = false;
paddleR.movingUp = true;
}
else if (sKey)
{
paddleR.idle = false;
paddleR.movingUp = false;
paddleR.movingDown = true;
}
//checking if idle
if(!paddleR.movingDown && !paddleR.movingUp)
{
paddleR.idle = true;
}
if (!paddleL.movingDown && !paddleL.movingUp)
{
paddleL.idle = true;
}
//checking if idle
Thread.Sleep(50);
}
}
private void Form1_KeyDown(object sender, KeyEventArgs e)
{
KeySwitch.setKeysTrue(e);
}
private void Form1_KeyUp(object sender, KeyEventArgs e)
{
KeySwitch.setKeysFalse(e);
}
//Key Swicth Region
#region
static class KeySwitch
{
public static void setKeysTrue(KeyEventArgs e)
{
switch (e.KeyCode)
{
case Keys.Up:
upArrow = true;
Debug.Write("Up Arrow Pressed");
break;
case Keys.Down:
downArrow = true;
Debug.Write("Down Arrow Pressed");
break;
case Keys.W:
wKey = true;
Debug.Write("W Key Arrow Pressed");
break;
case Keys.S:
sKey = false;
Debug.Write("S Key Pressed");
break;
}
}
public static void setKeysFalse(KeyEventArgs e)
{
switch (e.KeyCode)
{
case Keys.Up:
upArrow = false;
Debug.Write("Up Arrow Released");
break;
case Keys.Down:
downArrow = false;
Debug.Write("Down Arrow Released");
break;
case Keys.W:
wKey = false;
Debug.Write("W Key Released");
break;
case Keys.S:
sKey = false;
Debug.Write("S Key Released");
break;
}
}
}
#endregion //KeySwitch Class KeySwitchClass
private void button1_Click(object sender, EventArgs e)
{
DebugHelper.GetPaddleState(paddleL, paddleR);
ActiveControl = null;
}
private void gameLoop_Tick(object sender, EventArgs e)
{
if (paddleL.movingUp)
{
aPaddleLeft.Location = new Point(aPaddleLeft.Location.X, aPaddleLeft.Location.Y + movementspeed);
}
else if (paddleR.movingDown)
{
aPaddleRight.Location = new Point(aPaddleRight.Location.X, aPaddleLeft.Location.Y - movementspeed);
}
}
}
}
c# winforms
asked Nov 20 '18 at 3:04
spacecadetMJspacecadetMJ
12
This is just a thought. You do not have any thing pointing to a refresher.. I update certain elements and controls by using this.Refresh(); this is a thought. I looked through the code, but your problem lies with point A transition to point B. Think of a desktop folder. You delete the contents inside the folder but the folder on desktop still shows the contents, even though they are deleted. When you right click the desktop and click refresh. Then it updates to the current state. Try something like that to refresh the X,Y points of the picturebox.
– Halonic
Nov 23 '18 at 13:34
add a comment |
0
0
0
1
My goal for my code is to create a simple pong game in winforms (Should've used monogame), however my code should be working.
Problem: The picturebox location will not update when I change it's location.
I suspect something is taking up the UI thread probably my series of KeyDown / KeyUp events?
EDIT: Based on some testing I have recently done it seems the timer is not ticking, however I may be wrong.
Code:
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
Thread t = new Thread(ChangePaddleState);
t.Start();
BringToFront();
Activate();
}
//change this later?
static bool upArrow = false;
static bool downArrow = false;
static bool wKey = false;
static bool sKey = false;
//movement speed of paddle
const byte movementspeed = 3;
Paddle paddleL = new Paddle();
Paddle paddleR = new Paddle();
void ChangePaddleState()
{
while (true)
{
//left paddle
if (upArrow)
{
paddleL.idle = false;
paddleL.movingDown = false;
paddleL.movingUp = true;
}
else if (downArrow)
{
paddleL.idle = false;
paddleL.movingUp = false;
paddleL.movingDown = true;
}
//left paddle
//right paddle
if (wKey)
{
paddleR.movingDown = false;
paddleR.idle = false;
paddleR.movingUp = true;
}
else if (sKey)
{
paddleR.idle = false;
paddleR.movingUp = false;
paddleR.movingDown = true;
}
//checking if idle
if(!paddleR.movingDown && !paddleR.movingUp)
{
paddleR.idle = true;
}
if (!paddleL.movingDown && !paddleL.movingUp)
{
paddleL.idle = true;
}
//checking if idle
Thread.Sleep(50);
}
}
private void Form1_KeyDown(object sender, KeyEventArgs e)
{
KeySwitch.setKeysTrue(e);
}
private void Form1_KeyUp(object sender, KeyEventArgs e)
{
KeySwitch.setKeysFalse(e);
}
//Key Swicth Region
#region
static class KeySwitch
{
public static void setKeysTrue(KeyEventArgs e)
{
switch (e.KeyCode)
{
case Keys.Up:
upArrow = true;
Debug.Write("Up Arrow Pressed");
break;
case Keys.Down:
downArrow = true;
Debug.Write("Down Arrow Pressed");
break;
case Keys.W:
wKey = true;
Debug.Write("W Key Arrow Pressed");
break;
case Keys.S:
sKey = false;
Debug.Write("S Key Pressed");
break;
}
}
public static void setKeysFalse(KeyEventArgs e)
{
switch (e.KeyCode)
{
case Keys.Up:
upArrow = false;
Debug.Write("Up Arrow Released");
break;
case Keys.Down:
downArrow = false;
Debug.Write("Down Arrow Released");
break;
case Keys.W:
wKey = false;
Debug.Write("W Key Released");
break;
case Keys.S:
sKey = false;
Debug.Write("S Key Released");
break;
}
}
}
#endregion //KeySwitch Class KeySwitchClass
private void button1_Click(object sender, EventArgs e)
{
DebugHelper.GetPaddleState(paddleL, paddleR);
ActiveControl = null;
}
private void gameLoop_Tick(object sender, EventArgs e)
{
if (paddleL.movingUp)
{
aPaddleLeft.Location = new Point(aPaddleLeft.Location.X, aPaddleLeft.Location.Y + movementspeed);
}
else if (paddleR.movingDown)
{
aPaddleRight.Location = new Point(aPaddleRight.Location.X, aPaddleLeft.Location.Y - movementspeed);
}
}
}
}
c# winforms
asked Nov 20 '18 at 3:04
spacecadetMJspacecadetMJ
12
My goal for my code is to create a simple pong game in winforms (Should've used monogame), however my code should be working.
Problem: The picturebox location will not update when I change it's location.
I suspect something is taking up the UI thread probably my series of KeyDown / KeyUp events?
EDIT: Based on some testing I have recently done it seems the timer is not ticking, however I may be wrong.
Code:
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
Thread t = new Thread(ChangePaddleState);
t.Start();
BringToFront();
Activate();
}
//change this later?
static bool upArrow = false;
static bool downArrow = false;
static bool wKey = false;
static bool sKey = false;
//movement speed of paddle
const byte movementspeed = 3;
Paddle paddleL = new Paddle();
Paddle paddleR = new Paddle();
void ChangePaddleState()
{
while (true)
{
//left paddle
if (upArrow)
{
paddleL.idle = false;
paddleL.movingDown = false;
paddleL.movingUp = true;
}
else if (downArrow)
{
paddleL.idle = false;
paddleL.movingUp = false;
paddleL.movingDown = true;
}
//left paddle
//right paddle
if (wKey)
{
paddleR.movingDown = false;
paddleR.idle = false;
paddleR.movingUp = true;
}
else if (sKey)
{
paddleR.idle = false;
paddleR.movingUp = false;
paddleR.movingDown = true;
}
//checking if idle
if(!paddleR.movingDown && !paddleR.movingUp)
{
paddleR.idle = true;
}
if (!paddleL.movingDown && !paddleL.movingUp)
{
paddleL.idle = true;
}
//checking if idle
Thread.Sleep(50);
}
}
private void Form1_KeyDown(object sender, KeyEventArgs e)
{
KeySwitch.setKeysTrue(e);
}
private void Form1_KeyUp(object sender, KeyEventArgs e)
{
KeySwitch.setKeysFalse(e);
}
//Key Swicth Region
#region
static class KeySwitch
{
public static void setKeysTrue(KeyEventArgs e)
{
switch (e.KeyCode)
{
case Keys.Up:
upArrow = true;
Debug.Write("Up Arrow Pressed");
break;
case Keys.Down:
downArrow = true;
Debug.Write("Down Arrow Pressed");
break;
case Keys.W:
wKey = true;
Debug.Write("W Key Arrow Pressed");
break;
case Keys.S:
sKey = false;
Debug.Write("S Key Pressed");
break;
}
}
public static void setKeysFalse(KeyEventArgs e)
{
switch (e.KeyCode)
{
case Keys.Up:
upArrow = false;
Debug.Write("Up Arrow Released");
break;
case Keys.Down:
downArrow = false;
Debug.Write("Down Arrow Released");
break;
case Keys.W:
wKey = false;
Debug.Write("W Key Released");
break;
case Keys.S:
sKey = false;
Debug.Write("S Key Released");
break;
}
}
}
#endregion //KeySwitch Class KeySwitchClass
private void button1_Click(object sender, EventArgs e)
{
DebugHelper.GetPaddleState(paddleL, paddleR);
ActiveControl = null;
}
private void gameLoop_Tick(object sender, EventArgs e)
{
if (paddleL.movingUp)
{
aPaddleLeft.Location = new Point(aPaddleLeft.Location.X, aPaddleLeft.Location.Y + movementspeed);
}
else if (paddleR.movingDown)
{
aPaddleRight.Location = new Point(aPaddleRight.Location.X, aPaddleLeft.Location.Y - movementspeed);
}
}
}
}
c# winforms
c# winforms
asked Nov 20 '18 at 3:04
spacecadetMJspacecadetMJ
12
asked Nov 20 '18 at 3:04
spacecadetMJspacecadetMJ
12
edited Nov 20 '18 at 3:24
spacecadetMJ
asked Nov 20 '18 at 3:04
spacecadetMJspacecadetMJ
12
asked Nov 20 '18 at 3:04
spacecadetMJspacecadetMJ
12
asked Nov 20 '18 at 3:04
spacecadetMJspacecadetMJ
12
12
This is just a thought. You do not have any thing pointing to a refresher.. I update certain elements and controls by using this.Refresh(); this is a thought. I looked through the code, but your problem lies with point A transition to point B. Think of a desktop folder. You delete the contents inside the folder but the folder on desktop still shows the contents, even though they are deleted. When you right click the desktop and click refresh. Then it updates to the current state. Try something like that to refresh the X,Y points of the picturebox.
– Halonic
Nov 23 '18 at 13:34
add a comment |
This is just a thought. You do not have any thing pointing to a refresher.. I update certain elements and controls by using this.Refresh(); this is a thought. I looked through the code, but your problem lies with point A transition to point B. Think of a desktop folder. You delete the contents inside the folder but the folder on desktop still shows the contents, even though they are deleted. When you right click the desktop and click refresh. Then it updates to the current state. Try something like that to refresh the X,Y points of the picturebox.
– Halonic
Nov 23 '18 at 13:34
This is just a thought. You do not have any thing pointing to a refresher.. I update certain elements and controls by using this.Refresh(); this is a thought. I looked through the code, but your problem lies with point A transition to point B. Think of a desktop folder. You delete the contents inside the folder but the folder on desktop still shows the contents, even though they are deleted. When you right click the desktop and click refresh. Then it updates to the current state. Try something like that to refresh the X,Y points of the picturebox.
– Halonic
Nov 23 '18 at 13:34
This is just a thought. You do not have any thing pointing to a refresher.. I update certain elements and controls by using this.Refresh(); this is a thought. I looked through the code, but your problem lies with point A transition to point B. Think of a desktop folder. You delete the contents inside the folder but the folder on desktop still shows the contents, even though they are deleted. When you right click the desktop and click refresh. Then it updates to the current state. Try something like that to refresh the X,Y points of the picturebox.
– Halonic
Nov 23 '18 at 13:34
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53385612%2fmoving-picturebox-in-winforms%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53385612%2fmoving-picturebox-in-winforms%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
This is just a thought. You do not have any thing pointing to a refresher.. I update certain elements and controls by using this.Refresh(); this is a thought. I looked through the code, but your problem lies with point A transition to point B. Think of a desktop folder. You delete the contents inside the folder but the folder on desktop still shows the contents, even though they are deleted. When you right click the desktop and click refresh. Then it updates to the current state. Try something like that to refresh the X,Y points of the picturebox.
– Halonic
Nov 23 '18 at 13:34