Mixing
Kotlin/Android - setOnClickListener only works in one button
I got a recyclerView with multiple items (ViewHolders). In one (ViewHolderItemTratamentos) of these I got the following elements:
When the first "add button" is clicked, through an inflator layout, the same elements (editText and button) are created beneath the previous ones. Just like this:
Till here, everything is ok. Another row is created with a equal editText and a equal button which got a different id, R.id.btn_add_field_din (from the layout inflated). This button right here got the same logic behind it. It inflates the same layout (same row). But then, this third button won't work, and it got the same id (R.id.btn_add_field_din). I also tried by tag, but it gave me the same problem.
The problem is that I want to have many rows as I want it, but from the third button the setClickOnListener lost action. Do you know what might be? Here's the code:
ADAPTER:
holder.add_field_button.setOnClickListener {
holder.parent_linear_layout.apply {
val inflater = LayoutInflater.from(context)
val rowView = inflater.inflate(R.layout.used_products_field, this, false)
holder.parent_linear_layout.addView(rowView, holder.parent_linear_layout.childCount!! - 0)
holder.add_field_button.text = "-"
//remove row
removeField(holder.add_field_button, holder.parent_linear_layout)
btn_add_field_din.setOnClickListener {
val inflater = LayoutInflater.from(context)
val rowView = inflater.inflate(R.layout.used_products_field, this, false)
holder.parent_linear_layout.addView(rowView, holder.parent_linear_layout.childCount!! - 0)
btn_add_field_din.text = "-"
//remove row
removeField(btn_add_field_din, holder.parent_linear_layout)
}
}
}
LAYOUT INFLATED (R.layout.used_products_field):
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal" >
<EditText
android:id="@+id/number_edit_text"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="5"
android:focusedByDefault="true"
android:inputType="phone"/>
<Button
android:id="@+id/btn_add_field_din"
android:layout_width="50dp"
android:layout_height="wrap_content"
android:layout_gravity="center"
style="@style/botaoCard"
android:textSize="24dp"
android:text="+"
android:padding="5dp"/>
</LinearLayout>
android button kotlin onclicklistener layout-inflater asked Jan 1 at 18:51
Pedro RelvasPedro Relvas
749
add a comment |
I got a recyclerView with multiple items (ViewHolders). In one (ViewHolderItemTratamentos) of these I got the following elements:
When the first "add button" is clicked, through an inflator layout, the same elements (editText and button) are created beneath the previous ones. Just like this:
Till here, everything is ok. Another row is created with a equal editText and a equal button which got a different id, R.id.btn_add_field_din (from the layout inflated). This button right here got the same logic behind it. It inflates the same layout (same row). But then, this third button won't work, and it got the same id (R.id.btn_add_field_din). I also tried by tag, but it gave me the same problem.
The problem is that I want to have many rows as I want it, but from the third button the setClickOnListener lost action. Do you know what might be? Here's the code:
ADAPTER:
holder.add_field_button.setOnClickListener {
holder.parent_linear_layout.apply {
val inflater = LayoutInflater.from(context)
val rowView = inflater.inflate(R.layout.used_products_field, this, false)
holder.parent_linear_layout.addView(rowView, holder.parent_linear_layout.childCount!! - 0)
holder.add_field_button.text = "-"
//remove row
removeField(holder.add_field_button, holder.parent_linear_layout)
btn_add_field_din.setOnClickListener {
val inflater = LayoutInflater.from(context)
val rowView = inflater.inflate(R.layout.used_products_field, this, false)
holder.parent_linear_layout.addView(rowView, holder.parent_linear_layout.childCount!! - 0)
btn_add_field_din.text = "-"
//remove row
removeField(btn_add_field_din, holder.parent_linear_layout)
}
}
}
LAYOUT INFLATED (R.layout.used_products_field):
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal" >
<EditText
android:id="@+id/number_edit_text"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="5"
android:focusedByDefault="true"
android:inputType="phone"/>
<Button
android:id="@+id/btn_add_field_din"
android:layout_width="50dp"
android:layout_height="wrap_content"
android:layout_gravity="center"
style="@style/botaoCard"
android:textSize="24dp"
android:text="+"
android:padding="5dp"/>
</LinearLayout>
asked Jan 1 at 18:51
Pedro RelvasPedro Relvas
749
Instead of maintaining views directly. Maintain the data set. Take arrayList which holds all items which you want to display. Now when user click add button just add new item to that list and notify your adapter.
– Moinkhan
Jan 2 at 6:05
@Moinkhan can you give that example in code? I'm confused about it. Thank you.
– Pedro Relvas
Jan 2 at 12:55
add a comment |
I got a recyclerView with multiple items (ViewHolders). In one (ViewHolderItemTratamentos) of these I got the following elements:
When the first "add button" is clicked, through an inflator layout, the same elements (editText and button) are created beneath the previous ones. Just like this:
Till here, everything is ok. Another row is created with a equal editText and a equal button which got a different id, R.id.btn_add_field_din (from the layout inflated). This button right here got the same logic behind it. It inflates the same layout (same row). But then, this third button won't work, and it got the same id (R.id.btn_add_field_din). I also tried by tag, but it gave me the same problem.
The problem is that I want to have many rows as I want it, but from the third button the setClickOnListener lost action. Do you know what might be? Here's the code:
ADAPTER:
holder.add_field_button.setOnClickListener {
holder.parent_linear_layout.apply {
val inflater = LayoutInflater.from(context)
val rowView = inflater.inflate(R.layout.used_products_field, this, false)
holder.parent_linear_layout.addView(rowView, holder.parent_linear_layout.childCount!! - 0)
holder.add_field_button.text = "-"
//remove row
removeField(holder.add_field_button, holder.parent_linear_layout)
btn_add_field_din.setOnClickListener {
val inflater = LayoutInflater.from(context)
val rowView = inflater.inflate(R.layout.used_products_field, this, false)
holder.parent_linear_layout.addView(rowView, holder.parent_linear_layout.childCount!! - 0)
btn_add_field_din.text = "-"
//remove row
removeField(btn_add_field_din, holder.parent_linear_layout)
}
}
}
LAYOUT INFLATED (R.layout.used_products_field):
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal" >
<EditText
android:id="@+id/number_edit_text"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="5"
android:focusedByDefault="true"
android:inputType="phone"/>
<Button
android:id="@+id/btn_add_field_din"
android:layout_width="50dp"
android:layout_height="wrap_content"
android:layout_gravity="center"
style="@style/botaoCard"
android:textSize="24dp"
android:text="+"
android:padding="5dp"/>
</LinearLayout>
asked Jan 1 at 18:51
Pedro RelvasPedro Relvas
749
I got a recyclerView with multiple items (ViewHolders). In one (ViewHolderItemTratamentos) of these I got the following elements:
When the first "add button" is clicked, through an inflator layout, the same elements (editText and button) are created beneath the previous ones. Just like this:
Till here, everything is ok. Another row is created with a equal editText and a equal button which got a different id, R.id.btn_add_field_din (from the layout inflated). This button right here got the same logic behind it. It inflates the same layout (same row). But then, this third button won't work, and it got the same id (R.id.btn_add_field_din). I also tried by tag, but it gave me the same problem.
The problem is that I want to have many rows as I want it, but from the third button the setClickOnListener lost action. Do you know what might be? Here's the code:
ADAPTER:
holder.add_field_button.setOnClickListener {
holder.parent_linear_layout.apply {
val inflater = LayoutInflater.from(context)
val rowView = inflater.inflate(R.layout.used_products_field, this, false)
holder.parent_linear_layout.addView(rowView, holder.parent_linear_layout.childCount!! - 0)
holder.add_field_button.text = "-"
//remove row
removeField(holder.add_field_button, holder.parent_linear_layout)
btn_add_field_din.setOnClickListener {
val inflater = LayoutInflater.from(context)
val rowView = inflater.inflate(R.layout.used_products_field, this, false)
holder.parent_linear_layout.addView(rowView, holder.parent_linear_layout.childCount!! - 0)
btn_add_field_din.text = "-"
//remove row
removeField(btn_add_field_din, holder.parent_linear_layout)
}
}
}
LAYOUT INFLATED (R.layout.used_products_field):
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal" >
<EditText
android:id="@+id/number_edit_text"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="5"
android:focusedByDefault="true"
android:inputType="phone"/>
<Button
android:id="@+id/btn_add_field_din"
android:layout_width="50dp"
android:layout_height="wrap_content"
android:layout_gravity="center"
style="@style/botaoCard"
android:textSize="24dp"
android:text="+"
android:padding="5dp"/>
</LinearLayout>
asked Jan 1 at 18:51
Pedro RelvasPedro Relvas
749
asked Jan 1 at 18:51
Pedro RelvasPedro Relvas
749
asked Jan 1 at 18:51
Pedro RelvasPedro Relvas
749
asked Jan 1 at 18:51
Pedro RelvasPedro Relvas
749
asked Jan 1 at 18:51
Pedro RelvasPedro Relvas
749
749
Instead of maintaining views directly. Maintain the data set. Take arrayList which holds all items which you want to display. Now when user click add button just add new item to that list and notify your adapter.
– Moinkhan
Jan 2 at 6:05
@Moinkhan can you give that example in code? I'm confused about it. Thank you.
– Pedro Relvas
Jan 2 at 12:55
add a comment |
Instead of maintaining views directly. Maintain the data set. Take arrayList which holds all items which you want to display. Now when user click add button just add new item to that list and notify your adapter.
– Moinkhan
Jan 2 at 6:05
@Moinkhan can you give that example in code? I'm confused about it. Thank you.
– Pedro Relvas
Jan 2 at 12:55
Instead of maintaining views directly. Maintain the data set. Take arrayList which holds all items which you want to display. Now when user click add button just add new item to that list and notify your adapter.
– Moinkhan
Jan 2 at 6:05
Instead of maintaining views directly. Maintain the data set. Take arrayList which holds all items which you want to display. Now when user click add button just add new item to that list and notify your adapter.
– Moinkhan
Jan 2 at 6:05
@Moinkhan can you give that example in code? I'm confused about it. Thank you.
– Pedro Relvas
Jan 2 at 12:55
@Moinkhan can you give that example in code? I'm confused about it. Thank you.
– Pedro Relvas
Jan 2 at 12:55
add a comment |
1 Answer
1
active
oldest
votes
The way you inflate the view yet using synthetic references to inner views.. I'm not sure it works this way because R is created on compilation, not runtime. And I suppose you use multiple ViewHolder of this kind inside the RecyclerView. In which case, the same ID would be set to multiple Views, which is not possible.
My guess is that btn_add_field_din does not reference the view you think. Inspect it. Try to set a background Color.RED see if that's the right view.
Also, removeField(btn_add_field_din, holder.parent_linear_layout) seems to remove the view, does it?
answered Jan 2 at 13:51
shkschneidershkschneider
11k114395
yes, the removeField remove the view, it's not relevant for my question. I've inspected and it is, is the view I think, unfortunately. Yes, the id is multiplicated... but it need to be, to do the action, right? Thank you for your atention.
– Pedro Relvas
Jan 2 at 14:20
Do not duplicate the view. Use a good-oldfindViewByIdfor such cases. Also, if you remove the view usingremoveField()then how would a listener respond to it?
– shkschneider
Jan 2 at 14:25
The remove the view is optional, you don't need to click it. But how am I supose to use the findViewById? I need that all the next "btn_add_field_din" to do the action, the inflate... and onyl the first works.
– Pedro Relvas
Jan 2 at 14:29
Ok.rowView.findViewById(R.id.btn_add_field_din).setOnClickListenershould be more specific. You got the idea.
– shkschneider
Jan 2 at 14:34
Also tried it before. Same problem...
– Pedro Relvas
Jan 2 at 14:39
|
show 1 more comment
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53998060%2fkotlin-android-setonclicklistener-only-works-in-one-button%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
The way you inflate the view yet using synthetic references to inner views.. I'm not sure it works this way because R is created on compilation, not runtime. And I suppose you use multiple ViewHolder of this kind inside the RecyclerView. In which case, the same ID would be set to multiple Views, which is not possible.
My guess is that btn_add_field_din does not reference the view you think. Inspect it. Try to set a background Color.RED see if that's the right view.
Also, removeField(btn_add_field_din, holder.parent_linear_layout) seems to remove the view, does it?
answered Jan 2 at 13:51
shkschneidershkschneider
11k114395
yes, the removeField remove the view, it's not relevant for my question. I've inspected and it is, is the view I think, unfortunately. Yes, the id is multiplicated... but it need to be, to do the action, right? Thank you for your atention.
– Pedro Relvas
Jan 2 at 14:20
Do not duplicate the view. Use a good-oldfindViewByIdfor such cases. Also, if you remove the view usingremoveField()then how would a listener respond to it?
– shkschneider
Jan 2 at 14:25
The remove the view is optional, you don't need to click it. But how am I supose to use the findViewById? I need that all the next "btn_add_field_din" to do the action, the inflate... and onyl the first works.
– Pedro Relvas
Jan 2 at 14:29
Ok.rowView.findViewById(R.id.btn_add_field_din).setOnClickListenershould be more specific. You got the idea.
– shkschneider
Jan 2 at 14:34
Also tried it before. Same problem...
– Pedro Relvas
Jan 2 at 14:39
|
show 1 more comment
The way you inflate the view yet using synthetic references to inner views.. I'm not sure it works this way because R is created on compilation, not runtime. And I suppose you use multiple ViewHolder of this kind inside the RecyclerView. In which case, the same ID would be set to multiple Views, which is not possible.
My guess is that btn_add_field_din does not reference the view you think. Inspect it. Try to set a background Color.RED see if that's the right view.
Also, removeField(btn_add_field_din, holder.parent_linear_layout) seems to remove the view, does it?
answered Jan 2 at 13:51
shkschneidershkschneider
11k114395
yes, the removeField remove the view, it's not relevant for my question. I've inspected and it is, is the view I think, unfortunately. Yes, the id is multiplicated... but it need to be, to do the action, right? Thank you for your atention.
– Pedro Relvas
Jan 2 at 14:20
Do not duplicate the view. Use a good-oldfindViewByIdfor such cases. Also, if you remove the view usingremoveField()then how would a listener respond to it?
– shkschneider
Jan 2 at 14:25
The remove the view is optional, you don't need to click it. But how am I supose to use the findViewById? I need that all the next "btn_add_field_din" to do the action, the inflate... and onyl the first works.
– Pedro Relvas
Jan 2 at 14:29
Ok.rowView.findViewById(R.id.btn_add_field_din).setOnClickListenershould be more specific. You got the idea.
– shkschneider
Jan 2 at 14:34
Also tried it before. Same problem...
– Pedro Relvas
Jan 2 at 14:39
|
show 1 more comment
The way you inflate the view yet using synthetic references to inner views.. I'm not sure it works this way because R is created on compilation, not runtime. And I suppose you use multiple ViewHolder of this kind inside the RecyclerView. In which case, the same ID would be set to multiple Views, which is not possible.
My guess is that btn_add_field_din does not reference the view you think. Inspect it. Try to set a background Color.RED see if that's the right view.
Also, removeField(btn_add_field_din, holder.parent_linear_layout) seems to remove the view, does it?
answered Jan 2 at 13:51
shkschneidershkschneider
11k114395
The way you inflate the view yet using synthetic references to inner views.. I'm not sure it works this way because R is created on compilation, not runtime. And I suppose you use multiple ViewHolder of this kind inside the RecyclerView. In which case, the same ID would be set to multiple Views, which is not possible.
My guess is that btn_add_field_din does not reference the view you think. Inspect it. Try to set a background Color.RED see if that's the right view.
Also, removeField(btn_add_field_din, holder.parent_linear_layout) seems to remove the view, does it?
answered Jan 2 at 13:51
shkschneidershkschneider
11k114395
answered Jan 2 at 13:51
shkschneidershkschneider
11k114395
answered Jan 2 at 13:51
shkschneidershkschneider
11k114395
answered Jan 2 at 13:51
shkschneidershkschneider
11k114395
11k114395
yes, the removeField remove the view, it's not relevant for my question. I've inspected and it is, is the view I think, unfortunately. Yes, the id is multiplicated... but it need to be, to do the action, right? Thank you for your atention.
– Pedro Relvas
Jan 2 at 14:20
Do not duplicate the view. Use a good-oldfindViewByIdfor such cases. Also, if you remove the view usingremoveField()then how would a listener respond to it?
– shkschneider
Jan 2 at 14:25
The remove the view is optional, you don't need to click it. But how am I supose to use the findViewById? I need that all the next "btn_add_field_din" to do the action, the inflate... and onyl the first works.
– Pedro Relvas
Jan 2 at 14:29
Ok.rowView.findViewById(R.id.btn_add_field_din).setOnClickListenershould be more specific. You got the idea.
– shkschneider
Jan 2 at 14:34
Also tried it before. Same problem...
– Pedro Relvas
Jan 2 at 14:39
|
show 1 more comment
yes, the removeField remove the view, it's not relevant for my question. I've inspected and it is, is the view I think, unfortunately. Yes, the id is multiplicated... but it need to be, to do the action, right? Thank you for your atention.
– Pedro Relvas
Jan 2 at 14:20
Do not duplicate the view. Use a good-oldfindViewByIdfor such cases. Also, if you remove the view usingremoveField()then how would a listener respond to it?
– shkschneider
Jan 2 at 14:25
The remove the view is optional, you don't need to click it. But how am I supose to use the findViewById? I need that all the next "btn_add_field_din" to do the action, the inflate... and onyl the first works.
– Pedro Relvas
Jan 2 at 14:29
Ok.rowView.findViewById(R.id.btn_add_field_din).setOnClickListenershould be more specific. You got the idea.
– shkschneider
Jan 2 at 14:34
Also tried it before. Same problem...
– Pedro Relvas
Jan 2 at 14:39
yes, the removeField remove the view, it's not relevant for my question. I've inspected and it is, is the view I think, unfortunately. Yes, the id is multiplicated... but it need to be, to do the action, right? Thank you for your atention.
– Pedro Relvas
Jan 2 at 14:20
yes, the removeField remove the view, it's not relevant for my question. I've inspected and it is, is the view I think, unfortunately. Yes, the id is multiplicated... but it need to be, to do the action, right? Thank you for your atention.
– Pedro Relvas
Jan 2 at 14:20
Do not duplicate the view. Use a good-old
findViewById for such cases. Also, if you remove the view using removeField() then how would a listener respond to it?– shkschneider
Jan 2 at 14:25
Do not duplicate the view. Use a good-old
findViewById for such cases. Also, if you remove the view using removeField() then how would a listener respond to it?– shkschneider
Jan 2 at 14:25
The remove the view is optional, you don't need to click it. But how am I supose to use the findViewById? I need that all the next "btn_add_field_din" to do the action, the inflate... and onyl the first works.
– Pedro Relvas
Jan 2 at 14:29
The remove the view is optional, you don't need to click it. But how am I supose to use the findViewById? I need that all the next "btn_add_field_din" to do the action, the inflate... and onyl the first works.
– Pedro Relvas
Jan 2 at 14:29
Ok.
rowView.findViewById(R.id.btn_add_field_din).setOnClickListener should be more specific. You got the idea.– shkschneider
Jan 2 at 14:34
Ok.
rowView.findViewById(R.id.btn_add_field_din).setOnClickListener should be more specific. You got the idea.– shkschneider
Jan 2 at 14:34
Also tried it before. Same problem...
– Pedro Relvas
Jan 2 at 14:39
Also tried it before. Same problem...
– Pedro Relvas
Jan 2 at 14:39
|
show 1 more comment
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53998060%2fkotlin-android-setonclicklistener-only-works-in-one-button%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Instead of maintaining views directly. Maintain the data set. Take arrayList which holds all items which you want to display. Now when user click add button just add new item to that list and notify your adapter.
– Moinkhan
Jan 2 at 6:05
@Moinkhan can you give that example in code? I'm confused about it. Thank you.
– Pedro Relvas
Jan 2 at 12:55