Mixing
Accessing objects
I wrote a simple function to access some values in the array below, and nested in the array are multiple objects.
My question has to do with my 2 loops. I understand that I must initially loop through the array to gain access to the 3 objects, but why must I loop through the 3 objects before I can access the values?
Basically why can't I run an initial for loop and access a sound by doing this:
animalNoises[i][animal][country]
the above returns as undefined for me. Does it have something to do with the way each 3 animal objects are structured?
Thanks for the help. I really appreciate the stack overflow community for the constant help.
function petSounds(animal, country) {
let phrase = ''
for (let i = 0; i < animalNoises.length; i++) {
for (let key in animalNoises[i]){
if (animal === key){
let sound = animalNoises[i][key][country];
phrase = animal + 's' + ' in ' + country + ' say ' + sound
}
}
}
return phrase
}
let animalNoises = [
{ 'dog': {
'America' : 'Woof! Woof!',
'Germany' : 'Wau Wau!',
'England' : 'Bow wow!',
'Uruguay' : 'Jua jua!',
'Afrikaans' : 'Blaf!',
'Korea' : 'Mong mong!',
'Iceland' : 'Voff voff!',
'Albania' : 'Ham!',
'Algeria' : 'Ouaf ouaf!'
}
},
{ 'cat': {
'America' : 'Meow',
'Germany' : 'Miauw!',
'England' : 'mew mew',
'Uruguay' : 'Miau Miau!',
'Afrikaans' : 'Purr',
'Korea' : 'Nyaong!',
'Iceland' : 'Kurnau!',
'Albania' : 'Miau',
'Algeria' : 'Miaou!'
}
},
{ 'chicken': {
'America' : 'Cluck cluck',
'Germany' : 'tock tock tock',
'England' : 'Cluck Cluck',
'Uruguay' : 'gut gut gdak',
'Afrikaans' : 'kukeleku',
'Korea' : 'ko-ko-ko',
'Iceland' : 'Chuck-chuck!',
'Albania' : 'Kotkot',
'Algeria' : 'Cotcotcodet'
}
}
];
javascript arrays javascript-objects for-in-loop
edited Nov 21 '18 at 6:38
Adriano
1,34811325
asked Nov 21 '18 at 5:10
TerryTerry
161
add a comment |
I wrote a simple function to access some values in the array below, and nested in the array are multiple objects.
My question has to do with my 2 loops. I understand that I must initially loop through the array to gain access to the 3 objects, but why must I loop through the 3 objects before I can access the values?
Basically why can't I run an initial for loop and access a sound by doing this:
animalNoises[i][animal][country]
the above returns as undefined for me. Does it have something to do with the way each 3 animal objects are structured?
Thanks for the help. I really appreciate the stack overflow community for the constant help.
function petSounds(animal, country) {
let phrase = ''
for (let i = 0; i < animalNoises.length; i++) {
for (let key in animalNoises[i]){
if (animal === key){
let sound = animalNoises[i][key][country];
phrase = animal + 's' + ' in ' + country + ' say ' + sound
}
}
}
return phrase
}
let animalNoises = [
{ 'dog': {
'America' : 'Woof! Woof!',
'Germany' : 'Wau Wau!',
'England' : 'Bow wow!',
'Uruguay' : 'Jua jua!',
'Afrikaans' : 'Blaf!',
'Korea' : 'Mong mong!',
'Iceland' : 'Voff voff!',
'Albania' : 'Ham!',
'Algeria' : 'Ouaf ouaf!'
}
},
{ 'cat': {
'America' : 'Meow',
'Germany' : 'Miauw!',
'England' : 'mew mew',
'Uruguay' : 'Miau Miau!',
'Afrikaans' : 'Purr',
'Korea' : 'Nyaong!',
'Iceland' : 'Kurnau!',
'Albania' : 'Miau',
'Algeria' : 'Miaou!'
}
},
{ 'chicken': {
'America' : 'Cluck cluck',
'Germany' : 'tock tock tock',
'England' : 'Cluck Cluck',
'Uruguay' : 'gut gut gdak',
'Afrikaans' : 'kukeleku',
'Korea' : 'ko-ko-ko',
'Iceland' : 'Chuck-chuck!',
'Albania' : 'Kotkot',
'Algeria' : 'Cotcotcodet'
}
}
];
javascript arrays javascript-objects for-in-loop
edited Nov 21 '18 at 6:38
Adriano
1,34811325
asked Nov 21 '18 at 5:10
TerryTerry
161
1
Works withconsole.log(petSounds('dog', 'America'));->dogs in America say Woof! Woof!andconsole.log(petSounds('chicken', 'Algeria'));->chickens in Algeria say Cotcotcodet
– CertainPerformance
Nov 21 '18 at 5:11
the code seems alright. May be you are calling it with arguments which are not part of object's keys and hence it returns undefined.
– Saurabh Tiwari
Nov 21 '18 at 5:17
Also, you do understand that this way you will get a single return value at the end of all the loops.
– Saurabh Tiwari
Nov 21 '18 at 5:18
4
If you change the structure to a more reasonable{'dog': {...}, 'cat': {...}, 'chicken': {...}}, you will be able to doanimalSounds[animal][country], with zero loops.
– Amadan
Nov 21 '18 at 5:19
add a comment |
I wrote a simple function to access some values in the array below, and nested in the array are multiple objects.
My question has to do with my 2 loops. I understand that I must initially loop through the array to gain access to the 3 objects, but why must I loop through the 3 objects before I can access the values?
Basically why can't I run an initial for loop and access a sound by doing this:
animalNoises[i][animal][country]
the above returns as undefined for me. Does it have something to do with the way each 3 animal objects are structured?
Thanks for the help. I really appreciate the stack overflow community for the constant help.
function petSounds(animal, country) {
let phrase = ''
for (let i = 0; i < animalNoises.length; i++) {
for (let key in animalNoises[i]){
if (animal === key){
let sound = animalNoises[i][key][country];
phrase = animal + 's' + ' in ' + country + ' say ' + sound
}
}
}
return phrase
}
let animalNoises = [
{ 'dog': {
'America' : 'Woof! Woof!',
'Germany' : 'Wau Wau!',
'England' : 'Bow wow!',
'Uruguay' : 'Jua jua!',
'Afrikaans' : 'Blaf!',
'Korea' : 'Mong mong!',
'Iceland' : 'Voff voff!',
'Albania' : 'Ham!',
'Algeria' : 'Ouaf ouaf!'
}
},
{ 'cat': {
'America' : 'Meow',
'Germany' : 'Miauw!',
'England' : 'mew mew',
'Uruguay' : 'Miau Miau!',
'Afrikaans' : 'Purr',
'Korea' : 'Nyaong!',
'Iceland' : 'Kurnau!',
'Albania' : 'Miau',
'Algeria' : 'Miaou!'
}
},
{ 'chicken': {
'America' : 'Cluck cluck',
'Germany' : 'tock tock tock',
'England' : 'Cluck Cluck',
'Uruguay' : 'gut gut gdak',
'Afrikaans' : 'kukeleku',
'Korea' : 'ko-ko-ko',
'Iceland' : 'Chuck-chuck!',
'Albania' : 'Kotkot',
'Algeria' : 'Cotcotcodet'
}
}
];
javascript arrays javascript-objects for-in-loop
edited Nov 21 '18 at 6:38
Adriano
1,34811325
asked Nov 21 '18 at 5:10
TerryTerry
161
I wrote a simple function to access some values in the array below, and nested in the array are multiple objects.
My question has to do with my 2 loops. I understand that I must initially loop through the array to gain access to the 3 objects, but why must I loop through the 3 objects before I can access the values?
Basically why can't I run an initial for loop and access a sound by doing this:
animalNoises[i][animal][country]
the above returns as undefined for me. Does it have something to do with the way each 3 animal objects are structured?
Thanks for the help. I really appreciate the stack overflow community for the constant help.
function petSounds(animal, country) {
let phrase = ''
for (let i = 0; i < animalNoises.length; i++) {
for (let key in animalNoises[i]){
if (animal === key){
let sound = animalNoises[i][key][country];
phrase = animal + 's' + ' in ' + country + ' say ' + sound
}
}
}
return phrase
}
let animalNoises = [
{ 'dog': {
'America' : 'Woof! Woof!',
'Germany' : 'Wau Wau!',
'England' : 'Bow wow!',
'Uruguay' : 'Jua jua!',
'Afrikaans' : 'Blaf!',
'Korea' : 'Mong mong!',
'Iceland' : 'Voff voff!',
'Albania' : 'Ham!',
'Algeria' : 'Ouaf ouaf!'
}
},
{ 'cat': {
'America' : 'Meow',
'Germany' : 'Miauw!',
'England' : 'mew mew',
'Uruguay' : 'Miau Miau!',
'Afrikaans' : 'Purr',
'Korea' : 'Nyaong!',
'Iceland' : 'Kurnau!',
'Albania' : 'Miau',
'Algeria' : 'Miaou!'
}
},
{ 'chicken': {
'America' : 'Cluck cluck',
'Germany' : 'tock tock tock',
'England' : 'Cluck Cluck',
'Uruguay' : 'gut gut gdak',
'Afrikaans' : 'kukeleku',
'Korea' : 'ko-ko-ko',
'Iceland' : 'Chuck-chuck!',
'Albania' : 'Kotkot',
'Algeria' : 'Cotcotcodet'
}
}
];
javascript arrays javascript-objects for-in-loop
javascript arrays javascript-objects for-in-loop
edited Nov 21 '18 at 6:38
Adriano
1,34811325
asked Nov 21 '18 at 5:10
TerryTerry
161
edited Nov 21 '18 at 6:38
Adriano
1,34811325
asked Nov 21 '18 at 5:10
TerryTerry
161
edited Nov 21 '18 at 6:38
Adriano
1,34811325
edited Nov 21 '18 at 6:38
Adriano
1,34811325
edited Nov 21 '18 at 6:38
Adriano
1,34811325
1,34811325
asked Nov 21 '18 at 5:10
TerryTerry
161
asked Nov 21 '18 at 5:10
TerryTerry
161
asked Nov 21 '18 at 5:10
TerryTerry
161
161
1
Works withconsole.log(petSounds('dog', 'America'));->dogs in America say Woof! Woof!andconsole.log(petSounds('chicken', 'Algeria'));->chickens in Algeria say Cotcotcodet
– CertainPerformance
Nov 21 '18 at 5:11
the code seems alright. May be you are calling it with arguments which are not part of object's keys and hence it returns undefined.
– Saurabh Tiwari
Nov 21 '18 at 5:17
Also, you do understand that this way you will get a single return value at the end of all the loops.
– Saurabh Tiwari
Nov 21 '18 at 5:18
4
If you change the structure to a more reasonable{'dog': {...}, 'cat': {...}, 'chicken': {...}}, you will be able to doanimalSounds[animal][country], with zero loops.
– Amadan
Nov 21 '18 at 5:19
add a comment |
1
Works withconsole.log(petSounds('dog', 'America'));->dogs in America say Woof! Woof!andconsole.log(petSounds('chicken', 'Algeria'));->chickens in Algeria say Cotcotcodet
– CertainPerformance
Nov 21 '18 at 5:11
the code seems alright. May be you are calling it with arguments which are not part of object's keys and hence it returns undefined.
– Saurabh Tiwari
Nov 21 '18 at 5:17
Also, you do understand that this way you will get a single return value at the end of all the loops.
– Saurabh Tiwari
Nov 21 '18 at 5:18
4
If you change the structure to a more reasonable{'dog': {...}, 'cat': {...}, 'chicken': {...}}, you will be able to doanimalSounds[animal][country], with zero loops.
– Amadan
Nov 21 '18 at 5:19
1
1
Works with
console.log(petSounds('dog', 'America')); -> dogs in America say Woof! Woof! and console.log(petSounds('chicken', 'Algeria')); -> chickens in Algeria say Cotcotcodet– CertainPerformance
Nov 21 '18 at 5:11
Works with
console.log(petSounds('dog', 'America')); -> dogs in America say Woof! Woof! and console.log(petSounds('chicken', 'Algeria')); -> chickens in Algeria say Cotcotcodet– CertainPerformance
Nov 21 '18 at 5:11
the code seems alright. May be you are calling it with arguments which are not part of object's keys and hence it returns undefined.
– Saurabh Tiwari
Nov 21 '18 at 5:17
the code seems alright. May be you are calling it with arguments which are not part of object's keys and hence it returns undefined.
– Saurabh Tiwari
Nov 21 '18 at 5:17
Also, you do understand that this way you will get a single return value at the end of all the loops.
– Saurabh Tiwari
Nov 21 '18 at 5:18
Also, you do understand that this way you will get a single return value at the end of all the loops.
– Saurabh Tiwari
Nov 21 '18 at 5:18
4
4
If you change the structure to a more reasonable
{'dog': {...}, 'cat': {...}, 'chicken': {...}}, you will be able to do animalSounds[animal][country], with zero loops.– Amadan
Nov 21 '18 at 5:19
If you change the structure to a more reasonable
{'dog': {...}, 'cat': {...}, 'chicken': {...}}, you will be able to do animalSounds[animal][country], with zero loops.– Amadan
Nov 21 '18 at 5:19
add a comment |
3 Answers
3
active
oldest
votes
You need to update your json to simplify function (use an object keyed by animal type):
function petSounds(animal, country) {
const sound = animalNoises[animal][country];
const phrase = animal + 's' + ' in ' + country + ' say ' + sound;
return phrase;
}
let animalNoises = {
'dog': {
'America': 'Woof! Woof!',
'Germany': 'Wau Wau!',
'England': 'Bow wow!',
'Uruguay': 'Jua jua!',
'Afrikaans': 'Blaf!',
'Korea': 'Mong mong!',
'Iceland': 'Voff voff!',
'Albania': 'Ham!',
'Algeria': 'Ouaf ouaf!'
},
'cat': {
'America': 'Meow',
'Germany': 'Miauw!',
'England': 'mew mew',
'Uruguay': 'Miau Miau!',
'Afrikaans': 'Purr',
'Korea': 'Nyaong!',
'Iceland': 'Kurnau!',
'Albania': 'Miau',
'Algeria': 'Miaou!'
},
'chicken': {
'America': 'Cluck cluck',
'Germany': 'tock tock tock',
'England': 'Cluck Cluck',
'Uruguay': 'gut gut gdak',
'Afrikaans': 'kukeleku',
'Korea': 'ko-ko-ko',
'Iceland': 'Chuck-chuck!',
'Albania': 'Kotkot',
'Algeria': 'Cotcotcodet'
}
};
console.log(petSounds('cat', 'America'));
console.log(petSounds('dog', 'Iceland'));
console.log(petSounds('chicken', 'Germany'));edited Nov 21 '18 at 5:41
slider
8,26811130
answered Nov 21 '18 at 5:29
Jatin KathrotiyaJatin Kathrotiya
419210
add a comment |
Your solution works, with single for loop. You missed specifying single quotes.
When I simply console this it returns specific value.
animalNoises[0]['dog']['Korea']
"Mong mong!"
In loop you need to access from your array by specifying key name and country values.
It doesn't have anything to do with the way each 3 animal objects are structured
When I call your function it is running fine.
petSounds('dog', 'Korea')
"dogs in Korea say Mong mong!"
Or you can modify your function as below which does same reducing inner loop:
function petSounds(animal, country) {
let phrase = ''
for (let i = 0; i < animalNoises.length; i++) {
let key = Object.keys(animalNoises[i])[0];
if (animal === key){
let sound = animalNoises[i][key][country];
phrase = animal + 's' + ' in ' + country + ' say ' + sound
}
}
return phrase
}
answered Nov 21 '18 at 6:55
GautamGautam
335
I thought his second for loop was checking for the validity of the animal? It's so that it can make sure the key exists before trying to concatenate it to his return value
– Robert Mennell
Nov 21 '18 at 7:37
The second loop is not required. you can take key name by Object.keys(animalNoises[i])[0] to compare with animal
– Gautam
Nov 21 '18 at 10:43
I think you're missing what I'm saying. Others have already suggested possibly changing the format of the JSON, but what if the JSON is provided from an outside source and your objects have extra keys? Plus what if there is a prototype property equal to the key you sent in? His second loop is checking to make sure that the object has it's own property of the animal.
– Robert Mennell
Nov 21 '18 at 10:57
1
In that case the second loop is required. But I think what he is asking in his question is : Why must I loop through the 3 objects before I can access the values? So as per his question he can access the values without looping. But if objects have extra keys then I agree to your comment.
– Gautam
Nov 21 '18 at 11:02
add a comment |
If you want to keep the form you have now you can always use an Array#find(), and then a in operator check, and then with template literals you can easily create your string.
function petSounds(animal, country) {
const noise = animalNoises.find(obj => animal in obj)[animal][country];
return `${animal}s in ${country} say ${noise}`
}
let animalNoises = [
{ 'dog': {
'America' : 'Woof! Woof!',
'Germany' : 'Wau Wau!',
'England' : 'Bow wow!',
'Uruguay' : 'Jua jua!',
'Afrikaans' : 'Blaf!',
'Korea' : 'Mong mong!',
'Iceland' : 'Voff voff!',
'Albania' : 'Ham!',
'Algeria' : 'Ouaf ouaf!'
}
},
{ 'cat': {
'America' : 'Meow',
'Germany' : 'Miauw!',
'England' : 'mew mew',
'Uruguay' : 'Miau Miau!',
'Afrikaans' : 'Purr',
'Korea' : 'Nyaong!',
'Iceland' : 'Kurnau!',
'Albania' : 'Miau',
'Algeria' : 'Miaou!'
}
},
{ 'chicken': {
'America' : 'Cluck cluck',
'Germany' : 'tock tock tock',
'England' : 'Cluck Cluck',
'Uruguay' : 'gut gut gdak',
'Afrikaans' : 'kukeleku',
'Korea' : 'ko-ko-ko',
'Iceland' : 'Chuck-chuck!',
'Albania' : 'Kotkot',
'Algeria' : 'Cotcotcodet'
}
}
];
Otherwise with your version you're looping while looping when you can just simply check for existence.
Of course there are many ways to skin a cat, so the above is equivalent to
function petSounds(animal, country) {
const noise = animalNoises.find(obj => obj.hasOwnProperty(animal))[animal][country];
return `${animal}s in ${country} say ${noise}`
}
Of course if you are receiving this JSON from somewhere else you could do a reduction on it and then associate the keys and values into a super object(using Array#reduce() and Object.entries())
animalNoises = animalNoise.reduce((acc, obj) => {
Object.entries(obj).forEach(([key, value]) => {
acc[key] = value;
});
return acc;
},
{}
)
function petSounds(animal, country) {
return `${animal}s in ${country} say ${animalNoises[animal][country]}`;
}
If you want to learn more about the cool things you can do with Arrays you should check out the MDN for JavaScript Arrays
The in operator is a really useful way to make Object#hasOwnProperty() shorter
And as always a lot more information about JavaScript can be found at the MDN
Some extra fun with Object Sestructuring for just another way to arrange things:
function petSounds(animal, country) {
const { [animal]: { [country]: noise } } = animalNoises.find(obj => animal in obj);
return `${animal}s in ${country} say ${noise}`
}
answered Nov 21 '18 at 5:49
Robert MennellRobert Mennell
963517
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53405590%2faccessing-objects%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
3 Answers
3
active
oldest
votes
3 Answers
3
active
oldest
votes
active
oldest
votes
active
oldest
votes
You need to update your json to simplify function (use an object keyed by animal type):
function petSounds(animal, country) {
const sound = animalNoises[animal][country];
const phrase = animal + 's' + ' in ' + country + ' say ' + sound;
return phrase;
}
let animalNoises = {
'dog': {
'America': 'Woof! Woof!',
'Germany': 'Wau Wau!',
'England': 'Bow wow!',
'Uruguay': 'Jua jua!',
'Afrikaans': 'Blaf!',
'Korea': 'Mong mong!',
'Iceland': 'Voff voff!',
'Albania': 'Ham!',
'Algeria': 'Ouaf ouaf!'
},
'cat': {
'America': 'Meow',
'Germany': 'Miauw!',
'England': 'mew mew',
'Uruguay': 'Miau Miau!',
'Afrikaans': 'Purr',
'Korea': 'Nyaong!',
'Iceland': 'Kurnau!',
'Albania': 'Miau',
'Algeria': 'Miaou!'
},
'chicken': {
'America': 'Cluck cluck',
'Germany': 'tock tock tock',
'England': 'Cluck Cluck',
'Uruguay': 'gut gut gdak',
'Afrikaans': 'kukeleku',
'Korea': 'ko-ko-ko',
'Iceland': 'Chuck-chuck!',
'Albania': 'Kotkot',
'Algeria': 'Cotcotcodet'
}
};
console.log(petSounds('cat', 'America'));
console.log(petSounds('dog', 'Iceland'));
console.log(petSounds('chicken', 'Germany'));edited Nov 21 '18 at 5:41
slider
8,26811130
answered Nov 21 '18 at 5:29
Jatin KathrotiyaJatin Kathrotiya
419210
add a comment |
You need to update your json to simplify function (use an object keyed by animal type):
function petSounds(animal, country) {
const sound = animalNoises[animal][country];
const phrase = animal + 's' + ' in ' + country + ' say ' + sound;
return phrase;
}
let animalNoises = {
'dog': {
'America': 'Woof! Woof!',
'Germany': 'Wau Wau!',
'England': 'Bow wow!',
'Uruguay': 'Jua jua!',
'Afrikaans': 'Blaf!',
'Korea': 'Mong mong!',
'Iceland': 'Voff voff!',
'Albania': 'Ham!',
'Algeria': 'Ouaf ouaf!'
},
'cat': {
'America': 'Meow',
'Germany': 'Miauw!',
'England': 'mew mew',
'Uruguay': 'Miau Miau!',
'Afrikaans': 'Purr',
'Korea': 'Nyaong!',
'Iceland': 'Kurnau!',
'Albania': 'Miau',
'Algeria': 'Miaou!'
},
'chicken': {
'America': 'Cluck cluck',
'Germany': 'tock tock tock',
'England': 'Cluck Cluck',
'Uruguay': 'gut gut gdak',
'Afrikaans': 'kukeleku',
'Korea': 'ko-ko-ko',
'Iceland': 'Chuck-chuck!',
'Albania': 'Kotkot',
'Algeria': 'Cotcotcodet'
}
};
console.log(petSounds('cat', 'America'));
console.log(petSounds('dog', 'Iceland'));
console.log(petSounds('chicken', 'Germany'));edited Nov 21 '18 at 5:41
slider
8,26811130
answered Nov 21 '18 at 5:29
Jatin KathrotiyaJatin Kathrotiya
419210
add a comment |
You need to update your json to simplify function (use an object keyed by animal type):
function petSounds(animal, country) {
const sound = animalNoises[animal][country];
const phrase = animal + 's' + ' in ' + country + ' say ' + sound;
return phrase;
}
let animalNoises = {
'dog': {
'America': 'Woof! Woof!',
'Germany': 'Wau Wau!',
'England': 'Bow wow!',
'Uruguay': 'Jua jua!',
'Afrikaans': 'Blaf!',
'Korea': 'Mong mong!',
'Iceland': 'Voff voff!',
'Albania': 'Ham!',
'Algeria': 'Ouaf ouaf!'
},
'cat': {
'America': 'Meow',
'Germany': 'Miauw!',
'England': 'mew mew',
'Uruguay': 'Miau Miau!',
'Afrikaans': 'Purr',
'Korea': 'Nyaong!',
'Iceland': 'Kurnau!',
'Albania': 'Miau',
'Algeria': 'Miaou!'
},
'chicken': {
'America': 'Cluck cluck',
'Germany': 'tock tock tock',
'England': 'Cluck Cluck',
'Uruguay': 'gut gut gdak',
'Afrikaans': 'kukeleku',
'Korea': 'ko-ko-ko',
'Iceland': 'Chuck-chuck!',
'Albania': 'Kotkot',
'Algeria': 'Cotcotcodet'
}
};
console.log(petSounds('cat', 'America'));
console.log(petSounds('dog', 'Iceland'));
console.log(petSounds('chicken', 'Germany'));edited Nov 21 '18 at 5:41
slider
8,26811130
answered Nov 21 '18 at 5:29
Jatin KathrotiyaJatin Kathrotiya
419210
You need to update your json to simplify function (use an object keyed by animal type):
function petSounds(animal, country) {
const sound = animalNoises[animal][country];
const phrase = animal + 's' + ' in ' + country + ' say ' + sound;
return phrase;
}
let animalNoises = {
'dog': {
'America': 'Woof! Woof!',
'Germany': 'Wau Wau!',
'England': 'Bow wow!',
'Uruguay': 'Jua jua!',
'Afrikaans': 'Blaf!',
'Korea': 'Mong mong!',
'Iceland': 'Voff voff!',
'Albania': 'Ham!',
'Algeria': 'Ouaf ouaf!'
},
'cat': {
'America': 'Meow',
'Germany': 'Miauw!',
'England': 'mew mew',
'Uruguay': 'Miau Miau!',
'Afrikaans': 'Purr',
'Korea': 'Nyaong!',
'Iceland': 'Kurnau!',
'Albania': 'Miau',
'Algeria': 'Miaou!'
},
'chicken': {
'America': 'Cluck cluck',
'Germany': 'tock tock tock',
'England': 'Cluck Cluck',
'Uruguay': 'gut gut gdak',
'Afrikaans': 'kukeleku',
'Korea': 'ko-ko-ko',
'Iceland': 'Chuck-chuck!',
'Albania': 'Kotkot',
'Algeria': 'Cotcotcodet'
}
};
console.log(petSounds('cat', 'America'));
console.log(petSounds('dog', 'Iceland'));
console.log(petSounds('chicken', 'Germany'));function petSounds(animal, country) {
const sound = animalNoises[animal][country];
const phrase = animal + 's' + ' in ' + country + ' say ' + sound;
return phrase;
}
let animalNoises = {
'dog': {
'America': 'Woof! Woof!',
'Germany': 'Wau Wau!',
'England': 'Bow wow!',
'Uruguay': 'Jua jua!',
'Afrikaans': 'Blaf!',
'Korea': 'Mong mong!',
'Iceland': 'Voff voff!',
'Albania': 'Ham!',
'Algeria': 'Ouaf ouaf!'
},
'cat': {
'America': 'Meow',
'Germany': 'Miauw!',
'England': 'mew mew',
'Uruguay': 'Miau Miau!',
'Afrikaans': 'Purr',
'Korea': 'Nyaong!',
'Iceland': 'Kurnau!',
'Albania': 'Miau',
'Algeria': 'Miaou!'
},
'chicken': {
'America': 'Cluck cluck',
'Germany': 'tock tock tock',
'England': 'Cluck Cluck',
'Uruguay': 'gut gut gdak',
'Afrikaans': 'kukeleku',
'Korea': 'ko-ko-ko',
'Iceland': 'Chuck-chuck!',
'Albania': 'Kotkot',
'Algeria': 'Cotcotcodet'
}
};
console.log(petSounds('cat', 'America'));
console.log(petSounds('dog', 'Iceland'));
console.log(petSounds('chicken', 'Germany'));function petSounds(animal, country) {
const sound = animalNoises[animal][country];
const phrase = animal + 's' + ' in ' + country + ' say ' + sound;
return phrase;
}
let animalNoises = {
'dog': {
'America': 'Woof! Woof!',
'Germany': 'Wau Wau!',
'England': 'Bow wow!',
'Uruguay': 'Jua jua!',
'Afrikaans': 'Blaf!',
'Korea': 'Mong mong!',
'Iceland': 'Voff voff!',
'Albania': 'Ham!',
'Algeria': 'Ouaf ouaf!'
},
'cat': {
'America': 'Meow',
'Germany': 'Miauw!',
'England': 'mew mew',
'Uruguay': 'Miau Miau!',
'Afrikaans': 'Purr',
'Korea': 'Nyaong!',
'Iceland': 'Kurnau!',
'Albania': 'Miau',
'Algeria': 'Miaou!'
},
'chicken': {
'America': 'Cluck cluck',
'Germany': 'tock tock tock',
'England': 'Cluck Cluck',
'Uruguay': 'gut gut gdak',
'Afrikaans': 'kukeleku',
'Korea': 'ko-ko-ko',
'Iceland': 'Chuck-chuck!',
'Albania': 'Kotkot',
'Algeria': 'Cotcotcodet'
}
};
console.log(petSounds('cat', 'America'));
console.log(petSounds('dog', 'Iceland'));
console.log(petSounds('chicken', 'Germany'));edited Nov 21 '18 at 5:41
slider
8,26811130
answered Nov 21 '18 at 5:29
Jatin KathrotiyaJatin Kathrotiya
419210
edited Nov 21 '18 at 5:41
slider
8,26811130
edited Nov 21 '18 at 5:41
slider
8,26811130
edited Nov 21 '18 at 5:41
slider
8,26811130
8,26811130
answered Nov 21 '18 at 5:29
Jatin KathrotiyaJatin Kathrotiya
419210
answered Nov 21 '18 at 5:29
Jatin KathrotiyaJatin Kathrotiya
419210
answered Nov 21 '18 at 5:29
Jatin KathrotiyaJatin Kathrotiya
419210
419210
add a comment |
add a comment |
Your solution works, with single for loop. You missed specifying single quotes.
When I simply console this it returns specific value.
animalNoises[0]['dog']['Korea']
"Mong mong!"
In loop you need to access from your array by specifying key name and country values.
It doesn't have anything to do with the way each 3 animal objects are structured
When I call your function it is running fine.
petSounds('dog', 'Korea')
"dogs in Korea say Mong mong!"
Or you can modify your function as below which does same reducing inner loop:
function petSounds(animal, country) {
let phrase = ''
for (let i = 0; i < animalNoises.length; i++) {
let key = Object.keys(animalNoises[i])[0];
if (animal === key){
let sound = animalNoises[i][key][country];
phrase = animal + 's' + ' in ' + country + ' say ' + sound
}
}
return phrase
}
answered Nov 21 '18 at 6:55
GautamGautam
335
I thought his second for loop was checking for the validity of the animal? It's so that it can make sure the key exists before trying to concatenate it to his return value
– Robert Mennell
Nov 21 '18 at 7:37
The second loop is not required. you can take key name by Object.keys(animalNoises[i])[0] to compare with animal
– Gautam
Nov 21 '18 at 10:43
I think you're missing what I'm saying. Others have already suggested possibly changing the format of the JSON, but what if the JSON is provided from an outside source and your objects have extra keys? Plus what if there is a prototype property equal to the key you sent in? His second loop is checking to make sure that the object has it's own property of the animal.
– Robert Mennell
Nov 21 '18 at 10:57
1
In that case the second loop is required. But I think what he is asking in his question is : Why must I loop through the 3 objects before I can access the values? So as per his question he can access the values without looping. But if objects have extra keys then I agree to your comment.
– Gautam
Nov 21 '18 at 11:02
add a comment |
Your solution works, with single for loop. You missed specifying single quotes.
When I simply console this it returns specific value.
animalNoises[0]['dog']['Korea']
"Mong mong!"
In loop you need to access from your array by specifying key name and country values.
It doesn't have anything to do with the way each 3 animal objects are structured
When I call your function it is running fine.
petSounds('dog', 'Korea')
"dogs in Korea say Mong mong!"
Or you can modify your function as below which does same reducing inner loop:
function petSounds(animal, country) {
let phrase = ''
for (let i = 0; i < animalNoises.length; i++) {
let key = Object.keys(animalNoises[i])[0];
if (animal === key){
let sound = animalNoises[i][key][country];
phrase = animal + 's' + ' in ' + country + ' say ' + sound
}
}
return phrase
}
answered Nov 21 '18 at 6:55
GautamGautam
335
I thought his second for loop was checking for the validity of the animal? It's so that it can make sure the key exists before trying to concatenate it to his return value
– Robert Mennell
Nov 21 '18 at 7:37
The second loop is not required. you can take key name by Object.keys(animalNoises[i])[0] to compare with animal
– Gautam
Nov 21 '18 at 10:43
I think you're missing what I'm saying. Others have already suggested possibly changing the format of the JSON, but what if the JSON is provided from an outside source and your objects have extra keys? Plus what if there is a prototype property equal to the key you sent in? His second loop is checking to make sure that the object has it's own property of the animal.
– Robert Mennell
Nov 21 '18 at 10:57
1
In that case the second loop is required. But I think what he is asking in his question is : Why must I loop through the 3 objects before I can access the values? So as per his question he can access the values without looping. But if objects have extra keys then I agree to your comment.
– Gautam
Nov 21 '18 at 11:02
add a comment |
Your solution works, with single for loop. You missed specifying single quotes.
When I simply console this it returns specific value.
animalNoises[0]['dog']['Korea']
"Mong mong!"
In loop you need to access from your array by specifying key name and country values.
It doesn't have anything to do with the way each 3 animal objects are structured
When I call your function it is running fine.
petSounds('dog', 'Korea')
"dogs in Korea say Mong mong!"
Or you can modify your function as below which does same reducing inner loop:
function petSounds(animal, country) {
let phrase = ''
for (let i = 0; i < animalNoises.length; i++) {
let key = Object.keys(animalNoises[i])[0];
if (animal === key){
let sound = animalNoises[i][key][country];
phrase = animal + 's' + ' in ' + country + ' say ' + sound
}
}
return phrase
}
answered Nov 21 '18 at 6:55
GautamGautam
335
Your solution works, with single for loop. You missed specifying single quotes.
When I simply console this it returns specific value.
animalNoises[0]['dog']['Korea']
"Mong mong!"
In loop you need to access from your array by specifying key name and country values.
It doesn't have anything to do with the way each 3 animal objects are structured
When I call your function it is running fine.
petSounds('dog', 'Korea')
"dogs in Korea say Mong mong!"
Or you can modify your function as below which does same reducing inner loop:
function petSounds(animal, country) {
let phrase = ''
for (let i = 0; i < animalNoises.length; i++) {
let key = Object.keys(animalNoises[i])[0];
if (animal === key){
let sound = animalNoises[i][key][country];
phrase = animal + 's' + ' in ' + country + ' say ' + sound
}
}
return phrase
}
answered Nov 21 '18 at 6:55
GautamGautam
335
edited Nov 21 '18 at 10:48
answered Nov 21 '18 at 6:55
GautamGautam
335
answered Nov 21 '18 at 6:55
GautamGautam
335
answered Nov 21 '18 at 6:55
GautamGautam
335
335
I thought his second for loop was checking for the validity of the animal? It's so that it can make sure the key exists before trying to concatenate it to his return value
– Robert Mennell
Nov 21 '18 at 7:37
The second loop is not required. you can take key name by Object.keys(animalNoises[i])[0] to compare with animal
– Gautam
Nov 21 '18 at 10:43
I think you're missing what I'm saying. Others have already suggested possibly changing the format of the JSON, but what if the JSON is provided from an outside source and your objects have extra keys? Plus what if there is a prototype property equal to the key you sent in? His second loop is checking to make sure that the object has it's own property of the animal.
– Robert Mennell
Nov 21 '18 at 10:57
1
In that case the second loop is required. But I think what he is asking in his question is : Why must I loop through the 3 objects before I can access the values? So as per his question he can access the values without looping. But if objects have extra keys then I agree to your comment.
– Gautam
Nov 21 '18 at 11:02
add a comment |
I thought his second for loop was checking for the validity of the animal? It's so that it can make sure the key exists before trying to concatenate it to his return value
– Robert Mennell
Nov 21 '18 at 7:37
The second loop is not required. you can take key name by Object.keys(animalNoises[i])[0] to compare with animal
– Gautam
Nov 21 '18 at 10:43
I think you're missing what I'm saying. Others have already suggested possibly changing the format of the JSON, but what if the JSON is provided from an outside source and your objects have extra keys? Plus what if there is a prototype property equal to the key you sent in? His second loop is checking to make sure that the object has it's own property of the animal.
– Robert Mennell
Nov 21 '18 at 10:57
1
In that case the second loop is required. But I think what he is asking in his question is : Why must I loop through the 3 objects before I can access the values? So as per his question he can access the values without looping. But if objects have extra keys then I agree to your comment.
– Gautam
Nov 21 '18 at 11:02
I thought his second for loop was checking for the validity of the animal? It's so that it can make sure the key exists before trying to concatenate it to his return value
– Robert Mennell
Nov 21 '18 at 7:37
I thought his second for loop was checking for the validity of the animal? It's so that it can make sure the key exists before trying to concatenate it to his return value
– Robert Mennell
Nov 21 '18 at 7:37
The second loop is not required. you can take key name by Object.keys(animalNoises[i])[0] to compare with animal
– Gautam
Nov 21 '18 at 10:43
The second loop is not required. you can take key name by Object.keys(animalNoises[i])[0] to compare with animal
– Gautam
Nov 21 '18 at 10:43
I think you're missing what I'm saying. Others have already suggested possibly changing the format of the JSON, but what if the JSON is provided from an outside source and your objects have extra keys? Plus what if there is a prototype property equal to the key you sent in? His second loop is checking to make sure that the object has it's own property of the animal.
– Robert Mennell
Nov 21 '18 at 10:57
I think you're missing what I'm saying. Others have already suggested possibly changing the format of the JSON, but what if the JSON is provided from an outside source and your objects have extra keys? Plus what if there is a prototype property equal to the key you sent in? His second loop is checking to make sure that the object has it's own property of the animal.
– Robert Mennell
Nov 21 '18 at 10:57
1
1
In that case the second loop is required. But I think what he is asking in his question is : Why must I loop through the 3 objects before I can access the values? So as per his question he can access the values without looping. But if objects have extra keys then I agree to your comment.
– Gautam
Nov 21 '18 at 11:02
In that case the second loop is required. But I think what he is asking in his question is : Why must I loop through the 3 objects before I can access the values? So as per his question he can access the values without looping. But if objects have extra keys then I agree to your comment.
– Gautam
Nov 21 '18 at 11:02
add a comment |
If you want to keep the form you have now you can always use an Array#find(), and then a in operator check, and then with template literals you can easily create your string.
function petSounds(animal, country) {
const noise = animalNoises.find(obj => animal in obj)[animal][country];
return `${animal}s in ${country} say ${noise}`
}
let animalNoises = [
{ 'dog': {
'America' : 'Woof! Woof!',
'Germany' : 'Wau Wau!',
'England' : 'Bow wow!',
'Uruguay' : 'Jua jua!',
'Afrikaans' : 'Blaf!',
'Korea' : 'Mong mong!',
'Iceland' : 'Voff voff!',
'Albania' : 'Ham!',
'Algeria' : 'Ouaf ouaf!'
}
},
{ 'cat': {
'America' : 'Meow',
'Germany' : 'Miauw!',
'England' : 'mew mew',
'Uruguay' : 'Miau Miau!',
'Afrikaans' : 'Purr',
'Korea' : 'Nyaong!',
'Iceland' : 'Kurnau!',
'Albania' : 'Miau',
'Algeria' : 'Miaou!'
}
},
{ 'chicken': {
'America' : 'Cluck cluck',
'Germany' : 'tock tock tock',
'England' : 'Cluck Cluck',
'Uruguay' : 'gut gut gdak',
'Afrikaans' : 'kukeleku',
'Korea' : 'ko-ko-ko',
'Iceland' : 'Chuck-chuck!',
'Albania' : 'Kotkot',
'Algeria' : 'Cotcotcodet'
}
}
];
Otherwise with your version you're looping while looping when you can just simply check for existence.
Of course there are many ways to skin a cat, so the above is equivalent to
function petSounds(animal, country) {
const noise = animalNoises.find(obj => obj.hasOwnProperty(animal))[animal][country];
return `${animal}s in ${country} say ${noise}`
}
Of course if you are receiving this JSON from somewhere else you could do a reduction on it and then associate the keys and values into a super object(using Array#reduce() and Object.entries())
animalNoises = animalNoise.reduce((acc, obj) => {
Object.entries(obj).forEach(([key, value]) => {
acc[key] = value;
});
return acc;
},
{}
)
function petSounds(animal, country) {
return `${animal}s in ${country} say ${animalNoises[animal][country]}`;
}
If you want to learn more about the cool things you can do with Arrays you should check out the MDN for JavaScript Arrays
The in operator is a really useful way to make Object#hasOwnProperty() shorter
And as always a lot more information about JavaScript can be found at the MDN
Some extra fun with Object Sestructuring for just another way to arrange things:
function petSounds(animal, country) {
const { [animal]: { [country]: noise } } = animalNoises.find(obj => animal in obj);
return `${animal}s in ${country} say ${noise}`
}
answered Nov 21 '18 at 5:49
Robert MennellRobert Mennell
963517
add a comment |
If you want to keep the form you have now you can always use an Array#find(), and then a in operator check, and then with template literals you can easily create your string.
function petSounds(animal, country) {
const noise = animalNoises.find(obj => animal in obj)[animal][country];
return `${animal}s in ${country} say ${noise}`
}
let animalNoises = [
{ 'dog': {
'America' : 'Woof! Woof!',
'Germany' : 'Wau Wau!',
'England' : 'Bow wow!',
'Uruguay' : 'Jua jua!',
'Afrikaans' : 'Blaf!',
'Korea' : 'Mong mong!',
'Iceland' : 'Voff voff!',
'Albania' : 'Ham!',
'Algeria' : 'Ouaf ouaf!'
}
},
{ 'cat': {
'America' : 'Meow',
'Germany' : 'Miauw!',
'England' : 'mew mew',
'Uruguay' : 'Miau Miau!',
'Afrikaans' : 'Purr',
'Korea' : 'Nyaong!',
'Iceland' : 'Kurnau!',
'Albania' : 'Miau',
'Algeria' : 'Miaou!'
}
},
{ 'chicken': {
'America' : 'Cluck cluck',
'Germany' : 'tock tock tock',
'England' : 'Cluck Cluck',
'Uruguay' : 'gut gut gdak',
'Afrikaans' : 'kukeleku',
'Korea' : 'ko-ko-ko',
'Iceland' : 'Chuck-chuck!',
'Albania' : 'Kotkot',
'Algeria' : 'Cotcotcodet'
}
}
];
Otherwise with your version you're looping while looping when you can just simply check for existence.
Of course there are many ways to skin a cat, so the above is equivalent to
function petSounds(animal, country) {
const noise = animalNoises.find(obj => obj.hasOwnProperty(animal))[animal][country];
return `${animal}s in ${country} say ${noise}`
}
Of course if you are receiving this JSON from somewhere else you could do a reduction on it and then associate the keys and values into a super object(using Array#reduce() and Object.entries())
animalNoises = animalNoise.reduce((acc, obj) => {
Object.entries(obj).forEach(([key, value]) => {
acc[key] = value;
});
return acc;
},
{}
)
function petSounds(animal, country) {
return `${animal}s in ${country} say ${animalNoises[animal][country]}`;
}
If you want to learn more about the cool things you can do with Arrays you should check out the MDN for JavaScript Arrays
The in operator is a really useful way to make Object#hasOwnProperty() shorter
And as always a lot more information about JavaScript can be found at the MDN
Some extra fun with Object Sestructuring for just another way to arrange things:
function petSounds(animal, country) {
const { [animal]: { [country]: noise } } = animalNoises.find(obj => animal in obj);
return `${animal}s in ${country} say ${noise}`
}
answered Nov 21 '18 at 5:49
Robert MennellRobert Mennell
963517
add a comment |
If you want to keep the form you have now you can always use an Array#find(), and then a in operator check, and then with template literals you can easily create your string.
function petSounds(animal, country) {
const noise = animalNoises.find(obj => animal in obj)[animal][country];
return `${animal}s in ${country} say ${noise}`
}
let animalNoises = [
{ 'dog': {
'America' : 'Woof! Woof!',
'Germany' : 'Wau Wau!',
'England' : 'Bow wow!',
'Uruguay' : 'Jua jua!',
'Afrikaans' : 'Blaf!',
'Korea' : 'Mong mong!',
'Iceland' : 'Voff voff!',
'Albania' : 'Ham!',
'Algeria' : 'Ouaf ouaf!'
}
},
{ 'cat': {
'America' : 'Meow',
'Germany' : 'Miauw!',
'England' : 'mew mew',
'Uruguay' : 'Miau Miau!',
'Afrikaans' : 'Purr',
'Korea' : 'Nyaong!',
'Iceland' : 'Kurnau!',
'Albania' : 'Miau',
'Algeria' : 'Miaou!'
}
},
{ 'chicken': {
'America' : 'Cluck cluck',
'Germany' : 'tock tock tock',
'England' : 'Cluck Cluck',
'Uruguay' : 'gut gut gdak',
'Afrikaans' : 'kukeleku',
'Korea' : 'ko-ko-ko',
'Iceland' : 'Chuck-chuck!',
'Albania' : 'Kotkot',
'Algeria' : 'Cotcotcodet'
}
}
];
Otherwise with your version you're looping while looping when you can just simply check for existence.
Of course there are many ways to skin a cat, so the above is equivalent to
function petSounds(animal, country) {
const noise = animalNoises.find(obj => obj.hasOwnProperty(animal))[animal][country];
return `${animal}s in ${country} say ${noise}`
}
Of course if you are receiving this JSON from somewhere else you could do a reduction on it and then associate the keys and values into a super object(using Array#reduce() and Object.entries())
animalNoises = animalNoise.reduce((acc, obj) => {
Object.entries(obj).forEach(([key, value]) => {
acc[key] = value;
});
return acc;
},
{}
)
function petSounds(animal, country) {
return `${animal}s in ${country} say ${animalNoises[animal][country]}`;
}
If you want to learn more about the cool things you can do with Arrays you should check out the MDN for JavaScript Arrays
The in operator is a really useful way to make Object#hasOwnProperty() shorter
And as always a lot more information about JavaScript can be found at the MDN
Some extra fun with Object Sestructuring for just another way to arrange things:
function petSounds(animal, country) {
const { [animal]: { [country]: noise } } = animalNoises.find(obj => animal in obj);
return `${animal}s in ${country} say ${noise}`
}
answered Nov 21 '18 at 5:49
Robert MennellRobert Mennell
963517
If you want to keep the form you have now you can always use an Array#find(), and then a in operator check, and then with template literals you can easily create your string.
function petSounds(animal, country) {
const noise = animalNoises.find(obj => animal in obj)[animal][country];
return `${animal}s in ${country} say ${noise}`
}
let animalNoises = [
{ 'dog': {
'America' : 'Woof! Woof!',
'Germany' : 'Wau Wau!',
'England' : 'Bow wow!',
'Uruguay' : 'Jua jua!',
'Afrikaans' : 'Blaf!',
'Korea' : 'Mong mong!',
'Iceland' : 'Voff voff!',
'Albania' : 'Ham!',
'Algeria' : 'Ouaf ouaf!'
}
},
{ 'cat': {
'America' : 'Meow',
'Germany' : 'Miauw!',
'England' : 'mew mew',
'Uruguay' : 'Miau Miau!',
'Afrikaans' : 'Purr',
'Korea' : 'Nyaong!',
'Iceland' : 'Kurnau!',
'Albania' : 'Miau',
'Algeria' : 'Miaou!'
}
},
{ 'chicken': {
'America' : 'Cluck cluck',
'Germany' : 'tock tock tock',
'England' : 'Cluck Cluck',
'Uruguay' : 'gut gut gdak',
'Afrikaans' : 'kukeleku',
'Korea' : 'ko-ko-ko',
'Iceland' : 'Chuck-chuck!',
'Albania' : 'Kotkot',
'Algeria' : 'Cotcotcodet'
}
}
];
Otherwise with your version you're looping while looping when you can just simply check for existence.
Of course there are many ways to skin a cat, so the above is equivalent to
function petSounds(animal, country) {
const noise = animalNoises.find(obj => obj.hasOwnProperty(animal))[animal][country];
return `${animal}s in ${country} say ${noise}`
}
Of course if you are receiving this JSON from somewhere else you could do a reduction on it and then associate the keys and values into a super object(using Array#reduce() and Object.entries())
animalNoises = animalNoise.reduce((acc, obj) => {
Object.entries(obj).forEach(([key, value]) => {
acc[key] = value;
});
return acc;
},
{}
)
function petSounds(animal, country) {
return `${animal}s in ${country} say ${animalNoises[animal][country]}`;
}
If you want to learn more about the cool things you can do with Arrays you should check out the MDN for JavaScript Arrays
The in operator is a really useful way to make Object#hasOwnProperty() shorter
And as always a lot more information about JavaScript can be found at the MDN
Some extra fun with Object Sestructuring for just another way to arrange things:
function petSounds(animal, country) {
const { [animal]: { [country]: noise } } = animalNoises.find(obj => animal in obj);
return `${animal}s in ${country} say ${noise}`
}
answered Nov 21 '18 at 5:49
Robert MennellRobert Mennell
963517
edited Nov 21 '18 at 10:58
answered Nov 21 '18 at 5:49
Robert MennellRobert Mennell
963517
answered Nov 21 '18 at 5:49
Robert MennellRobert Mennell
963517
answered Nov 21 '18 at 5:49
Robert MennellRobert Mennell
963517
963517
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53405590%2faccessing-objects%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Works with
console.log(petSounds('dog', 'America'));->dogs in America say Woof! Woof!andconsole.log(petSounds('chicken', 'Algeria'));->chickens in Algeria say Cotcotcodet– CertainPerformance
Nov 21 '18 at 5:11
the code seems alright. May be you are calling it with arguments which are not part of object's keys and hence it returns undefined.
– Saurabh Tiwari
Nov 21 '18 at 5:17
Also, you do understand that this way you will get a single return value at the end of all the loops.
– Saurabh Tiwari
Nov 21 '18 at 5:18
4
If you change the structure to a more reasonable
{'dog': {...}, 'cat': {...}, 'chicken': {...}}, you will be able to doanimalSounds[animal][country], with zero loops.– Amadan
Nov 21 '18 at 5:19