eDSL - implement an action that could be used only once in the sequence












3














I'm developing the following eDSL :



import Control.Monad.Free

type CommandHandler
= PersistedCommand -> Maybe AggregateSnapshot -> CommandDirective

data CommandDirective = Reject RejectionReason
| SkipBecauseAlreadyProcessed
| Transact (CommandTransaction ())

type RejectionReason = String

data Action a = PersistEvent Event a
| UpdateSnapshot AggregateSnapshot a
| GetCurrentTime (UTCTime -> a )
| GetNewEventId (EventId -> a) deriving (Functor)

type CommandTransaction a = Free Action a

persistEvent :: Event -> CommandTransaction ()
persistEvent event = Free . PersistEvent event $ Pure ()

updateSnapshot :: AggregateSnapshot -> CommandTransaction ()
updateSnapshot aggregateSnapshot
= Free . UpdateSnapshot aggregateSnapshot $ Pure ()

getNewEventID :: CommandTransaction EventId
getNewEventID = Free $ GetNewEventId Pure

getCurrentTime :: CommandTransaction UTCTime
getCurrentTime = Free $ GetCurrentTime Pure


I would like UpdateSnapshot to be used only once in a sequence not twice as I'm doing now. I could do it with phantom types and then UpdateSnapshot will be the last element of the action chain. But It's kind of semantically wrong and it does not work for 2 actions with the same nature then....



e.g : 2 last updateSnapshot should not be valid :



do
now <- getCurrentTime
eventId <- getNewEventID
persistEvent $ WorkspaceCreated
{ eventId = eventId
, createdOn = now
, workspaceId = workspaceId }
updateSnapshot $ AggregateSnapshot
{ lastOffsetConsumed = 0
, commandsProcessed = Set.fromList [commandId]
, state = AggregateState { aggregateId = workspaceId } }
updateSnapshot $ AggregateSnapshot
{ lastOffsetConsumed = 0
, commandsProcessed = Set.fromList [commandId]
, state = AggregateState { aggregateId = workspaceId } }









share|improve this question




















  • 1




    What do you mean by "not twice as I'm doing now?" Where are you using UpdateSnapshot?
    – Mark Seemann
    Nov 19 '18 at 19:54










  • I put en example of dsl to show what I meant by using twice UpdateSnapshot
    – Nicolas Henin
    Nov 19 '18 at 20:26










  • How about taking UpdateSnapshot out of Action and make it a FreeT that you can use to contain the (amputated) CommandTransaction? Most of the functions (persistEvent, getNewEventID, etc.) would return UpdateSnapshotT CommandTransaction a, but updateSnapshot would only return CommandTransaction. I haven't tried, so it may be a stupid idea...
    – Mark Seemann
    Nov 19 '18 at 20:33










  • It's a stupid idea.
    – Mark Seemann
    Nov 19 '18 at 21:29










  • Don't be to hard on yourself :-)
    – Nicolas Henin
    Nov 22 '18 at 10:25
















3














I'm developing the following eDSL :



import Control.Monad.Free

type CommandHandler
= PersistedCommand -> Maybe AggregateSnapshot -> CommandDirective

data CommandDirective = Reject RejectionReason
| SkipBecauseAlreadyProcessed
| Transact (CommandTransaction ())

type RejectionReason = String

data Action a = PersistEvent Event a
| UpdateSnapshot AggregateSnapshot a
| GetCurrentTime (UTCTime -> a )
| GetNewEventId (EventId -> a) deriving (Functor)

type CommandTransaction a = Free Action a

persistEvent :: Event -> CommandTransaction ()
persistEvent event = Free . PersistEvent event $ Pure ()

updateSnapshot :: AggregateSnapshot -> CommandTransaction ()
updateSnapshot aggregateSnapshot
= Free . UpdateSnapshot aggregateSnapshot $ Pure ()

getNewEventID :: CommandTransaction EventId
getNewEventID = Free $ GetNewEventId Pure

getCurrentTime :: CommandTransaction UTCTime
getCurrentTime = Free $ GetCurrentTime Pure


I would like UpdateSnapshot to be used only once in a sequence not twice as I'm doing now. I could do it with phantom types and then UpdateSnapshot will be the last element of the action chain. But It's kind of semantically wrong and it does not work for 2 actions with the same nature then....



e.g : 2 last updateSnapshot should not be valid :



do
now <- getCurrentTime
eventId <- getNewEventID
persistEvent $ WorkspaceCreated
{ eventId = eventId
, createdOn = now
, workspaceId = workspaceId }
updateSnapshot $ AggregateSnapshot
{ lastOffsetConsumed = 0
, commandsProcessed = Set.fromList [commandId]
, state = AggregateState { aggregateId = workspaceId } }
updateSnapshot $ AggregateSnapshot
{ lastOffsetConsumed = 0
, commandsProcessed = Set.fromList [commandId]
, state = AggregateState { aggregateId = workspaceId } }









share|improve this question




















  • 1




    What do you mean by "not twice as I'm doing now?" Where are you using UpdateSnapshot?
    – Mark Seemann
    Nov 19 '18 at 19:54










  • I put en example of dsl to show what I meant by using twice UpdateSnapshot
    – Nicolas Henin
    Nov 19 '18 at 20:26










  • How about taking UpdateSnapshot out of Action and make it a FreeT that you can use to contain the (amputated) CommandTransaction? Most of the functions (persistEvent, getNewEventID, etc.) would return UpdateSnapshotT CommandTransaction a, but updateSnapshot would only return CommandTransaction. I haven't tried, so it may be a stupid idea...
    – Mark Seemann
    Nov 19 '18 at 20:33










  • It's a stupid idea.
    – Mark Seemann
    Nov 19 '18 at 21:29










  • Don't be to hard on yourself :-)
    – Nicolas Henin
    Nov 22 '18 at 10:25














3












3








3


2





I'm developing the following eDSL :



import Control.Monad.Free

type CommandHandler
= PersistedCommand -> Maybe AggregateSnapshot -> CommandDirective

data CommandDirective = Reject RejectionReason
| SkipBecauseAlreadyProcessed
| Transact (CommandTransaction ())

type RejectionReason = String

data Action a = PersistEvent Event a
| UpdateSnapshot AggregateSnapshot a
| GetCurrentTime (UTCTime -> a )
| GetNewEventId (EventId -> a) deriving (Functor)

type CommandTransaction a = Free Action a

persistEvent :: Event -> CommandTransaction ()
persistEvent event = Free . PersistEvent event $ Pure ()

updateSnapshot :: AggregateSnapshot -> CommandTransaction ()
updateSnapshot aggregateSnapshot
= Free . UpdateSnapshot aggregateSnapshot $ Pure ()

getNewEventID :: CommandTransaction EventId
getNewEventID = Free $ GetNewEventId Pure

getCurrentTime :: CommandTransaction UTCTime
getCurrentTime = Free $ GetCurrentTime Pure


I would like UpdateSnapshot to be used only once in a sequence not twice as I'm doing now. I could do it with phantom types and then UpdateSnapshot will be the last element of the action chain. But It's kind of semantically wrong and it does not work for 2 actions with the same nature then....



e.g : 2 last updateSnapshot should not be valid :



do
now <- getCurrentTime
eventId <- getNewEventID
persistEvent $ WorkspaceCreated
{ eventId = eventId
, createdOn = now
, workspaceId = workspaceId }
updateSnapshot $ AggregateSnapshot
{ lastOffsetConsumed = 0
, commandsProcessed = Set.fromList [commandId]
, state = AggregateState { aggregateId = workspaceId } }
updateSnapshot $ AggregateSnapshot
{ lastOffsetConsumed = 0
, commandsProcessed = Set.fromList [commandId]
, state = AggregateState { aggregateId = workspaceId } }









share|improve this question















I'm developing the following eDSL :



import Control.Monad.Free

type CommandHandler
= PersistedCommand -> Maybe AggregateSnapshot -> CommandDirective

data CommandDirective = Reject RejectionReason
| SkipBecauseAlreadyProcessed
| Transact (CommandTransaction ())

type RejectionReason = String

data Action a = PersistEvent Event a
| UpdateSnapshot AggregateSnapshot a
| GetCurrentTime (UTCTime -> a )
| GetNewEventId (EventId -> a) deriving (Functor)

type CommandTransaction a = Free Action a

persistEvent :: Event -> CommandTransaction ()
persistEvent event = Free . PersistEvent event $ Pure ()

updateSnapshot :: AggregateSnapshot -> CommandTransaction ()
updateSnapshot aggregateSnapshot
= Free . UpdateSnapshot aggregateSnapshot $ Pure ()

getNewEventID :: CommandTransaction EventId
getNewEventID = Free $ GetNewEventId Pure

getCurrentTime :: CommandTransaction UTCTime
getCurrentTime = Free $ GetCurrentTime Pure


I would like UpdateSnapshot to be used only once in a sequence not twice as I'm doing now. I could do it with phantom types and then UpdateSnapshot will be the last element of the action chain. But It's kind of semantically wrong and it does not work for 2 actions with the same nature then....



e.g : 2 last updateSnapshot should not be valid :



do
now <- getCurrentTime
eventId <- getNewEventID
persistEvent $ WorkspaceCreated
{ eventId = eventId
, createdOn = now
, workspaceId = workspaceId }
updateSnapshot $ AggregateSnapshot
{ lastOffsetConsumed = 0
, commandsProcessed = Set.fromList [commandId]
, state = AggregateState { aggregateId = workspaceId } }
updateSnapshot $ AggregateSnapshot
{ lastOffsetConsumed = 0
, commandsProcessed = Set.fromList [commandId]
, state = AggregateState { aggregateId = workspaceId } }






haskell dsl free-monad






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Nov 20 '18 at 9:47









leftaroundabout

79k3117233




79k3117233










asked Nov 19 '18 at 16:13









Nicolas Henin

1,06521433




1,06521433








  • 1




    What do you mean by "not twice as I'm doing now?" Where are you using UpdateSnapshot?
    – Mark Seemann
    Nov 19 '18 at 19:54










  • I put en example of dsl to show what I meant by using twice UpdateSnapshot
    – Nicolas Henin
    Nov 19 '18 at 20:26










  • How about taking UpdateSnapshot out of Action and make it a FreeT that you can use to contain the (amputated) CommandTransaction? Most of the functions (persistEvent, getNewEventID, etc.) would return UpdateSnapshotT CommandTransaction a, but updateSnapshot would only return CommandTransaction. I haven't tried, so it may be a stupid idea...
    – Mark Seemann
    Nov 19 '18 at 20:33










  • It's a stupid idea.
    – Mark Seemann
    Nov 19 '18 at 21:29










  • Don't be to hard on yourself :-)
    – Nicolas Henin
    Nov 22 '18 at 10:25














  • 1




    What do you mean by "not twice as I'm doing now?" Where are you using UpdateSnapshot?
    – Mark Seemann
    Nov 19 '18 at 19:54










  • I put en example of dsl to show what I meant by using twice UpdateSnapshot
    – Nicolas Henin
    Nov 19 '18 at 20:26










  • How about taking UpdateSnapshot out of Action and make it a FreeT that you can use to contain the (amputated) CommandTransaction? Most of the functions (persistEvent, getNewEventID, etc.) would return UpdateSnapshotT CommandTransaction a, but updateSnapshot would only return CommandTransaction. I haven't tried, so it may be a stupid idea...
    – Mark Seemann
    Nov 19 '18 at 20:33










  • It's a stupid idea.
    – Mark Seemann
    Nov 19 '18 at 21:29










  • Don't be to hard on yourself :-)
    – Nicolas Henin
    Nov 22 '18 at 10:25








1




1




What do you mean by "not twice as I'm doing now?" Where are you using UpdateSnapshot?
– Mark Seemann
Nov 19 '18 at 19:54




What do you mean by "not twice as I'm doing now?" Where are you using UpdateSnapshot?
– Mark Seemann
Nov 19 '18 at 19:54












I put en example of dsl to show what I meant by using twice UpdateSnapshot
– Nicolas Henin
Nov 19 '18 at 20:26




I put en example of dsl to show what I meant by using twice UpdateSnapshot
– Nicolas Henin
Nov 19 '18 at 20:26












How about taking UpdateSnapshot out of Action and make it a FreeT that you can use to contain the (amputated) CommandTransaction? Most of the functions (persistEvent, getNewEventID, etc.) would return UpdateSnapshotT CommandTransaction a, but updateSnapshot would only return CommandTransaction. I haven't tried, so it may be a stupid idea...
– Mark Seemann
Nov 19 '18 at 20:33




How about taking UpdateSnapshot out of Action and make it a FreeT that you can use to contain the (amputated) CommandTransaction? Most of the functions (persistEvent, getNewEventID, etc.) would return UpdateSnapshotT CommandTransaction a, but updateSnapshot would only return CommandTransaction. I haven't tried, so it may be a stupid idea...
– Mark Seemann
Nov 19 '18 at 20:33












It's a stupid idea.
– Mark Seemann
Nov 19 '18 at 21:29




It's a stupid idea.
– Mark Seemann
Nov 19 '18 at 21:29












Don't be to hard on yourself :-)
– Nicolas Henin
Nov 22 '18 at 10:25




Don't be to hard on yourself :-)
– Nicolas Henin
Nov 22 '18 at 10:25












0






active

oldest

votes











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53378681%2fedsl-implement-an-action-that-could-be-used-only-once-in-the-sequence%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























0






active

oldest

votes








0






active

oldest

votes









active

oldest

votes






active

oldest

votes
















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.





Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


Please pay close attention to the following guidance:


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53378681%2fedsl-implement-an-action-that-could-be-used-only-once-in-the-sequence%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

'app-layout' is not a known element: how to share Component with different Modules

android studio warns about leanback feature tag usage required on manifest while using Unity exported app?

WPF add header to Image with URL pettitions [duplicate]