Mixing
How can I efficiently compare each value in an array with each other value?
I have an array called entriesFinal that contains arrays with a start time, end time, and duration.
I want to push these entries to an empty array called ganttData, adding on a couple of extra fields.
Some of the entries in entriesFinal overlap, and I don't want these in ganttData.
Below is my current implementation which is functionally perfect, but the execution time is too long.
N.B. forEachAsync is a custom method that is functionally equivalent to a regular forEach, but works asynchronously.
let invalidEntries =
await forEachAsync(entriesFinal, async entry1 => {
await forEachAsync(entriesFinal, async entry2 => {
if(entry1 != entry2){
let invalidStart = entry2.startTime.isBetween(entry1.startTime, entry1.endTime)
let invalidEnd= entry2.endTime.isBetween(entry1.startTime, entry1.endTime)
if(invalidStart || invalidEnd){
invalidEntries.push(entry2)
}
}
})
})
await forEachAsync(entriesFinal, async entry => {
if(!invalidEntries.includes(entry)){
ganttData.push({
name: channel.name,
label: label,
startTime: entry.startTime.format("DD/MM/YYYY HH:mm:ss"),
endTime: entry.endTime.format("DD/MM/YYYY HH:mm:ss"),
duration: entry.duration
})
}
})
Is there a more efficient way of excluding the overlapping entries? This whole sequence is inside a wider loop which runs ~1500 times, hence my need to minimize the execution time of this process.
javascript arrays sorting
asked Nov 21 '18 at 12:36
CharlieCharlie
400115
add a comment |
I have an array called entriesFinal that contains arrays with a start time, end time, and duration.
I want to push these entries to an empty array called ganttData, adding on a couple of extra fields.
Some of the entries in entriesFinal overlap, and I don't want these in ganttData.
Below is my current implementation which is functionally perfect, but the execution time is too long.
N.B. forEachAsync is a custom method that is functionally equivalent to a regular forEach, but works asynchronously.
let invalidEntries =
await forEachAsync(entriesFinal, async entry1 => {
await forEachAsync(entriesFinal, async entry2 => {
if(entry1 != entry2){
let invalidStart = entry2.startTime.isBetween(entry1.startTime, entry1.endTime)
let invalidEnd= entry2.endTime.isBetween(entry1.startTime, entry1.endTime)
if(invalidStart || invalidEnd){
invalidEntries.push(entry2)
}
}
})
})
await forEachAsync(entriesFinal, async entry => {
if(!invalidEntries.includes(entry)){
ganttData.push({
name: channel.name,
label: label,
startTime: entry.startTime.format("DD/MM/YYYY HH:mm:ss"),
endTime: entry.endTime.format("DD/MM/YYYY HH:mm:ss"),
duration: entry.duration
})
}
})
Is there a more efficient way of excluding the overlapping entries? This whole sequence is inside a wider loop which runs ~1500 times, hence my need to minimize the execution time of this process.
javascript arrays sorting
asked Nov 21 '18 at 12:36
CharlieCharlie
400115
did you compare the time with regularfor(;;)loop? function calls have pretty big overhead depending on the browser optimizations
– Slai
Nov 21 '18 at 12:43
2
if you sort entries by startTime, you'll only need to compare an entry with the previous one, not with all others.
– georg
Nov 21 '18 at 12:44
@Slai are you talking about the isBetween() function? If so, I am using moment.js for the dates and isBetween() is a built-in function
– Charlie
Nov 21 '18 at 12:44
1
functions in general have more overhead than native JavaScript, but my guess is that the custom forEachAsync has even more overhead stackoverflow.com/questions/43821759/…
– Slai
Nov 21 '18 at 12:52
add a comment |
I have an array called entriesFinal that contains arrays with a start time, end time, and duration.
I want to push these entries to an empty array called ganttData, adding on a couple of extra fields.
Some of the entries in entriesFinal overlap, and I don't want these in ganttData.
Below is my current implementation which is functionally perfect, but the execution time is too long.
N.B. forEachAsync is a custom method that is functionally equivalent to a regular forEach, but works asynchronously.
let invalidEntries =
await forEachAsync(entriesFinal, async entry1 => {
await forEachAsync(entriesFinal, async entry2 => {
if(entry1 != entry2){
let invalidStart = entry2.startTime.isBetween(entry1.startTime, entry1.endTime)
let invalidEnd= entry2.endTime.isBetween(entry1.startTime, entry1.endTime)
if(invalidStart || invalidEnd){
invalidEntries.push(entry2)
}
}
})
})
await forEachAsync(entriesFinal, async entry => {
if(!invalidEntries.includes(entry)){
ganttData.push({
name: channel.name,
label: label,
startTime: entry.startTime.format("DD/MM/YYYY HH:mm:ss"),
endTime: entry.endTime.format("DD/MM/YYYY HH:mm:ss"),
duration: entry.duration
})
}
})
Is there a more efficient way of excluding the overlapping entries? This whole sequence is inside a wider loop which runs ~1500 times, hence my need to minimize the execution time of this process.
javascript arrays sorting
asked Nov 21 '18 at 12:36
CharlieCharlie
400115
I have an array called entriesFinal that contains arrays with a start time, end time, and duration.
I want to push these entries to an empty array called ganttData, adding on a couple of extra fields.
Some of the entries in entriesFinal overlap, and I don't want these in ganttData.
Below is my current implementation which is functionally perfect, but the execution time is too long.
N.B. forEachAsync is a custom method that is functionally equivalent to a regular forEach, but works asynchronously.
let invalidEntries =
await forEachAsync(entriesFinal, async entry1 => {
await forEachAsync(entriesFinal, async entry2 => {
if(entry1 != entry2){
let invalidStart = entry2.startTime.isBetween(entry1.startTime, entry1.endTime)
let invalidEnd= entry2.endTime.isBetween(entry1.startTime, entry1.endTime)
if(invalidStart || invalidEnd){
invalidEntries.push(entry2)
}
}
})
})
await forEachAsync(entriesFinal, async entry => {
if(!invalidEntries.includes(entry)){
ganttData.push({
name: channel.name,
label: label,
startTime: entry.startTime.format("DD/MM/YYYY HH:mm:ss"),
endTime: entry.endTime.format("DD/MM/YYYY HH:mm:ss"),
duration: entry.duration
})
}
})
Is there a more efficient way of excluding the overlapping entries? This whole sequence is inside a wider loop which runs ~1500 times, hence my need to minimize the execution time of this process.
javascript arrays sorting
javascript arrays sorting
asked Nov 21 '18 at 12:36
CharlieCharlie
400115
asked Nov 21 '18 at 12:36
CharlieCharlie
400115
asked Nov 21 '18 at 12:36
CharlieCharlie
400115
asked Nov 21 '18 at 12:36
CharlieCharlie
400115
asked Nov 21 '18 at 12:36
CharlieCharlie
400115
400115
did you compare the time with regularfor(;;)loop? function calls have pretty big overhead depending on the browser optimizations
– Slai
Nov 21 '18 at 12:43
2
if you sort entries by startTime, you'll only need to compare an entry with the previous one, not with all others.
– georg
Nov 21 '18 at 12:44
@Slai are you talking about the isBetween() function? If so, I am using moment.js for the dates and isBetween() is a built-in function
– Charlie
Nov 21 '18 at 12:44
1
functions in general have more overhead than native JavaScript, but my guess is that the custom forEachAsync has even more overhead stackoverflow.com/questions/43821759/…
– Slai
Nov 21 '18 at 12:52
add a comment |
did you compare the time with regularfor(;;)loop? function calls have pretty big overhead depending on the browser optimizations
– Slai
Nov 21 '18 at 12:43
2
if you sort entries by startTime, you'll only need to compare an entry with the previous one, not with all others.
– georg
Nov 21 '18 at 12:44
@Slai are you talking about the isBetween() function? If so, I am using moment.js for the dates and isBetween() is a built-in function
– Charlie
Nov 21 '18 at 12:44
1
functions in general have more overhead than native JavaScript, but my guess is that the custom forEachAsync has even more overhead stackoverflow.com/questions/43821759/…
– Slai
Nov 21 '18 at 12:52
did you compare the time with regular
for(;;) loop? function calls have pretty big overhead depending on the browser optimizations– Slai
Nov 21 '18 at 12:43
did you compare the time with regular
for(;;) loop? function calls have pretty big overhead depending on the browser optimizations– Slai
Nov 21 '18 at 12:43
2
2
if you sort entries by startTime, you'll only need to compare an entry with the previous one, not with all others.
– georg
Nov 21 '18 at 12:44
if you sort entries by startTime, you'll only need to compare an entry with the previous one, not with all others.
– georg
Nov 21 '18 at 12:44
@Slai are you talking about the isBetween() function? If so, I am using moment.js for the dates and isBetween() is a built-in function
– Charlie
Nov 21 '18 at 12:44
@Slai are you talking about the isBetween() function? If so, I am using moment.js for the dates and isBetween() is a built-in function
– Charlie
Nov 21 '18 at 12:44
1
1
functions in general have more overhead than native JavaScript, but my guess is that the custom forEachAsync has even more overhead stackoverflow.com/questions/43821759/…
– Slai
Nov 21 '18 at 12:52
functions in general have more overhead than native JavaScript, but my guess is that the custom forEachAsync has even more overhead stackoverflow.com/questions/43821759/…
– Slai
Nov 21 '18 at 12:52
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53412183%2fhow-can-i-efficiently-compare-each-value-in-an-array-with-each-other-value%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53412183%2fhow-can-i-efficiently-compare-each-value-in-an-array-with-each-other-value%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
did you compare the time with regular
for(;;)loop? function calls have pretty big overhead depending on the browser optimizations– Slai
Nov 21 '18 at 12:43
2
if you sort entries by startTime, you'll only need to compare an entry with the previous one, not with all others.
– georg
Nov 21 '18 at 12:44
@Slai are you talking about the isBetween() function? If so, I am using moment.js for the dates and isBetween() is a built-in function
– Charlie
Nov 21 '18 at 12:44
1
functions in general have more overhead than native JavaScript, but my guess is that the custom forEachAsync has even more overhead stackoverflow.com/questions/43821759/…
– Slai
Nov 21 '18 at 12:52