Android app crashes when I call mAdaper.notifyDataSetChanged();












-1















This is an app thats supposed to get the contacts from the phone and list the ones that have a phone number in a listview.
But the app crashes when mAdaper.notifyDataSetChanged(); is called :/
please help.



public class MainActivity extends Activity{
static int num = 0;

ListView lv;
ArrayAdapter<String> mAdaper;
ArrayList<String> contacts = new ArrayList<String>();


@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);


getContacts();

lv = (ListView)findViewById(R.id.listView1);
mAdaper = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_1, contacts);

lv.setAdapter(mAdaper);

}

private void getContacts(){

ContentResolver cr = getContentResolver();
Cursor cur = cr.query(ContactsContract.Contacts.CONTENT_URI, null, // projection,
null, // selection,
null, // selectionArgs,
"_ID DESC" // sortOrder
);

if (cur.getCount() > 0) {
while (cur.moveToNext() && num < 10) {
String id = cur.getString(cur
.getColumnIndex(ContactsContract.Contacts._ID));
String name = cur
.getString(cur
.getColumnIndex(ContactsContract.Contacts.DISPLAY_NAME));
if (Integer
.parseInt(cur.getString(cur
.getColumnIndex(ContactsContract.Contacts.HAS_PHONE_NUMBER))) > 0) {

// TableRow row = new TableRow(this);
TextView tv = new TextView(this);
String row = id + " - " + name;
contacts.add(row);
//mAdaper.add(row);
num++;

}
}
}
mAdaper.notifyDataSetChanged();

}









share|improve this question



























    -1















    This is an app thats supposed to get the contacts from the phone and list the ones that have a phone number in a listview.
    But the app crashes when mAdaper.notifyDataSetChanged(); is called :/
    please help.



    public class MainActivity extends Activity{
    static int num = 0;

    ListView lv;
    ArrayAdapter<String> mAdaper;
    ArrayList<String> contacts = new ArrayList<String>();


    @Override
    protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);


    getContacts();

    lv = (ListView)findViewById(R.id.listView1);
    mAdaper = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_1, contacts);

    lv.setAdapter(mAdaper);

    }

    private void getContacts(){

    ContentResolver cr = getContentResolver();
    Cursor cur = cr.query(ContactsContract.Contacts.CONTENT_URI, null, // projection,
    null, // selection,
    null, // selectionArgs,
    "_ID DESC" // sortOrder
    );

    if (cur.getCount() > 0) {
    while (cur.moveToNext() && num < 10) {
    String id = cur.getString(cur
    .getColumnIndex(ContactsContract.Contacts._ID));
    String name = cur
    .getString(cur
    .getColumnIndex(ContactsContract.Contacts.DISPLAY_NAME));
    if (Integer
    .parseInt(cur.getString(cur
    .getColumnIndex(ContactsContract.Contacts.HAS_PHONE_NUMBER))) > 0) {

    // TableRow row = new TableRow(this);
    TextView tv = new TextView(this);
    String row = id + " - " + name;
    contacts.add(row);
    //mAdaper.add(row);
    num++;

    }
    }
    }
    mAdaper.notifyDataSetChanged();

    }









    share|improve this question

























      -1












      -1








      -1








      This is an app thats supposed to get the contacts from the phone and list the ones that have a phone number in a listview.
      But the app crashes when mAdaper.notifyDataSetChanged(); is called :/
      please help.



      public class MainActivity extends Activity{
      static int num = 0;

      ListView lv;
      ArrayAdapter<String> mAdaper;
      ArrayList<String> contacts = new ArrayList<String>();


      @Override
      protected void onCreate(Bundle savedInstanceState) {
      super.onCreate(savedInstanceState);
      setContentView(R.layout.activity_main);


      getContacts();

      lv = (ListView)findViewById(R.id.listView1);
      mAdaper = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_1, contacts);

      lv.setAdapter(mAdaper);

      }

      private void getContacts(){

      ContentResolver cr = getContentResolver();
      Cursor cur = cr.query(ContactsContract.Contacts.CONTENT_URI, null, // projection,
      null, // selection,
      null, // selectionArgs,
      "_ID DESC" // sortOrder
      );

      if (cur.getCount() > 0) {
      while (cur.moveToNext() && num < 10) {
      String id = cur.getString(cur
      .getColumnIndex(ContactsContract.Contacts._ID));
      String name = cur
      .getString(cur
      .getColumnIndex(ContactsContract.Contacts.DISPLAY_NAME));
      if (Integer
      .parseInt(cur.getString(cur
      .getColumnIndex(ContactsContract.Contacts.HAS_PHONE_NUMBER))) > 0) {

      // TableRow row = new TableRow(this);
      TextView tv = new TextView(this);
      String row = id + " - " + name;
      contacts.add(row);
      //mAdaper.add(row);
      num++;

      }
      }
      }
      mAdaper.notifyDataSetChanged();

      }









      share|improve this question














      This is an app thats supposed to get the contacts from the phone and list the ones that have a phone number in a listview.
      But the app crashes when mAdaper.notifyDataSetChanged(); is called :/
      please help.



      public class MainActivity extends Activity{
      static int num = 0;

      ListView lv;
      ArrayAdapter<String> mAdaper;
      ArrayList<String> contacts = new ArrayList<String>();


      @Override
      protected void onCreate(Bundle savedInstanceState) {
      super.onCreate(savedInstanceState);
      setContentView(R.layout.activity_main);


      getContacts();

      lv = (ListView)findViewById(R.id.listView1);
      mAdaper = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_1, contacts);

      lv.setAdapter(mAdaper);

      }

      private void getContacts(){

      ContentResolver cr = getContentResolver();
      Cursor cur = cr.query(ContactsContract.Contacts.CONTENT_URI, null, // projection,
      null, // selection,
      null, // selectionArgs,
      "_ID DESC" // sortOrder
      );

      if (cur.getCount() > 0) {
      while (cur.moveToNext() && num < 10) {
      String id = cur.getString(cur
      .getColumnIndex(ContactsContract.Contacts._ID));
      String name = cur
      .getString(cur
      .getColumnIndex(ContactsContract.Contacts.DISPLAY_NAME));
      if (Integer
      .parseInt(cur.getString(cur
      .getColumnIndex(ContactsContract.Contacts.HAS_PHONE_NUMBER))) > 0) {

      // TableRow row = new TableRow(this);
      TextView tv = new TextView(this);
      String row = id + " - " + name;
      contacts.add(row);
      //mAdaper.add(row);
      num++;

      }
      }
      }
      mAdaper.notifyDataSetChanged();

      }






      android






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked May 8 '13 at 0:16









      SiavashSiavash

      4,54973455




      4,54973455
























          2 Answers
          2






          active

          oldest

          votes


















          1














          You are calling getContacts() before initializing the mAdapter. In the getContacts(), you are calling mAdapter.notifyDataSetChanged();. At this point, mAdapter is not yet initialized.



          Call getContacts() after you have initialized the mAdapter.



          lv = (ListView)findViewById(R.id.listView1);
          mAdapter = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_1, contacts);
          lv.setAdapter(mAdapter);
          getContacts();





          share|improve this answer































            0














            I've done this (I think it's very dirty) by calling onCreate(null) after changing data-sets. This restores my Recycler perfectly:



            This crashes:



                // delete selected items from database
            sqLiteDatabase.execSQL("DELETE FROM country WHERE selected");
            cursor = getDBContent();
            cursor.close();
            mainActivityAdapter.notifyDataSetChanged();


            This not:



                // delete selected items from database
            sqLiteDatabase.execSQL("DELETE FROM country WHERE selected");
            cursor = getDBContent();
            cursor.close();
            this.onCreate(null);


            I did a System.out.println() and wether the cursor nor the mainActivityAdapter has been "null". But in my example, the index of the cursor seems to be the couse of the crashing, even that I restored it. But I don't mind, as long as the above is working and running stable (maybe it is inefficient).






            share|improve this answer























              Your Answer






              StackExchange.ifUsing("editor", function () {
              StackExchange.using("externalEditor", function () {
              StackExchange.using("snippets", function () {
              StackExchange.snippets.init();
              });
              });
              }, "code-snippets");

              StackExchange.ready(function() {
              var channelOptions = {
              tags: "".split(" "),
              id: "1"
              };
              initTagRenderer("".split(" "), "".split(" "), channelOptions);

              StackExchange.using("externalEditor", function() {
              // Have to fire editor after snippets, if snippets enabled
              if (StackExchange.settings.snippets.snippetsEnabled) {
              StackExchange.using("snippets", function() {
              createEditor();
              });
              }
              else {
              createEditor();
              }
              });

              function createEditor() {
              StackExchange.prepareEditor({
              heartbeatType: 'answer',
              autoActivateHeartbeat: false,
              convertImagesToLinks: true,
              noModals: true,
              showLowRepImageUploadWarning: true,
              reputationToPostImages: 10,
              bindNavPrevention: true,
              postfix: "",
              imageUploader: {
              brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
              contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
              allowUrls: true
              },
              onDemand: true,
              discardSelector: ".discard-answer"
              ,immediatelyShowMarkdownHelp:true
              });


              }
              });














              draft saved

              draft discarded


















              StackExchange.ready(
              function () {
              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f16430679%2fandroid-app-crashes-when-i-call-madaper-notifydatasetchanged%23new-answer', 'question_page');
              }
              );

              Post as a guest















              Required, but never shown

























              2 Answers
              2






              active

              oldest

              votes








              2 Answers
              2






              active

              oldest

              votes









              active

              oldest

              votes






              active

              oldest

              votes









              1














              You are calling getContacts() before initializing the mAdapter. In the getContacts(), you are calling mAdapter.notifyDataSetChanged();. At this point, mAdapter is not yet initialized.



              Call getContacts() after you have initialized the mAdapter.



              lv = (ListView)findViewById(R.id.listView1);
              mAdapter = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_1, contacts);
              lv.setAdapter(mAdapter);
              getContacts();





              share|improve this answer




























                1














                You are calling getContacts() before initializing the mAdapter. In the getContacts(), you are calling mAdapter.notifyDataSetChanged();. At this point, mAdapter is not yet initialized.



                Call getContacts() after you have initialized the mAdapter.



                lv = (ListView)findViewById(R.id.listView1);
                mAdapter = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_1, contacts);
                lv.setAdapter(mAdapter);
                getContacts();





                share|improve this answer


























                  1












                  1








                  1







                  You are calling getContacts() before initializing the mAdapter. In the getContacts(), you are calling mAdapter.notifyDataSetChanged();. At this point, mAdapter is not yet initialized.



                  Call getContacts() after you have initialized the mAdapter.



                  lv = (ListView)findViewById(R.id.listView1);
                  mAdapter = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_1, contacts);
                  lv.setAdapter(mAdapter);
                  getContacts();





                  share|improve this answer













                  You are calling getContacts() before initializing the mAdapter. In the getContacts(), you are calling mAdapter.notifyDataSetChanged();. At this point, mAdapter is not yet initialized.



                  Call getContacts() after you have initialized the mAdapter.



                  lv = (ListView)findViewById(R.id.listView1);
                  mAdapter = new ArrayAdapter<String>(this, android.R.layout.simple_list_item_1, contacts);
                  lv.setAdapter(mAdapter);
                  getContacts();






                  share|improve this answer












                  share|improve this answer



                  share|improve this answer










                  answered May 8 '13 at 0:18









                  Aswin RajendiranAswin Rajendiran

                  3,14211617




                  3,14211617

























                      0














                      I've done this (I think it's very dirty) by calling onCreate(null) after changing data-sets. This restores my Recycler perfectly:



                      This crashes:



                          // delete selected items from database
                      sqLiteDatabase.execSQL("DELETE FROM country WHERE selected");
                      cursor = getDBContent();
                      cursor.close();
                      mainActivityAdapter.notifyDataSetChanged();


                      This not:



                          // delete selected items from database
                      sqLiteDatabase.execSQL("DELETE FROM country WHERE selected");
                      cursor = getDBContent();
                      cursor.close();
                      this.onCreate(null);


                      I did a System.out.println() and wether the cursor nor the mainActivityAdapter has been "null". But in my example, the index of the cursor seems to be the couse of the crashing, even that I restored it. But I don't mind, as long as the above is working and running stable (maybe it is inefficient).






                      share|improve this answer




























                        0














                        I've done this (I think it's very dirty) by calling onCreate(null) after changing data-sets. This restores my Recycler perfectly:



                        This crashes:



                            // delete selected items from database
                        sqLiteDatabase.execSQL("DELETE FROM country WHERE selected");
                        cursor = getDBContent();
                        cursor.close();
                        mainActivityAdapter.notifyDataSetChanged();


                        This not:



                            // delete selected items from database
                        sqLiteDatabase.execSQL("DELETE FROM country WHERE selected");
                        cursor = getDBContent();
                        cursor.close();
                        this.onCreate(null);


                        I did a System.out.println() and wether the cursor nor the mainActivityAdapter has been "null". But in my example, the index of the cursor seems to be the couse of the crashing, even that I restored it. But I don't mind, as long as the above is working and running stable (maybe it is inefficient).






                        share|improve this answer


























                          0












                          0








                          0







                          I've done this (I think it's very dirty) by calling onCreate(null) after changing data-sets. This restores my Recycler perfectly:



                          This crashes:



                              // delete selected items from database
                          sqLiteDatabase.execSQL("DELETE FROM country WHERE selected");
                          cursor = getDBContent();
                          cursor.close();
                          mainActivityAdapter.notifyDataSetChanged();


                          This not:



                              // delete selected items from database
                          sqLiteDatabase.execSQL("DELETE FROM country WHERE selected");
                          cursor = getDBContent();
                          cursor.close();
                          this.onCreate(null);


                          I did a System.out.println() and wether the cursor nor the mainActivityAdapter has been "null". But in my example, the index of the cursor seems to be the couse of the crashing, even that I restored it. But I don't mind, as long as the above is working and running stable (maybe it is inefficient).






                          share|improve this answer













                          I've done this (I think it's very dirty) by calling onCreate(null) after changing data-sets. This restores my Recycler perfectly:



                          This crashes:



                              // delete selected items from database
                          sqLiteDatabase.execSQL("DELETE FROM country WHERE selected");
                          cursor = getDBContent();
                          cursor.close();
                          mainActivityAdapter.notifyDataSetChanged();


                          This not:



                              // delete selected items from database
                          sqLiteDatabase.execSQL("DELETE FROM country WHERE selected");
                          cursor = getDBContent();
                          cursor.close();
                          this.onCreate(null);


                          I did a System.out.println() and wether the cursor nor the mainActivityAdapter has been "null". But in my example, the index of the cursor seems to be the couse of the crashing, even that I restored it. But I don't mind, as long as the above is working and running stable (maybe it is inefficient).







                          share|improve this answer












                          share|improve this answer



                          share|improve this answer










                          answered Jan 1 at 16:16









                          MartinMartin

                          1691211




                          1691211






























                              draft saved

                              draft discarded




















































                              Thanks for contributing an answer to Stack Overflow!


                              • Please be sure to answer the question. Provide details and share your research!

                              But avoid



                              • Asking for help, clarification, or responding to other answers.

                              • Making statements based on opinion; back them up with references or personal experience.


                              To learn more, see our tips on writing great answers.




                              draft saved


                              draft discarded














                              StackExchange.ready(
                              function () {
                              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f16430679%2fandroid-app-crashes-when-i-call-madaper-notifydatasetchanged%23new-answer', 'question_page');
                              }
                              );

                              Post as a guest















                              Required, but never shown





















































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown

































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown







                              Popular posts from this blog

                              MongoDB - Not Authorized To Execute Command

                              Npm cannot find a required file even through it is in the searched directory

                              in spring boot 2.1 many test slices are not allowed anymore due to multiple @BootstrapWith