How to construct a raw SQL Query in EF Core with dynamic number of parameters

.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ height:90px;width:728px;box-sizing:border-box;
}

I am trying to dynamically construct a raw SQL query that will have X number of conditions. I am working from the info on this page: https://docs.microsoft.com/en-us/ef/core/querying/raw-sql

Currently I have something similar to this:

String rawQuery = "SELECT * FROM ItemsTable WHERE ";



foreach (f in FilterList) {

  rawQuery = rawQuery + String.Format(f.condition, f.userInput);

  // f.condition is something like "Name LIKE {0}"

}



var filteredItems = context.ItemsTable

  .FromSql(rawQuery)

  .ToList();

The problem is, my parameters are not being substituted in using .FromSql(), so I am vulnerable to SQL injection attacks.

Is there a way to use .FromSql() for this task?

OR, Is there another way I can protect against SQL injection?

asked Jan 3 at 2:29

Daniel Stafford

8117

1

Use Passing Parameters as suggested in the link. It even states to do so to prevent sql injection.

– Erik Philips
Jan 3 at 2:49

add a comment |

I am trying to dynamically construct a raw SQL query that will have X number of conditions. I am working from the info on this page: https://docs.microsoft.com/en-us/ef/core/querying/raw-sql

Currently I have something similar to this:

String rawQuery = "SELECT * FROM ItemsTable WHERE ";



foreach (f in FilterList) {

  rawQuery = rawQuery + String.Format(f.condition, f.userInput);

  // f.condition is something like "Name LIKE {0}"

}



var filteredItems = context.ItemsTable

  .FromSql(rawQuery)

  .ToList();

The problem is, my parameters are not being substituted in using .FromSql(), so I am vulnerable to SQL injection attacks.

Is there a way to use .FromSql() for this task?

OR, Is there another way I can protect against SQL injection?

asked Jan 3 at 2:29

Daniel Stafford

8117

1

Use Passing Parameters as suggested in the link. It even states to do so to prevent sql injection.

– Erik Philips
Jan 3 at 2:49

add a comment |

I am trying to dynamically construct a raw SQL query that will have X number of conditions. I am working from the info on this page: https://docs.microsoft.com/en-us/ef/core/querying/raw-sql

Currently I have something similar to this:

String rawQuery = "SELECT * FROM ItemsTable WHERE ";



foreach (f in FilterList) {

  rawQuery = rawQuery + String.Format(f.condition, f.userInput);

  // f.condition is something like "Name LIKE {0}"

}



var filteredItems = context.ItemsTable

  .FromSql(rawQuery)

  .ToList();

The problem is, my parameters are not being substituted in using .FromSql(), so I am vulnerable to SQL injection attacks.

Is there a way to use .FromSql() for this task?

OR, Is there another way I can protect against SQL injection?

asked Jan 3 at 2:29

Daniel Stafford

8117

I am trying to dynamically construct a raw SQL query that will have X number of conditions. I am working from the info on this page: https://docs.microsoft.com/en-us/ef/core/querying/raw-sql

Currently I have something similar to this:

String rawQuery = "SELECT * FROM ItemsTable WHERE ";



foreach (f in FilterList) {

  rawQuery = rawQuery + String.Format(f.condition, f.userInput);

  // f.condition is something like "Name LIKE {0}"

}



var filteredItems = context.ItemsTable

  .FromSql(rawQuery)

  .ToList();

The problem is, my parameters are not being substituted in using .FromSql(), so I am vulnerable to SQL injection attacks.

Is there a way to use .FromSql() for this task?

OR, Is there another way I can protect against SQL injection?

c# sql linq entity-framework-core

asked Jan 3 at 2:29

Daniel Stafford

8117

asked Jan 3 at 2:29

Daniel Stafford

8117

asked Jan 3 at 2:29

Daniel Stafford

8117

asked Jan 3 at 2:29

Daniel Stafford

8117

asked Jan 3 at 2:29

Daniel Stafford

8117

1

Use Passing Parameters as suggested in the link. It even states to do so to prevent sql injection.

– Erik Philips
Jan 3 at 2:49

add a comment |

1

Use Passing Parameters as suggested in the link. It even states to do so to prevent sql injection.

– Erik Philips
Jan 3 at 2:49

Use Passing Parameters as suggested in the link. It even states to do so to prevent sql injection.

– Erik Philips
Jan 3 at 2:49

add a comment |

1 Answer
1

active

oldest

votes

You can make the query parameterized, build a list of SqlParameters, and then pass the query and the parameters into FromSql():

var rawQuery = new StringBuilder("SELECT * FROM ItemsTable WHERE ");

var sqlParameters = new List<SqlParameter>();



foreach (var f in FilterList) {

  var parameterName = $"@p{FilterList.IndexOf(f)}";

  var parameterizedCondition = string.Format(f.condition, parameterName);

  // f.condition is something like "Name LIKE {0}"



  rawQuery.Append(parameterizedCondition);

  sqlParameters.Add(new SqlParameter(parameterName, f.userInput));

}



var filteredItems = context.ItemsTable

  .FromSql(rawQuery.ToString(), sqlParameters)

  .ToList();

edited Jan 3 at 3:33

answered Jan 3 at 3:12

devNull

72257

add a comment |

Your Answer

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});

}
});

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54015590%2fhow-to-construct-a-raw-sql-query-in-ef-core-with-dynamic-number-of-parameters%23new-answer', 'question_page');
}
);

Post as a guest

Name

Required, but never shown

1 Answer
1

active

oldest

votes

1 Answer
1

active

oldest

votes

You can make the query parameterized, build a list of SqlParameters, and then pass the query and the parameters into FromSql():

var rawQuery = new StringBuilder("SELECT * FROM ItemsTable WHERE ");

var sqlParameters = new List<SqlParameter>();



foreach (var f in FilterList) {

  var parameterName = $"@p{FilterList.IndexOf(f)}";

  var parameterizedCondition = string.Format(f.condition, parameterName);

  // f.condition is something like "Name LIKE {0}"



  rawQuery.Append(parameterizedCondition);

  sqlParameters.Add(new SqlParameter(parameterName, f.userInput));

}



var filteredItems = context.ItemsTable

  .FromSql(rawQuery.ToString(), sqlParameters)

  .ToList();

edited Jan 3 at 3:33

answered Jan 3 at 3:12

devNull

72257

add a comment |

You can make the query parameterized, build a list of SqlParameters, and then pass the query and the parameters into FromSql():

var rawQuery = new StringBuilder("SELECT * FROM ItemsTable WHERE ");

var sqlParameters = new List<SqlParameter>();



foreach (var f in FilterList) {

  var parameterName = $"@p{FilterList.IndexOf(f)}";

  var parameterizedCondition = string.Format(f.condition, parameterName);

  // f.condition is something like "Name LIKE {0}"



  rawQuery.Append(parameterizedCondition);

  sqlParameters.Add(new SqlParameter(parameterName, f.userInput));

}



var filteredItems = context.ItemsTable

  .FromSql(rawQuery.ToString(), sqlParameters)

  .ToList();

edited Jan 3 at 3:33

answered Jan 3 at 3:12

devNull

72257

add a comment |

You can make the query parameterized, build a list of SqlParameters, and then pass the query and the parameters into FromSql():

var rawQuery = new StringBuilder("SELECT * FROM ItemsTable WHERE ");

var sqlParameters = new List<SqlParameter>();



foreach (var f in FilterList) {

  var parameterName = $"@p{FilterList.IndexOf(f)}";

  var parameterizedCondition = string.Format(f.condition, parameterName);

  // f.condition is something like "Name LIKE {0}"



  rawQuery.Append(parameterizedCondition);

  sqlParameters.Add(new SqlParameter(parameterName, f.userInput));

}



var filteredItems = context.ItemsTable

  .FromSql(rawQuery.ToString(), sqlParameters)

  .ToList();

edited Jan 3 at 3:33

answered Jan 3 at 3:12

devNull

72257

You can make the query parameterized, build a list of SqlParameters, and then pass the query and the parameters into FromSql():

var rawQuery = new StringBuilder("SELECT * FROM ItemsTable WHERE ");

var sqlParameters = new List<SqlParameter>();



foreach (var f in FilterList) {

  var parameterName = $"@p{FilterList.IndexOf(f)}";

  var parameterizedCondition = string.Format(f.condition, parameterName);

  // f.condition is something like "Name LIKE {0}"



  rawQuery.Append(parameterizedCondition);

  sqlParameters.Add(new SqlParameter(parameterName, f.userInput));

}



var filteredItems = context.ItemsTable

  .FromSql(rawQuery.ToString(), sqlParameters)

  .ToList();

edited Jan 3 at 3:33

answered Jan 3 at 3:12

devNull

72257

edited Jan 3 at 3:33

answered Jan 3 at 3:12

devNull

72257

answered Jan 3 at 3:12

devNull

72257

answered Jan 3 at 3:12

devNull

72257

add a comment |

draft saved

draft discarded

Thanks for contributing an answer to Stack Overflow!

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Name

Required, but never shown

Name

Required, but never shown

This page is only for reference, If you need detailed information, please check here

Search This Blog

Ufyukyu