Mixing
When to call File.Dispose()
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ height:90px;width:728px;box-sizing:border-box;
}
I am trying to use a text writer to write text to a file in .NET Core. The below code doesn't output anything to the file:
TextWriter writer = File.CreateText(@"...txt");
writer.Write("Hello World");
However, this does:
TextWriter writer = File.CreateText(@"...txt");
writer.Write("Hello World");
writer.Dispose();
Why is that? What does that extra line tell the program to do differently? I don't want to close the TextWriter because it is going to be writing logs, which are running constantly and indefinitely whilst my application is running.
How can I keep it open until the application stops running?
UPDATE
So the reason I want to do this, is I am using an SDK that writes its logs to a TextWriter:
TextWriterLogger(textWriter);
//Creates a logger that writes to a TextWriter. User is responsible for providing an instance of TextWriter that is thread safe.
But if I just enclose this in a using statement, logs won't be written because by the time they are ready to be written, the using statement will have executed and the TextWriter disposed.
Thanks
c# file dispose textwriter
asked Jan 3 at 4:36
Harry StuartHarry Stuart
392313
add a comment |
I am trying to use a text writer to write text to a file in .NET Core. The below code doesn't output anything to the file:
TextWriter writer = File.CreateText(@"...txt");
writer.Write("Hello World");
However, this does:
TextWriter writer = File.CreateText(@"...txt");
writer.Write("Hello World");
writer.Dispose();
Why is that? What does that extra line tell the program to do differently? I don't want to close the TextWriter because it is going to be writing logs, which are running constantly and indefinitely whilst my application is running.
How can I keep it open until the application stops running?
UPDATE
So the reason I want to do this, is I am using an SDK that writes its logs to a TextWriter:
TextWriterLogger(textWriter);
//Creates a logger that writes to a TextWriter. User is responsible for providing an instance of TextWriter that is thread safe.
But if I just enclose this in a using statement, logs won't be written because by the time they are ready to be written, the using statement will have executed and the TextWriter disposed.
Thanks
c# file dispose textwriter
asked Jan 3 at 4:36
Harry StuartHarry Stuart
392313
1
normally we open the file write and dispose and then reopen next time
– Ehsan Sajjad
Jan 3 at 4:38
On some classes, however, it is possible to re-open an object which has been Close'd. Some such classes may keep some resources alive after a Close, in order to permit reopening; others may not keep any resources alive on Close, but might set a flag on Dispose to explicitly forbid re-opening.
– Common Man
Jan 3 at 4:43
You really shouldn't keep a file open like that throughout the lifetime of your app. You should do it something like this for a once of write:using (TextWriter textWriter = File.AppendText(@"...txt")) TextWriterLogger(textWriter);. If you're in a method that is writing many lines then keep the writer open for the duration of the method, but be careful of re-entrancy issues.
– Enigmativity
Jan 3 at 4:52
The issue is, my code is not controlling when a log is written to the file so it's hard to wrap in a using statement. I am using TheGeneral's approach of just auto flushing. Is there anyway I can automatically dispose then instantiate once text has completed being written.
– Harry Stuart
Jan 3 at 4:56
add a comment |
I am trying to use a text writer to write text to a file in .NET Core. The below code doesn't output anything to the file:
TextWriter writer = File.CreateText(@"...txt");
writer.Write("Hello World");
However, this does:
TextWriter writer = File.CreateText(@"...txt");
writer.Write("Hello World");
writer.Dispose();
Why is that? What does that extra line tell the program to do differently? I don't want to close the TextWriter because it is going to be writing logs, which are running constantly and indefinitely whilst my application is running.
How can I keep it open until the application stops running?
UPDATE
So the reason I want to do this, is I am using an SDK that writes its logs to a TextWriter:
TextWriterLogger(textWriter);
//Creates a logger that writes to a TextWriter. User is responsible for providing an instance of TextWriter that is thread safe.
But if I just enclose this in a using statement, logs won't be written because by the time they are ready to be written, the using statement will have executed and the TextWriter disposed.
Thanks
c# file dispose textwriter
asked Jan 3 at 4:36
Harry StuartHarry Stuart
392313
I am trying to use a text writer to write text to a file in .NET Core. The below code doesn't output anything to the file:
TextWriter writer = File.CreateText(@"...txt");
writer.Write("Hello World");
However, this does:
TextWriter writer = File.CreateText(@"...txt");
writer.Write("Hello World");
writer.Dispose();
Why is that? What does that extra line tell the program to do differently? I don't want to close the TextWriter because it is going to be writing logs, which are running constantly and indefinitely whilst my application is running.
How can I keep it open until the application stops running?
UPDATE
So the reason I want to do this, is I am using an SDK that writes its logs to a TextWriter:
TextWriterLogger(textWriter);
//Creates a logger that writes to a TextWriter. User is responsible for providing an instance of TextWriter that is thread safe.
But if I just enclose this in a using statement, logs won't be written because by the time they are ready to be written, the using statement will have executed and the TextWriter disposed.
Thanks
c# file dispose textwriter
c# file dispose textwriter
asked Jan 3 at 4:36
Harry StuartHarry Stuart
392313
asked Jan 3 at 4:36
Harry StuartHarry Stuart
392313
edited Jan 3 at 4:45
Harry Stuart
asked Jan 3 at 4:36
Harry StuartHarry Stuart
392313
asked Jan 3 at 4:36
Harry StuartHarry Stuart
392313
asked Jan 3 at 4:36
Harry StuartHarry Stuart
392313
392313
1
normally we open the file write and dispose and then reopen next time
– Ehsan Sajjad
Jan 3 at 4:38
On some classes, however, it is possible to re-open an object which has been Close'd. Some such classes may keep some resources alive after a Close, in order to permit reopening; others may not keep any resources alive on Close, but might set a flag on Dispose to explicitly forbid re-opening.
– Common Man
Jan 3 at 4:43
You really shouldn't keep a file open like that throughout the lifetime of your app. You should do it something like this for a once of write:using (TextWriter textWriter = File.AppendText(@"...txt")) TextWriterLogger(textWriter);. If you're in a method that is writing many lines then keep the writer open for the duration of the method, but be careful of re-entrancy issues.
– Enigmativity
Jan 3 at 4:52
The issue is, my code is not controlling when a log is written to the file so it's hard to wrap in a using statement. I am using TheGeneral's approach of just auto flushing. Is there anyway I can automatically dispose then instantiate once text has completed being written.
– Harry Stuart
Jan 3 at 4:56
add a comment |
1
normally we open the file write and dispose and then reopen next time
– Ehsan Sajjad
Jan 3 at 4:38
On some classes, however, it is possible to re-open an object which has been Close'd. Some such classes may keep some resources alive after a Close, in order to permit reopening; others may not keep any resources alive on Close, but might set a flag on Dispose to explicitly forbid re-opening.
– Common Man
Jan 3 at 4:43
You really shouldn't keep a file open like that throughout the lifetime of your app. You should do it something like this for a once of write:using (TextWriter textWriter = File.AppendText(@"...txt")) TextWriterLogger(textWriter);. If you're in a method that is writing many lines then keep the writer open for the duration of the method, but be careful of re-entrancy issues.
– Enigmativity
Jan 3 at 4:52
The issue is, my code is not controlling when a log is written to the file so it's hard to wrap in a using statement. I am using TheGeneral's approach of just auto flushing. Is there anyway I can automatically dispose then instantiate once text has completed being written.
– Harry Stuart
Jan 3 at 4:56
1
1
normally we open the file write and dispose and then reopen next time
– Ehsan Sajjad
Jan 3 at 4:38
normally we open the file write and dispose and then reopen next time
– Ehsan Sajjad
Jan 3 at 4:38
On some classes, however, it is possible to re-open an object which has been Close'd. Some such classes may keep some resources alive after a Close, in order to permit reopening; others may not keep any resources alive on Close, but might set a flag on Dispose to explicitly forbid re-opening.
– Common Man
Jan 3 at 4:43
On some classes, however, it is possible to re-open an object which has been Close'd. Some such classes may keep some resources alive after a Close, in order to permit reopening; others may not keep any resources alive on Close, but might set a flag on Dispose to explicitly forbid re-opening.
– Common Man
Jan 3 at 4:43
You really shouldn't keep a file open like that throughout the lifetime of your app. You should do it something like this for a once of write:
using (TextWriter textWriter = File.AppendText(@"...txt")) TextWriterLogger(textWriter);. If you're in a method that is writing many lines then keep the writer open for the duration of the method, but be careful of re-entrancy issues.– Enigmativity
Jan 3 at 4:52
You really shouldn't keep a file open like that throughout the lifetime of your app. You should do it something like this for a once of write:
using (TextWriter textWriter = File.AppendText(@"...txt")) TextWriterLogger(textWriter);. If you're in a method that is writing many lines then keep the writer open for the duration of the method, but be careful of re-entrancy issues.– Enigmativity
Jan 3 at 4:52
The issue is, my code is not controlling when a log is written to the file so it's hard to wrap in a using statement. I am using TheGeneral's approach of just auto flushing. Is there anyway I can automatically dispose then instantiate once text has completed being written.
– Harry Stuart
Jan 3 at 4:56
The issue is, my code is not controlling when a log is written to the file so it's hard to wrap in a using statement. I am using TheGeneral's approach of just auto flushing. Is there anyway I can automatically dispose then instantiate once text has completed being written.
– Harry Stuart
Jan 3 at 4:56
add a comment |
1 Answer
1
active
oldest
votes
Dispose calls Flush, which writes the internal bytes stored in a buffer to disk
Without closing or disposing a file, you are leaving unmanaged resources around and will potentially lock the file, not to mention memory leaks. Instead always use a using statement
using (TextWriter writer = File.CreateText(@"...txt"))
{
writer.Write("Hello World");
}
However if you want to continually write to the file, you will have to flush it
FileStream.Flush Method
Clears buffers for this stream and causes any buffered data to be
written to the file.
TextWriter writer = File.CreateText(@"...txt");
...
writer.Write("Hello World");
...
writer.Flush(); // at this point the bytes are flushed to disk
...
...
writer.Dispose();
In short most streams are backed by an internal array (buffer), so you dont thrash writes. The Default size is 4k, when it hits the buffer size then it automatically flushes. If you want to see immediate writes, the you have to flush it every time
Lastly some streams have an auto flush feature, which can do this job for you
AutoFlush
Gets or sets a value indicating whether the StreamWriter will flush
its buffer to the underlying stream after every call to Write(Char)
When you are finished with the stream always dispose it
answered Jan 3 at 4:38
Michael RandallMichael Randall
37.1k84171
But the OP is wanting to continually write to the same file while the app is open.
– Enigmativity
Jan 3 at 4:39
@Enigmativity oh good point
– Michael Randall
Jan 3 at 4:39
Very very nice explanation, thank you! I am usingStreamWriterinstead to auto flush which is helpful. I have more ignorance than I thought!
– Harry Stuart
Jan 3 at 4:53
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54016413%2fwhen-to-call-file-dispose%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
Dispose calls Flush, which writes the internal bytes stored in a buffer to disk
Without closing or disposing a file, you are leaving unmanaged resources around and will potentially lock the file, not to mention memory leaks. Instead always use a using statement
using (TextWriter writer = File.CreateText(@"...txt"))
{
writer.Write("Hello World");
}
However if you want to continually write to the file, you will have to flush it
FileStream.Flush Method
Clears buffers for this stream and causes any buffered data to be
written to the file.
TextWriter writer = File.CreateText(@"...txt");
...
writer.Write("Hello World");
...
writer.Flush(); // at this point the bytes are flushed to disk
...
...
writer.Dispose();
In short most streams are backed by an internal array (buffer), so you dont thrash writes. The Default size is 4k, when it hits the buffer size then it automatically flushes. If you want to see immediate writes, the you have to flush it every time
Lastly some streams have an auto flush feature, which can do this job for you
AutoFlush
Gets or sets a value indicating whether the StreamWriter will flush
its buffer to the underlying stream after every call to Write(Char)
When you are finished with the stream always dispose it
answered Jan 3 at 4:38
Michael RandallMichael Randall
37.1k84171
But the OP is wanting to continually write to the same file while the app is open.
– Enigmativity
Jan 3 at 4:39
@Enigmativity oh good point
– Michael Randall
Jan 3 at 4:39
Very very nice explanation, thank you! I am usingStreamWriterinstead to auto flush which is helpful. I have more ignorance than I thought!
– Harry Stuart
Jan 3 at 4:53
add a comment |
Dispose calls Flush, which writes the internal bytes stored in a buffer to disk
Without closing or disposing a file, you are leaving unmanaged resources around and will potentially lock the file, not to mention memory leaks. Instead always use a using statement
using (TextWriter writer = File.CreateText(@"...txt"))
{
writer.Write("Hello World");
}
However if you want to continually write to the file, you will have to flush it
FileStream.Flush Method
Clears buffers for this stream and causes any buffered data to be
written to the file.
TextWriter writer = File.CreateText(@"...txt");
...
writer.Write("Hello World");
...
writer.Flush(); // at this point the bytes are flushed to disk
...
...
writer.Dispose();
In short most streams are backed by an internal array (buffer), so you dont thrash writes. The Default size is 4k, when it hits the buffer size then it automatically flushes. If you want to see immediate writes, the you have to flush it every time
Lastly some streams have an auto flush feature, which can do this job for you
AutoFlush
Gets or sets a value indicating whether the StreamWriter will flush
its buffer to the underlying stream after every call to Write(Char)
When you are finished with the stream always dispose it
answered Jan 3 at 4:38
Michael RandallMichael Randall
37.1k84171
But the OP is wanting to continually write to the same file while the app is open.
– Enigmativity
Jan 3 at 4:39
@Enigmativity oh good point
– Michael Randall
Jan 3 at 4:39
Very very nice explanation, thank you! I am usingStreamWriterinstead to auto flush which is helpful. I have more ignorance than I thought!
– Harry Stuart
Jan 3 at 4:53
add a comment |
Dispose calls Flush, which writes the internal bytes stored in a buffer to disk
Without closing or disposing a file, you are leaving unmanaged resources around and will potentially lock the file, not to mention memory leaks. Instead always use a using statement
using (TextWriter writer = File.CreateText(@"...txt"))
{
writer.Write("Hello World");
}
However if you want to continually write to the file, you will have to flush it
FileStream.Flush Method
Clears buffers for this stream and causes any buffered data to be
written to the file.
TextWriter writer = File.CreateText(@"...txt");
...
writer.Write("Hello World");
...
writer.Flush(); // at this point the bytes are flushed to disk
...
...
writer.Dispose();
In short most streams are backed by an internal array (buffer), so you dont thrash writes. The Default size is 4k, when it hits the buffer size then it automatically flushes. If you want to see immediate writes, the you have to flush it every time
Lastly some streams have an auto flush feature, which can do this job for you
AutoFlush
Gets or sets a value indicating whether the StreamWriter will flush
its buffer to the underlying stream after every call to Write(Char)
When you are finished with the stream always dispose it
answered Jan 3 at 4:38
Michael RandallMichael Randall
37.1k84171
Dispose calls Flush, which writes the internal bytes stored in a buffer to disk
Without closing or disposing a file, you are leaving unmanaged resources around and will potentially lock the file, not to mention memory leaks. Instead always use a using statement
using (TextWriter writer = File.CreateText(@"...txt"))
{
writer.Write("Hello World");
}
However if you want to continually write to the file, you will have to flush it
FileStream.Flush Method
Clears buffers for this stream and causes any buffered data to be
written to the file.
TextWriter writer = File.CreateText(@"...txt");
...
writer.Write("Hello World");
...
writer.Flush(); // at this point the bytes are flushed to disk
...
...
writer.Dispose();
In short most streams are backed by an internal array (buffer), so you dont thrash writes. The Default size is 4k, when it hits the buffer size then it automatically flushes. If you want to see immediate writes, the you have to flush it every time
Lastly some streams have an auto flush feature, which can do this job for you
AutoFlush
Gets or sets a value indicating whether the StreamWriter will flush
its buffer to the underlying stream after every call to Write(Char)
When you are finished with the stream always dispose it
answered Jan 3 at 4:38
Michael RandallMichael Randall
37.1k84171
edited Jan 3 at 4:45
answered Jan 3 at 4:38
Michael RandallMichael Randall
37.1k84171
answered Jan 3 at 4:38
Michael RandallMichael Randall
37.1k84171
answered Jan 3 at 4:38
Michael RandallMichael Randall
37.1k84171
37.1k84171
But the OP is wanting to continually write to the same file while the app is open.
– Enigmativity
Jan 3 at 4:39
@Enigmativity oh good point
– Michael Randall
Jan 3 at 4:39
Very very nice explanation, thank you! I am usingStreamWriterinstead to auto flush which is helpful. I have more ignorance than I thought!
– Harry Stuart
Jan 3 at 4:53
add a comment |
But the OP is wanting to continually write to the same file while the app is open.
– Enigmativity
Jan 3 at 4:39
@Enigmativity oh good point
– Michael Randall
Jan 3 at 4:39
Very very nice explanation, thank you! I am usingStreamWriterinstead to auto flush which is helpful. I have more ignorance than I thought!
– Harry Stuart
Jan 3 at 4:53
But the OP is wanting to continually write to the same file while the app is open.
– Enigmativity
Jan 3 at 4:39
But the OP is wanting to continually write to the same file while the app is open.
– Enigmativity
Jan 3 at 4:39
@Enigmativity oh good point
– Michael Randall
Jan 3 at 4:39
@Enigmativity oh good point
– Michael Randall
Jan 3 at 4:39
Very very nice explanation, thank you! I am using
StreamWriter instead to auto flush which is helpful. I have more ignorance than I thought!– Harry Stuart
Jan 3 at 4:53
Very very nice explanation, thank you! I am using
StreamWriter instead to auto flush which is helpful. I have more ignorance than I thought!– Harry Stuart
Jan 3 at 4:53
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54016413%2fwhen-to-call-file-dispose%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
normally we open the file write and dispose and then reopen next time
– Ehsan Sajjad
Jan 3 at 4:38
On some classes, however, it is possible to re-open an object which has been Close'd. Some such classes may keep some resources alive after a Close, in order to permit reopening; others may not keep any resources alive on Close, but might set a flag on Dispose to explicitly forbid re-opening.
– Common Man
Jan 3 at 4:43
You really shouldn't keep a file open like that throughout the lifetime of your app. You should do it something like this for a once of write:
using (TextWriter textWriter = File.AppendText(@"...txt")) TextWriterLogger(textWriter);. If you're in a method that is writing many lines then keep the writer open for the duration of the method, but be careful of re-entrancy issues.– Enigmativity
Jan 3 at 4:52
The issue is, my code is not controlling when a log is written to the file so it's hard to wrap in a using statement. I am using TheGeneral's approach of just auto flushing. Is there anyway I can automatically dispose then instantiate once text has completed being written.
– Harry Stuart
Jan 3 at 4:56