Mixing
Protect pages by raising 404
I am learning Django, and I want to protect certain pages by raising 404 if request is not from certain login user.
I already foreginkey topic to user. Here is the code to protect topic page.
@login_required
def topic(request, topic_id):
topic = Topic.objects.get(id=topic_id)
if topic.owner != request.user:
raise Http404
I wonder are there better ways if I want to protect a lot of pages so I don't have to add the same code in every function?
python django
asked Jan 2 at 0:11
Lee RogerLee Roger
196
add a comment |
I am learning Django, and I want to protect certain pages by raising 404 if request is not from certain login user.
I already foreginkey topic to user. Here is the code to protect topic page.
@login_required
def topic(request, topic_id):
topic = Topic.objects.get(id=topic_id)
if topic.owner != request.user:
raise Http404
I wonder are there better ways if I want to protect a lot of pages so I don't have to add the same code in every function?
python django
asked Jan 2 at 0:11
Lee RogerLee Roger
196
403 would be more appropriate than 404.
– Daniel Roseman
Jan 2 at 0:48
1
@DanielRoseman 404 is perfectly valid if you don't want to indicate the existence of records with these ids in the database.
– Norrius
Jan 2 at 1:39
add a comment |
I am learning Django, and I want to protect certain pages by raising 404 if request is not from certain login user.
I already foreginkey topic to user. Here is the code to protect topic page.
@login_required
def topic(request, topic_id):
topic = Topic.objects.get(id=topic_id)
if topic.owner != request.user:
raise Http404
I wonder are there better ways if I want to protect a lot of pages so I don't have to add the same code in every function?
python django
asked Jan 2 at 0:11
Lee RogerLee Roger
196
I am learning Django, and I want to protect certain pages by raising 404 if request is not from certain login user.
I already foreginkey topic to user. Here is the code to protect topic page.
@login_required
def topic(request, topic_id):
topic = Topic.objects.get(id=topic_id)
if topic.owner != request.user:
raise Http404
I wonder are there better ways if I want to protect a lot of pages so I don't have to add the same code in every function?
python django
python django
asked Jan 2 at 0:11
Lee RogerLee Roger
196
asked Jan 2 at 0:11
Lee RogerLee Roger
196
asked Jan 2 at 0:11
Lee RogerLee Roger
196
asked Jan 2 at 0:11
Lee RogerLee Roger
196
asked Jan 2 at 0:11
Lee RogerLee Roger
196
196
403 would be more appropriate than 404.
– Daniel Roseman
Jan 2 at 0:48
1
@DanielRoseman 404 is perfectly valid if you don't want to indicate the existence of records with these ids in the database.
– Norrius
Jan 2 at 1:39
add a comment |
403 would be more appropriate than 404.
– Daniel Roseman
Jan 2 at 0:48
1
@DanielRoseman 404 is perfectly valid if you don't want to indicate the existence of records with these ids in the database.
– Norrius
Jan 2 at 1:39
403 would be more appropriate than 404.
– Daniel Roseman
Jan 2 at 0:48
403 would be more appropriate than 404.
– Daniel Roseman
Jan 2 at 0:48
1
1
@DanielRoseman 404 is perfectly valid if you don't want to indicate the existence of records with these ids in the database.
– Norrius
Jan 2 at 1:39
@DanielRoseman 404 is perfectly valid if you don't want to indicate the existence of records with these ids in the database.
– Norrius
Jan 2 at 1:39
add a comment |
1 Answer
1
active
oldest
votes
If you definitely want to raise 404, a quicker method would be to make the user check part of the query itself - then your can use the get_object_or_404 shortcut:
topic = get_object_or_404(Topic, id=topic_id, owner=request.uset)
answered Jan 2 at 1:45
Daniel RosemanDaniel Roseman
455k41591648
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53999955%2fprotect-pages-by-raising-404%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
If you definitely want to raise 404, a quicker method would be to make the user check part of the query itself - then your can use the get_object_or_404 shortcut:
topic = get_object_or_404(Topic, id=topic_id, owner=request.uset)
answered Jan 2 at 1:45
Daniel RosemanDaniel Roseman
455k41591648
add a comment |
If you definitely want to raise 404, a quicker method would be to make the user check part of the query itself - then your can use the get_object_or_404 shortcut:
topic = get_object_or_404(Topic, id=topic_id, owner=request.uset)
answered Jan 2 at 1:45
Daniel RosemanDaniel Roseman
455k41591648
add a comment |
If you definitely want to raise 404, a quicker method would be to make the user check part of the query itself - then your can use the get_object_or_404 shortcut:
topic = get_object_or_404(Topic, id=topic_id, owner=request.uset)
answered Jan 2 at 1:45
Daniel RosemanDaniel Roseman
455k41591648
If you definitely want to raise 404, a quicker method would be to make the user check part of the query itself - then your can use the get_object_or_404 shortcut:
topic = get_object_or_404(Topic, id=topic_id, owner=request.uset)
answered Jan 2 at 1:45
Daniel RosemanDaniel Roseman
455k41591648
answered Jan 2 at 1:45
Daniel RosemanDaniel Roseman
455k41591648
answered Jan 2 at 1:45
Daniel RosemanDaniel Roseman
455k41591648
answered Jan 2 at 1:45
Daniel RosemanDaniel Roseman
455k41591648
455k41591648
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53999955%2fprotect-pages-by-raising-404%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
403 would be more appropriate than 404.
– Daniel Roseman
Jan 2 at 0:48
1
@DanielRoseman 404 is perfectly valid if you don't want to indicate the existence of records with these ids in the database.
– Norrius
Jan 2 at 1:39