PCF Integration for actuator with custom context path
Really struggling here.
We are running some Spring Boot services (1.5.x) on PCF. now I try to get the PCF integration working via actuator.
This is giving me more trouble than I was expecting. The issue is that a lot of our services are having a custom server.contextPath
(e.g. /api/vX). By this design we now also have the /cloudfoundryapplication endpoint on this contextPath (so sadly PCF can not find it).
I already found the issue in the Spring Boot Repository.
Here is the link to the issue describing it and providing a fix https://github.com/spring-projects/spring-boot/issues/9081.
@Bean
public TomcatEmbeddedServletContainerFactory servletContainerFactory() {
return new TomcatEmbeddedServletContainerFactory() {
protected void prepareContext(Host host, ServletContextInitializer initializers) {
super.prepareContext(host, initializers);
StandardContext child = new StandardContext();
child.addLifecycleListener(new FixContextListener());
child.setPath("/cloudfoundryapplication");
ServletContainerInitializer initializer = ActuatorConfig.this.getServletContextInitializer(this.getContextPath());
child.addServletContainerInitializer(initializer, Collections.emptySet());
child.setCrossContext(true);
host.addChild(child);
}
};
}
private ServletContainerInitializer getServletContextInitializer(String contextPath) {
return (c, context) -> {
Servlet servlet = new GenericServlet() {
public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
ServletContext context = req.getServletContext().getContext(contextPath);
context.getRequestDispatcher("/cloudfoundryapplication").forward(req, res);
}
};
context.addServlet("cloudfoundry", servlet).addMapping(new String{"/*"});
};
}
I tried it - and well, it just works.
My problem now is, when I create this Bean, my RestControllers accessing HttpServletResponse behave differently. One of the cases which was directly caught by our Integration-Test was that we can not set e.g. the contentType via setter any more.
e.g.
public ResponseEntity<byte> getSomeImage(HttpServletResponse response, ..){
... getData
response.setContentType("image/png");
return ResponseEntity.ok().body(bytes);
}
is getting ignored: The error in the IntegrationTest is
Expected content-type "image/png" doesn't match actual content-type "application/octet-stream;charset=UTF-8".
Without the bean it works just like before.
spring spring-mvc spring-boot spring-boot-actuator
add a comment |
Really struggling here.
We are running some Spring Boot services (1.5.x) on PCF. now I try to get the PCF integration working via actuator.
This is giving me more trouble than I was expecting. The issue is that a lot of our services are having a custom server.contextPath
(e.g. /api/vX). By this design we now also have the /cloudfoundryapplication endpoint on this contextPath (so sadly PCF can not find it).
I already found the issue in the Spring Boot Repository.
Here is the link to the issue describing it and providing a fix https://github.com/spring-projects/spring-boot/issues/9081.
@Bean
public TomcatEmbeddedServletContainerFactory servletContainerFactory() {
return new TomcatEmbeddedServletContainerFactory() {
protected void prepareContext(Host host, ServletContextInitializer initializers) {
super.prepareContext(host, initializers);
StandardContext child = new StandardContext();
child.addLifecycleListener(new FixContextListener());
child.setPath("/cloudfoundryapplication");
ServletContainerInitializer initializer = ActuatorConfig.this.getServletContextInitializer(this.getContextPath());
child.addServletContainerInitializer(initializer, Collections.emptySet());
child.setCrossContext(true);
host.addChild(child);
}
};
}
private ServletContainerInitializer getServletContextInitializer(String contextPath) {
return (c, context) -> {
Servlet servlet = new GenericServlet() {
public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
ServletContext context = req.getServletContext().getContext(contextPath);
context.getRequestDispatcher("/cloudfoundryapplication").forward(req, res);
}
};
context.addServlet("cloudfoundry", servlet).addMapping(new String{"/*"});
};
}
I tried it - and well, it just works.
My problem now is, when I create this Bean, my RestControllers accessing HttpServletResponse behave differently. One of the cases which was directly caught by our Integration-Test was that we can not set e.g. the contentType via setter any more.
e.g.
public ResponseEntity<byte> getSomeImage(HttpServletResponse response, ..){
... getData
response.setContentType("image/png");
return ResponseEntity.ok().body(bytes);
}
is getting ignored: The error in the IntegrationTest is
Expected content-type "image/png" doesn't match actual content-type "application/octet-stream;charset=UTF-8".
Without the bean it works just like before.
spring spring-mvc spring-boot spring-boot-actuator
add a comment |
Really struggling here.
We are running some Spring Boot services (1.5.x) on PCF. now I try to get the PCF integration working via actuator.
This is giving me more trouble than I was expecting. The issue is that a lot of our services are having a custom server.contextPath
(e.g. /api/vX). By this design we now also have the /cloudfoundryapplication endpoint on this contextPath (so sadly PCF can not find it).
I already found the issue in the Spring Boot Repository.
Here is the link to the issue describing it and providing a fix https://github.com/spring-projects/spring-boot/issues/9081.
@Bean
public TomcatEmbeddedServletContainerFactory servletContainerFactory() {
return new TomcatEmbeddedServletContainerFactory() {
protected void prepareContext(Host host, ServletContextInitializer initializers) {
super.prepareContext(host, initializers);
StandardContext child = new StandardContext();
child.addLifecycleListener(new FixContextListener());
child.setPath("/cloudfoundryapplication");
ServletContainerInitializer initializer = ActuatorConfig.this.getServletContextInitializer(this.getContextPath());
child.addServletContainerInitializer(initializer, Collections.emptySet());
child.setCrossContext(true);
host.addChild(child);
}
};
}
private ServletContainerInitializer getServletContextInitializer(String contextPath) {
return (c, context) -> {
Servlet servlet = new GenericServlet() {
public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
ServletContext context = req.getServletContext().getContext(contextPath);
context.getRequestDispatcher("/cloudfoundryapplication").forward(req, res);
}
};
context.addServlet("cloudfoundry", servlet).addMapping(new String{"/*"});
};
}
I tried it - and well, it just works.
My problem now is, when I create this Bean, my RestControllers accessing HttpServletResponse behave differently. One of the cases which was directly caught by our Integration-Test was that we can not set e.g. the contentType via setter any more.
e.g.
public ResponseEntity<byte> getSomeImage(HttpServletResponse response, ..){
... getData
response.setContentType("image/png");
return ResponseEntity.ok().body(bytes);
}
is getting ignored: The error in the IntegrationTest is
Expected content-type "image/png" doesn't match actual content-type "application/octet-stream;charset=UTF-8".
Without the bean it works just like before.
spring spring-mvc spring-boot spring-boot-actuator
Really struggling here.
We are running some Spring Boot services (1.5.x) on PCF. now I try to get the PCF integration working via actuator.
This is giving me more trouble than I was expecting. The issue is that a lot of our services are having a custom server.contextPath
(e.g. /api/vX). By this design we now also have the /cloudfoundryapplication endpoint on this contextPath (so sadly PCF can not find it).
I already found the issue in the Spring Boot Repository.
Here is the link to the issue describing it and providing a fix https://github.com/spring-projects/spring-boot/issues/9081.
@Bean
public TomcatEmbeddedServletContainerFactory servletContainerFactory() {
return new TomcatEmbeddedServletContainerFactory() {
protected void prepareContext(Host host, ServletContextInitializer initializers) {
super.prepareContext(host, initializers);
StandardContext child = new StandardContext();
child.addLifecycleListener(new FixContextListener());
child.setPath("/cloudfoundryapplication");
ServletContainerInitializer initializer = ActuatorConfig.this.getServletContextInitializer(this.getContextPath());
child.addServletContainerInitializer(initializer, Collections.emptySet());
child.setCrossContext(true);
host.addChild(child);
}
};
}
private ServletContainerInitializer getServletContextInitializer(String contextPath) {
return (c, context) -> {
Servlet servlet = new GenericServlet() {
public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
ServletContext context = req.getServletContext().getContext(contextPath);
context.getRequestDispatcher("/cloudfoundryapplication").forward(req, res);
}
};
context.addServlet("cloudfoundry", servlet).addMapping(new String{"/*"});
};
}
I tried it - and well, it just works.
My problem now is, when I create this Bean, my RestControllers accessing HttpServletResponse behave differently. One of the cases which was directly caught by our Integration-Test was that we can not set e.g. the contentType via setter any more.
e.g.
public ResponseEntity<byte> getSomeImage(HttpServletResponse response, ..){
... getData
response.setContentType("image/png");
return ResponseEntity.ok().body(bytes);
}
is getting ignored: The error in the IntegrationTest is
Expected content-type "image/png" doesn't match actual content-type "application/octet-stream;charset=UTF-8".
Without the bean it works just like before.
spring spring-mvc spring-boot spring-boot-actuator
spring spring-mvc spring-boot spring-boot-actuator
asked Nov 20 '18 at 18:42
eiselemseiselems
8010
8010
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53399500%2fpcf-integration-for-actuator-with-custom-context-path%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53399500%2fpcf-integration-for-actuator-with-custom-context-path%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown