Mixing
A little problem with a program that has an array and two functions is random but it shouldnt be
-3
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i <= sal; i++) {
if (sal%i == 0)
return true;
else
return false;
}
}
int lkd(int a, int b) // Checks the gcd
{
int c;
while (b > 0)
{
c = b;
b = a % b;
a = c;
}
return a;
}
int main()
{
int ok;
do
{
int n;//Number of elements
int*a; //Given number array variable
cout << "Put in the number of elements" << endl;
std::cin >> n;
a = new int[n];
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a;
}
int rez = a[0];
for (int i = 1; i < n; i++) {
if (sal_sk(a[i] == true))
rez = lkd(rez, a[i]);
}
delete a;
cout << "Composite figure gcd is " << rez << endl;
cout << " Do you want to continue(1) or to end (0)?" << endl;
cin >> ok;// Asks the user to enter in if he wants to continue or to end
} while (ok == 1);
}
Hey guys, I have two functions that check the greatest common divisor of composite figures in an array but it is random and idk why.
For Example if I enter 3 elements 4 6 9 it sometimes prints out that the gcd is 3 but sometimes it prints out that it is 1 which is correct but it happens at random times,and if I enter 9 4 6 it says that the gcd is 2, i just dont understand.Thanks in advance
c++ arrays function
edited Nov 21 '18 at 14:21
JeJo
4,3473725
asked Nov 21 '18 at 14:16
MrLucky2243MrLucky2243
215
|
show 1 more comment
-3
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i <= sal; i++) {
if (sal%i == 0)
return true;
else
return false;
}
}
int lkd(int a, int b) // Checks the gcd
{
int c;
while (b > 0)
{
c = b;
b = a % b;
a = c;
}
return a;
}
int main()
{
int ok;
do
{
int n;//Number of elements
int*a; //Given number array variable
cout << "Put in the number of elements" << endl;
std::cin >> n;
a = new int[n];
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a;
}
int rez = a[0];
for (int i = 1; i < n; i++) {
if (sal_sk(a[i] == true))
rez = lkd(rez, a[i]);
}
delete a;
cout << "Composite figure gcd is " << rez << endl;
cout << " Do you want to continue(1) or to end (0)?" << endl;
cin >> ok;// Asks the user to enter in if he wants to continue or to end
} while (ok == 1);
}
Hey guys, I have two functions that check the greatest common divisor of composite figures in an array but it is random and idk why.
For Example if I enter 3 elements 4 6 9 it sometimes prints out that the gcd is 3 but sometimes it prints out that it is 1 which is correct but it happens at random times,and if I enter 9 4 6 it says that the gcd is 2, i just dont understand.Thanks in advance
c++ arrays function
edited Nov 21 '18 at 14:21
JeJo
4,3473725
asked Nov 21 '18 at 14:16
MrLucky2243MrLucky2243
215
1
There isn't really a point to having aforloop that alwaysreturns on the first iteration. What did you intend for that function to actually do? You probably don't want to necessarily return on the first iteration.
– François Andrieux
Nov 21 '18 at 14:42
bool sal_sk(int sal)returns true if sal is even false if it is not. It does not for the reason @FrançoisAndrieux mentioned. You probably want to move the return false out of the loop and change thefor (int i = 2; i <= sal; i++) {tofor (int i = 2; i < sal; i++) {
– drescherjm
Nov 21 '18 at 14:52
Hey that function is intented to return true when the number is composite and false when it is not, I dont understand why it is always true tho :/
– MrLucky2243
Nov 21 '18 at 14:56
Okay that seems to helped a bit, could you check thelkdfunction because for example when I enter 17 2 4 it should return that gcd is 2 but it returns 1
– MrLucky2243
Nov 21 '18 at 15:00
Thank you! seriously!
– MrLucky2243
Nov 21 '18 at 15:11
|
show 1 more comment
-3
-3
-3
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i <= sal; i++) {
if (sal%i == 0)
return true;
else
return false;
}
}
int lkd(int a, int b) // Checks the gcd
{
int c;
while (b > 0)
{
c = b;
b = a % b;
a = c;
}
return a;
}
int main()
{
int ok;
do
{
int n;//Number of elements
int*a; //Given number array variable
cout << "Put in the number of elements" << endl;
std::cin >> n;
a = new int[n];
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a;
}
int rez = a[0];
for (int i = 1; i < n; i++) {
if (sal_sk(a[i] == true))
rez = lkd(rez, a[i]);
}
delete a;
cout << "Composite figure gcd is " << rez << endl;
cout << " Do you want to continue(1) or to end (0)?" << endl;
cin >> ok;// Asks the user to enter in if he wants to continue or to end
} while (ok == 1);
}
Hey guys, I have two functions that check the greatest common divisor of composite figures in an array but it is random and idk why.
For Example if I enter 3 elements 4 6 9 it sometimes prints out that the gcd is 3 but sometimes it prints out that it is 1 which is correct but it happens at random times,and if I enter 9 4 6 it says that the gcd is 2, i just dont understand.Thanks in advance
c++ arrays function
edited Nov 21 '18 at 14:21
JeJo
4,3473725
asked Nov 21 '18 at 14:16
MrLucky2243MrLucky2243
215
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i <= sal; i++) {
if (sal%i == 0)
return true;
else
return false;
}
}
int lkd(int a, int b) // Checks the gcd
{
int c;
while (b > 0)
{
c = b;
b = a % b;
a = c;
}
return a;
}
int main()
{
int ok;
do
{
int n;//Number of elements
int*a; //Given number array variable
cout << "Put in the number of elements" << endl;
std::cin >> n;
a = new int[n];
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a;
}
int rez = a[0];
for (int i = 1; i < n; i++) {
if (sal_sk(a[i] == true))
rez = lkd(rez, a[i]);
}
delete a;
cout << "Composite figure gcd is " << rez << endl;
cout << " Do you want to continue(1) or to end (0)?" << endl;
cin >> ok;// Asks the user to enter in if he wants to continue or to end
} while (ok == 1);
}
Hey guys, I have two functions that check the greatest common divisor of composite figures in an array but it is random and idk why.
For Example if I enter 3 elements 4 6 9 it sometimes prints out that the gcd is 3 but sometimes it prints out that it is 1 which is correct but it happens at random times,and if I enter 9 4 6 it says that the gcd is 2, i just dont understand.Thanks in advance
c++ arrays function
c++ arrays function
edited Nov 21 '18 at 14:21
JeJo
4,3473725
asked Nov 21 '18 at 14:16
MrLucky2243MrLucky2243
215
edited Nov 21 '18 at 14:21
JeJo
4,3473725
asked Nov 21 '18 at 14:16
MrLucky2243MrLucky2243
215
edited Nov 21 '18 at 14:21
JeJo
4,3473725
edited Nov 21 '18 at 14:21
JeJo
4,3473725
edited Nov 21 '18 at 14:21
JeJo
4,3473725
4,3473725
asked Nov 21 '18 at 14:16
MrLucky2243MrLucky2243
215
asked Nov 21 '18 at 14:16
MrLucky2243MrLucky2243
215
asked Nov 21 '18 at 14:16
MrLucky2243MrLucky2243
215
215
1
There isn't really a point to having aforloop that alwaysreturns on the first iteration. What did you intend for that function to actually do? You probably don't want to necessarily return on the first iteration.
– François Andrieux
Nov 21 '18 at 14:42
bool sal_sk(int sal)returns true if sal is even false if it is not. It does not for the reason @FrançoisAndrieux mentioned. You probably want to move the return false out of the loop and change thefor (int i = 2; i <= sal; i++) {tofor (int i = 2; i < sal; i++) {
– drescherjm
Nov 21 '18 at 14:52
Hey that function is intented to return true when the number is composite and false when it is not, I dont understand why it is always true tho :/
– MrLucky2243
Nov 21 '18 at 14:56
Okay that seems to helped a bit, could you check thelkdfunction because for example when I enter 17 2 4 it should return that gcd is 2 but it returns 1
– MrLucky2243
Nov 21 '18 at 15:00
Thank you! seriously!
– MrLucky2243
Nov 21 '18 at 15:11
|
show 1 more comment
1
There isn't really a point to having aforloop that alwaysreturns on the first iteration. What did you intend for that function to actually do? You probably don't want to necessarily return on the first iteration.
– François Andrieux
Nov 21 '18 at 14:42
bool sal_sk(int sal)returns true if sal is even false if it is not. It does not for the reason @FrançoisAndrieux mentioned. You probably want to move the return false out of the loop and change thefor (int i = 2; i <= sal; i++) {tofor (int i = 2; i < sal; i++) {
– drescherjm
Nov 21 '18 at 14:52
Hey that function is intented to return true when the number is composite and false when it is not, I dont understand why it is always true tho :/
– MrLucky2243
Nov 21 '18 at 14:56
Okay that seems to helped a bit, could you check thelkdfunction because for example when I enter 17 2 4 it should return that gcd is 2 but it returns 1
– MrLucky2243
Nov 21 '18 at 15:00
Thank you! seriously!
– MrLucky2243
Nov 21 '18 at 15:11
1
1
There isn't really a point to having a
for loop that always returns on the first iteration. What did you intend for that function to actually do? You probably don't want to necessarily return on the first iteration.– François Andrieux
Nov 21 '18 at 14:42
There isn't really a point to having a
for loop that always returns on the first iteration. What did you intend for that function to actually do? You probably don't want to necessarily return on the first iteration.– François Andrieux
Nov 21 '18 at 14:42
bool sal_sk(int sal) returns true if sal is even false if it is not. It does not for the reason @FrançoisAndrieux mentioned. You probably want to move the return false out of the loop and change the for (int i = 2; i <= sal; i++) { to for (int i = 2; i < sal; i++) {– drescherjm
Nov 21 '18 at 14:52
bool sal_sk(int sal) returns true if sal is even false if it is not. It does not for the reason @FrançoisAndrieux mentioned. You probably want to move the return false out of the loop and change the for (int i = 2; i <= sal; i++) { to for (int i = 2; i < sal; i++) {– drescherjm
Nov 21 '18 at 14:52
Hey that function is intented to return true when the number is composite and false when it is not, I dont understand why it is always true tho :/
– MrLucky2243
Nov 21 '18 at 14:56
Hey that function is intented to return true when the number is composite and false when it is not, I dont understand why it is always true tho :/
– MrLucky2243
Nov 21 '18 at 14:56
Okay that seems to helped a bit, could you check the
lkd function because for example when I enter 17 2 4 it should return that gcd is 2 but it returns 1– MrLucky2243
Nov 21 '18 at 15:00
Okay that seems to helped a bit, could you check the
lkd function because for example when I enter 17 2 4 it should return that gcd is 2 but it returns 1– MrLucky2243
Nov 21 '18 at 15:00
Thank you! seriously!
– MrLucky2243
Nov 21 '18 at 15:11
Thank you! seriously!
– MrLucky2243
Nov 21 '18 at 15:11
|
show 1 more comment
2 Answers
2
active
oldest
votes
0
bool sal_sk(int sal) returns true if sal is even false if it is not because you return always on the first iteration of your loop as @FrançoisAndrieux mentioned.
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i <= sal; i++) {
if (sal%i == 0)
return true;
else
return false;
}
}
To return true on composite make the following changes.
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i < sal; i++) {
if (sal%i == 0)
return true; // Has some factor other than 1 and itself
}
return false; // Does not have a factor other than 1 and itself
}
Another bug is here:
for (int i = 1; i < n; i++) {
if (sal_sk(a[i] == true))
rez = lkd(rez, a[i]);
}
This code passes true or false to sal_sk() depending on if a[i] !=0
Instead you want:
for (int i = 1; i < n; i++) {
if (sal_sk(a[i]))
rez = lkd(rez, a[i]);
}
This is also a bug:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a; // This puts the value in a[0] always!
}
The code should be:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> a[i]; // Put the value in the array at index i
}
answered Nov 21 '18 at 15:00
drescherjmdrescherjm
6,43523452
add a comment |
-1
The code here:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a;
}
does not fill in all the array elements, but instead just overwrites the first entry.
This is far from the only problem with your code. In particular, sal_sk is not doing whatever you think its doing.
answered Nov 21 '18 at 14:23
jwimberleyjwimberley
1,144518
It should bestd::cin>>a?
– MrLucky2243
Nov 21 '18 at 14:25
1
It should be std::cin >> a[i].
– jwimberley
Nov 21 '18 at 14:26
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53414057%2fa-little-problem-with-a-program-that-has-an-array-and-two-functions-is-random-bu%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
0
bool sal_sk(int sal) returns true if sal is even false if it is not because you return always on the first iteration of your loop as @FrançoisAndrieux mentioned.
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i <= sal; i++) {
if (sal%i == 0)
return true;
else
return false;
}
}
To return true on composite make the following changes.
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i < sal; i++) {
if (sal%i == 0)
return true; // Has some factor other than 1 and itself
}
return false; // Does not have a factor other than 1 and itself
}
Another bug is here:
for (int i = 1; i < n; i++) {
if (sal_sk(a[i] == true))
rez = lkd(rez, a[i]);
}
This code passes true or false to sal_sk() depending on if a[i] !=0
Instead you want:
for (int i = 1; i < n; i++) {
if (sal_sk(a[i]))
rez = lkd(rez, a[i]);
}
This is also a bug:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a; // This puts the value in a[0] always!
}
The code should be:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> a[i]; // Put the value in the array at index i
}
answered Nov 21 '18 at 15:00
drescherjmdrescherjm
6,43523452
add a comment |
0
bool sal_sk(int sal) returns true if sal is even false if it is not because you return always on the first iteration of your loop as @FrançoisAndrieux mentioned.
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i <= sal; i++) {
if (sal%i == 0)
return true;
else
return false;
}
}
To return true on composite make the following changes.
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i < sal; i++) {
if (sal%i == 0)
return true; // Has some factor other than 1 and itself
}
return false; // Does not have a factor other than 1 and itself
}
Another bug is here:
for (int i = 1; i < n; i++) {
if (sal_sk(a[i] == true))
rez = lkd(rez, a[i]);
}
This code passes true or false to sal_sk() depending on if a[i] !=0
Instead you want:
for (int i = 1; i < n; i++) {
if (sal_sk(a[i]))
rez = lkd(rez, a[i]);
}
This is also a bug:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a; // This puts the value in a[0] always!
}
The code should be:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> a[i]; // Put the value in the array at index i
}
answered Nov 21 '18 at 15:00
drescherjmdrescherjm
6,43523452
add a comment |
0
0
0
bool sal_sk(int sal) returns true if sal is even false if it is not because you return always on the first iteration of your loop as @FrançoisAndrieux mentioned.
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i <= sal; i++) {
if (sal%i == 0)
return true;
else
return false;
}
}
To return true on composite make the following changes.
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i < sal; i++) {
if (sal%i == 0)
return true; // Has some factor other than 1 and itself
}
return false; // Does not have a factor other than 1 and itself
}
Another bug is here:
for (int i = 1; i < n; i++) {
if (sal_sk(a[i] == true))
rez = lkd(rez, a[i]);
}
This code passes true or false to sal_sk() depending on if a[i] !=0
Instead you want:
for (int i = 1; i < n; i++) {
if (sal_sk(a[i]))
rez = lkd(rez, a[i]);
}
This is also a bug:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a; // This puts the value in a[0] always!
}
The code should be:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> a[i]; // Put the value in the array at index i
}
answered Nov 21 '18 at 15:00
drescherjmdrescherjm
6,43523452
bool sal_sk(int sal) returns true if sal is even false if it is not because you return always on the first iteration of your loop as @FrançoisAndrieux mentioned.
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i <= sal; i++) {
if (sal%i == 0)
return true;
else
return false;
}
}
To return true on composite make the following changes.
bool sal_sk(int sal) // If sal is a composite figure, then true, if its not then false.
{
for (int i = 2; i < sal; i++) {
if (sal%i == 0)
return true; // Has some factor other than 1 and itself
}
return false; // Does not have a factor other than 1 and itself
}
Another bug is here:
for (int i = 1; i < n; i++) {
if (sal_sk(a[i] == true))
rez = lkd(rez, a[i]);
}
This code passes true or false to sal_sk() depending on if a[i] !=0
Instead you want:
for (int i = 1; i < n; i++) {
if (sal_sk(a[i]))
rez = lkd(rez, a[i]);
}
This is also a bug:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a; // This puts the value in a[0] always!
}
The code should be:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> a[i]; // Put the value in the array at index i
}
answered Nov 21 '18 at 15:00
drescherjmdrescherjm
6,43523452
edited Nov 21 '18 at 16:59
answered Nov 21 '18 at 15:00
drescherjmdrescherjm
6,43523452
answered Nov 21 '18 at 15:00
drescherjmdrescherjm
6,43523452
answered Nov 21 '18 at 15:00
drescherjmdrescherjm
6,43523452
6,43523452
add a comment |
add a comment |
-1
The code here:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a;
}
does not fill in all the array elements, but instead just overwrites the first entry.
This is far from the only problem with your code. In particular, sal_sk is not doing whatever you think its doing.
answered Nov 21 '18 at 14:23
jwimberleyjwimberley
1,144518
It should bestd::cin>>a?
– MrLucky2243
Nov 21 '18 at 14:25
1
It should be std::cin >> a[i].
– jwimberley
Nov 21 '18 at 14:26
add a comment |
-1
The code here:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a;
}
does not fill in all the array elements, but instead just overwrites the first entry.
This is far from the only problem with your code. In particular, sal_sk is not doing whatever you think its doing.
answered Nov 21 '18 at 14:23
jwimberleyjwimberley
1,144518
It should bestd::cin>>a?
– MrLucky2243
Nov 21 '18 at 14:25
1
It should be std::cin >> a[i].
– jwimberley
Nov 21 '18 at 14:26
add a comment |
-1
-1
-1
The code here:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a;
}
does not fill in all the array elements, but instead just overwrites the first entry.
This is far from the only problem with your code. In particular, sal_sk is not doing whatever you think its doing.
answered Nov 21 '18 at 14:23
jwimberleyjwimberley
1,144518
The code here:
cout << "Enter the array elements" << endl;
for (int i = 0; i < n; i++) {
std::cin >> *a;
}
does not fill in all the array elements, but instead just overwrites the first entry.
This is far from the only problem with your code. In particular, sal_sk is not doing whatever you think its doing.
answered Nov 21 '18 at 14:23
jwimberleyjwimberley
1,144518
edited Nov 21 '18 at 14:28
answered Nov 21 '18 at 14:23
jwimberleyjwimberley
1,144518
answered Nov 21 '18 at 14:23
jwimberleyjwimberley
1,144518
answered Nov 21 '18 at 14:23
jwimberleyjwimberley
1,144518
1,144518
It should bestd::cin>>a?
– MrLucky2243
Nov 21 '18 at 14:25
1
It should be std::cin >> a[i].
– jwimberley
Nov 21 '18 at 14:26
add a comment |
It should bestd::cin>>a?
– MrLucky2243
Nov 21 '18 at 14:25
1
It should be std::cin >> a[i].
– jwimberley
Nov 21 '18 at 14:26
It should be
std::cin>>a ?– MrLucky2243
Nov 21 '18 at 14:25
It should be
std::cin>>a ?– MrLucky2243
Nov 21 '18 at 14:25
1
1
It should be std::cin >> a[i].
– jwimberley
Nov 21 '18 at 14:26
It should be std::cin >> a[i].
– jwimberley
Nov 21 '18 at 14:26
add a comment |
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53414057%2fa-little-problem-with-a-program-that-has-an-array-and-two-functions-is-random-bu%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
There isn't really a point to having a
forloop that alwaysreturns on the first iteration. What did you intend for that function to actually do? You probably don't want to necessarily return on the first iteration.– François Andrieux
Nov 21 '18 at 14:42
bool sal_sk(int sal)returns true if sal is even false if it is not. It does not for the reason @FrançoisAndrieux mentioned. You probably want to move the return false out of the loop and change thefor (int i = 2; i <= sal; i++) {tofor (int i = 2; i < sal; i++) {– drescherjm
Nov 21 '18 at 14:52
Hey that function is intented to return true when the number is composite and false when it is not, I dont understand why it is always true tho :/
– MrLucky2243
Nov 21 '18 at 14:56
Okay that seems to helped a bit, could you check the
lkdfunction because for example when I enter 17 2 4 it should return that gcd is 2 but it returns 1– MrLucky2243
Nov 21 '18 at 15:00
Thank you! seriously!
– MrLucky2243
Nov 21 '18 at 15:11