Unable to get the number of alphabets/digits/special characters in a given string

String: This is a string with with alphabets digits 123 special characters @#!

here is my program:

static void Main()

    {

        Console.WriteLine("Enter a string to calculate alphabets,digits and special characters");

        string userstr = Console.ReadLine();



        int alphabet, splch, digits;

        alphabet = splch = digits = 0;



        for (int i = 0; i < userstr.Length; i++)

        {

            if (userstr[i] >= 'a' || userstr[i] <= 'z')

            {

                alphabet++;

            }

            else if (userstr[i] >= 0 || userstr[i] <= 9)

            {

                digits++;

            }



            else { splch++; }

        }



        Console.WriteLine("No of Alphabets {0},digits {1}, special characters {2} in given string are", alphabet, digits, splch);

    }

edited Jan 2 at 6:07

JohnB

1,94011320

asked Jan 2 at 4:07

Ash0214

102

2

What is the question? Are you facing issue in this code? what issue?

– Chetan Ranpariya
Jan 2 at 4:10

2

Replace || with &&. And you should handle capital letters. You’d Better use standard functions.

– dyukha
Jan 2 at 4:10

add a comment |

String: This is a string with with alphabets digits 123 special characters @#!

here is my program:

static void Main()

    {

        Console.WriteLine("Enter a string to calculate alphabets,digits and special characters");

        string userstr = Console.ReadLine();



        int alphabet, splch, digits;

        alphabet = splch = digits = 0;



        for (int i = 0; i < userstr.Length; i++)

        {

            if (userstr[i] >= 'a' || userstr[i] <= 'z')

            {

                alphabet++;

            }

            else if (userstr[i] >= 0 || userstr[i] <= 9)

            {

                digits++;

            }



            else { splch++; }

        }



        Console.WriteLine("No of Alphabets {0},digits {1}, special characters {2} in given string are", alphabet, digits, splch);

    }

edited Jan 2 at 6:07

JohnB

1,94011320

asked Jan 2 at 4:07

Ash0214

102

2

What is the question? Are you facing issue in this code? what issue?

– Chetan Ranpariya
Jan 2 at 4:10

2

Replace || with &&. And you should handle capital letters. You’d Better use standard functions.

– dyukha
Jan 2 at 4:10

add a comment |

String: This is a string with with alphabets digits 123 special characters @#!

here is my program:

static void Main()

    {

        Console.WriteLine("Enter a string to calculate alphabets,digits and special characters");

        string userstr = Console.ReadLine();



        int alphabet, splch, digits;

        alphabet = splch = digits = 0;



        for (int i = 0; i < userstr.Length; i++)

        {

            if (userstr[i] >= 'a' || userstr[i] <= 'z')

            {

                alphabet++;

            }

            else if (userstr[i] >= 0 || userstr[i] <= 9)

            {

                digits++;

            }



            else { splch++; }

        }



        Console.WriteLine("No of Alphabets {0},digits {1}, special characters {2} in given string are", alphabet, digits, splch);

    }

edited Jan 2 at 6:07

JohnB

1,94011320

asked Jan 2 at 4:07

Ash0214

102

String: This is a string with with alphabets digits 123 special characters @#!

here is my program:

static void Main()

    {

        Console.WriteLine("Enter a string to calculate alphabets,digits and special characters");

        string userstr = Console.ReadLine();



        int alphabet, splch, digits;

        alphabet = splch = digits = 0;



        for (int i = 0; i < userstr.Length; i++)

        {

            if (userstr[i] >= 'a' || userstr[i] <= 'z')

            {

                alphabet++;

            }

            else if (userstr[i] >= 0 || userstr[i] <= 9)

            {

                digits++;

            }



            else { splch++; }

        }



        Console.WriteLine("No of Alphabets {0},digits {1}, special characters {2} in given string are", alphabet, digits, splch);

    }

edited Jan 2 at 6:07

JohnB

1,94011320

asked Jan 2 at 4:07

Ash0214

102

edited Jan 2 at 6:07

JohnB

1,94011320

asked Jan 2 at 4:07

Ash0214

102

edited Jan 2 at 6:07

JohnB

1,94011320

edited Jan 2 at 6:07

JohnB

1,94011320

edited Jan 2 at 6:07

JohnB

1,94011320

asked Jan 2 at 4:07

Ash0214

102

asked Jan 2 at 4:07

Ash0214

102

asked Jan 2 at 4:07

Ash0214

102

2

What is the question? Are you facing issue in this code? what issue?

– Chetan Ranpariya
Jan 2 at 4:10

2

Replace || with &&. And you should handle capital letters. You’d Better use standard functions.

– dyukha
Jan 2 at 4:10

add a comment |

2

What is the question? Are you facing issue in this code? what issue?

– Chetan Ranpariya
Jan 2 at 4:10

2

Replace || with &&. And you should handle capital letters. You’d Better use standard functions.

– dyukha
Jan 2 at 4:10

What is the question? Are you facing issue in this code? what issue?

– Chetan Ranpariya
Jan 2 at 4:10

Replace || with &&. And you should handle capital letters. You’d Better use standard functions.

– dyukha
Jan 2 at 4:10

add a comment |

1 Answer
1

active

oldest

votes

You had heaps of mistakes,

you need && instead of ||

you need to account for capitals

you were comparing your numbers wrong and not using the char for 0 and 9

Code (i took the liberty of converting it a foreach)

foreach (var c in userstr)

{

   if (c >= 'a' && c <= 'z' || c >= 'A' && c <= 'Z')

      alphabet++;

   else if (c >= '0'&& c <= '9')

      digits++;

   else

      splch++;     

}

foreach (var c in input)

{

   if (char.IsLetter(c))

      alphabet++;

   else if (char.IsDigit(c))

      digits++;

   else

      splch++; 

}

edited Jan 2 at 4:28

answered Jan 2 at 4:14

Michael Randall

34.8k83868

Thanks much for your help!!! Appreciate it!!

– Ash0214
Jan 2 at 6:14

add a comment |

Your Answer

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});

}
});

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54001081%2funable-to-get-the-number-of-alphabets-digits-special-characters-in-a-given-strin%23new-answer', 'question_page');
}
);

Post as a guest

Name

Required, but never shown

1 Answer
1

active

oldest

votes

1 Answer
1

active

oldest

votes

You had heaps of mistakes,

you need && instead of ||

you need to account for capitals

you were comparing your numbers wrong and not using the char for 0 and 9

Code (i took the liberty of converting it a foreach)

foreach (var c in userstr)

{

   if (c >= 'a' && c <= 'z' || c >= 'A' && c <= 'Z')

      alphabet++;

   else if (c >= '0'&& c <= '9')

      digits++;

   else

      splch++;     

}

foreach (var c in input)

{

   if (char.IsLetter(c))

      alphabet++;

   else if (char.IsDigit(c))

      digits++;

   else

      splch++; 

}

edited Jan 2 at 4:28

answered Jan 2 at 4:14

Michael Randall

34.8k83868

Thanks much for your help!!! Appreciate it!!

– Ash0214
Jan 2 at 6:14

add a comment |

You had heaps of mistakes,

you need && instead of ||

you need to account for capitals

you were comparing your numbers wrong and not using the char for 0 and 9

Code (i took the liberty of converting it a foreach)

foreach (var c in userstr)

{

   if (c >= 'a' && c <= 'z' || c >= 'A' && c <= 'Z')

      alphabet++;

   else if (c >= '0'&& c <= '9')

      digits++;

   else

      splch++;     

}

foreach (var c in input)

{

   if (char.IsLetter(c))

      alphabet++;

   else if (char.IsDigit(c))

      digits++;

   else

      splch++; 

}

edited Jan 2 at 4:28

answered Jan 2 at 4:14

Michael Randall

34.8k83868

Thanks much for your help!!! Appreciate it!!

– Ash0214
Jan 2 at 6:14

add a comment |

You had heaps of mistakes,

you need && instead of ||

you need to account for capitals

you were comparing your numbers wrong and not using the char for 0 and 9

Code (i took the liberty of converting it a foreach)

foreach (var c in userstr)

{

   if (c >= 'a' && c <= 'z' || c >= 'A' && c <= 'Z')

      alphabet++;

   else if (c >= '0'&& c <= '9')

      digits++;

   else

      splch++;     

}

foreach (var c in input)

{

   if (char.IsLetter(c))

      alphabet++;

   else if (char.IsDigit(c))

      digits++;

   else

      splch++; 

}

edited Jan 2 at 4:28

answered Jan 2 at 4:14

Michael Randall

34.8k83868

You had heaps of mistakes,

you need && instead of ||

you need to account for capitals

you were comparing your numbers wrong and not using the char for 0 and 9

Code (i took the liberty of converting it a foreach)

foreach (var c in userstr)

{

   if (c >= 'a' && c <= 'z' || c >= 'A' && c <= 'Z')

      alphabet++;

   else if (c >= '0'&& c <= '9')

      digits++;

   else

      splch++;     

}

foreach (var c in input)

{

   if (char.IsLetter(c))

      alphabet++;

   else if (char.IsDigit(c))

      digits++;

   else

      splch++; 

}

edited Jan 2 at 4:28

answered Jan 2 at 4:14

Michael Randall

34.8k83868

edited Jan 2 at 4:28

answered Jan 2 at 4:14

Michael Randall

34.8k83868

answered Jan 2 at 4:14

Michael Randall

34.8k83868

answered Jan 2 at 4:14

Michael Randall

34.8k83868

Thanks much for your help!!! Appreciate it!!

– Ash0214
Jan 2 at 6:14

add a comment |

Thanks much for your help!!! Appreciate it!!

– Ash0214
Jan 2 at 6:14

Thanks much for your help!!! Appreciate it!!

– Ash0214
Jan 2 at 6:14

add a comment |

draft saved

draft discarded

Thanks for contributing an answer to Stack Overflow!

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Name

Required, but never shown

Name

Required, but never shown

This page is only for reference, If you need detailed information, please check here

Search This Blog

Ufyukyu