Simplify the very long if statement in PHP












1















$gateway_site_id = $_POST['gateway_site_id'];
$site_location = $_POST['site_location'];
$city = $_POST['city'];
$contact = $_POST['gateway_site_id'];
$date_installed = $_POST['date_installed'];
$care_of = $_POST['care_of'];
$notes = $_POST['notes'];
$gateway_username = $_POST['gateway_username'];



if(empty($gateway_username)){
$gateway_username="N/A";
}if(empty($notes)){
$notes="N/A";
}if(empty($care_of)){
$care_of="N/A";
}if(empty($date_installed)){
$date_installed="N/A";
}if(empty($city)){
$city="N/A";
}if(empty($site_location)){
$site_location="N/A";
}if(empty($gateway_site_id)){
$gateway_site_id="N/A";
}


When I submit my form, I just want to set empty fields with N/A.
My code is working but I think its too long, is there a way to simplify it?










share|improve this question





























    1















    $gateway_site_id = $_POST['gateway_site_id'];
    $site_location = $_POST['site_location'];
    $city = $_POST['city'];
    $contact = $_POST['gateway_site_id'];
    $date_installed = $_POST['date_installed'];
    $care_of = $_POST['care_of'];
    $notes = $_POST['notes'];
    $gateway_username = $_POST['gateway_username'];



    if(empty($gateway_username)){
    $gateway_username="N/A";
    }if(empty($notes)){
    $notes="N/A";
    }if(empty($care_of)){
    $care_of="N/A";
    }if(empty($date_installed)){
    $date_installed="N/A";
    }if(empty($city)){
    $city="N/A";
    }if(empty($site_location)){
    $site_location="N/A";
    }if(empty($gateway_site_id)){
    $gateway_site_id="N/A";
    }


    When I submit my form, I just want to set empty fields with N/A.
    My code is working but I think its too long, is there a way to simplify it?










    share|improve this question



























      1












      1








      1








      $gateway_site_id = $_POST['gateway_site_id'];
      $site_location = $_POST['site_location'];
      $city = $_POST['city'];
      $contact = $_POST['gateway_site_id'];
      $date_installed = $_POST['date_installed'];
      $care_of = $_POST['care_of'];
      $notes = $_POST['notes'];
      $gateway_username = $_POST['gateway_username'];



      if(empty($gateway_username)){
      $gateway_username="N/A";
      }if(empty($notes)){
      $notes="N/A";
      }if(empty($care_of)){
      $care_of="N/A";
      }if(empty($date_installed)){
      $date_installed="N/A";
      }if(empty($city)){
      $city="N/A";
      }if(empty($site_location)){
      $site_location="N/A";
      }if(empty($gateway_site_id)){
      $gateway_site_id="N/A";
      }


      When I submit my form, I just want to set empty fields with N/A.
      My code is working but I think its too long, is there a way to simplify it?










      share|improve this question
















      $gateway_site_id = $_POST['gateway_site_id'];
      $site_location = $_POST['site_location'];
      $city = $_POST['city'];
      $contact = $_POST['gateway_site_id'];
      $date_installed = $_POST['date_installed'];
      $care_of = $_POST['care_of'];
      $notes = $_POST['notes'];
      $gateway_username = $_POST['gateway_username'];



      if(empty($gateway_username)){
      $gateway_username="N/A";
      }if(empty($notes)){
      $notes="N/A";
      }if(empty($care_of)){
      $care_of="N/A";
      }if(empty($date_installed)){
      $date_installed="N/A";
      }if(empty($city)){
      $city="N/A";
      }if(empty($site_location)){
      $site_location="N/A";
      }if(empty($gateway_site_id)){
      $gateway_site_id="N/A";
      }


      When I submit my form, I just want to set empty fields with N/A.
      My code is working but I think its too long, is there a way to simplify it?







      php if-statement






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 21 '18 at 7:05









      Delwar Sumon

      373112




      373112










      asked Nov 21 '18 at 6:49









      ICG DEVSICG DEVS

      488




      488
























          4 Answers
          4






          active

          oldest

          votes


















          3














          Check emptiness with ternary operator and write like this:



          $gateway_site_id = $_POST['gateway_site_id'] ?: 'N/A' ;
          // ...
          $gateway_username = $_POST['gateway_username'] ?: 'N/A';

          // all `if`s can be removed





          share|improve this answer































            3














            Something like this:



            $required = ['gateway_site_id', 'site_location', 'city', 'gateway_site_id', 'date_installed', 'care_of', 'notes','gateway_username'];
            foreach ($required as $req)
            ${$req} = isset($_POST[$req]) ? $_POST[$req] : 'NA';





            share|improve this answer































              1














              If you are using PHP 7 then you can use Coalescing Operator to check for empty value in POST array like :



              $gateway_site_id    = $_POST['gateway_site_id'] ?? 'N/A';
              $site_location = $_POST['site_location'] ?? 'N/A';
              $city = $_POST['city'] ?? 'N/A';
              $contact = $_POST['gateway_site_id'] ?? 'N/A';
              $date_installed = $_POST['date_installed'] ?? 'N/A';
              $care_of = $_POST['care_of'] ?? 'N/A';
              $notes = $_POST['notes'] ?? 'N/A';
              $gateway_username = $_POST['gateway_username'] ?? 'N/A';





              share|improve this answer































                1














                Try This:



                $gateway_site_id = empty($_POST['gateway_site_id']) ? $_POST['gateway_site_id'] : 'N/A';
                $site_location = empty($_POST['site_location']) ? $_POST['site_location'] : 'N/A';
                $city = empty($_POST['city']) ? $_POST['city'] : 'N/A';
                $contact = empty($_POST['gateway_site_id']) ? $_POST['gateway_site_id'] : 'N/A';
                $date_installed = empty($_POST['date_installed']) ? $_POST['date_installed'] : 'N/A';
                $care_of = empty($_POST['care_of']) ? $_POST['care_of'] : 'N/A';
                $notes = empty($_POST['notes']) ? $_POST['notes'] : 'N/A';
                $gateway_username = empty($_POST['gateway_username']) ? $_POST['gateway_username'] : 'N/A';





                share|improve this answer























                  Your Answer






                  StackExchange.ifUsing("editor", function () {
                  StackExchange.using("externalEditor", function () {
                  StackExchange.using("snippets", function () {
                  StackExchange.snippets.init();
                  });
                  });
                  }, "code-snippets");

                  StackExchange.ready(function() {
                  var channelOptions = {
                  tags: "".split(" "),
                  id: "1"
                  };
                  initTagRenderer("".split(" "), "".split(" "), channelOptions);

                  StackExchange.using("externalEditor", function() {
                  // Have to fire editor after snippets, if snippets enabled
                  if (StackExchange.settings.snippets.snippetsEnabled) {
                  StackExchange.using("snippets", function() {
                  createEditor();
                  });
                  }
                  else {
                  createEditor();
                  }
                  });

                  function createEditor() {
                  StackExchange.prepareEditor({
                  heartbeatType: 'answer',
                  autoActivateHeartbeat: false,
                  convertImagesToLinks: true,
                  noModals: true,
                  showLowRepImageUploadWarning: true,
                  reputationToPostImages: 10,
                  bindNavPrevention: true,
                  postfix: "",
                  imageUploader: {
                  brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
                  contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
                  allowUrls: true
                  },
                  onDemand: true,
                  discardSelector: ".discard-answer"
                  ,immediatelyShowMarkdownHelp:true
                  });


                  }
                  });














                  draft saved

                  draft discarded


















                  StackExchange.ready(
                  function () {
                  StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53406632%2fsimplify-the-very-long-if-statement-in-php%23new-answer', 'question_page');
                  }
                  );

                  Post as a guest















                  Required, but never shown

























                  4 Answers
                  4






                  active

                  oldest

                  votes








                  4 Answers
                  4






                  active

                  oldest

                  votes









                  active

                  oldest

                  votes






                  active

                  oldest

                  votes









                  3














                  Check emptiness with ternary operator and write like this:



                  $gateway_site_id = $_POST['gateway_site_id'] ?: 'N/A' ;
                  // ...
                  $gateway_username = $_POST['gateway_username'] ?: 'N/A';

                  // all `if`s can be removed





                  share|improve this answer




























                    3














                    Check emptiness with ternary operator and write like this:



                    $gateway_site_id = $_POST['gateway_site_id'] ?: 'N/A' ;
                    // ...
                    $gateway_username = $_POST['gateway_username'] ?: 'N/A';

                    // all `if`s can be removed





                    share|improve this answer


























                      3












                      3








                      3







                      Check emptiness with ternary operator and write like this:



                      $gateway_site_id = $_POST['gateway_site_id'] ?: 'N/A' ;
                      // ...
                      $gateway_username = $_POST['gateway_username'] ?: 'N/A';

                      // all `if`s can be removed





                      share|improve this answer













                      Check emptiness with ternary operator and write like this:



                      $gateway_site_id = $_POST['gateway_site_id'] ?: 'N/A' ;
                      // ...
                      $gateway_username = $_POST['gateway_username'] ?: 'N/A';

                      // all `if`s can be removed






                      share|improve this answer












                      share|improve this answer



                      share|improve this answer










                      answered Nov 21 '18 at 6:52









                      u_mulderu_mulder

                      35.7k53046




                      35.7k53046

























                          3














                          Something like this:



                          $required = ['gateway_site_id', 'site_location', 'city', 'gateway_site_id', 'date_installed', 'care_of', 'notes','gateway_username'];
                          foreach ($required as $req)
                          ${$req} = isset($_POST[$req]) ? $_POST[$req] : 'NA';





                          share|improve this answer




























                            3














                            Something like this:



                            $required = ['gateway_site_id', 'site_location', 'city', 'gateway_site_id', 'date_installed', 'care_of', 'notes','gateway_username'];
                            foreach ($required as $req)
                            ${$req} = isset($_POST[$req]) ? $_POST[$req] : 'NA';





                            share|improve this answer


























                              3












                              3








                              3







                              Something like this:



                              $required = ['gateway_site_id', 'site_location', 'city', 'gateway_site_id', 'date_installed', 'care_of', 'notes','gateway_username'];
                              foreach ($required as $req)
                              ${$req} = isset($_POST[$req]) ? $_POST[$req] : 'NA';





                              share|improve this answer













                              Something like this:



                              $required = ['gateway_site_id', 'site_location', 'city', 'gateway_site_id', 'date_installed', 'care_of', 'notes','gateway_username'];
                              foreach ($required as $req)
                              ${$req} = isset($_POST[$req]) ? $_POST[$req] : 'NA';






                              share|improve this answer












                              share|improve this answer



                              share|improve this answer










                              answered Nov 21 '18 at 6:55









                              RainDevRainDev

                              78548




                              78548























                                  1














                                  If you are using PHP 7 then you can use Coalescing Operator to check for empty value in POST array like :



                                  $gateway_site_id    = $_POST['gateway_site_id'] ?? 'N/A';
                                  $site_location = $_POST['site_location'] ?? 'N/A';
                                  $city = $_POST['city'] ?? 'N/A';
                                  $contact = $_POST['gateway_site_id'] ?? 'N/A';
                                  $date_installed = $_POST['date_installed'] ?? 'N/A';
                                  $care_of = $_POST['care_of'] ?? 'N/A';
                                  $notes = $_POST['notes'] ?? 'N/A';
                                  $gateway_username = $_POST['gateway_username'] ?? 'N/A';





                                  share|improve this answer




























                                    1














                                    If you are using PHP 7 then you can use Coalescing Operator to check for empty value in POST array like :



                                    $gateway_site_id    = $_POST['gateway_site_id'] ?? 'N/A';
                                    $site_location = $_POST['site_location'] ?? 'N/A';
                                    $city = $_POST['city'] ?? 'N/A';
                                    $contact = $_POST['gateway_site_id'] ?? 'N/A';
                                    $date_installed = $_POST['date_installed'] ?? 'N/A';
                                    $care_of = $_POST['care_of'] ?? 'N/A';
                                    $notes = $_POST['notes'] ?? 'N/A';
                                    $gateway_username = $_POST['gateway_username'] ?? 'N/A';





                                    share|improve this answer


























                                      1












                                      1








                                      1







                                      If you are using PHP 7 then you can use Coalescing Operator to check for empty value in POST array like :



                                      $gateway_site_id    = $_POST['gateway_site_id'] ?? 'N/A';
                                      $site_location = $_POST['site_location'] ?? 'N/A';
                                      $city = $_POST['city'] ?? 'N/A';
                                      $contact = $_POST['gateway_site_id'] ?? 'N/A';
                                      $date_installed = $_POST['date_installed'] ?? 'N/A';
                                      $care_of = $_POST['care_of'] ?? 'N/A';
                                      $notes = $_POST['notes'] ?? 'N/A';
                                      $gateway_username = $_POST['gateway_username'] ?? 'N/A';





                                      share|improve this answer













                                      If you are using PHP 7 then you can use Coalescing Operator to check for empty value in POST array like :



                                      $gateway_site_id    = $_POST['gateway_site_id'] ?? 'N/A';
                                      $site_location = $_POST['site_location'] ?? 'N/A';
                                      $city = $_POST['city'] ?? 'N/A';
                                      $contact = $_POST['gateway_site_id'] ?? 'N/A';
                                      $date_installed = $_POST['date_installed'] ?? 'N/A';
                                      $care_of = $_POST['care_of'] ?? 'N/A';
                                      $notes = $_POST['notes'] ?? 'N/A';
                                      $gateway_username = $_POST['gateway_username'] ?? 'N/A';






                                      share|improve this answer












                                      share|improve this answer



                                      share|improve this answer










                                      answered Nov 21 '18 at 6:54









                                      Manoj SinghManoj Singh

                                      22016




                                      22016























                                          1














                                          Try This:



                                          $gateway_site_id = empty($_POST['gateway_site_id']) ? $_POST['gateway_site_id'] : 'N/A';
                                          $site_location = empty($_POST['site_location']) ? $_POST['site_location'] : 'N/A';
                                          $city = empty($_POST['city']) ? $_POST['city'] : 'N/A';
                                          $contact = empty($_POST['gateway_site_id']) ? $_POST['gateway_site_id'] : 'N/A';
                                          $date_installed = empty($_POST['date_installed']) ? $_POST['date_installed'] : 'N/A';
                                          $care_of = empty($_POST['care_of']) ? $_POST['care_of'] : 'N/A';
                                          $notes = empty($_POST['notes']) ? $_POST['notes'] : 'N/A';
                                          $gateway_username = empty($_POST['gateway_username']) ? $_POST['gateway_username'] : 'N/A';





                                          share|improve this answer




























                                            1














                                            Try This:



                                            $gateway_site_id = empty($_POST['gateway_site_id']) ? $_POST['gateway_site_id'] : 'N/A';
                                            $site_location = empty($_POST['site_location']) ? $_POST['site_location'] : 'N/A';
                                            $city = empty($_POST['city']) ? $_POST['city'] : 'N/A';
                                            $contact = empty($_POST['gateway_site_id']) ? $_POST['gateway_site_id'] : 'N/A';
                                            $date_installed = empty($_POST['date_installed']) ? $_POST['date_installed'] : 'N/A';
                                            $care_of = empty($_POST['care_of']) ? $_POST['care_of'] : 'N/A';
                                            $notes = empty($_POST['notes']) ? $_POST['notes'] : 'N/A';
                                            $gateway_username = empty($_POST['gateway_username']) ? $_POST['gateway_username'] : 'N/A';





                                            share|improve this answer


























                                              1












                                              1








                                              1







                                              Try This:



                                              $gateway_site_id = empty($_POST['gateway_site_id']) ? $_POST['gateway_site_id'] : 'N/A';
                                              $site_location = empty($_POST['site_location']) ? $_POST['site_location'] : 'N/A';
                                              $city = empty($_POST['city']) ? $_POST['city'] : 'N/A';
                                              $contact = empty($_POST['gateway_site_id']) ? $_POST['gateway_site_id'] : 'N/A';
                                              $date_installed = empty($_POST['date_installed']) ? $_POST['date_installed'] : 'N/A';
                                              $care_of = empty($_POST['care_of']) ? $_POST['care_of'] : 'N/A';
                                              $notes = empty($_POST['notes']) ? $_POST['notes'] : 'N/A';
                                              $gateway_username = empty($_POST['gateway_username']) ? $_POST['gateway_username'] : 'N/A';





                                              share|improve this answer













                                              Try This:



                                              $gateway_site_id = empty($_POST['gateway_site_id']) ? $_POST['gateway_site_id'] : 'N/A';
                                              $site_location = empty($_POST['site_location']) ? $_POST['site_location'] : 'N/A';
                                              $city = empty($_POST['city']) ? $_POST['city'] : 'N/A';
                                              $contact = empty($_POST['gateway_site_id']) ? $_POST['gateway_site_id'] : 'N/A';
                                              $date_installed = empty($_POST['date_installed']) ? $_POST['date_installed'] : 'N/A';
                                              $care_of = empty($_POST['care_of']) ? $_POST['care_of'] : 'N/A';
                                              $notes = empty($_POST['notes']) ? $_POST['notes'] : 'N/A';
                                              $gateway_username = empty($_POST['gateway_username']) ? $_POST['gateway_username'] : 'N/A';






                                              share|improve this answer












                                              share|improve this answer



                                              share|improve this answer










                                              answered Nov 21 '18 at 6:56









                                              Delwar SumonDelwar Sumon

                                              373112




                                              373112






























                                                  draft saved

                                                  draft discarded




















































                                                  Thanks for contributing an answer to Stack Overflow!


                                                  • Please be sure to answer the question. Provide details and share your research!

                                                  But avoid



                                                  • Asking for help, clarification, or responding to other answers.

                                                  • Making statements based on opinion; back them up with references or personal experience.


                                                  To learn more, see our tips on writing great answers.




                                                  draft saved


                                                  draft discarded














                                                  StackExchange.ready(
                                                  function () {
                                                  StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53406632%2fsimplify-the-very-long-if-statement-in-php%23new-answer', 'question_page');
                                                  }
                                                  );

                                                  Post as a guest















                                                  Required, but never shown





















































                                                  Required, but never shown














                                                  Required, but never shown












                                                  Required, but never shown







                                                  Required, but never shown

































                                                  Required, but never shown














                                                  Required, but never shown












                                                  Required, but never shown







                                                  Required, but never shown







                                                  Popular posts from this blog

                                                  MongoDB - Not Authorized To Execute Command

                                                  in spring boot 2.1 many test slices are not allowed anymore due to multiple @BootstrapWith

                                                  Npm cannot find a required file even through it is in the searched directory