Should I create a new Fragment instance every time with BottomNavigationView












0















I am trying to create an android app with BottomNavigationView and Fragments. My code is:



public class MainActivity extends AppCompatActivity {

//some code
//some code
//some code
//some code

private BottomNavigationView.OnNavigationItemSelectedListener
mOnNavigationItemSelectedListener
= new BottomNavigationView.OnNavigationItemSelectedListener() {

@Override
public boolean onNavigationItemSelected(@NonNull MenuItem item) {
switch (item.getItemId()) {
case R.id.navigation_home:
getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeHome).commit();
return true;
case R.id.navigation_dashboard:
getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeDashboard).commit();
return true;
case R.id.navigation_notifications:
getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeNotifications).commit();
return true;
}
return false;
}
};
}


Should I create a new object of each class every time, when the user select a different item on the menu?



Is it good practice to create one object for each class like below?



public class MainActivity extends AppCompatActivity {

//some code
//some code
//some code
//some code

private final Fragment home = new myframeHome();
private final Fragment dashboard = new myframeDashboard();
private final Fragment notifications = new myframeNotifications();

private BottomNavigationView.OnNavigationItemSelectedListener
mOnNavigationItemSelectedListener
= new BottomNavigationView.OnNavigationItemSelectedListener() {

@Override
public boolean onNavigationItemSelected(@NonNull MenuItem item) {
switch (item.getItemId()) {
case R.id.navigation_home:
getFragmentManager().beginTransaction().replace(R.id.myframe, home).commit();
return true;
case R.id.navigation_dashboard:
getFragmentManager().beginTransaction().replace(R.id.myframe, dashboard).commit();
return true;
case R.id.navigation_notifications:
getFragmentManager().beginTransaction().replace(R.id.myframe, notifications).commit();
return true;
}
return false;
}
};
}


Which of the two methods should I use?










share|improve this question



























    0















    I am trying to create an android app with BottomNavigationView and Fragments. My code is:



    public class MainActivity extends AppCompatActivity {

    //some code
    //some code
    //some code
    //some code

    private BottomNavigationView.OnNavigationItemSelectedListener
    mOnNavigationItemSelectedListener
    = new BottomNavigationView.OnNavigationItemSelectedListener() {

    @Override
    public boolean onNavigationItemSelected(@NonNull MenuItem item) {
    switch (item.getItemId()) {
    case R.id.navigation_home:
    getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeHome).commit();
    return true;
    case R.id.navigation_dashboard:
    getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeDashboard).commit();
    return true;
    case R.id.navigation_notifications:
    getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeNotifications).commit();
    return true;
    }
    return false;
    }
    };
    }


    Should I create a new object of each class every time, when the user select a different item on the menu?



    Is it good practice to create one object for each class like below?



    public class MainActivity extends AppCompatActivity {

    //some code
    //some code
    //some code
    //some code

    private final Fragment home = new myframeHome();
    private final Fragment dashboard = new myframeDashboard();
    private final Fragment notifications = new myframeNotifications();

    private BottomNavigationView.OnNavigationItemSelectedListener
    mOnNavigationItemSelectedListener
    = new BottomNavigationView.OnNavigationItemSelectedListener() {

    @Override
    public boolean onNavigationItemSelected(@NonNull MenuItem item) {
    switch (item.getItemId()) {
    case R.id.navigation_home:
    getFragmentManager().beginTransaction().replace(R.id.myframe, home).commit();
    return true;
    case R.id.navigation_dashboard:
    getFragmentManager().beginTransaction().replace(R.id.myframe, dashboard).commit();
    return true;
    case R.id.navigation_notifications:
    getFragmentManager().beginTransaction().replace(R.id.myframe, notifications).commit();
    return true;
    }
    return false;
    }
    };
    }


    Which of the two methods should I use?










    share|improve this question

























      0












      0








      0








      I am trying to create an android app with BottomNavigationView and Fragments. My code is:



      public class MainActivity extends AppCompatActivity {

      //some code
      //some code
      //some code
      //some code

      private BottomNavigationView.OnNavigationItemSelectedListener
      mOnNavigationItemSelectedListener
      = new BottomNavigationView.OnNavigationItemSelectedListener() {

      @Override
      public boolean onNavigationItemSelected(@NonNull MenuItem item) {
      switch (item.getItemId()) {
      case R.id.navigation_home:
      getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeHome).commit();
      return true;
      case R.id.navigation_dashboard:
      getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeDashboard).commit();
      return true;
      case R.id.navigation_notifications:
      getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeNotifications).commit();
      return true;
      }
      return false;
      }
      };
      }


      Should I create a new object of each class every time, when the user select a different item on the menu?



      Is it good practice to create one object for each class like below?



      public class MainActivity extends AppCompatActivity {

      //some code
      //some code
      //some code
      //some code

      private final Fragment home = new myframeHome();
      private final Fragment dashboard = new myframeDashboard();
      private final Fragment notifications = new myframeNotifications();

      private BottomNavigationView.OnNavigationItemSelectedListener
      mOnNavigationItemSelectedListener
      = new BottomNavigationView.OnNavigationItemSelectedListener() {

      @Override
      public boolean onNavigationItemSelected(@NonNull MenuItem item) {
      switch (item.getItemId()) {
      case R.id.navigation_home:
      getFragmentManager().beginTransaction().replace(R.id.myframe, home).commit();
      return true;
      case R.id.navigation_dashboard:
      getFragmentManager().beginTransaction().replace(R.id.myframe, dashboard).commit();
      return true;
      case R.id.navigation_notifications:
      getFragmentManager().beginTransaction().replace(R.id.myframe, notifications).commit();
      return true;
      }
      return false;
      }
      };
      }


      Which of the two methods should I use?










      share|improve this question














      I am trying to create an android app with BottomNavigationView and Fragments. My code is:



      public class MainActivity extends AppCompatActivity {

      //some code
      //some code
      //some code
      //some code

      private BottomNavigationView.OnNavigationItemSelectedListener
      mOnNavigationItemSelectedListener
      = new BottomNavigationView.OnNavigationItemSelectedListener() {

      @Override
      public boolean onNavigationItemSelected(@NonNull MenuItem item) {
      switch (item.getItemId()) {
      case R.id.navigation_home:
      getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeHome).commit();
      return true;
      case R.id.navigation_dashboard:
      getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeDashboard).commit();
      return true;
      case R.id.navigation_notifications:
      getFragmentManager().beginTransaction().replace(R.id.myframe, new myframeNotifications).commit();
      return true;
      }
      return false;
      }
      };
      }


      Should I create a new object of each class every time, when the user select a different item on the menu?



      Is it good practice to create one object for each class like below?



      public class MainActivity extends AppCompatActivity {

      //some code
      //some code
      //some code
      //some code

      private final Fragment home = new myframeHome();
      private final Fragment dashboard = new myframeDashboard();
      private final Fragment notifications = new myframeNotifications();

      private BottomNavigationView.OnNavigationItemSelectedListener
      mOnNavigationItemSelectedListener
      = new BottomNavigationView.OnNavigationItemSelectedListener() {

      @Override
      public boolean onNavigationItemSelected(@NonNull MenuItem item) {
      switch (item.getItemId()) {
      case R.id.navigation_home:
      getFragmentManager().beginTransaction().replace(R.id.myframe, home).commit();
      return true;
      case R.id.navigation_dashboard:
      getFragmentManager().beginTransaction().replace(R.id.myframe, dashboard).commit();
      return true;
      case R.id.navigation_notifications:
      getFragmentManager().beginTransaction().replace(R.id.myframe, notifications).commit();
      return true;
      }
      return false;
      }
      };
      }


      Which of the two methods should I use?







      java android android-fragments bottomnavigationview






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Jan 2 at 18:13









      GeorgeGeorge

      103




      103
























          0






          active

          oldest

          votes












          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54011196%2fshould-i-create-a-new-fragment-instance-every-time-with-bottomnavigationview%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Stack Overflow!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54011196%2fshould-i-create-a-new-fragment-instance-every-time-with-bottomnavigationview%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          'app-layout' is not a known element: how to share Component with different Modules

          android studio warns about leanback feature tag usage required on manifest while using Unity exported app?

          WPF add header to Image with URL pettitions [duplicate]