Terminating multiple operations without a deadlock
I have multiple background threads which update the UI from time to time. I need to terminate them properly from the UI thread and be sure that there's no deadlock/race condition.
Here's an example that creates 100 operations and then terminates them:
class CancellationToken {
private let updateLock = DispatchSemaphore(value: 1)
private var canceled = false
var isCanceled: Bool {
updateLock.wait()
defer { updateLock.signal() }
return canceled
}
func cancel() {
updateLock.wait()
defer { updateLock.signal() }
canceled = true
}
}
// UI thread
let processingQueue = OperationQueue()
let cancelationToken = CancelationToken()
for _ in 0..100 {
processingQueue.addOperation {
// do some stuff on background thread
...
# 2
guard !cancelationToken.isCanceled else { return }
# 3
DispatchQueue.main.async {
# 4
guard !cancelationToken.isCanceled else { return }
// update UI
}
}
}
// we are still on UI thread
cancelationToken.cancel()
for operation in processingQueue.operations {
operation.waitUntilFinished() #1
}
Is #2 -> #1 -> #3 -> deadlock
possible there?
swift multithreading thread-safety
add a comment |
I have multiple background threads which update the UI from time to time. I need to terminate them properly from the UI thread and be sure that there's no deadlock/race condition.
Here's an example that creates 100 operations and then terminates them:
class CancellationToken {
private let updateLock = DispatchSemaphore(value: 1)
private var canceled = false
var isCanceled: Bool {
updateLock.wait()
defer { updateLock.signal() }
return canceled
}
func cancel() {
updateLock.wait()
defer { updateLock.signal() }
canceled = true
}
}
// UI thread
let processingQueue = OperationQueue()
let cancelationToken = CancelationToken()
for _ in 0..100 {
processingQueue.addOperation {
// do some stuff on background thread
...
# 2
guard !cancelationToken.isCanceled else { return }
# 3
DispatchQueue.main.async {
# 4
guard !cancelationToken.isCanceled else { return }
// update UI
}
}
}
// we are still on UI thread
cancelationToken.cancel()
for operation in processingQueue.operations {
operation.waitUntilFinished() #1
}
Is #2 -> #1 -> #3 -> deadlock
possible there?
swift multithreading thread-safety
add a comment |
I have multiple background threads which update the UI from time to time. I need to terminate them properly from the UI thread and be sure that there's no deadlock/race condition.
Here's an example that creates 100 operations and then terminates them:
class CancellationToken {
private let updateLock = DispatchSemaphore(value: 1)
private var canceled = false
var isCanceled: Bool {
updateLock.wait()
defer { updateLock.signal() }
return canceled
}
func cancel() {
updateLock.wait()
defer { updateLock.signal() }
canceled = true
}
}
// UI thread
let processingQueue = OperationQueue()
let cancelationToken = CancelationToken()
for _ in 0..100 {
processingQueue.addOperation {
// do some stuff on background thread
...
# 2
guard !cancelationToken.isCanceled else { return }
# 3
DispatchQueue.main.async {
# 4
guard !cancelationToken.isCanceled else { return }
// update UI
}
}
}
// we are still on UI thread
cancelationToken.cancel()
for operation in processingQueue.operations {
operation.waitUntilFinished() #1
}
Is #2 -> #1 -> #3 -> deadlock
possible there?
swift multithreading thread-safety
I have multiple background threads which update the UI from time to time. I need to terminate them properly from the UI thread and be sure that there's no deadlock/race condition.
Here's an example that creates 100 operations and then terminates them:
class CancellationToken {
private let updateLock = DispatchSemaphore(value: 1)
private var canceled = false
var isCanceled: Bool {
updateLock.wait()
defer { updateLock.signal() }
return canceled
}
func cancel() {
updateLock.wait()
defer { updateLock.signal() }
canceled = true
}
}
// UI thread
let processingQueue = OperationQueue()
let cancelationToken = CancelationToken()
for _ in 0..100 {
processingQueue.addOperation {
// do some stuff on background thread
...
# 2
guard !cancelationToken.isCanceled else { return }
# 3
DispatchQueue.main.async {
# 4
guard !cancelationToken.isCanceled else { return }
// update UI
}
}
}
// we are still on UI thread
cancelationToken.cancel()
for operation in processingQueue.operations {
operation.waitUntilFinished() #1
}
Is #2 -> #1 -> #3 -> deadlock
possible there?
swift multithreading thread-safety
swift multithreading thread-safety
edited Nov 24 '18 at 14:25
Dan Pristupov
asked Nov 20 '18 at 14:07
Dan PristupovDan Pristupov
1114
1114
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53394826%2fterminating-multiple-operations-without-a-deadlock%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53394826%2fterminating-multiple-operations-without-a-deadlock%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown