Mixing
PHPUnit code coverage reports false positive inside foreach
PHPUnit code coverage is reporting 100% coverage for the following function which is clearly wrong:
public function run(){
foreach ([1] as $value) {
if($value === 1 ){
echo "Is calledn"; // TRUE positive
}
else{
echo "Not calledn"; // TRUE negative
echo "Not called eithern"; // FALSE positive
}
}
}
The last line echo "Not called either" is not run, but the report says it is!
If I refactor the body of the foreach loop into another function the report becomes correct:
public function run(){
foreach ([1] as $value) {
$this->run2($value);
}
}
public function run2($value){
if($value === 1 ){
echo "Is calledn"; // TRUE positive
}
else{
echo "Not calledn"; // TRUE negative
echo "Not called eithern"; // TRUE negative
}
}
Tested with php-code-coverage 6.0.7 using PHP 7.2.10-0ubuntu0.18.04.1 with Xdebug 2.6.0 and PHPUnit 7.3.2
I've tried a few older versions of phpunit and get the same results.
Is this a bug or am I missing something here?
php phpunit php-code-coverage
asked Nov 22 '18 at 9:28
DavidDavid
81222033
add a comment |
PHPUnit code coverage is reporting 100% coverage for the following function which is clearly wrong:
public function run(){
foreach ([1] as $value) {
if($value === 1 ){
echo "Is calledn"; // TRUE positive
}
else{
echo "Not calledn"; // TRUE negative
echo "Not called eithern"; // FALSE positive
}
}
}
The last line echo "Not called either" is not run, but the report says it is!
If I refactor the body of the foreach loop into another function the report becomes correct:
public function run(){
foreach ([1] as $value) {
$this->run2($value);
}
}
public function run2($value){
if($value === 1 ){
echo "Is calledn"; // TRUE positive
}
else{
echo "Not calledn"; // TRUE negative
echo "Not called eithern"; // TRUE negative
}
}
Tested with php-code-coverage 6.0.7 using PHP 7.2.10-0ubuntu0.18.04.1 with Xdebug 2.6.0 and PHPUnit 7.3.2
I've tried a few older versions of phpunit and get the same results.
Is this a bug or am I missing something here?
php phpunit php-code-coverage
asked Nov 22 '18 at 9:28
DavidDavid
81222033
add a comment |
PHPUnit code coverage is reporting 100% coverage for the following function which is clearly wrong:
public function run(){
foreach ([1] as $value) {
if($value === 1 ){
echo "Is calledn"; // TRUE positive
}
else{
echo "Not calledn"; // TRUE negative
echo "Not called eithern"; // FALSE positive
}
}
}
The last line echo "Not called either" is not run, but the report says it is!
If I refactor the body of the foreach loop into another function the report becomes correct:
public function run(){
foreach ([1] as $value) {
$this->run2($value);
}
}
public function run2($value){
if($value === 1 ){
echo "Is calledn"; // TRUE positive
}
else{
echo "Not calledn"; // TRUE negative
echo "Not called eithern"; // TRUE negative
}
}
Tested with php-code-coverage 6.0.7 using PHP 7.2.10-0ubuntu0.18.04.1 with Xdebug 2.6.0 and PHPUnit 7.3.2
I've tried a few older versions of phpunit and get the same results.
Is this a bug or am I missing something here?
php phpunit php-code-coverage
asked Nov 22 '18 at 9:28
DavidDavid
81222033
PHPUnit code coverage is reporting 100% coverage for the following function which is clearly wrong:
public function run(){
foreach ([1] as $value) {
if($value === 1 ){
echo "Is calledn"; // TRUE positive
}
else{
echo "Not calledn"; // TRUE negative
echo "Not called eithern"; // FALSE positive
}
}
}
The last line echo "Not called either" is not run, but the report says it is!
If I refactor the body of the foreach loop into another function the report becomes correct:
public function run(){
foreach ([1] as $value) {
$this->run2($value);
}
}
public function run2($value){
if($value === 1 ){
echo "Is calledn"; // TRUE positive
}
else{
echo "Not calledn"; // TRUE negative
echo "Not called eithern"; // TRUE negative
}
}
Tested with php-code-coverage 6.0.7 using PHP 7.2.10-0ubuntu0.18.04.1 with Xdebug 2.6.0 and PHPUnit 7.3.2
I've tried a few older versions of phpunit and get the same results.
Is this a bug or am I missing something here?
php phpunit php-code-coverage
php phpunit php-code-coverage
asked Nov 22 '18 at 9:28
DavidDavid
81222033
asked Nov 22 '18 at 9:28
DavidDavid
81222033
edited Nov 26 '18 at 13:19
David
asked Nov 22 '18 at 9:28
DavidDavid
81222033
asked Nov 22 '18 at 9:28
DavidDavid
81222033
asked Nov 22 '18 at 9:28
DavidDavid
81222033
81222033
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
This is caused by a currently unresolved bug in PHP as described here and here.
The problem can avoided by using a standard for loop instead of a foreach loop. Or, by moving the foreach body into another function as described in the question.
answered Nov 26 '18 at 20:37
DavidDavid
81222033
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53427672%2fphpunit-code-coverage-reports-false-positive-inside-foreach%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
This is caused by a currently unresolved bug in PHP as described here and here.
The problem can avoided by using a standard for loop instead of a foreach loop. Or, by moving the foreach body into another function as described in the question.
answered Nov 26 '18 at 20:37
DavidDavid
81222033
add a comment |
This is caused by a currently unresolved bug in PHP as described here and here.
The problem can avoided by using a standard for loop instead of a foreach loop. Or, by moving the foreach body into another function as described in the question.
answered Nov 26 '18 at 20:37
DavidDavid
81222033
add a comment |
This is caused by a currently unresolved bug in PHP as described here and here.
The problem can avoided by using a standard for loop instead of a foreach loop. Or, by moving the foreach body into another function as described in the question.
answered Nov 26 '18 at 20:37
DavidDavid
81222033
This is caused by a currently unresolved bug in PHP as described here and here.
The problem can avoided by using a standard for loop instead of a foreach loop. Or, by moving the foreach body into another function as described in the question.
answered Nov 26 '18 at 20:37
DavidDavid
81222033
answered Nov 26 '18 at 20:37
DavidDavid
81222033
answered Nov 26 '18 at 20:37
DavidDavid
81222033
answered Nov 26 '18 at 20:37
DavidDavid
81222033
81222033
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53427672%2fphpunit-code-coverage-reports-false-positive-inside-foreach%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
