Scons appending a random '1' to macro definition on OSX only












3















I have a command line argument that defines the type to use for a Vector3 class. It is defined in the SConstruct file as follows:



EnumVariable('vector3_type', 'The type to use for Vector3's xyz coordinates', 'float', allowed_values=['float', 'double', 'long_double'], ignorecase=2)


This variable is added to the environment here:



if env['vector3_type'] != 'long_double':
env.Append(CPPDEFINES = ["BIGROCK_VEC3_TYPE %s" % env['vector3_type']])
else:
env.Append(CPPDEFINES = ["BIGROCK_VEC3_TYPE long double"])


This works fine on Windows 10, but when I try to compile on OSX, I get the following error:



In file included from src/octree.cpp:1:
In file included from src/octree.h:5:
src/vector3.h:15:9: error: expected member name or ';' after declaration specifiers
BIGROCK_VEC3_TYPE x, y, z;
^~~~~~~~~~~~~~~~~
<command line>:1:33: note: expanded from here
#define BIGROCK_VEC3_TYPE float 1
~~~~~ ^


Either scons or g++ is adding an extra '1' to the end of my macro, causing the rest of my code to break.



When I print env['vector3_type'] in scons, it doesn't have a 1 attached. I have no idea where this 1 is being added.










share|improve this question

























  • Please mark your answer as the answer so this doesn't show up as unanswered.

    – bdbaddog
    Jan 1 at 22:52






  • 1





    StackOverflow says I have to wait until tomorrow to accept my own answer, sorry

    – TGRCDev
    Jan 1 at 23:31
















3















I have a command line argument that defines the type to use for a Vector3 class. It is defined in the SConstruct file as follows:



EnumVariable('vector3_type', 'The type to use for Vector3's xyz coordinates', 'float', allowed_values=['float', 'double', 'long_double'], ignorecase=2)


This variable is added to the environment here:



if env['vector3_type'] != 'long_double':
env.Append(CPPDEFINES = ["BIGROCK_VEC3_TYPE %s" % env['vector3_type']])
else:
env.Append(CPPDEFINES = ["BIGROCK_VEC3_TYPE long double"])


This works fine on Windows 10, but when I try to compile on OSX, I get the following error:



In file included from src/octree.cpp:1:
In file included from src/octree.h:5:
src/vector3.h:15:9: error: expected member name or ';' after declaration specifiers
BIGROCK_VEC3_TYPE x, y, z;
^~~~~~~~~~~~~~~~~
<command line>:1:33: note: expanded from here
#define BIGROCK_VEC3_TYPE float 1
~~~~~ ^


Either scons or g++ is adding an extra '1' to the end of my macro, causing the rest of my code to break.



When I print env['vector3_type'] in scons, it doesn't have a 1 attached. I have no idea where this 1 is being added.










share|improve this question

























  • Please mark your answer as the answer so this doesn't show up as unanswered.

    – bdbaddog
    Jan 1 at 22:52






  • 1





    StackOverflow says I have to wait until tomorrow to accept my own answer, sorry

    – TGRCDev
    Jan 1 at 23:31














3












3








3








I have a command line argument that defines the type to use for a Vector3 class. It is defined in the SConstruct file as follows:



EnumVariable('vector3_type', 'The type to use for Vector3's xyz coordinates', 'float', allowed_values=['float', 'double', 'long_double'], ignorecase=2)


This variable is added to the environment here:



if env['vector3_type'] != 'long_double':
env.Append(CPPDEFINES = ["BIGROCK_VEC3_TYPE %s" % env['vector3_type']])
else:
env.Append(CPPDEFINES = ["BIGROCK_VEC3_TYPE long double"])


This works fine on Windows 10, but when I try to compile on OSX, I get the following error:



In file included from src/octree.cpp:1:
In file included from src/octree.h:5:
src/vector3.h:15:9: error: expected member name or ';' after declaration specifiers
BIGROCK_VEC3_TYPE x, y, z;
^~~~~~~~~~~~~~~~~
<command line>:1:33: note: expanded from here
#define BIGROCK_VEC3_TYPE float 1
~~~~~ ^


Either scons or g++ is adding an extra '1' to the end of my macro, causing the rest of my code to break.



When I print env['vector3_type'] in scons, it doesn't have a 1 attached. I have no idea where this 1 is being added.










share|improve this question
















I have a command line argument that defines the type to use for a Vector3 class. It is defined in the SConstruct file as follows:



EnumVariable('vector3_type', 'The type to use for Vector3's xyz coordinates', 'float', allowed_values=['float', 'double', 'long_double'], ignorecase=2)


This variable is added to the environment here:



if env['vector3_type'] != 'long_double':
env.Append(CPPDEFINES = ["BIGROCK_VEC3_TYPE %s" % env['vector3_type']])
else:
env.Append(CPPDEFINES = ["BIGROCK_VEC3_TYPE long double"])


This works fine on Windows 10, but when I try to compile on OSX, I get the following error:



In file included from src/octree.cpp:1:
In file included from src/octree.h:5:
src/vector3.h:15:9: error: expected member name or ';' after declaration specifiers
BIGROCK_VEC3_TYPE x, y, z;
^~~~~~~~~~~~~~~~~
<command line>:1:33: note: expanded from here
#define BIGROCK_VEC3_TYPE float 1
~~~~~ ^


Either scons or g++ is adding an extra '1' to the end of my macro, causing the rest of my code to break.



When I print env['vector3_type'] in scons, it doesn't have a 1 attached. I have no idea where this 1 is being added.







c++ macos g++ scons






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Jan 1 at 0:47







TGRCDev

















asked Jan 1 at 0:37









TGRCDevTGRCDev

264




264













  • Please mark your answer as the answer so this doesn't show up as unanswered.

    – bdbaddog
    Jan 1 at 22:52






  • 1





    StackOverflow says I have to wait until tomorrow to accept my own answer, sorry

    – TGRCDev
    Jan 1 at 23:31



















  • Please mark your answer as the answer so this doesn't show up as unanswered.

    – bdbaddog
    Jan 1 at 22:52






  • 1





    StackOverflow says I have to wait until tomorrow to accept my own answer, sorry

    – TGRCDev
    Jan 1 at 23:31

















Please mark your answer as the answer so this doesn't show up as unanswered.

– bdbaddog
Jan 1 at 22:52





Please mark your answer as the answer so this doesn't show up as unanswered.

– bdbaddog
Jan 1 at 22:52




1




1





StackOverflow says I have to wait until tomorrow to accept my own answer, sorry

– TGRCDev
Jan 1 at 23:31





StackOverflow says I have to wait until tomorrow to accept my own answer, sorry

– TGRCDev
Jan 1 at 23:31












1 Answer
1






active

oldest

votes


















1














This makes me feel a bit foolish. Scons assumes that a lone string within CPPDEFINES is a flag name, and will append 1 to it for #ifdef and #ifndef directives. The proper way to pass this #define is:



if env['vector3_type'] != 'long_double':
env.Append(CPPDEFINES = [("BIGROCK_VEC3_TYPE", env['vector3_type'])])
else:
env.Append(CPPDEFINES = [("BIGROCK_VEC3_TYPE", "long double")])





share|improve this answer























    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53992347%2fscons-appending-a-random-1-to-macro-definition-on-osx-only%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    1














    This makes me feel a bit foolish. Scons assumes that a lone string within CPPDEFINES is a flag name, and will append 1 to it for #ifdef and #ifndef directives. The proper way to pass this #define is:



    if env['vector3_type'] != 'long_double':
    env.Append(CPPDEFINES = [("BIGROCK_VEC3_TYPE", env['vector3_type'])])
    else:
    env.Append(CPPDEFINES = [("BIGROCK_VEC3_TYPE", "long double")])





    share|improve this answer




























      1














      This makes me feel a bit foolish. Scons assumes that a lone string within CPPDEFINES is a flag name, and will append 1 to it for #ifdef and #ifndef directives. The proper way to pass this #define is:



      if env['vector3_type'] != 'long_double':
      env.Append(CPPDEFINES = [("BIGROCK_VEC3_TYPE", env['vector3_type'])])
      else:
      env.Append(CPPDEFINES = [("BIGROCK_VEC3_TYPE", "long double")])





      share|improve this answer


























        1












        1








        1







        This makes me feel a bit foolish. Scons assumes that a lone string within CPPDEFINES is a flag name, and will append 1 to it for #ifdef and #ifndef directives. The proper way to pass this #define is:



        if env['vector3_type'] != 'long_double':
        env.Append(CPPDEFINES = [("BIGROCK_VEC3_TYPE", env['vector3_type'])])
        else:
        env.Append(CPPDEFINES = [("BIGROCK_VEC3_TYPE", "long double")])





        share|improve this answer













        This makes me feel a bit foolish. Scons assumes that a lone string within CPPDEFINES is a flag name, and will append 1 to it for #ifdef and #ifndef directives. The proper way to pass this #define is:



        if env['vector3_type'] != 'long_double':
        env.Append(CPPDEFINES = [("BIGROCK_VEC3_TYPE", env['vector3_type'])])
        else:
        env.Append(CPPDEFINES = [("BIGROCK_VEC3_TYPE", "long double")])






        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Jan 1 at 20:20









        TGRCDevTGRCDev

        264




        264
































            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53992347%2fscons-appending-a-random-1-to-macro-definition-on-osx-only%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            MongoDB - Not Authorized To Execute Command

            Npm cannot find a required file even through it is in the searched directory

            in spring boot 2.1 many test slices are not allowed anymore due to multiple @BootstrapWith