Mixing
RichEditBox not working properly on Dark Theme
0
I am developing an app, which offers Rich Text editing capabilities, with light and dark theme.
When swithing to the dark theme, I am unable to view the text in focus, and any text coloring gets lost when switching focus.
I have created a simple text case that has two rich text boxes, a button to change the selected text to red, and two button to switch between light and dark theme.
I am applying a styling to the rich edit box, but it looks like is ignoring the x:Key="TextControlForegroundFocused", or maybe computing SystemBaseHighColor prior applying the theme cahnges.
XAML
<Page.Resources>
<!-- RichEditBox Styling-->
<SolidColorBrush x:Key="TextControlForegroundFocused" Color="{ThemeResource SystemBaseHighColor}"/>
<SolidColorBrush x:Key="TextControlForegroundDisabled" Color="{ThemeResource SystemBaseHighColor}"/>
<SolidColorBrush x:Key="TextControlBackgroundFocused" Color="{ThemeResource TextControlForeground}"/>
</Page.Resources>
<StackPanel Name="_Root" >
<StackPanel Orientation="Horizontal" >
<Button Content="Red" Click="OnRed"/>
<Button Content="Dark Theme" Click="OnDark"/>
<Button Content="Light Theme" Click="OnLight"/>
</StackPanel>
<StackPanel Orientation="Horizontal">
<RichEditBox Name="RichEditor1" Style="{ThemeResource EditBoxStyle}" Width="250" Height="200"/>
<RichEditBox Name="RichEditor2" Style="{ThemeResource EditBoxStyle}" Width="250" Height="200"/>
</StackPanel>
</StackPanel>
C#
private void OnRed(object sender, RoutedEventArgs e)
{
RichEditor1.Document.Selection.CharacterFormat.ForegroundColor = Colors.Red;
RichEditor2.Document.Selection.CharacterFormat.ForegroundColor = Colors.Red;
}
private void OnDark(object sender, RoutedEventArgs e)
{
_Root.RequestedTheme = ElementTheme.Dark;
_Root.Background = new SolidColorBrush(Colors.Black);
}
private void OnLight(object sender, RoutedEventArgs e)
{
_Root.RequestedTheme = ElementTheme.Light;
_Root.Background = new SolidColorBrush(Colors.White);
}
Any suggestion on how to make this work?
uwp themes richeditbox
asked Nov 21 '18 at 14:30
ClaudiaWeyClaudiaWey
727
|
show 1 more comment
0
I am developing an app, which offers Rich Text editing capabilities, with light and dark theme.
When swithing to the dark theme, I am unable to view the text in focus, and any text coloring gets lost when switching focus.
I have created a simple text case that has two rich text boxes, a button to change the selected text to red, and two button to switch between light and dark theme.
I am applying a styling to the rich edit box, but it looks like is ignoring the x:Key="TextControlForegroundFocused", or maybe computing SystemBaseHighColor prior applying the theme cahnges.
XAML
<Page.Resources>
<!-- RichEditBox Styling-->
<SolidColorBrush x:Key="TextControlForegroundFocused" Color="{ThemeResource SystemBaseHighColor}"/>
<SolidColorBrush x:Key="TextControlForegroundDisabled" Color="{ThemeResource SystemBaseHighColor}"/>
<SolidColorBrush x:Key="TextControlBackgroundFocused" Color="{ThemeResource TextControlForeground}"/>
</Page.Resources>
<StackPanel Name="_Root" >
<StackPanel Orientation="Horizontal" >
<Button Content="Red" Click="OnRed"/>
<Button Content="Dark Theme" Click="OnDark"/>
<Button Content="Light Theme" Click="OnLight"/>
</StackPanel>
<StackPanel Orientation="Horizontal">
<RichEditBox Name="RichEditor1" Style="{ThemeResource EditBoxStyle}" Width="250" Height="200"/>
<RichEditBox Name="RichEditor2" Style="{ThemeResource EditBoxStyle}" Width="250" Height="200"/>
</StackPanel>
</StackPanel>
C#
private void OnRed(object sender, RoutedEventArgs e)
{
RichEditor1.Document.Selection.CharacterFormat.ForegroundColor = Colors.Red;
RichEditor2.Document.Selection.CharacterFormat.ForegroundColor = Colors.Red;
}
private void OnDark(object sender, RoutedEventArgs e)
{
_Root.RequestedTheme = ElementTheme.Dark;
_Root.Background = new SolidColorBrush(Colors.Black);
}
private void OnLight(object sender, RoutedEventArgs e)
{
_Root.RequestedTheme = ElementTheme.Light;
_Root.Background = new SolidColorBrush(Colors.White);
}
Any suggestion on how to make this work?
uwp themes richeditbox
asked Nov 21 '18 at 14:30
ClaudiaWeyClaudiaWey
727
'unable to view the text in focus' It's because you set _Root.Background to black and rewrite the 'TextControlForegroundFocused' to 'SystemBaseHighColor'. When you switch to 'Dark', they're all black. That's why you cannot see the text in focus.
– Xavier Xie - MSFT
Nov 23 '18 at 6:00
'text coloring gets lost when switching focus.' I could reproduce this question, I've reported to the relevant team, they're investigating it.
– Xavier Xie - MSFT
Nov 23 '18 at 6:01
SystemBaseHighColor suppose to be white (#FFFFFFFF) when the theme is Dark. So TextControlForegroundFocused should be visible on the black background, but it is not. Looks to me like the value of SystemBaseHighColor is not computed based on the current Dark theme. Even if I remove the overwriting style for TextControlForegroundFocused, the text is not visible when in focus. Would you have a suggestion on how to change the code to make it work when switching the theme?
– ClaudiaWey
Nov 23 '18 at 15:44
Actually it looks like any setting for TextControlForegroundFocused is ignored.
– ClaudiaWey
Nov 23 '18 at 16:19
I removed all your custom style for the RicheditBox, when RicheditBox get focused, the foreground will be changed to white, I can see the text. See Screenshot
– Xavier Xie - MSFT
Nov 26 '18 at 2:23
|
show 1 more comment
0
0
0
I am developing an app, which offers Rich Text editing capabilities, with light and dark theme.
When swithing to the dark theme, I am unable to view the text in focus, and any text coloring gets lost when switching focus.
I have created a simple text case that has two rich text boxes, a button to change the selected text to red, and two button to switch between light and dark theme.
I am applying a styling to the rich edit box, but it looks like is ignoring the x:Key="TextControlForegroundFocused", or maybe computing SystemBaseHighColor prior applying the theme cahnges.
XAML
<Page.Resources>
<!-- RichEditBox Styling-->
<SolidColorBrush x:Key="TextControlForegroundFocused" Color="{ThemeResource SystemBaseHighColor}"/>
<SolidColorBrush x:Key="TextControlForegroundDisabled" Color="{ThemeResource SystemBaseHighColor}"/>
<SolidColorBrush x:Key="TextControlBackgroundFocused" Color="{ThemeResource TextControlForeground}"/>
</Page.Resources>
<StackPanel Name="_Root" >
<StackPanel Orientation="Horizontal" >
<Button Content="Red" Click="OnRed"/>
<Button Content="Dark Theme" Click="OnDark"/>
<Button Content="Light Theme" Click="OnLight"/>
</StackPanel>
<StackPanel Orientation="Horizontal">
<RichEditBox Name="RichEditor1" Style="{ThemeResource EditBoxStyle}" Width="250" Height="200"/>
<RichEditBox Name="RichEditor2" Style="{ThemeResource EditBoxStyle}" Width="250" Height="200"/>
</StackPanel>
</StackPanel>
C#
private void OnRed(object sender, RoutedEventArgs e)
{
RichEditor1.Document.Selection.CharacterFormat.ForegroundColor = Colors.Red;
RichEditor2.Document.Selection.CharacterFormat.ForegroundColor = Colors.Red;
}
private void OnDark(object sender, RoutedEventArgs e)
{
_Root.RequestedTheme = ElementTheme.Dark;
_Root.Background = new SolidColorBrush(Colors.Black);
}
private void OnLight(object sender, RoutedEventArgs e)
{
_Root.RequestedTheme = ElementTheme.Light;
_Root.Background = new SolidColorBrush(Colors.White);
}
Any suggestion on how to make this work?
uwp themes richeditbox
asked Nov 21 '18 at 14:30
ClaudiaWeyClaudiaWey
727
I am developing an app, which offers Rich Text editing capabilities, with light and dark theme.
When swithing to the dark theme, I am unable to view the text in focus, and any text coloring gets lost when switching focus.
I have created a simple text case that has two rich text boxes, a button to change the selected text to red, and two button to switch between light and dark theme.
I am applying a styling to the rich edit box, but it looks like is ignoring the x:Key="TextControlForegroundFocused", or maybe computing SystemBaseHighColor prior applying the theme cahnges.
XAML
<Page.Resources>
<!-- RichEditBox Styling-->
<SolidColorBrush x:Key="TextControlForegroundFocused" Color="{ThemeResource SystemBaseHighColor}"/>
<SolidColorBrush x:Key="TextControlForegroundDisabled" Color="{ThemeResource SystemBaseHighColor}"/>
<SolidColorBrush x:Key="TextControlBackgroundFocused" Color="{ThemeResource TextControlForeground}"/>
</Page.Resources>
<StackPanel Name="_Root" >
<StackPanel Orientation="Horizontal" >
<Button Content="Red" Click="OnRed"/>
<Button Content="Dark Theme" Click="OnDark"/>
<Button Content="Light Theme" Click="OnLight"/>
</StackPanel>
<StackPanel Orientation="Horizontal">
<RichEditBox Name="RichEditor1" Style="{ThemeResource EditBoxStyle}" Width="250" Height="200"/>
<RichEditBox Name="RichEditor2" Style="{ThemeResource EditBoxStyle}" Width="250" Height="200"/>
</StackPanel>
</StackPanel>
C#
private void OnRed(object sender, RoutedEventArgs e)
{
RichEditor1.Document.Selection.CharacterFormat.ForegroundColor = Colors.Red;
RichEditor2.Document.Selection.CharacterFormat.ForegroundColor = Colors.Red;
}
private void OnDark(object sender, RoutedEventArgs e)
{
_Root.RequestedTheme = ElementTheme.Dark;
_Root.Background = new SolidColorBrush(Colors.Black);
}
private void OnLight(object sender, RoutedEventArgs e)
{
_Root.RequestedTheme = ElementTheme.Light;
_Root.Background = new SolidColorBrush(Colors.White);
}
Any suggestion on how to make this work?
uwp themes richeditbox
uwp themes richeditbox
asked Nov 21 '18 at 14:30
ClaudiaWeyClaudiaWey
727
asked Nov 21 '18 at 14:30
ClaudiaWeyClaudiaWey
727
asked Nov 21 '18 at 14:30
ClaudiaWeyClaudiaWey
727
asked Nov 21 '18 at 14:30
ClaudiaWeyClaudiaWey
727
asked Nov 21 '18 at 14:30
ClaudiaWeyClaudiaWey
727
727
'unable to view the text in focus' It's because you set _Root.Background to black and rewrite the 'TextControlForegroundFocused' to 'SystemBaseHighColor'. When you switch to 'Dark', they're all black. That's why you cannot see the text in focus.
– Xavier Xie - MSFT
Nov 23 '18 at 6:00
'text coloring gets lost when switching focus.' I could reproduce this question, I've reported to the relevant team, they're investigating it.
– Xavier Xie - MSFT
Nov 23 '18 at 6:01
SystemBaseHighColor suppose to be white (#FFFFFFFF) when the theme is Dark. So TextControlForegroundFocused should be visible on the black background, but it is not. Looks to me like the value of SystemBaseHighColor is not computed based on the current Dark theme. Even if I remove the overwriting style for TextControlForegroundFocused, the text is not visible when in focus. Would you have a suggestion on how to change the code to make it work when switching the theme?
– ClaudiaWey
Nov 23 '18 at 15:44
Actually it looks like any setting for TextControlForegroundFocused is ignored.
– ClaudiaWey
Nov 23 '18 at 16:19
I removed all your custom style for the RicheditBox, when RicheditBox get focused, the foreground will be changed to white, I can see the text. See Screenshot
– Xavier Xie - MSFT
Nov 26 '18 at 2:23
|
show 1 more comment
'unable to view the text in focus' It's because you set _Root.Background to black and rewrite the 'TextControlForegroundFocused' to 'SystemBaseHighColor'. When you switch to 'Dark', they're all black. That's why you cannot see the text in focus.
– Xavier Xie - MSFT
Nov 23 '18 at 6:00
'text coloring gets lost when switching focus.' I could reproduce this question, I've reported to the relevant team, they're investigating it.
– Xavier Xie - MSFT
Nov 23 '18 at 6:01
SystemBaseHighColor suppose to be white (#FFFFFFFF) when the theme is Dark. So TextControlForegroundFocused should be visible on the black background, but it is not. Looks to me like the value of SystemBaseHighColor is not computed based on the current Dark theme. Even if I remove the overwriting style for TextControlForegroundFocused, the text is not visible when in focus. Would you have a suggestion on how to change the code to make it work when switching the theme?
– ClaudiaWey
Nov 23 '18 at 15:44
Actually it looks like any setting for TextControlForegroundFocused is ignored.
– ClaudiaWey
Nov 23 '18 at 16:19
I removed all your custom style for the RicheditBox, when RicheditBox get focused, the foreground will be changed to white, I can see the text. See Screenshot
– Xavier Xie - MSFT
Nov 26 '18 at 2:23
'unable to view the text in focus' It's because you set _Root.Background to black and rewrite the 'TextControlForegroundFocused' to 'SystemBaseHighColor'. When you switch to 'Dark', they're all black. That's why you cannot see the text in focus.
– Xavier Xie - MSFT
Nov 23 '18 at 6:00
'unable to view the text in focus' It's because you set _Root.Background to black and rewrite the 'TextControlForegroundFocused' to 'SystemBaseHighColor'. When you switch to 'Dark', they're all black. That's why you cannot see the text in focus.
– Xavier Xie - MSFT
Nov 23 '18 at 6:00
'text coloring gets lost when switching focus.' I could reproduce this question, I've reported to the relevant team, they're investigating it.
– Xavier Xie - MSFT
Nov 23 '18 at 6:01
'text coloring gets lost when switching focus.' I could reproduce this question, I've reported to the relevant team, they're investigating it.
– Xavier Xie - MSFT
Nov 23 '18 at 6:01
SystemBaseHighColor suppose to be white (#FFFFFFFF) when the theme is Dark. So TextControlForegroundFocused should be visible on the black background, but it is not. Looks to me like the value of SystemBaseHighColor is not computed based on the current Dark theme. Even if I remove the overwriting style for TextControlForegroundFocused, the text is not visible when in focus. Would you have a suggestion on how to change the code to make it work when switching the theme?
– ClaudiaWey
Nov 23 '18 at 15:44
SystemBaseHighColor suppose to be white (#FFFFFFFF) when the theme is Dark. So TextControlForegroundFocused should be visible on the black background, but it is not. Looks to me like the value of SystemBaseHighColor is not computed based on the current Dark theme. Even if I remove the overwriting style for TextControlForegroundFocused, the text is not visible when in focus. Would you have a suggestion on how to change the code to make it work when switching the theme?
– ClaudiaWey
Nov 23 '18 at 15:44
Actually it looks like any setting for TextControlForegroundFocused is ignored.
– ClaudiaWey
Nov 23 '18 at 16:19
Actually it looks like any setting for TextControlForegroundFocused is ignored.
– ClaudiaWey
Nov 23 '18 at 16:19
I removed all your custom style for the RicheditBox, when RicheditBox get focused, the foreground will be changed to white, I can see the text. See Screenshot
– Xavier Xie - MSFT
Nov 26 '18 at 2:23
I removed all your custom style for the RicheditBox, when RicheditBox get focused, the foreground will be changed to white, I can see the text. See Screenshot
– Xavier Xie - MSFT
Nov 26 '18 at 2:23
|
show 1 more comment
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53414318%2fricheditbox-not-working-properly-on-dark-theme%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53414318%2fricheditbox-not-working-properly-on-dark-theme%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
'unable to view the text in focus' It's because you set _Root.Background to black and rewrite the 'TextControlForegroundFocused' to 'SystemBaseHighColor'. When you switch to 'Dark', they're all black. That's why you cannot see the text in focus.
– Xavier Xie - MSFT
Nov 23 '18 at 6:00
'text coloring gets lost when switching focus.' I could reproduce this question, I've reported to the relevant team, they're investigating it.
– Xavier Xie - MSFT
Nov 23 '18 at 6:01
SystemBaseHighColor suppose to be white (#FFFFFFFF) when the theme is Dark. So TextControlForegroundFocused should be visible on the black background, but it is not. Looks to me like the value of SystemBaseHighColor is not computed based on the current Dark theme. Even if I remove the overwriting style for TextControlForegroundFocused, the text is not visible when in focus. Would you have a suggestion on how to change the code to make it work when switching the theme?
– ClaudiaWey
Nov 23 '18 at 15:44
Actually it looks like any setting for TextControlForegroundFocused is ignored.
– ClaudiaWey
Nov 23 '18 at 16:19
I removed all your custom style for the RicheditBox, when RicheditBox get focused, the foreground will be changed to white, I can see the text. See Screenshot
– Xavier Xie - MSFT
Nov 26 '18 at 2:23