Javascript + Firebase blog addpost function firstId returns undefined












0















I am creating a blog with Js and Firebase. When I add the posts to the firebase database the first one's Id is undefined then in starts increasing from myid-0.
Here is my code:



<button onclick="writeUserData(document.getElementById('blog-title').value, document.getElementById('blog-content').value, uniqueId(uniqueId))">Add</button>


...........



function uniqueId(uniqueId) {
var counter = 0;
window.uniqueId = function(){
return ('myid-' + counter++);
}
}

function writeUserData(title, content, postID) {
firebase.database().ref('posts/' + postID).set({
title: title,
content: content
});
}


Why is it not starting to add the post from myid-0?










share|improve this question





























    0















    I am creating a blog with Js and Firebase. When I add the posts to the firebase database the first one's Id is undefined then in starts increasing from myid-0.
    Here is my code:



    <button onclick="writeUserData(document.getElementById('blog-title').value, document.getElementById('blog-content').value, uniqueId(uniqueId))">Add</button>


    ...........



    function uniqueId(uniqueId) {
    var counter = 0;
    window.uniqueId = function(){
    return ('myid-' + counter++);
    }
    }

    function writeUserData(title, content, postID) {
    firebase.database().ref('posts/' + postID).set({
    title: title,
    content: content
    });
    }


    Why is it not starting to add the post from myid-0?










    share|improve this question



























      0












      0








      0








      I am creating a blog with Js and Firebase. When I add the posts to the firebase database the first one's Id is undefined then in starts increasing from myid-0.
      Here is my code:



      <button onclick="writeUserData(document.getElementById('blog-title').value, document.getElementById('blog-content').value, uniqueId(uniqueId))">Add</button>


      ...........



      function uniqueId(uniqueId) {
      var counter = 0;
      window.uniqueId = function(){
      return ('myid-' + counter++);
      }
      }

      function writeUserData(title, content, postID) {
      firebase.database().ref('posts/' + postID).set({
      title: title,
      content: content
      });
      }


      Why is it not starting to add the post from myid-0?










      share|improve this question
















      I am creating a blog with Js and Firebase. When I add the posts to the firebase database the first one's Id is undefined then in starts increasing from myid-0.
      Here is my code:



      <button onclick="writeUserData(document.getElementById('blog-title').value, document.getElementById('blog-content').value, uniqueId(uniqueId))">Add</button>


      ...........



      function uniqueId(uniqueId) {
      var counter = 0;
      window.uniqueId = function(){
      return ('myid-' + counter++);
      }
      }

      function writeUserData(title, content, postID) {
      firebase.database().ref('posts/' + postID).set({
      title: title,
      content: content
      });
      }


      Why is it not starting to add the post from myid-0?







      javascript firebase firebase-realtime-database






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 22 '18 at 0:41









      Frank van Puffelen

      237k29382408




      237k29382408










      asked Nov 21 '18 at 23:32









      Gabriella CsernusGabriella Csernus

      5210




      5210
























          1 Answer
          1






          active

          oldest

          votes


















          1














          This is because your function uniqueId() is not correct. You can see it by having a button in your page with the following code:



          <input
          id="clickMe"
          type="button"
          value="clickme"
          onclick="console.log(uniqueId());"
          />


          So if you change your function to something like the following it will work:



          var counter = 0;
          function uniqueId() {
          return 'myid-' + counter++;
          }

          function writeUserData(title, content, postID) {
          firebase.database().ref('posts/' + postID).set({
          title: title,
          content: content
          });
          }


          ......



          <button onclick="writeUserData(document.getElementById('blog-title').value, document.getElementById('blog-content').value, uniqueId())">Add</button>




          Note however that you can let Firebase generating the UniqueIds, see https://firebase.google.com/docs/reference/js/firebase.database.Reference#push






          share|improve this answer


























          • It works! Thanks a lot!

            – Gabriella Csernus
            Nov 22 '18 at 10:26






          • 1





            You are welcome. Note that you can let Firebase generating the Unique Ids, see firebase.google.com/docs/reference/js/…

            – Renaud Tarnec
            Nov 22 '18 at 10:45











          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53421915%2fjavascript-firebase-blog-addpost-function-firstid-returns-undefined%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          1 Answer
          1






          active

          oldest

          votes








          1 Answer
          1






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes









          1














          This is because your function uniqueId() is not correct. You can see it by having a button in your page with the following code:



          <input
          id="clickMe"
          type="button"
          value="clickme"
          onclick="console.log(uniqueId());"
          />


          So if you change your function to something like the following it will work:



          var counter = 0;
          function uniqueId() {
          return 'myid-' + counter++;
          }

          function writeUserData(title, content, postID) {
          firebase.database().ref('posts/' + postID).set({
          title: title,
          content: content
          });
          }


          ......



          <button onclick="writeUserData(document.getElementById('blog-title').value, document.getElementById('blog-content').value, uniqueId())">Add</button>




          Note however that you can let Firebase generating the UniqueIds, see https://firebase.google.com/docs/reference/js/firebase.database.Reference#push






          share|improve this answer


























          • It works! Thanks a lot!

            – Gabriella Csernus
            Nov 22 '18 at 10:26






          • 1





            You are welcome. Note that you can let Firebase generating the Unique Ids, see firebase.google.com/docs/reference/js/…

            – Renaud Tarnec
            Nov 22 '18 at 10:45
















          1














          This is because your function uniqueId() is not correct. You can see it by having a button in your page with the following code:



          <input
          id="clickMe"
          type="button"
          value="clickme"
          onclick="console.log(uniqueId());"
          />


          So if you change your function to something like the following it will work:



          var counter = 0;
          function uniqueId() {
          return 'myid-' + counter++;
          }

          function writeUserData(title, content, postID) {
          firebase.database().ref('posts/' + postID).set({
          title: title,
          content: content
          });
          }


          ......



          <button onclick="writeUserData(document.getElementById('blog-title').value, document.getElementById('blog-content').value, uniqueId())">Add</button>




          Note however that you can let Firebase generating the UniqueIds, see https://firebase.google.com/docs/reference/js/firebase.database.Reference#push






          share|improve this answer


























          • It works! Thanks a lot!

            – Gabriella Csernus
            Nov 22 '18 at 10:26






          • 1





            You are welcome. Note that you can let Firebase generating the Unique Ids, see firebase.google.com/docs/reference/js/…

            – Renaud Tarnec
            Nov 22 '18 at 10:45














          1












          1








          1







          This is because your function uniqueId() is not correct. You can see it by having a button in your page with the following code:



          <input
          id="clickMe"
          type="button"
          value="clickme"
          onclick="console.log(uniqueId());"
          />


          So if you change your function to something like the following it will work:



          var counter = 0;
          function uniqueId() {
          return 'myid-' + counter++;
          }

          function writeUserData(title, content, postID) {
          firebase.database().ref('posts/' + postID).set({
          title: title,
          content: content
          });
          }


          ......



          <button onclick="writeUserData(document.getElementById('blog-title').value, document.getElementById('blog-content').value, uniqueId())">Add</button>




          Note however that you can let Firebase generating the UniqueIds, see https://firebase.google.com/docs/reference/js/firebase.database.Reference#push






          share|improve this answer















          This is because your function uniqueId() is not correct. You can see it by having a button in your page with the following code:



          <input
          id="clickMe"
          type="button"
          value="clickme"
          onclick="console.log(uniqueId());"
          />


          So if you change your function to something like the following it will work:



          var counter = 0;
          function uniqueId() {
          return 'myid-' + counter++;
          }

          function writeUserData(title, content, postID) {
          firebase.database().ref('posts/' + postID).set({
          title: title,
          content: content
          });
          }


          ......



          <button onclick="writeUserData(document.getElementById('blog-title').value, document.getElementById('blog-content').value, uniqueId())">Add</button>




          Note however that you can let Firebase generating the UniqueIds, see https://firebase.google.com/docs/reference/js/firebase.database.Reference#push







          share|improve this answer














          share|improve this answer



          share|improve this answer








          edited Nov 22 '18 at 10:56

























          answered Nov 22 '18 at 8:19









          Renaud TarnecRenaud Tarnec

          11.6k21531




          11.6k21531













          • It works! Thanks a lot!

            – Gabriella Csernus
            Nov 22 '18 at 10:26






          • 1





            You are welcome. Note that you can let Firebase generating the Unique Ids, see firebase.google.com/docs/reference/js/…

            – Renaud Tarnec
            Nov 22 '18 at 10:45



















          • It works! Thanks a lot!

            – Gabriella Csernus
            Nov 22 '18 at 10:26






          • 1





            You are welcome. Note that you can let Firebase generating the Unique Ids, see firebase.google.com/docs/reference/js/…

            – Renaud Tarnec
            Nov 22 '18 at 10:45

















          It works! Thanks a lot!

          – Gabriella Csernus
          Nov 22 '18 at 10:26





          It works! Thanks a lot!

          – Gabriella Csernus
          Nov 22 '18 at 10:26




          1




          1





          You are welcome. Note that you can let Firebase generating the Unique Ids, see firebase.google.com/docs/reference/js/…

          – Renaud Tarnec
          Nov 22 '18 at 10:45





          You are welcome. Note that you can let Firebase generating the Unique Ids, see firebase.google.com/docs/reference/js/…

          – Renaud Tarnec
          Nov 22 '18 at 10:45




















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Stack Overflow!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53421915%2fjavascript-firebase-blog-addpost-function-firstid-returns-undefined%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          'app-layout' is not a known element: how to share Component with different Modules

          android studio warns about leanback feature tag usage required on manifest while using Unity exported app?

          WPF add header to Image with URL pettitions [duplicate]