Mixing
Cannot read property 'firstname' of undefined in view engine node js
0
I am trying to display json data on a website using view engine (ejs) but I am facing following error Cannot read property 'firstname' of undefined
this is my program
node.js
io.readEmp().then(function(data){
res.render('Dashboard',{data:data});
}).catch(function(err){console.log(err.message);});
index.ejs
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data.key.firstname %></li><%}%>
</ul>
jsonfile
{
"id01":{"firstname":"abc","lastname":"xy"},
"id02":{"firstname":"pqr","lastname":"xy"}
}
error
Cannot read property 'firstname' of undefined
node.js json ejs viewengine
asked Jan 2 at 18:28
Dhruvin modiDhruvin modi
4519
add a comment |
0
I am trying to display json data on a website using view engine (ejs) but I am facing following error Cannot read property 'firstname' of undefined
this is my program
node.js
io.readEmp().then(function(data){
res.render('Dashboard',{data:data});
}).catch(function(err){console.log(err.message);});
index.ejs
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data.key.firstname %></li><%}%>
</ul>
jsonfile
{
"id01":{"firstname":"abc","lastname":"xy"},
"id02":{"firstname":"pqr","lastname":"xy"}
}
error
Cannot read property 'firstname' of undefined
node.js json ejs viewengine
asked Jan 2 at 18:28
Dhruvin modiDhruvin modi
4519
add a comment |
0
0
0
I am trying to display json data on a website using view engine (ejs) but I am facing following error Cannot read property 'firstname' of undefined
this is my program
node.js
io.readEmp().then(function(data){
res.render('Dashboard',{data:data});
}).catch(function(err){console.log(err.message);});
index.ejs
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data.key.firstname %></li><%}%>
</ul>
jsonfile
{
"id01":{"firstname":"abc","lastname":"xy"},
"id02":{"firstname":"pqr","lastname":"xy"}
}
error
Cannot read property 'firstname' of undefined
node.js json ejs viewengine
asked Jan 2 at 18:28
Dhruvin modiDhruvin modi
4519
I am trying to display json data on a website using view engine (ejs) but I am facing following error Cannot read property 'firstname' of undefined
this is my program
node.js
io.readEmp().then(function(data){
res.render('Dashboard',{data:data});
}).catch(function(err){console.log(err.message);});
index.ejs
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data.key.firstname %></li><%}%>
</ul>
jsonfile
{
"id01":{"firstname":"abc","lastname":"xy"},
"id02":{"firstname":"pqr","lastname":"xy"}
}
error
Cannot read property 'firstname' of undefined
node.js json ejs viewengine
node.js json ejs viewengine
asked Jan 2 at 18:28
Dhruvin modiDhruvin modi
4519
asked Jan 2 at 18:28
Dhruvin modiDhruvin modi
4519
asked Jan 2 at 18:28
Dhruvin modiDhruvin modi
4519
asked Jan 2 at 18:28
Dhruvin modiDhruvin modi
4519
asked Jan 2 at 18:28
Dhruvin modiDhruvin modi
4519
4519
add a comment |
add a comment |
3 Answers
3
active
oldest
votes
0
If you have data as an object like you display then 'key' will be the item key and you need to use the key access notation for an object thusly:
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data[key].firstname %></li><%}%>
</ul>
'key' for the first item will be "id01", so this is equivalent (on the first pass) for saying data.id01.firstname.
answered Jan 2 at 19:03
PaulPaul
26.9k86294
oh right, thanks alot..!
– Dhruvin modi
Jan 2 at 19:09
Please, reread my solution. I have given a more detailed example showing what I meant about this not being the proper way of handling a hashmap example
– Moosecouture
Jan 2 at 19:51
@Moosecouture that's a matter of opinion; in cases where the OP is generating their own data the risk you present is extremely small to nonexistent, and there can be equally good reasons for maintaining the object structure rather than switching it to an array.
– Paul
Jan 2 at 20:28
Hence, why I presented a maintainable DRY code that does not look like thisdata[key].firstnameand instead makes it look DRYperson.firstname
– Moosecouture
Jan 2 at 20:30
Coding is all opinion. Writing something like this will likely make it very hard to get hired in a modern company though. Hence, Object.values or Object.entities if you need the ID of the hashmap for a link. Just be careful out there. Hashmaps are a great way of preventing duplicates but they have their limits. Iteration and size are two major reasons for not being in a practice of doing data[key].some[innerKey].somemore[inneInnerKey]
– Moosecouture
Jan 2 at 21:07
add a comment |
0
Like I was trying to say earlier. Turning an Object into an array is better. Because if you are using a hashMap structure these can be deeply nested. Example being an object like the below
{"id01":{
"address": {
"street": "123 Main St",
"city": "San Francisco",
"state": "CA"
},
"dogs": {
"spot": {
"type": "German Shepherd",
"foods": {
"soft" : {
"Purina": "Cat Chow"
},
"unconventional": {
"vomit": "Vomit",
"squirrels" : "Squirrels"
}
}
},
"spike": {
"type": "Doberman"
}
}
}}
will result in something looking like this using the method suggested.
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data[key].firstname %></li>
<li class="list-group-item"><%= data[key].address.street %></li>
<li class="list-group-item"><%= data[key].address.city %></li>
<li class="list-group-item"><%= data[key].address.state %></li>
<li>
<ul>
<% for(var dogKey in data[key].dogs){%>
<li class="list-group-item"><%= data[key].dogs[dogKey].type %></li>
<li>
<ul>
<% for(var dogFoodKey in data[key].dogs[dogKey].foods){%>
<li class="list-group-item"><%= data[key].dogs[dogKey].foods[dogFoodKey]. %></li>
<%}%>
</ul>
</li>
<%}%>
</ul>
</li>
<%}%>
</ul>
It is terribly untidy. It needs a serious refactoring. As a practice you should not repeat yourself.
Instead, I would suggest the following which re-writes the object into an array as it receives it.
<ul class="list-group list-group-flush">
<% for(var person in Object.values(data)){%>
<li class="list-group-item"><%= person.firstname %></li>
<li class="list-group-item"><%= person.address.street %></li>
<li class="list-group-item"><%= person.address.city %></li>
<li class="list-group-item"><%= person.address.state %></li>
<li>
<ul>
<% for(var dog in person.dogs){%>
<li class="list-group-item"><%= dog.type %></li>
<li>
<ul>
<% for(var food of Object.values(dog.foods)){%>
<li class="list-group-item"><%= food %></li>
<%}%>
</ul>
</li>
<%}%>
</ul>
</li>
<%}%>
</ul>
answered Jan 2 at 18:42
MoosecoutureMoosecouture
30818
yup error is gone but the values(i.e abc & pqr) are not displaying on site.
– Dhruvin modi
Jan 2 at 18:51
He should not have to transform his JSON data to make this work.
– Paul
Jan 2 at 19:03
nope, it is still in object form. let me try...and I also want to know the reason behind.
– Dhruvin modi
Jan 2 at 19:05
You should as a practice, use arrays either at runtime or compile and search because it results in better code when iterating. Please check out my updated post that goes into more detail as to why you should have this going through as an array either in the JSON file or when using your template engine.
– Moosecouture
Jan 2 at 20:00
add a comment |
-1
you need to make few changes as below in your index.ejs file
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item">
<%= key.firstname %>
</li>
<%}%>
</ul>
Note: you have to use key.firstname and not data.key.firstname
answered Jan 2 at 18:57
Aravind Kumar JAravind Kumar J
11
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54011361%2fcannot-read-property-firstname-of-undefined-in-view-engine-node-js%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
3 Answers
3
active
oldest
votes
3 Answers
3
active
oldest
votes
active
oldest
votes
active
oldest
votes
0
If you have data as an object like you display then 'key' will be the item key and you need to use the key access notation for an object thusly:
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data[key].firstname %></li><%}%>
</ul>
'key' for the first item will be "id01", so this is equivalent (on the first pass) for saying data.id01.firstname.
answered Jan 2 at 19:03
PaulPaul
26.9k86294
oh right, thanks alot..!
– Dhruvin modi
Jan 2 at 19:09
Please, reread my solution. I have given a more detailed example showing what I meant about this not being the proper way of handling a hashmap example
– Moosecouture
Jan 2 at 19:51
@Moosecouture that's a matter of opinion; in cases where the OP is generating their own data the risk you present is extremely small to nonexistent, and there can be equally good reasons for maintaining the object structure rather than switching it to an array.
– Paul
Jan 2 at 20:28
Hence, why I presented a maintainable DRY code that does not look like thisdata[key].firstnameand instead makes it look DRYperson.firstname
– Moosecouture
Jan 2 at 20:30
Coding is all opinion. Writing something like this will likely make it very hard to get hired in a modern company though. Hence, Object.values or Object.entities if you need the ID of the hashmap for a link. Just be careful out there. Hashmaps are a great way of preventing duplicates but they have their limits. Iteration and size are two major reasons for not being in a practice of doing data[key].some[innerKey].somemore[inneInnerKey]
– Moosecouture
Jan 2 at 21:07
add a comment |
0
If you have data as an object like you display then 'key' will be the item key and you need to use the key access notation for an object thusly:
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data[key].firstname %></li><%}%>
</ul>
'key' for the first item will be "id01", so this is equivalent (on the first pass) for saying data.id01.firstname.
answered Jan 2 at 19:03
PaulPaul
26.9k86294
oh right, thanks alot..!
– Dhruvin modi
Jan 2 at 19:09
Please, reread my solution. I have given a more detailed example showing what I meant about this not being the proper way of handling a hashmap example
– Moosecouture
Jan 2 at 19:51
@Moosecouture that's a matter of opinion; in cases where the OP is generating their own data the risk you present is extremely small to nonexistent, and there can be equally good reasons for maintaining the object structure rather than switching it to an array.
– Paul
Jan 2 at 20:28
Hence, why I presented a maintainable DRY code that does not look like thisdata[key].firstnameand instead makes it look DRYperson.firstname
– Moosecouture
Jan 2 at 20:30
Coding is all opinion. Writing something like this will likely make it very hard to get hired in a modern company though. Hence, Object.values or Object.entities if you need the ID of the hashmap for a link. Just be careful out there. Hashmaps are a great way of preventing duplicates but they have their limits. Iteration and size are two major reasons for not being in a practice of doing data[key].some[innerKey].somemore[inneInnerKey]
– Moosecouture
Jan 2 at 21:07
add a comment |
0
0
0
If you have data as an object like you display then 'key' will be the item key and you need to use the key access notation for an object thusly:
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data[key].firstname %></li><%}%>
</ul>
'key' for the first item will be "id01", so this is equivalent (on the first pass) for saying data.id01.firstname.
answered Jan 2 at 19:03
PaulPaul
26.9k86294
If you have data as an object like you display then 'key' will be the item key and you need to use the key access notation for an object thusly:
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data[key].firstname %></li><%}%>
</ul>
'key' for the first item will be "id01", so this is equivalent (on the first pass) for saying data.id01.firstname.
answered Jan 2 at 19:03
PaulPaul
26.9k86294
answered Jan 2 at 19:03
PaulPaul
26.9k86294
answered Jan 2 at 19:03
PaulPaul
26.9k86294
answered Jan 2 at 19:03
PaulPaul
26.9k86294
26.9k86294
oh right, thanks alot..!
– Dhruvin modi
Jan 2 at 19:09
Please, reread my solution. I have given a more detailed example showing what I meant about this not being the proper way of handling a hashmap example
– Moosecouture
Jan 2 at 19:51
@Moosecouture that's a matter of opinion; in cases where the OP is generating their own data the risk you present is extremely small to nonexistent, and there can be equally good reasons for maintaining the object structure rather than switching it to an array.
– Paul
Jan 2 at 20:28
Hence, why I presented a maintainable DRY code that does not look like thisdata[key].firstnameand instead makes it look DRYperson.firstname
– Moosecouture
Jan 2 at 20:30
Coding is all opinion. Writing something like this will likely make it very hard to get hired in a modern company though. Hence, Object.values or Object.entities if you need the ID of the hashmap for a link. Just be careful out there. Hashmaps are a great way of preventing duplicates but they have their limits. Iteration and size are two major reasons for not being in a practice of doing data[key].some[innerKey].somemore[inneInnerKey]
– Moosecouture
Jan 2 at 21:07
add a comment |
oh right, thanks alot..!
– Dhruvin modi
Jan 2 at 19:09
Please, reread my solution. I have given a more detailed example showing what I meant about this not being the proper way of handling a hashmap example
– Moosecouture
Jan 2 at 19:51
@Moosecouture that's a matter of opinion; in cases where the OP is generating their own data the risk you present is extremely small to nonexistent, and there can be equally good reasons for maintaining the object structure rather than switching it to an array.
– Paul
Jan 2 at 20:28
Hence, why I presented a maintainable DRY code that does not look like thisdata[key].firstnameand instead makes it look DRYperson.firstname
– Moosecouture
Jan 2 at 20:30
Coding is all opinion. Writing something like this will likely make it very hard to get hired in a modern company though. Hence, Object.values or Object.entities if you need the ID of the hashmap for a link. Just be careful out there. Hashmaps are a great way of preventing duplicates but they have their limits. Iteration and size are two major reasons for not being in a practice of doing data[key].some[innerKey].somemore[inneInnerKey]
– Moosecouture
Jan 2 at 21:07
oh right, thanks alot..!
– Dhruvin modi
Jan 2 at 19:09
oh right, thanks alot..!
– Dhruvin modi
Jan 2 at 19:09
Please, reread my solution. I have given a more detailed example showing what I meant about this not being the proper way of handling a hashmap example
– Moosecouture
Jan 2 at 19:51
Please, reread my solution. I have given a more detailed example showing what I meant about this not being the proper way of handling a hashmap example
– Moosecouture
Jan 2 at 19:51
@Moosecouture that's a matter of opinion; in cases where the OP is generating their own data the risk you present is extremely small to nonexistent, and there can be equally good reasons for maintaining the object structure rather than switching it to an array.
– Paul
Jan 2 at 20:28
@Moosecouture that's a matter of opinion; in cases where the OP is generating their own data the risk you present is extremely small to nonexistent, and there can be equally good reasons for maintaining the object structure rather than switching it to an array.
– Paul
Jan 2 at 20:28
Hence, why I presented a maintainable DRY code that does not look like this
data[key].firstname and instead makes it look DRY person.firstname– Moosecouture
Jan 2 at 20:30
Hence, why I presented a maintainable DRY code that does not look like this
data[key].firstname and instead makes it look DRY person.firstname– Moosecouture
Jan 2 at 20:30
Coding is all opinion. Writing something like this will likely make it very hard to get hired in a modern company though. Hence, Object.values or Object.entities if you need the ID of the hashmap for a link. Just be careful out there. Hashmaps are a great way of preventing duplicates but they have their limits. Iteration and size are two major reasons for not being in a practice of doing data[key].some[innerKey].somemore[inneInnerKey]
– Moosecouture
Jan 2 at 21:07
Coding is all opinion. Writing something like this will likely make it very hard to get hired in a modern company though. Hence, Object.values or Object.entities if you need the ID of the hashmap for a link. Just be careful out there. Hashmaps are a great way of preventing duplicates but they have their limits. Iteration and size are two major reasons for not being in a practice of doing data[key].some[innerKey].somemore[inneInnerKey]
– Moosecouture
Jan 2 at 21:07
add a comment |
0
Like I was trying to say earlier. Turning an Object into an array is better. Because if you are using a hashMap structure these can be deeply nested. Example being an object like the below
{"id01":{
"address": {
"street": "123 Main St",
"city": "San Francisco",
"state": "CA"
},
"dogs": {
"spot": {
"type": "German Shepherd",
"foods": {
"soft" : {
"Purina": "Cat Chow"
},
"unconventional": {
"vomit": "Vomit",
"squirrels" : "Squirrels"
}
}
},
"spike": {
"type": "Doberman"
}
}
}}
will result in something looking like this using the method suggested.
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data[key].firstname %></li>
<li class="list-group-item"><%= data[key].address.street %></li>
<li class="list-group-item"><%= data[key].address.city %></li>
<li class="list-group-item"><%= data[key].address.state %></li>
<li>
<ul>
<% for(var dogKey in data[key].dogs){%>
<li class="list-group-item"><%= data[key].dogs[dogKey].type %></li>
<li>
<ul>
<% for(var dogFoodKey in data[key].dogs[dogKey].foods){%>
<li class="list-group-item"><%= data[key].dogs[dogKey].foods[dogFoodKey]. %></li>
<%}%>
</ul>
</li>
<%}%>
</ul>
</li>
<%}%>
</ul>
It is terribly untidy. It needs a serious refactoring. As a practice you should not repeat yourself.
Instead, I would suggest the following which re-writes the object into an array as it receives it.
<ul class="list-group list-group-flush">
<% for(var person in Object.values(data)){%>
<li class="list-group-item"><%= person.firstname %></li>
<li class="list-group-item"><%= person.address.street %></li>
<li class="list-group-item"><%= person.address.city %></li>
<li class="list-group-item"><%= person.address.state %></li>
<li>
<ul>
<% for(var dog in person.dogs){%>
<li class="list-group-item"><%= dog.type %></li>
<li>
<ul>
<% for(var food of Object.values(dog.foods)){%>
<li class="list-group-item"><%= food %></li>
<%}%>
</ul>
</li>
<%}%>
</ul>
</li>
<%}%>
</ul>
answered Jan 2 at 18:42
MoosecoutureMoosecouture
30818
yup error is gone but the values(i.e abc & pqr) are not displaying on site.
– Dhruvin modi
Jan 2 at 18:51
He should not have to transform his JSON data to make this work.
– Paul
Jan 2 at 19:03
nope, it is still in object form. let me try...and I also want to know the reason behind.
– Dhruvin modi
Jan 2 at 19:05
You should as a practice, use arrays either at runtime or compile and search because it results in better code when iterating. Please check out my updated post that goes into more detail as to why you should have this going through as an array either in the JSON file or when using your template engine.
– Moosecouture
Jan 2 at 20:00
add a comment |
0
Like I was trying to say earlier. Turning an Object into an array is better. Because if you are using a hashMap structure these can be deeply nested. Example being an object like the below
{"id01":{
"address": {
"street": "123 Main St",
"city": "San Francisco",
"state": "CA"
},
"dogs": {
"spot": {
"type": "German Shepherd",
"foods": {
"soft" : {
"Purina": "Cat Chow"
},
"unconventional": {
"vomit": "Vomit",
"squirrels" : "Squirrels"
}
}
},
"spike": {
"type": "Doberman"
}
}
}}
will result in something looking like this using the method suggested.
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data[key].firstname %></li>
<li class="list-group-item"><%= data[key].address.street %></li>
<li class="list-group-item"><%= data[key].address.city %></li>
<li class="list-group-item"><%= data[key].address.state %></li>
<li>
<ul>
<% for(var dogKey in data[key].dogs){%>
<li class="list-group-item"><%= data[key].dogs[dogKey].type %></li>
<li>
<ul>
<% for(var dogFoodKey in data[key].dogs[dogKey].foods){%>
<li class="list-group-item"><%= data[key].dogs[dogKey].foods[dogFoodKey]. %></li>
<%}%>
</ul>
</li>
<%}%>
</ul>
</li>
<%}%>
</ul>
It is terribly untidy. It needs a serious refactoring. As a practice you should not repeat yourself.
Instead, I would suggest the following which re-writes the object into an array as it receives it.
<ul class="list-group list-group-flush">
<% for(var person in Object.values(data)){%>
<li class="list-group-item"><%= person.firstname %></li>
<li class="list-group-item"><%= person.address.street %></li>
<li class="list-group-item"><%= person.address.city %></li>
<li class="list-group-item"><%= person.address.state %></li>
<li>
<ul>
<% for(var dog in person.dogs){%>
<li class="list-group-item"><%= dog.type %></li>
<li>
<ul>
<% for(var food of Object.values(dog.foods)){%>
<li class="list-group-item"><%= food %></li>
<%}%>
</ul>
</li>
<%}%>
</ul>
</li>
<%}%>
</ul>
answered Jan 2 at 18:42
MoosecoutureMoosecouture
30818
yup error is gone but the values(i.e abc & pqr) are not displaying on site.
– Dhruvin modi
Jan 2 at 18:51
He should not have to transform his JSON data to make this work.
– Paul
Jan 2 at 19:03
nope, it is still in object form. let me try...and I also want to know the reason behind.
– Dhruvin modi
Jan 2 at 19:05
You should as a practice, use arrays either at runtime or compile and search because it results in better code when iterating. Please check out my updated post that goes into more detail as to why you should have this going through as an array either in the JSON file or when using your template engine.
– Moosecouture
Jan 2 at 20:00
add a comment |
0
0
0
Like I was trying to say earlier. Turning an Object into an array is better. Because if you are using a hashMap structure these can be deeply nested. Example being an object like the below
{"id01":{
"address": {
"street": "123 Main St",
"city": "San Francisco",
"state": "CA"
},
"dogs": {
"spot": {
"type": "German Shepherd",
"foods": {
"soft" : {
"Purina": "Cat Chow"
},
"unconventional": {
"vomit": "Vomit",
"squirrels" : "Squirrels"
}
}
},
"spike": {
"type": "Doberman"
}
}
}}
will result in something looking like this using the method suggested.
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data[key].firstname %></li>
<li class="list-group-item"><%= data[key].address.street %></li>
<li class="list-group-item"><%= data[key].address.city %></li>
<li class="list-group-item"><%= data[key].address.state %></li>
<li>
<ul>
<% for(var dogKey in data[key].dogs){%>
<li class="list-group-item"><%= data[key].dogs[dogKey].type %></li>
<li>
<ul>
<% for(var dogFoodKey in data[key].dogs[dogKey].foods){%>
<li class="list-group-item"><%= data[key].dogs[dogKey].foods[dogFoodKey]. %></li>
<%}%>
</ul>
</li>
<%}%>
</ul>
</li>
<%}%>
</ul>
It is terribly untidy. It needs a serious refactoring. As a practice you should not repeat yourself.
Instead, I would suggest the following which re-writes the object into an array as it receives it.
<ul class="list-group list-group-flush">
<% for(var person in Object.values(data)){%>
<li class="list-group-item"><%= person.firstname %></li>
<li class="list-group-item"><%= person.address.street %></li>
<li class="list-group-item"><%= person.address.city %></li>
<li class="list-group-item"><%= person.address.state %></li>
<li>
<ul>
<% for(var dog in person.dogs){%>
<li class="list-group-item"><%= dog.type %></li>
<li>
<ul>
<% for(var food of Object.values(dog.foods)){%>
<li class="list-group-item"><%= food %></li>
<%}%>
</ul>
</li>
<%}%>
</ul>
</li>
<%}%>
</ul>
answered Jan 2 at 18:42
MoosecoutureMoosecouture
30818
Like I was trying to say earlier. Turning an Object into an array is better. Because if you are using a hashMap structure these can be deeply nested. Example being an object like the below
{"id01":{
"address": {
"street": "123 Main St",
"city": "San Francisco",
"state": "CA"
},
"dogs": {
"spot": {
"type": "German Shepherd",
"foods": {
"soft" : {
"Purina": "Cat Chow"
},
"unconventional": {
"vomit": "Vomit",
"squirrels" : "Squirrels"
}
}
},
"spike": {
"type": "Doberman"
}
}
}}
will result in something looking like this using the method suggested.
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item"><%= data[key].firstname %></li>
<li class="list-group-item"><%= data[key].address.street %></li>
<li class="list-group-item"><%= data[key].address.city %></li>
<li class="list-group-item"><%= data[key].address.state %></li>
<li>
<ul>
<% for(var dogKey in data[key].dogs){%>
<li class="list-group-item"><%= data[key].dogs[dogKey].type %></li>
<li>
<ul>
<% for(var dogFoodKey in data[key].dogs[dogKey].foods){%>
<li class="list-group-item"><%= data[key].dogs[dogKey].foods[dogFoodKey]. %></li>
<%}%>
</ul>
</li>
<%}%>
</ul>
</li>
<%}%>
</ul>
It is terribly untidy. It needs a serious refactoring. As a practice you should not repeat yourself.
Instead, I would suggest the following which re-writes the object into an array as it receives it.
<ul class="list-group list-group-flush">
<% for(var person in Object.values(data)){%>
<li class="list-group-item"><%= person.firstname %></li>
<li class="list-group-item"><%= person.address.street %></li>
<li class="list-group-item"><%= person.address.city %></li>
<li class="list-group-item"><%= person.address.state %></li>
<li>
<ul>
<% for(var dog in person.dogs){%>
<li class="list-group-item"><%= dog.type %></li>
<li>
<ul>
<% for(var food of Object.values(dog.foods)){%>
<li class="list-group-item"><%= food %></li>
<%}%>
</ul>
</li>
<%}%>
</ul>
</li>
<%}%>
</ul>
answered Jan 2 at 18:42
MoosecoutureMoosecouture
30818
edited Jan 2 at 19:50
answered Jan 2 at 18:42
MoosecoutureMoosecouture
30818
answered Jan 2 at 18:42
MoosecoutureMoosecouture
30818
answered Jan 2 at 18:42
MoosecoutureMoosecouture
30818
30818
yup error is gone but the values(i.e abc & pqr) are not displaying on site.
– Dhruvin modi
Jan 2 at 18:51
He should not have to transform his JSON data to make this work.
– Paul
Jan 2 at 19:03
nope, it is still in object form. let me try...and I also want to know the reason behind.
– Dhruvin modi
Jan 2 at 19:05
You should as a practice, use arrays either at runtime or compile and search because it results in better code when iterating. Please check out my updated post that goes into more detail as to why you should have this going through as an array either in the JSON file or when using your template engine.
– Moosecouture
Jan 2 at 20:00
add a comment |
yup error is gone but the values(i.e abc & pqr) are not displaying on site.
– Dhruvin modi
Jan 2 at 18:51
He should not have to transform his JSON data to make this work.
– Paul
Jan 2 at 19:03
nope, it is still in object form. let me try...and I also want to know the reason behind.
– Dhruvin modi
Jan 2 at 19:05
You should as a practice, use arrays either at runtime or compile and search because it results in better code when iterating. Please check out my updated post that goes into more detail as to why you should have this going through as an array either in the JSON file or when using your template engine.
– Moosecouture
Jan 2 at 20:00
yup error is gone but the values(i.e abc & pqr) are not displaying on site.
– Dhruvin modi
Jan 2 at 18:51
yup error is gone but the values(i.e abc & pqr) are not displaying on site.
– Dhruvin modi
Jan 2 at 18:51
He should not have to transform his JSON data to make this work.
– Paul
Jan 2 at 19:03
He should not have to transform his JSON data to make this work.
– Paul
Jan 2 at 19:03
nope, it is still in object form. let me try...and I also want to know the reason behind.
– Dhruvin modi
Jan 2 at 19:05
nope, it is still in object form. let me try...and I also want to know the reason behind.
– Dhruvin modi
Jan 2 at 19:05
You should as a practice, use arrays either at runtime or compile and search because it results in better code when iterating. Please check out my updated post that goes into more detail as to why you should have this going through as an array either in the JSON file or when using your template engine.
– Moosecouture
Jan 2 at 20:00
You should as a practice, use arrays either at runtime or compile and search because it results in better code when iterating. Please check out my updated post that goes into more detail as to why you should have this going through as an array either in the JSON file or when using your template engine.
– Moosecouture
Jan 2 at 20:00
add a comment |
-1
you need to make few changes as below in your index.ejs file
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item">
<%= key.firstname %>
</li>
<%}%>
</ul>
Note: you have to use key.firstname and not data.key.firstname
answered Jan 2 at 18:57
Aravind Kumar JAravind Kumar J
11
add a comment |
-1
you need to make few changes as below in your index.ejs file
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item">
<%= key.firstname %>
</li>
<%}%>
</ul>
Note: you have to use key.firstname and not data.key.firstname
answered Jan 2 at 18:57
Aravind Kumar JAravind Kumar J
11
add a comment |
-1
-1
-1
you need to make few changes as below in your index.ejs file
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item">
<%= key.firstname %>
</li>
<%}%>
</ul>
Note: you have to use key.firstname and not data.key.firstname
answered Jan 2 at 18:57
Aravind Kumar JAravind Kumar J
11
you need to make few changes as below in your index.ejs file
<ul class="list-group list-group-flush">
<% for(var key in data){%>
<li class="list-group-item">
<%= key.firstname %>
</li>
<%}%>
</ul>
Note: you have to use key.firstname and not data.key.firstname
answered Jan 2 at 18:57
Aravind Kumar JAravind Kumar J
11
answered Jan 2 at 18:57
Aravind Kumar JAravind Kumar J
11
answered Jan 2 at 18:57
Aravind Kumar JAravind Kumar J
11
answered Jan 2 at 18:57
Aravind Kumar JAravind Kumar J
11
11
add a comment |
add a comment |
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54011361%2fcannot-read-property-firstname-of-undefined-in-view-engine-node-js%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
